eslint-plugin-chai-friendly 0.5.0 → 0.7.2

package/.editorconfig

@@ -8,5 +8,8 @@ charset = utf-8
 end_of_line = lf
 insert_final_newline = true
 indent_style = space
-indent_size = 2
+indent_size = 4
 trim_trailing_whitespace = true
+
+[*.json]
+indent_size = 2

package/.eslintignore

@@ -1 +1,2 @@
 node_modules
+!.eslintrc.js

package/.eslintrc.js

@@ -1,6 +1,15 @@
+'use strict';
+
 module.exports = {
-  extends: ['eslint:recommended'],
-  env: {
-    node: true
-  }
+    extends: ['eslint:recommended'],
+    env: {
+        node: true
+    },
+    parserOptions: {
+        ecmaVersion: 2020
+    },
+    rules: {
+        strict: ['error'],
+        indent: ['error', 4]
+    }
 };

package/.nyc_output/a9bacb87-6c71-4985-a8ed-1837b4c2d3e4.json

@@ -0,0 +1 @@
+{"/Users/user/repos/eslint-plugin-chai-friendly/lib/rules/no-unused-expressions.js":{"path":"/Users/user/repos/eslint-plugin-chai-friendly/lib/rules/no-unused-expressions.js","statementMap":{"0":{"start":{"line":17,"column":4},"end":{"line":17,"column":16}},"1":{"start":{"line":25,"column":4},"end":{"line":25,"column":17}},"2":{"start":{"line":29,"column":0},"end":{"line":266,"column":2}},"3":{"start":{"line":66,"column":21},"end":{"line":66,"column":45}},"4":{"start":{"line":67,"column":32},"end":{"line":67,"column":65}},"5":{"start":{"line":68,"column":27},"end":{"line":68,"column":55}},"6":{"start":{"line":69,"column":35},"end":{"line":69,"column":71}},"7":{"start":{"line":70,"column":28},"end":{"line":70,"column":57}},"8":{"start":{"line":77,"column":12},"end":{"line":78,"column":96}},"9":{"start":{"line":87,"column":12},"end":{"line":91,"column":13}},"10":{"start":{"line":87,"column":25},"end":{"line":87,"column":26}},"11":{"start":{"line":88,"column":16},"end":{"line":90,"column":17}},"12":{"start":{"line":89,"column":20},"end":{"line":89,"column":44}},"13":{"start":{"line":92,"column":12},"end":{"line":92,"column":32}},"14":{"start":{"line":100,"column":12},"end":{"line":100,"column":60}},"15":{"start":{"line":109,"column":25},"end":{"line":109,"column":56}},"16":{"start":{"line":110,"column":30},"end":{"line":110,"column":61}},"17":{"start":{"line":112,"column":12},"end":{"line":114,"column":58}},"18":{"start":{"line":121,"column":24},"end":{"line":166,"column":10}},"19":{"start":{"line":123,"column":16},"end":{"line":123,"column":65}},"20":{"start":{"line":130,"column":16},"end":{"line":130,"column":61}},"21":{"start":{"line":134,"column":16},"end":{"line":136,"column":17}},"22":{"start":{"line":135,"column":20},"end":{"line":135,"column":105}},"23":{"start":{"line":137,"column":16},"end":{"line":137,"column":28}},"24":{"start":{"line":143,"column":16},"end":{"line":143,"column":37}},"25":{"start":{"line":146,"column":16},"end":{"line":146,"column":37}},"26":{"start":{"line":149,"column":16},"end":{"line":151,"column":17}},"27":{"start":{"line":150,"column":20},"end":{"line":150,"column":60}},"28":{"start":{"line":152,"column":16},"end":{"line":152,"column":28}},"29":{"start":{"line":159,"column":16},"end":{"line":159,"column":45}},"30":{"start":{"line":164,"column":16},"end":{"line":164,"column":78}},"31":{"start":{"line":175,"column":29},"end":{"line":175,"column":44}},"32":{"start":{"line":176,"column":12},"end":{"line":178,"column":13}},"33":{"start":{"line":177,"column":16},"end":{"line":177,"column":29}},"34":{"start":{"line":180,"column":12},"end":{"line":180,"column":62}},"35":{"start":{"line":190,"column":12},"end":{"line":192,"column":13}},"36":{"start":{"line":191,"column":16},"end":{"line":191,"column":28}},"37":{"start":{"line":195,"column":12},"end":{"line":197,"column":13}},"38":{"start":{"line":196,"column":16},"end":{"line":196,"column":51}},"39":{"start":{"line":198,"column":12},"end":{"line":200,"column":13}},"40":{"start":{"line":199,"column":16},"end":{"line":199,"column":51}},"41":{"start":{"line":201,"column":12},"end":{"line":203,"column":13}},"42":{"start":{"line":202,"column":16},"end":{"line":202,"column":55}},"43":{"start":{"line":206,"column":12},"end":{"line":206,"column":24}},"44":{"start":{"line":216,"column":29},"end":{"line":216,"column":44}},"45":{"start":{"line":217,"column":12},"end":{"line":219,"column":13}},"46":{"start":{"line":218,"column":16},"end":{"line":218,"column":50}},"47":{"start":{"line":220,"column":12},"end":{"line":222,"column":13}},"48":{"start":{"line":221,"column":16},"end":{"line":221,"column":29}},"49":{"start":{"line":224,"column":12},"end":{"line":224,"column":62}},"50":{"start":{"line":234,"column":12},"end":{"line":236,"column":13}},"51":{"start":{"line":235,"column":16},"end":{"line":235,"column":28}},"52":{"start":{"line":239,"column":12},"end":{"line":241,"column":13}},"53":{"start":{"line":240,"column":16},"end":{"line":240,"column":51}},"54":{"start":{"line":242,"column":12},"end":{"line":244,"column":13}},"55":{"start":{"line":243,"column":16},"end":{"line":243,"column":51}},"56":{"start":{"line":245,"column":12},"end":{"line":247,"column":13}},"57":{"start":{"line":246,"column":16},"end":{"line":246,"column":55}},"58":{"start":{"line":250,"column":12},"end":{"line":250,"column":24}},"59":{"start":{"line":254,"column":8},"end":{"line":264,"column":10}},"60":{"start":{"line":256,"column":28},"end":{"line":259,"column":45}},"61":{"start":{"line":260,"column":16},"end":{"line":262,"column":17}},"62":{"start":{"line":261,"column":20},"end":{"line":261,"column":74}}},"fnMap":{"0":{"name":"alwaysTrue","decl":{"start":{"line":16,"column":9},"end":{"line":16,"column":19}},"loc":{"start":{"line":16,"column":22},"end":{"line":18,"column":1}},"line":16},"1":{"name":"alwaysFalse","decl":{"start":{"line":24,"column":9},"end":{"line":24,"column":20}},"loc":{"start":{"line":24,"column":23},"end":{"line":26,"column":1}},"line":24},"2":{"name":"(anonymous_2)","decl":{"start":{"line":65,"column":12},"end":{"line":65,"column":13}},"loc":{"start":{"line":65,"column":31},"end":{"line":265,"column":5}},"line":65},"3":{"name":"looksLikeDirective","decl":{"start":{"line":76,"column":17},"end":{"line":76,"column":35}},"loc":{"start":{"line":76,"column":42},"end":{"line":79,"column":9}},"line":76},"4":{"name":"takeWhile","decl":{"start":{"line":86,"column":17},"end":{"line":86,"column":26}},"loc":{"start":{"line":86,"column":44},"end":{"line":93,"column":9}},"line":86},"5":{"name":"directives","decl":{"start":{"line":99,"column":17},"end":{"line":99,"column":27}},"loc":{"start":{"line":99,"column":34},"end":{"line":101,"column":9}},"line":99},"6":{"name":"isDirective","decl":{"start":{"line":108,"column":17},"end":{"line":108,"column":28}},"loc":{"start":{"line":108,"column":46},"end":{"line":115,"column":9}},"line":108},"7":{"name":"(anonymous_7)","decl":{"start":{"line":122,"column":12},"end":{"line":122,"column":13}},"loc":{"start":{"line":122,"column":31},"end":{"line":124,"column":13}},"line":122},"8":{"name":"(anonymous_8)","decl":{"start":{"line":129,"column":12},"end":{"line":129,"column":13}},"loc":{"start":{"line":129,"column":34},"end":{"line":131,"column":13}},"line":129},"9":{"name":"(anonymous_9)","decl":{"start":{"line":133,"column":12},"end":{"line":133,"column":13}},"loc":{"start":{"line":133,"column":40},"end":{"line":138,"column":13}},"line":133},"10":{"name":"(anonymous_10)","decl":{"start":{"line":142,"column":12},"end":{"line":142,"column":13}},"loc":{"start":{"line":142,"column":25},"end":{"line":144,"column":13}},"line":142},"11":{"name":"(anonymous_11)","decl":{"start":{"line":145,"column":12},"end":{"line":145,"column":13}},"loc":{"start":{"line":145,"column":26},"end":{"line":147,"column":13}},"line":145},"12":{"name":"(anonymous_12)","decl":{"start":{"line":148,"column":12},"end":{"line":148,"column":13}},"loc":{"start":{"line":148,"column":36},"end":{"line":153,"column":13}},"line":148},"13":{"name":"(anonymous_13)","decl":{"start":{"line":158,"column":12},"end":{"line":158,"column":13}},"loc":{"start":{"line":158,"column":39},"end":{"line":160,"column":13}},"line":158},"14":{"name":"(anonymous_14)","decl":{"start":{"line":163,"column":12},"end":{"line":163,"column":13}},"loc":{"start":{"line":163,"column":34},"end":{"line":165,"column":13}},"line":163},"15":{"name":"isChaiExpectCall","decl":{"start":{"line":174,"column":17},"end":{"line":174,"column":33}},"loc":{"start":{"line":174,"column":40},"end":{"line":181,"column":9}},"line":174},"16":{"name":"findExpectCall","decl":{"start":{"line":188,"column":17},"end":{"line":188,"column":31}},"loc":{"start":{"line":188,"column":38},"end":{"line":207,"column":9}},"line":188},"17":{"name":"isChaiShouldCall","decl":{"start":{"line":215,"column":17},"end":{"line":215,"column":33}},"loc":{"start":{"line":215,"column":40},"end":{"line":225,"column":9}},"line":215},"18":{"name":"findShouldCall","decl":{"start":{"line":232,"column":17},"end":{"line":232,"column":31}},"loc":{"start":{"line":232,"column":38},"end":{"line":251,"column":9}},"line":232},"19":{"name":"(anonymous_19)","decl":{"start":{"line":255,"column":33},"end":{"line":255,"column":34}},"loc":{"start":{"line":255,"column":48},"end":{"line":263,"column":13}},"line":255}},"branchMap":{"0":{"loc":{"start":{"line":66,"column":21},"end":{"line":66,"column":45}},"type":"binary-expr","locations":[{"start":{"line":66,"column":21},"end":{"line":66,"column":39}},{"start":{"line":66,"column":43},"end":{"line":66,"column":45}}],"line":66},"1":{"loc":{"start":{"line":67,"column":32},"end":{"line":67,"column":65}},"type":"binary-expr","locations":[{"start":{"line":67,"column":32},"end":{"line":67,"column":56}},{"start":{"line":67,"column":60},"end":{"line":67,"column":65}}],"line":67},"2":{"loc":{"start":{"line":68,"column":27},"end":{"line":68,"column":55}},"type":"binary-expr","locations":[{"start":{"line":68,"column":27},"end":{"line":68,"column":46}},{"start":{"line":68,"column":50},"end":{"line":68,"column":55}}],"line":68},"3":{"loc":{"start":{"line":69,"column":35},"end":{"line":69,"column":71}},"type":"binary-expr","locations":[{"start":{"line":69,"column":35},"end":{"line":69,"column":62}},{"start":{"line":69,"column":66},"end":{"line":69,"column":71}}],"line":69},"4":{"loc":{"start":{"line":70,"column":28},"end":{"line":70,"column":57}},"type":"binary-expr","locations":[{"start":{"line":70,"column":28},"end":{"line":70,"column":48}},{"start":{"line":70,"column":52},"end":{"line":70,"column":57}}],"line":70},"5":{"loc":{"start":{"line":77,"column":19},"end":{"line":78,"column":95}},"type":"binary-expr","locations":[{"start":{"line":77,"column":19},"end":{"line":77,"column":54}},{"start":{"line":78,"column":16},"end":{"line":78,"column":50}},{"start":{"line":78,"column":54},"end":{"line":78,"column":95}}],"line":77},"6":{"loc":{"start":{"line":88,"column":16},"end":{"line":90,"column":17}},"type":"if","locations":[{"start":{"line":88,"column":16},"end":{"line":90,"column":17}},{"start":{"line":88,"column":16},"end":{"line":90,"column":17}}],"line":88},"7":{"loc":{"start":{"line":112,"column":19},"end":{"line":114,"column":57}},"type":"binary-expr","locations":[{"start":{"line":112,"column":20},"end":{"line":112,"column":45}},{"start":{"line":112,"column":49},"end":{"line":112,"column":81}},{"start":{"line":113,"column":21},"end":{"line":113,"column":54}},{"start":{"line":114,"column":20},"end":{"line":114,"column":57}}],"line":112},"8":{"loc":{"start":{"line":123,"column":24},"end":{"line":123,"column":57}},"type":"binary-expr","locations":[{"start":{"line":123,"column":24},"end":{"line":123,"column":42}},{"start":{"line":123,"column":46},"end":{"line":123,"column":57}}],"line":123},"9":{"loc":{"start":{"line":134,"column":16},"end":{"line":136,"column":17}},"type":"if","locations":[{"start":{"line":134,"column":16},"end":{"line":136,"column":17}},{"start":{"line":134,"column":16},"end":{"line":136,"column":17}}],"line":134},"10":{"loc":{"start":{"line":135,"column":27},"end":{"line":135,"column":104}},"type":"binary-expr","locations":[{"start":{"line":135,"column":27},"end":{"line":135,"column":64}},{"start":{"line":135,"column":68},"end":{"line":135,"column":104}}],"line":135},"11":{"loc":{"start":{"line":149,"column":16},"end":{"line":151,"column":17}},"type":"if","locations":[{"start":{"line":149,"column":16},"end":{"line":151,"column":17}},{"start":{"line":149,"column":16},"end":{"line":151,"column":17}}],"line":149},"12":{"loc":{"start":{"line":164,"column":23},"end":{"line":164,"column":77}},"type":"binary-expr","locations":[{"start":{"line":164,"column":23},"end":{"line":164,"column":47}},{"start":{"line":164,"column":51},"end":{"line":164,"column":77}}],"line":164},"13":{"loc":{"start":{"line":176,"column":12},"end":{"line":178,"column":13}},"type":"if","locations":[{"start":{"line":176,"column":12},"end":{"line":178,"column":13}},{"start":{"line":176,"column":12},"end":{"line":178,"column":13}}],"line":176},"14":{"loc":{"start":{"line":190,"column":12},"end":{"line":192,"column":13}},"type":"if","locations":[{"start":{"line":190,"column":12},"end":{"line":192,"column":13}},{"start":{"line":190,"column":12},"end":{"line":192,"column":13}}],"line":190},"15":{"loc":{"start":{"line":190,"column":16},"end":{"line":190,"column":116}},"type":"binary-expr","locations":[{"start":{"line":190,"column":16},"end":{"line":190,"column":46}},{"start":{"line":190,"column":50},"end":{"line":190,"column":83}},{"start":{"line":190,"column":87},"end":{"line":190,"column":116}}],"line":190},"16":{"loc":{"start":{"line":195,"column":12},"end":{"line":197,"column":13}},"type":"if","locations":[{"start":{"line":195,"column":12},"end":{"line":197,"column":13}},{"start":{"line":195,"column":12},"end":{"line":197,"column":13}}],"line":195},"17":{"loc":{"start":{"line":198,"column":12},"end":{"line":200,"column":13}},"type":"if","locations":[{"start":{"line":198,"column":12},"end":{"line":200,"column":13}},{"start":{"line":198,"column":12},"end":{"line":200,"column":13}}],"line":198},"18":{"loc":{"start":{"line":201,"column":12},"end":{"line":203,"column":13}},"type":"if","locations":[{"start":{"line":201,"column":12},"end":{"line":203,"column":13}},{"start":{"line":201,"column":12},"end":{"line":203,"column":13}}],"line":201},"19":{"loc":{"start":{"line":217,"column":12},"end":{"line":219,"column":13}},"type":"if","locations":[{"start":{"line":217,"column":12},"end":{"line":219,"column":13}},{"start":{"line":217,"column":12},"end":{"line":219,"column":13}}],"line":217},"20":{"loc":{"start":{"line":220,"column":12},"end":{"line":222,"column":13}},"type":"if","locations":[{"start":{"line":220,"column":12},"end":{"line":222,"column":13}},{"start":{"line":220,"column":12},"end":{"line":222,"column":13}}],"line":220},"21":{"loc":{"start":{"line":234,"column":12},"end":{"line":236,"column":13}},"type":"if","locations":[{"start":{"line":234,"column":12},"end":{"line":236,"column":13}},{"start":{"line":234,"column":12},"end":{"line":236,"column":13}}],"line":234},"22":{"loc":{"start":{"line":234,"column":16},"end":{"line":234,"column":100}},"type":"binary-expr","locations":[{"start":{"line":234,"column":16},"end":{"line":234,"column":48}},{"start":{"line":234,"column":52},"end":{"line":234,"column":65}},{"start":{"line":234,"column":69},"end":{"line":234,"column":100}}],"line":234},"23":{"loc":{"start":{"line":239,"column":12},"end":{"line":241,"column":13}},"type":"if","locations":[{"start":{"line":239,"column":12},"end":{"line":241,"column":13}},{"start":{"line":239,"column":12},"end":{"line":241,"column":13}}],"line":239},"24":{"loc":{"start":{"line":242,"column":12},"end":{"line":244,"column":13}},"type":"if","locations":[{"start":{"line":242,"column":12},"end":{"line":244,"column":13}},{"start":{"line":242,"column":12},"end":{"line":244,"column":13}}],"line":242},"25":{"loc":{"start":{"line":245,"column":12},"end":{"line":247,"column":13}},"type":"if","locations":[{"start":{"line":245,"column":12},"end":{"line":247,"column":13}},{"start":{"line":245,"column":12},"end":{"line":247,"column":13}}],"line":245},"26":{"loc":{"start":{"line":256,"column":28},"end":{"line":259,"column":45}},"type":"binary-expr","locations":[{"start":{"line":256,"column":28},"end":{"line":256,"column":66}},{"start":{"line":257,"column":23},"end":{"line":257,"column":64}},{"start":{"line":258,"column":23},"end":{"line":258,"column":45}},{"start":{"line":259,"column":23},"end":{"line":259,"column":45}}],"line":256},"27":{"loc":{"start":{"line":260,"column":16},"end":{"line":262,"column":17}},"type":"if","locations":[{"start":{"line":260,"column":16},"end":{"line":262,"column":17}},{"start":{"line":260,"column":16},"end":{"line":262,"column":17}}],"line":260}},"s":{"0":42,"1":27,"2":1,"3":79,"4":79,"5":79,"6":79,"7":79,"8":66,"9":52,"10":52,"11":66,"12":51,"13":1,"14":52,"15":54,"16":54,"17":54,"18":79,"19":106,"20":9,"21":7,"22":5,"23":2,"24":2,"25":2,"26":10,"27":6,"28":4,"29":3,"30":4,"31":45,"32":45,"33":36,"34":9,"35":38,"36":3,"37":35,"38":26,"39":9,"40":3,"41":6,"42":0,"43":6,"44":42,"45":42,"46":7,"47":42,"48":29,"49":13,"50":38,"51":5,"52":33,"53":22,"54":11,"55":3,"56":8,"57":0,"58":8,"59":79,"60":83,"61":83,"62":37},"f":{"0":42,"1":27,"2":79,"3":66,"4":52,"5":52,"6":54,"7":106,"8":9,"9":7,"10":2,"11":2,"12":10,"13":3,"14":4,"15":45,"16":38,"17":42,"18":38,"19":83},"b":{"0":[79,58],"1":[79,72],"2":[79,73],"3":[79,76],"4":[79,75],"5":[66,62,16],"6":[51,15],"7":[54,10,10,52],"8":[106,27],"9":[5,2],"10":[5,3],"11":[6,4],"12":[4,3],"13":[36,9],"14":[3,35],"15":[38,6,3],"16":[26,9],"17":[3,6],"18":[0,6],"19":[7,35],"20":[29,13],"21":[5,33],"22":[38,27,27],"23":[22,11],"24":[3,8],"25":[0,8],"26":[83,54,45,42],"27":[37,46]},"_coverageSchema":"1a1c01bbd47fc00a2c39e90264f33305004495a9","hash":"dd374607c4c2b081d47e729c0ee6547a96d54982","contentHash":"085284c031abf8ad77a81dcf5f0e6765748fe87b8d11666b4f9fb6745e154202"}}

package/.nyc_output/processinfo/a9bacb87-6c71-4985-a8ed-1837b4c2d3e4.json

@@ -0,0 +1 @@
+{"parent":null,"pid":33337,"argv":["/usr/local/bin/node","/Users/user/repos/eslint-plugin-chai-friendly/node_modules/.bin/mocha","tests","--recursive"],"execArgv":[],"cwd":"/Users/user/repos/eslint-plugin-chai-friendly","time":1620604159241,"ppid":33336,"coverageFilename":"/Users/user/repos/eslint-plugin-chai-friendly/.nyc_output/a9bacb87-6c71-4985-a8ed-1837b4c2d3e4.json","externalId":"","uuid":"a9bacb87-6c71-4985-a8ed-1837b4c2d3e4","files":["/Users/user/repos/eslint-plugin-chai-friendly/lib/rules/no-unused-expressions.js"]}

package/.nyc_output/processinfo/index.json

@@ -0,0 +1 @@
+{"processes":{"a9bacb87-6c71-4985-a8ed-1837b4c2d3e4":{"parent":null,"children":[]}},"files":{"/Users/user/repos/eslint-plugin-chai-friendly/lib/rules/no-unused-expressions.js":["a9bacb87-6c71-4985-a8ed-1837b4c2d3e4"]},"externalIds":{}}

package/README.md

@@ -1,6 +1,6 @@
 # eslint-plugin-chai-friendly
 
-[![npm](https://img.shields.io/npm/v/eslint-plugin-chai-friendly.svg)](https://www.npmjs.com/package/eslint-plugin-chai-friendly) [![npm](https://img.shields.io/npm/dm/eslint-plugin-chai-friendly.svg)](https://www.npmjs.com/package/eslint-plugin-chai-friendly)
+[![npm](https://img.shields.io/npm/v/eslint-plugin-chai-friendly.svg)](https://www.npmjs.com/package/eslint-plugin-chai-friendly) [![npm](https://img.shields.io/npm/dm/eslint-plugin-chai-friendly)](https://www.npmjs.com/package/eslint-plugin-chai-friendly)
 
 This plugin overrides `no-unused-expressions` to make it friendly towards chai `expect` and `should` statements.
 
@@ -71,6 +71,7 @@ This rule, in its default state, does not require any arguments. If you would li
 - `allowShortCircuit` set to `true` will allow you to use short circuit evaluations in your expressions (Default: `false`).
 - `allowTernary` set to `true` will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: `false`).
 - `allowTaggedTemplates` set to `true` will enable you to use tagged template literals in your expressions (Default: `false`).
+- `enforceForJSX` set to `true` will flag unused JSX element expressions (Default: `false`).
 
 These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).
 

package/lib/index.js

@@ -5,16 +5,16 @@
 "use strict";
 
 module.exports = {
-  configs: {
-    recommended: {
-      plugins: ['chai-friendly'],
-      rules: {
-        'chai-friendly/no-unused-expressions': 'error',
-        'no-unused-expressions': 'off'
-      }
+    configs: {
+        recommended: {
+            plugins: ['chai-friendly'],
+            rules: {
+                'chai-friendly/no-unused-expressions': 'error',
+                'no-unused-expressions': 'off'
+            }
+        }
+    },
+    rules: {
+        'no-unused-expressions': require('./rules/no-unused-expressions')
     }
-  },
-  rules: {
-    'no-unused-expressions': require('./rules/no-unused-expressions')
-  }
 };

package/lib/rules/no-unused-expressions.js

@@ -9,8 +9,27 @@
 // Rule Definition
 //------------------------------------------------------------------------------
 
+/**
+ * Returns `true`.
+ * @returns {boolean} `true`.
+ */
+function alwaysTrue() {
+    return true;
+}
+
+/**
+ * Returns `false`.
+ * @returns {boolean} `false`.
+ */
+function alwaysFalse() {
+    return false;
+}
+
+
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unused expressions",
             category: "Best Practices",
@@ -29,18 +48,26 @@ module.exports = {
                     },
                     allowTaggedTemplates: {
                         type: "boolean"
+                    },
+                    enforceForJSX: {
+                        type: "boolean",
+                        default: false
                     }
                 },
                 additionalProperties: false
             }
-        ]
+        ],
+
+        messages: {
+            unusedExpression: "Expected an assignment or function call and instead saw an expression."
+        }
     },
     create: function (context) {
         var config = context.options[0] || {},
             allowShortCircuit = config.allowShortCircuit || false,
             allowTernary = config.allowTernary || false,
-            allowTaggedTemplates = config.allowTaggedTemplates || false;
-
+            allowTaggedTemplates = config.allowTaggedTemplates || false,
+            enforceForJSX = config.enforceForJSX || false;
 
         /**
          * @param {ASTNode} node - any node
@@ -88,31 +115,55 @@ module.exports = {
         }
 
         /**
-         * Determines whether or not a given node is a valid expression. Recurses on short circuit eval and ternary nodes if enabled by flags.
-         * @param {ASTNode} node - any node
-         * @returns {boolean} whether the given node is a valid expression
+         * The member functions return `true` if the type has no side-effects.
+         * Unknown nodes are handled as `false`, then this rule ignores those.
          */
-        function isValidExpression(node) {
-            if (allowTernary) {
+        const Checker = Object.assign(Object.create(null), {
+            isDisallowed(node) {
+                return (Checker[node.type] || alwaysFalse)(node);
+            },
 
-                // Recursive check for ternary and logical expressions
-                if (node.type === "ConditionalExpression") {
-                    return isValidExpression(node.consequent) && isValidExpression(node.alternate);
+            ArrayExpression: alwaysTrue,
+            ArrowFunctionExpression: alwaysTrue,
+            BinaryExpression: alwaysTrue,
+            ChainExpression(node) {
+                return Checker.isDisallowed(node.expression);
+            },
+            ClassExpression: alwaysTrue,
+            ConditionalExpression(node) {
+                if (allowTernary) {
+                    return Checker.isDisallowed(node.consequent) || Checker.isDisallowed(node.alternate);
                 }
-            }
-            if (allowShortCircuit) {
-                if (node.type === "LogicalExpression") {
-                    return isValidExpression(node.right);
+                return true;
+            },
+            FunctionExpression: alwaysTrue,
+            Identifier: alwaysTrue,
+            Literal: alwaysTrue,
+            JSXElement() {
+                return enforceForJSX;
+            },
+            JSXFragment() {
+                return enforceForJSX;
+            },
+            LogicalExpression(node) {
+                if (allowShortCircuit) {
+                    return Checker.isDisallowed(node.right);
                 }
-            }
-
-            if (allowTaggedTemplates && node.type === "TaggedTemplateExpression") {
                 return true;
+            },
+            MemberExpression: alwaysTrue,
+            MetaProperty: alwaysTrue,
+            ObjectExpression: alwaysTrue,
+            SequenceExpression: alwaysTrue,
+            TaggedTemplateExpression() {
+                return !allowTaggedTemplates;
+            },
+            TemplateLiteral: alwaysTrue,
+            ThisExpression: alwaysTrue,
+            UnaryExpression(node) {
+                return node.operator !== "void" && node.operator !== "delete";
             }
-
-            return /^(?:Assignment|Call|New|Update|Yield|Await)Expression$/.test(node.type) ||
-                (node.type === "UnaryExpression" && ["delete", "void"].indexOf(node.operator) >= 0);
-        }
+        });
 
         /**
          * Determines whether or not a given node is a chai's expect statement.
@@ -121,14 +172,12 @@ module.exports = {
          * @returns {boolean} whether the given node is a chai expectation
          */
         function isChaiExpectCall(node) {
-            var expression = node.expression;
+            let expression = node.expression;
             if (expression.type !== 'MemberExpression') {
                 return false;
             }
 
-            var hasExpectCall =  Boolean(findExpectCall(expression.object));
-
-            return hasExpectCall;
+            return Boolean(findExpectCall(expression.object));
         }
 
         /**
@@ -149,6 +198,9 @@ module.exports = {
             if (node.type === 'CallExpression') {
                 return findExpectCall(node.callee);
             }
+            if (node.type === 'ChainExpression') {
+                return findExpectCall(node.expression);
+            }
 
             // Stop search, expect(...) not found
             return null;
@@ -161,14 +213,15 @@ module.exports = {
          * @returns {boolean} whether the given node is a chai should statement
          */
         function isChaiShouldCall(node) {
-            var expression = node.expression;
+            let expression = node.expression;
+            if (expression.type === 'ChainExpression') {
+                expression = expression.expression
+            }
             if (expression.type !== 'MemberExpression') {
                 return false;
             }
 
-            var hasShouldCall = Boolean(findShouldCall(expression.object));
-
-            return hasShouldCall;
+            return Boolean(findShouldCall(expression.object));
         }
 
         /**
@@ -189,6 +242,9 @@ module.exports = {
             if (node.type === 'CallExpression') {
                 return findShouldCall(node.callee);
             }
+            if (node.type === 'ChainExpression') {
+                return findShouldCall(node.expression);
+            }
 
             // Stop search, obj.should not found
             return null;
@@ -197,12 +253,12 @@ module.exports = {
 
         return {
             ExpressionStatement: function(node) {
-                var valid = isValidExpression(node.expression)
+                var valid = !Checker.isDisallowed(node.expression)
                     || isDirective(node, context.getAncestors())
                     || isChaiExpectCall(node)
                     || isChaiShouldCall(node);
                 if (!valid) {
-                    context.report(node, "Expected an assignment or function call and instead saw an expression.");
+                    context.report({node, messageId: "unusedExpression"});
                 }
             }
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-chai-friendly",
-  "version": "0.5.0",
+  "version": "0.7.2",
   "description": "This plugin makes 'no-unused-expressions' rule friendly towards chai expect statements.",
   "keywords": [
     "eslint",
@@ -24,15 +24,17 @@
   "main": "lib/index.js",
   "scripts": {
     "lint": "eslint .",
-    "test": "mocha tests --recursive"
+    "test": "nyc mocha tests --recursive"
   },
   "dependencies": {},
   "peerDependencies": {
     "eslint": ">=3.0.0"
   },
   "devDependencies": {
-    "eslint": "~6.6.0",
-    "mocha": "^6.2.2"
+    "babel-eslint": "^10.1.0",
+    "eslint": "^7.26.0",
+    "mocha": "^7.1.2",
+    "nyc": "^15.0.1"
   },
   "engines": {
     "node": ">=0.10.0"

package/tests/lib/rules/no-unused-expressions.js

@@ -71,12 +71,60 @@ ruleTester.run("no-unused-expressions", rule, {
             options: [{ allowTaggedTemplates: true }],
             parserOptions: { ecmaVersion: 6 }
         },
+        {
+            code: "import(\"foo\")",
+            parserOptions: { ecmaVersion: 11 }
+        },
+        {
+            code: "func?.(\"foo\")",
+            parserOptions: { ecmaVersion: 11 }
+        },
+        {
+            code: "obj?.foo(\"bar\")",
+            parserOptions: { ecmaVersion: 11 }
+        },
+        // JSX
+        {
+            code: "<div />",
+            parserOptions: { ecmaFeatures: { jsx: true } }
+        },
+        {
+            code: "<></>",
+            parserOptions: { ecmaFeatures: { jsx: true } }
+        },
+        {
+            code: "var partial = <div />",
+            parserOptions: { ecmaFeatures: { jsx: true } }
+        },
+        {
+            code: "var partial = <div />",
+            options: [{ enforceForJSX: true }],
+            parserOptions: { ecmaFeatures: { jsx: true } }
+        },
+        {
+            code: "var partial = <></>",
+            options: [{ enforceForJSX: true }],
+            parserOptions: { ecmaFeatures: { jsx: true } }
+        },
+
         // Chai statements
         "expect(foo).to.be.true;",
         "expect(foo).to.have.a.property('bar').which.is.true",
         "foo.should.be.true;",
         "foo.inner.nested.should.be.true",
-        "foo.should.have.a.property('bar').which.is.true;"
+        "foo.should.have.a.property('bar').which.is.true;",
+        {
+            code: "foo?.should.be.true;",
+            parserOptions: { ecmaVersion: 11 }
+        },
+        {
+            code: "foo?.bar?.should.be.true;",
+            parserOptions: { ecmaVersion: 11 }
+        },
+        {
+            code: "expect(foo?.bar).should.be.true;",
+            parserOptions: { ecmaVersion: 11 }
+        }
     ],
     invalid: [
         { code: "0", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement"}]},
@@ -85,11 +133,11 @@ ruleTester.run("no-unused-expressions", rule, {
         { code: "{0}", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement"}]},
         { code: "[]", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement"}]},
         { code: "a && b();", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement"}]},
-        { code: "a() || false", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }]},
-        { code: "a || (b = c)", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }]},
-        { code: "a ? b() || (c = d) : e", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }]},
-        { code: "a && b()", options: [{ allowTernary: true }], errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }]},
-        { code: "a ? b() : c()", options: [{ allowShortCircuit: true }], errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }]},
+        { code: "a() || false", errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]},
+        { code: "a || (b = c)", errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]},
+        { code: "a ? b() || (c = d) : e", errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]},
+        { code: "a && b()", options: [{ allowTernary: true }], errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]},
+        { code: "a ? b() : c()", options: [{ allowShortCircuit: true }], errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]},
         { code: "a || b", options: [{ allowShortCircuit: true }], errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement"}]},
         { code: "a() && b", options: [{ allowShortCircuit: true }], errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement"}]},
         { code: "a ? b : 0", options: [{ allowTernary: true }], errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement"}]},
@@ -106,32 +154,73 @@ ruleTester.run("no-unused-expressions", rule, {
             code: "`untagged template literal`",
             options: [{ allowTaggedTemplates: true }],
             parserOptions: { ecmaVersion: 6},
-            errors: ["Expected an assignment or function call and instead saw an expression."]
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
         },
         {
             code: "`untagged template literal`",
             options: [{ allowTaggedTemplates: false }],
             parserOptions: { ecmaVersion: 6},
-            errors: ["Expected an assignment or function call and instead saw an expression."]
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
         },
         {
             code: "tag`tagged template literal`",
             options: [{ allowTaggedTemplates: false }],
             parserOptions: { ecmaVersion: 6},
-            errors: ["Expected an assignment or function call and instead saw an expression."]
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
         },
         {
             code: "`untagged template literal`",
             parserOptions: { ecmaVersion: 6 },
-            errors: ["Expected an assignment or function call and instead saw an expression."]
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
         },
         {
             code: "tag`tagged template literal`",
             parserOptions: { ecmaVersion: 6 },
-            errors: ["Expected an assignment or function call and instead saw an expression."]
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
+        },
+
+        // Optional chaining
+        {
+            code: "obj?.foo",
+            parserOptions: { ecmaVersion: 2020 },
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
+        },
+        {
+            code: "obj?.foo.bar",
+            parserOptions: { ecmaVersion: 2020 },
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
+        },
+        {
+            code: "obj?.foo().bar",
+            parserOptions: { ecmaVersion: 2020 },
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
+        },
+        // JSX
+        {
+            code: "<div />",
+            options: [{ enforceForJSX: true }],
+            parserOptions: { ecmaFeatures: { jsx: true } },
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
+        },
+        {
+            code: "<></>",
+            options: [{ enforceForJSX: true }],
+            parserOptions: { ecmaFeatures: { jsx: true } },
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
         },
+
         // Chai statements
-        { code: "foo.expect('bar').not.to.pass;", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }]},
-        { code: "should.not.pass;", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }] },
+        { code: "foo.expect('bar').not.to.pass;", errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]},
+        { code: "should.not.pass;", errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }] },
+        {
+            code: "foo?.expect.to.be.true;",
+            parserOptions: { ecmaVersion: 11 },
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
+        },
+        {
+            code: "foo?.bar?.expect.to.be.true;",
+            parserOptions: { ecmaVersion: 11 },
+            errors: [{ messageId: "unusedExpression", type: "ExpressionStatement" }]
+        }
     ]
 });

package/lib/rules/og-rule.js

@@ -1,126 +0,0 @@
-/**
- * @fileoverview Flag expressions in statement position that do not side effect
- * @author Michael Ficarra
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = {
-    meta: {
-        docs: {
-            description: "disallow unused expressions",
-            category: "Best Practices",
-            recommended: false
-        },
-
-        schema: [
-            {
-                type: "object",
-                properties: {
-                    allowShortCircuit: {
-                        type: "boolean"
-                    },
-                    allowTernary: {
-                        type: "boolean"
-                    },
-                    allowTaggedTemplates: {
-                        type: "boolean"
-                    }
-                },
-                additionalProperties: false
-            }
-        ]
-    },
-
-    create(context) {
-        const config = context.options[0] || {},
-            allowShortCircuit = config.allowShortCircuit || false,
-            allowTernary = config.allowTernary || false,
-            allowTaggedTemplates = config.allowTaggedTemplates || false;
-
-        /**
-         * @param {ASTNode} node - any node
-         * @returns {boolean} whether the given node structurally represents a directive
-         */
-        function looksLikeDirective(node) {
-            return node.type === "ExpressionStatement" &&
-                node.expression.type === "Literal" && typeof node.expression.value === "string";
-        }
-
-        /**
-         * @param {Function} predicate - ([a] -> Boolean) the function used to make the determination
-         * @param {a[]} list - the input list
-         * @returns {a[]} the leading sequence of members in the given list that pass the given predicate
-         */
-        function takeWhile(predicate, list) {
-            for (let i = 0; i < list.length; ++i) {
-                if (!predicate(list[i])) {
-                    return list.slice(0, i);
-                }
-            }
-            return list.slice();
-        }
-
-        /**
-         * @param {ASTNode} node - a Program or BlockStatement node
-         * @returns {ASTNode[]} the leading sequence of directive nodes in the given node's body
-         */
-        function directives(node) {
-            return takeWhile(looksLikeDirective, node.body);
-        }
-
-        /**
-         * @param {ASTNode} node - any node
-         * @param {ASTNode[]} ancestors - the given node's ancestors
-         * @returns {boolean} whether the given node is considered a directive in its current position
-         */
-        function isDirective(node, ancestors) {
-            const parent = ancestors[ancestors.length - 1],
-                grandparent = ancestors[ancestors.length - 2];
-
-            return (parent.type === "Program" || parent.type === "BlockStatement" &&
-                    (/Function/.test(grandparent.type))) &&
-                    directives(parent).indexOf(node) >= 0;
-        }
-
-        /**
-         * Determines whether or not a given node is a valid expression. Recurses on short circuit eval and ternary nodes if enabled by flags.
-         * @param {ASTNode} node - any node
-         * @returns {boolean} whether the given node is a valid expression
-         */
-        function isValidExpression(node) {
-            if (allowTernary) {
-
-                // Recursive check for ternary and logical expressions
-                if (node.type === "ConditionalExpression") {
-                    return isValidExpression(node.consequent) && isValidExpression(node.alternate);
-                }
-            }
-
-            if (allowShortCircuit) {
-                if (node.type === "LogicalExpression") {
-                    return isValidExpression(node.right);
-                }
-            }
-
-            if (allowTaggedTemplates && node.type === "TaggedTemplateExpression") {
-                return true;
-            }
-
-            return /^(?:Assignment|Call|New|Update|Yield|Await)Expression$/.test(node.type) ||
-                (node.type === "UnaryExpression" && ["delete", "void"].indexOf(node.operator) >= 0);
-        }
-
-        return {
-            ExpressionStatement(node) {
-                if (!isValidExpression(node.expression) && !isDirective(node, context.getAncestors())) {
-                    context.report({ node, message: "Expected an assignment or function call and instead saw an expression." });
-                }
-            }
-        };
-
-    }
-};