eslint-plugin-chai-friendly 0.5.0 → 0.6.0

package/.editorconfig

@@ -8,5 +8,8 @@ charset = utf-8
 end_of_line = lf
 insert_final_newline = true
 indent_style = space
-indent_size = 2
+indent_size = 4
 trim_trailing_whitespace = true
+
+[*.json]
+indent_size = 2

package/.eslintignore

@@ -1 +1,2 @@
 node_modules
+!.eslintrc.js

package/.eslintrc.js

@@ -1,6 +1,12 @@
+'use strict';
+
 module.exports = {
-  extends: ['eslint:recommended'],
-  env: {
-    node: true
-  }
+    extends: ['eslint:recommended'],
+    env: {
+        node: true
+    },
+    rules: {
+        strict: ['error'],
+        indent: ['error', 4]
+    }
 };

package/.nyc_output/fd38766d-533f-46d0-9f65-df594829ca11.json

@@ -0,0 +1 @@
+{"/Users/user/repos/eslint-plugin-chai-friendly/lib/rules/no-unused-expressions.js":{"path":"/Users/user/repos/eslint-plugin-chai-friendly/lib/rules/no-unused-expressions.js","statementMap":{"0":{"start":{"line":12,"column":0},"end":{"line":212,"column":2}},"1":{"start":{"line":41,"column":21},"end":{"line":41,"column":45}},"2":{"start":{"line":42,"column":32},"end":{"line":42,"column":65}},"3":{"start":{"line":43,"column":27},"end":{"line":43,"column":55}},"4":{"start":{"line":44,"column":35},"end":{"line":44,"column":71}},"5":{"start":{"line":52,"column":12},"end":{"line":53,"column":96}},"6":{"start":{"line":62,"column":12},"end":{"line":66,"column":13}},"7":{"start":{"line":62,"column":25},"end":{"line":62,"column":26}},"8":{"start":{"line":63,"column":16},"end":{"line":65,"column":17}},"9":{"start":{"line":64,"column":20},"end":{"line":64,"column":44}},"10":{"start":{"line":67,"column":12},"end":{"line":67,"column":32}},"11":{"start":{"line":75,"column":12},"end":{"line":75,"column":60}},"12":{"start":{"line":84,"column":25},"end":{"line":84,"column":56}},"13":{"start":{"line":85,"column":30},"end":{"line":85,"column":61}},"14":{"start":{"line":87,"column":12},"end":{"line":89,"column":58}},"15":{"start":{"line":98,"column":12},"end":{"line":104,"column":13}},"16":{"start":{"line":101,"column":16},"end":{"line":103,"column":17}},"17":{"start":{"line":102,"column":20},"end":{"line":102,"column":99}},"18":{"start":{"line":105,"column":12},"end":{"line":109,"column":13}},"19":{"start":{"line":106,"column":16},"end":{"line":108,"column":17}},"20":{"start":{"line":107,"column":20},"end":{"line":107,"column":57}},"21":{"start":{"line":111,"column":12},"end":{"line":113,"column":13}},"22":{"start":{"line":112,"column":16},"end":{"line":112,"column":28}},"23":{"start":{"line":115,"column":12},"end":{"line":116,"column":100}},"24":{"start":{"line":126,"column":29},"end":{"line":126,"column":44}},"25":{"start":{"line":127,"column":12},"end":{"line":129,"column":13}},"26":{"start":{"line":128,"column":16},"end":{"line":128,"column":29}},"27":{"start":{"line":131,"column":33},"end":{"line":131,"column":75}},"28":{"start":{"line":133,"column":12},"end":{"line":133,"column":33}},"29":{"start":{"line":143,"column":12},"end":{"line":145,"column":13}},"30":{"start":{"line":144,"column":16},"end":{"line":144,"column":28}},"31":{"start":{"line":148,"column":12},"end":{"line":150,"column":13}},"32":{"start":{"line":149,"column":16},"end":{"line":149,"column":51}},"33":{"start":{"line":151,"column":12},"end":{"line":153,"column":13}},"34":{"start":{"line":152,"column":16},"end":{"line":152,"column":51}},"35":{"start":{"line":156,"column":12},"end":{"line":156,"column":24}},"36":{"start":{"line":166,"column":29},"end":{"line":166,"column":44}},"37":{"start":{"line":167,"column":12},"end":{"line":169,"column":13}},"38":{"start":{"line":168,"column":16},"end":{"line":168,"column":29}},"39":{"start":{"line":171,"column":32},"end":{"line":171,"column":74}},"40":{"start":{"line":173,"column":12},"end":{"line":173,"column":33}},"41":{"start":{"line":183,"column":12},"end":{"line":185,"column":13}},"42":{"start":{"line":184,"column":16},"end":{"line":184,"column":28}},"43":{"start":{"line":188,"column":12},"end":{"line":190,"column":13}},"44":{"start":{"line":189,"column":16},"end":{"line":189,"column":51}},"45":{"start":{"line":191,"column":12},"end":{"line":193,"column":13}},"46":{"start":{"line":192,"column":16},"end":{"line":192,"column":51}},"47":{"start":{"line":196,"column":12},"end":{"line":196,"column":24}},"48":{"start":{"line":200,"column":8},"end":{"line":210,"column":10}},"49":{"start":{"line":202,"column":28},"end":{"line":205,"column":45}},"50":{"start":{"line":206,"column":16},"end":{"line":208,"column":17}},"51":{"start":{"line":207,"column":20},"end":{"line":207,"column":115}}},"fnMap":{"0":{"name":"(anonymous_0)","decl":{"start":{"line":40,"column":12},"end":{"line":40,"column":13}},"loc":{"start":{"line":40,"column":31},"end":{"line":211,"column":5}},"line":40},"1":{"name":"looksLikeDirective","decl":{"start":{"line":51,"column":17},"end":{"line":51,"column":35}},"loc":{"start":{"line":51,"column":42},"end":{"line":54,"column":9}},"line":51},"2":{"name":"takeWhile","decl":{"start":{"line":61,"column":17},"end":{"line":61,"column":26}},"loc":{"start":{"line":61,"column":44},"end":{"line":68,"column":9}},"line":61},"3":{"name":"directives","decl":{"start":{"line":74,"column":17},"end":{"line":74,"column":27}},"loc":{"start":{"line":74,"column":34},"end":{"line":76,"column":9}},"line":74},"4":{"name":"isDirective","decl":{"start":{"line":83,"column":17},"end":{"line":83,"column":28}},"loc":{"start":{"line":83,"column":46},"end":{"line":90,"column":9}},"line":83},"5":{"name":"isValidExpression","decl":{"start":{"line":97,"column":17},"end":{"line":97,"column":34}},"loc":{"start":{"line":97,"column":41},"end":{"line":117,"column":9}},"line":97},"6":{"name":"isChaiExpectCall","decl":{"start":{"line":125,"column":17},"end":{"line":125,"column":33}},"loc":{"start":{"line":125,"column":40},"end":{"line":134,"column":9}},"line":125},"7":{"name":"findExpectCall","decl":{"start":{"line":141,"column":17},"end":{"line":141,"column":31}},"loc":{"start":{"line":141,"column":38},"end":{"line":157,"column":9}},"line":141},"8":{"name":"isChaiShouldCall","decl":{"start":{"line":165,"column":17},"end":{"line":165,"column":33}},"loc":{"start":{"line":165,"column":40},"end":{"line":174,"column":9}},"line":165},"9":{"name":"findShouldCall","decl":{"start":{"line":181,"column":17},"end":{"line":181,"column":31}},"loc":{"start":{"line":181,"column":38},"end":{"line":197,"column":9}},"line":181},"10":{"name":"(anonymous_10)","decl":{"start":{"line":201,"column":33},"end":{"line":201,"column":34}},"loc":{"start":{"line":201,"column":48},"end":{"line":209,"column":13}},"line":201}},"branchMap":{"0":{"loc":{"start":{"line":41,"column":21},"end":{"line":41,"column":45}},"type":"binary-expr","locations":[{"start":{"line":41,"column":21},"end":{"line":41,"column":39}},{"start":{"line":41,"column":43},"end":{"line":41,"column":45}}],"line":41},"1":{"loc":{"start":{"line":42,"column":32},"end":{"line":42,"column":65}},"type":"binary-expr","locations":[{"start":{"line":42,"column":32},"end":{"line":42,"column":56}},{"start":{"line":42,"column":60},"end":{"line":42,"column":65}}],"line":42},"2":{"loc":{"start":{"line":43,"column":27},"end":{"line":43,"column":55}},"type":"binary-expr","locations":[{"start":{"line":43,"column":27},"end":{"line":43,"column":46}},{"start":{"line":43,"column":50},"end":{"line":43,"column":55}}],"line":43},"3":{"loc":{"start":{"line":44,"column":35},"end":{"line":44,"column":71}},"type":"binary-expr","locations":[{"start":{"line":44,"column":35},"end":{"line":44,"column":62}},{"start":{"line":44,"column":66},"end":{"line":44,"column":71}}],"line":44},"4":{"loc":{"start":{"line":52,"column":19},"end":{"line":53,"column":95}},"type":"binary-expr","locations":[{"start":{"line":52,"column":19},"end":{"line":52,"column":54}},{"start":{"line":53,"column":16},"end":{"line":53,"column":50}},{"start":{"line":53,"column":54},"end":{"line":53,"column":95}}],"line":52},"5":{"loc":{"start":{"line":63,"column":16},"end":{"line":65,"column":17}},"type":"if","locations":[{"start":{"line":63,"column":16},"end":{"line":65,"column":17}},{"start":{"line":63,"column":16},"end":{"line":65,"column":17}}],"line":63},"6":{"loc":{"start":{"line":87,"column":19},"end":{"line":89,"column":57}},"type":"binary-expr","locations":[{"start":{"line":87,"column":20},"end":{"line":87,"column":45}},{"start":{"line":87,"column":49},"end":{"line":87,"column":81}},{"start":{"line":88,"column":21},"end":{"line":88,"column":54}},{"start":{"line":89,"column":20},"end":{"line":89,"column":57}}],"line":87},"7":{"loc":{"start":{"line":98,"column":12},"end":{"line":104,"column":13}},"type":"if","locations":[{"start":{"line":98,"column":12},"end":{"line":104,"column":13}},{"start":{"line":98,"column":12},"end":{"line":104,"column":13}}],"line":98},"8":{"loc":{"start":{"line":101,"column":16},"end":{"line":103,"column":17}},"type":"if","locations":[{"start":{"line":101,"column":16},"end":{"line":103,"column":17}},{"start":{"line":101,"column":16},"end":{"line":103,"column":17}}],"line":101},"9":{"loc":{"start":{"line":102,"column":27},"end":{"line":102,"column":98}},"type":"binary-expr","locations":[{"start":{"line":102,"column":27},"end":{"line":102,"column":61}},{"start":{"line":102,"column":65},"end":{"line":102,"column":98}}],"line":102},"10":{"loc":{"start":{"line":105,"column":12},"end":{"line":109,"column":13}},"type":"if","locations":[{"start":{"line":105,"column":12},"end":{"line":109,"column":13}},{"start":{"line":105,"column":12},"end":{"line":109,"column":13}}],"line":105},"11":{"loc":{"start":{"line":106,"column":16},"end":{"line":108,"column":17}},"type":"if","locations":[{"start":{"line":106,"column":16},"end":{"line":108,"column":17}},{"start":{"line":106,"column":16},"end":{"line":108,"column":17}}],"line":106},"12":{"loc":{"start":{"line":111,"column":12},"end":{"line":113,"column":13}},"type":"if","locations":[{"start":{"line":111,"column":12},"end":{"line":113,"column":13}},{"start":{"line":111,"column":12},"end":{"line":113,"column":13}}],"line":111},"13":{"loc":{"start":{"line":111,"column":16},"end":{"line":111,"column":80}},"type":"binary-expr","locations":[{"start":{"line":111,"column":16},"end":{"line":111,"column":36}},{"start":{"line":111,"column":40},"end":{"line":111,"column":80}}],"line":111},"14":{"loc":{"start":{"line":115,"column":19},"end":{"line":116,"column":99}},"type":"binary-expr","locations":[{"start":{"line":115,"column":19},"end":{"line":115,"column":98}},{"start":{"line":116,"column":17},"end":{"line":116,"column":48}},{"start":{"line":116,"column":52},"end":{"line":116,"column":98}}],"line":115},"15":{"loc":{"start":{"line":127,"column":12},"end":{"line":129,"column":13}},"type":"if","locations":[{"start":{"line":127,"column":12},"end":{"line":129,"column":13}},{"start":{"line":127,"column":12},"end":{"line":129,"column":13}}],"line":127},"16":{"loc":{"start":{"line":143,"column":12},"end":{"line":145,"column":13}},"type":"if","locations":[{"start":{"line":143,"column":12},"end":{"line":145,"column":13}},{"start":{"line":143,"column":12},"end":{"line":145,"column":13}}],"line":143},"17":{"loc":{"start":{"line":143,"column":16},"end":{"line":143,"column":116}},"type":"binary-expr","locations":[{"start":{"line":143,"column":16},"end":{"line":143,"column":46}},{"start":{"line":143,"column":50},"end":{"line":143,"column":83}},{"start":{"line":143,"column":87},"end":{"line":143,"column":116}}],"line":143},"18":{"loc":{"start":{"line":148,"column":12},"end":{"line":150,"column":13}},"type":"if","locations":[{"start":{"line":148,"column":12},"end":{"line":150,"column":13}},{"start":{"line":148,"column":12},"end":{"line":150,"column":13}}],"line":148},"19":{"loc":{"start":{"line":151,"column":12},"end":{"line":153,"column":13}},"type":"if","locations":[{"start":{"line":151,"column":12},"end":{"line":153,"column":13}},{"start":{"line":151,"column":12},"end":{"line":153,"column":13}}],"line":151},"20":{"loc":{"start":{"line":167,"column":12},"end":{"line":169,"column":13}},"type":"if","locations":[{"start":{"line":167,"column":12},"end":{"line":169,"column":13}},{"start":{"line":167,"column":12},"end":{"line":169,"column":13}}],"line":167},"21":{"loc":{"start":{"line":183,"column":12},"end":{"line":185,"column":13}},"type":"if","locations":[{"start":{"line":183,"column":12},"end":{"line":185,"column":13}},{"start":{"line":183,"column":12},"end":{"line":185,"column":13}}],"line":183},"22":{"loc":{"start":{"line":183,"column":16},"end":{"line":183,"column":100}},"type":"binary-expr","locations":[{"start":{"line":183,"column":16},"end":{"line":183,"column":48}},{"start":{"line":183,"column":52},"end":{"line":183,"column":65}},{"start":{"line":183,"column":69},"end":{"line":183,"column":100}}],"line":183},"23":{"loc":{"start":{"line":188,"column":12},"end":{"line":190,"column":13}},"type":"if","locations":[{"start":{"line":188,"column":12},"end":{"line":190,"column":13}},{"start":{"line":188,"column":12},"end":{"line":190,"column":13}}],"line":188},"24":{"loc":{"start":{"line":191,"column":12},"end":{"line":193,"column":13}},"type":"if","locations":[{"start":{"line":191,"column":12},"end":{"line":193,"column":13}},{"start":{"line":191,"column":12},"end":{"line":193,"column":13}}],"line":191},"25":{"loc":{"start":{"line":202,"column":28},"end":{"line":205,"column":45}},"type":"binary-expr","locations":[{"start":{"line":202,"column":28},"end":{"line":202,"column":62}},{"start":{"line":203,"column":23},"end":{"line":203,"column":64}},{"start":{"line":204,"column":23},"end":{"line":204,"column":45}},{"start":{"line":205,"column":23},"end":{"line":205,"column":45}}],"line":202},"26":{"loc":{"start":{"line":206,"column":16},"end":{"line":208,"column":17}},"type":"if","locations":[{"start":{"line":206,"column":16},"end":{"line":208,"column":17}},{"start":{"line":206,"column":16},"end":{"line":208,"column":17}}],"line":206}},"s":{"0":1,"1":62,"2":62,"3":62,"4":62,"5":56,"6":42,"7":42,"8":56,"9":41,"10":1,"11":42,"12":44,"13":44,"14":44,"15":83,"16":15,"17":5,"18":78,"19":14,"20":6,"21":72,"22":1,"23":71,"24":35,"25":35,"26":27,"27":8,"28":8,"29":35,"30":2,"31":33,"32":24,"33":9,"34":3,"35":6,"36":33,"37":33,"38":27,"39":6,"40":6,"41":19,"42":3,"43":16,"44":11,"45":5,"46":2,"47":3,"48":62,"49":69,"50":69,"51":30},"f":{"0":62,"1":56,"2":42,"3":42,"4":44,"5":83,"6":35,"7":35,"8":33,"9":19,"10":69},"b":{"0":[62,45],"1":[62,55],"2":[62,56],"3":[62,59],"4":[56,52,16],"5":[41,15],"6":[44,10,10,42],"7":[15,68],"8":[5,10],"9":[5,3],"10":[14,64],"11":[6,8],"12":[1,71],"13":[72,3],"14":[71,46,4],"15":[27,8],"16":[2,33],"17":[35,5,2],"18":[24,9],"19":[3,6],"20":[27,6],"21":[3,16],"22":[19,14,14],"23":[11,5],"24":[2,3],"25":[69,44,35,33],"26":[30,39]},"_coverageSchema":"1a1c01bbd47fc00a2c39e90264f33305004495a9","hash":"05973dc07792da4b010cbf63b0206f454d6787a3","contentHash":"d41ee3dc8a8706e57c6465dd74c3a83be88f133f2d09a982d81644df7fffac22"}}

package/.nyc_output/processinfo/fd38766d-533f-46d0-9f65-df594829ca11.json

@@ -0,0 +1 @@
+{"parent":null,"pid":73645,"argv":["/usr/local/bin/node","/Users/user/repos/eslint-plugin-chai-friendly/node_modules/.bin/mocha","tests","--recursive"],"execArgv":[],"cwd":"/Users/user/repos/eslint-plugin-chai-friendly","time":1587732197220,"ppid":73644,"coverageFilename":"/Users/user/repos/eslint-plugin-chai-friendly/.nyc_output/fd38766d-533f-46d0-9f65-df594829ca11.json","externalId":"","uuid":"fd38766d-533f-46d0-9f65-df594829ca11","files":["/Users/user/repos/eslint-plugin-chai-friendly/lib/rules/no-unused-expressions.js"]}

package/.nyc_output/processinfo/index.json

@@ -0,0 +1 @@
+{"processes":{"fd38766d-533f-46d0-9f65-df594829ca11":{"parent":null,"children":[]}},"files":{"/Users/user/repos/eslint-plugin-chai-friendly/lib/rules/no-unused-expressions.js":["fd38766d-533f-46d0-9f65-df594829ca11"]},"externalIds":{}}

package/README.md

@@ -1,6 +1,6 @@
 # eslint-plugin-chai-friendly
 
-[![npm](https://img.shields.io/npm/v/eslint-plugin-chai-friendly.svg)](https://www.npmjs.com/package/eslint-plugin-chai-friendly) [![npm](https://img.shields.io/npm/dm/eslint-plugin-chai-friendly.svg)](https://www.npmjs.com/package/eslint-plugin-chai-friendly)
+[![npm](https://img.shields.io/npm/v/eslint-plugin-chai-friendly.svg)](https://www.npmjs.com/package/eslint-plugin-chai-friendly) [![npm](https://img.shields.io/npm/dm/eslint-plugin-chai-friendly)](https://www.npmjs.com/package/eslint-plugin-chai-friendly)
 
 This plugin overrides `no-unused-expressions` to make it friendly towards chai `expect` and `should` statements.
 

package/lib/index.js

@@ -5,16 +5,16 @@
 "use strict";
 
 module.exports = {
-  configs: {
-    recommended: {
-      plugins: ['chai-friendly'],
-      rules: {
-        'chai-friendly/no-unused-expressions': 'error',
-        'no-unused-expressions': 'off'
-      }
+    configs: {
+        recommended: {
+            plugins: ['chai-friendly'],
+            rules: {
+                'chai-friendly/no-unused-expressions': 'error',
+                'no-unused-expressions': 'off'
+            }
+        }
+    },
+    rules: {
+        'no-unused-expressions': require('./rules/no-unused-expressions')
     }
-  },
-  rules: {
-    'no-unused-expressions': require('./rules/no-unused-expressions')
-  }
 };

package/lib/rules/no-unused-expressions.js

@@ -11,6 +11,8 @@
 
 module.exports = {
     meta: {
+        type: "suggestion",
+
         docs: {
             description: "disallow unused expressions",
             category: "Best Practices",
@@ -110,7 +112,7 @@ module.exports = {
                 return true;
             }
 
-            return /^(?:Assignment|Call|New|Update|Yield|Await)Expression$/.test(node.type) ||
+            return /^(?:Assignment|Call|New|Update|Yield|Await|Import)Expression$/.test(node.type) ||
                 (node.type === "UnaryExpression" && ["delete", "void"].indexOf(node.operator) >= 0);
         }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-chai-friendly",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "description": "This plugin makes 'no-unused-expressions' rule friendly towards chai expect statements.",
   "keywords": [
     "eslint",
@@ -24,15 +24,17 @@
   "main": "lib/index.js",
   "scripts": {
     "lint": "eslint .",
-    "test": "mocha tests --recursive"
+    "test": "nyc mocha tests --recursive"
   },
   "dependencies": {},
   "peerDependencies": {
     "eslint": ">=3.0.0"
   },
   "devDependencies": {
+    "babel-eslint": "^10.1.0",
     "eslint": "~6.6.0",
-    "mocha": "^6.2.2"
+    "mocha": "^7.1.1",
+    "nyc": "^15.0.1"
   },
   "engines": {
     "node": ">=0.10.0"

package/tests/lib/rules/no-unused-expressions.js

@@ -20,6 +20,10 @@ var ruleTester = new RuleTester();
 
 ruleTester.run("no-unused-expressions", rule, {
     valid: [
+        {
+            code: "import('./some-file.js');",
+            parser: require.resolve("babel-eslint")
+        },
         "function f(){}",
         "a = b",
         "new a",

package/lib/rules/og-rule.js

@@ -1,126 +0,0 @@
-/**
- * @fileoverview Flag expressions in statement position that do not side effect
- * @author Michael Ficarra
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-module.exports = {
-    meta: {
-        docs: {
-            description: "disallow unused expressions",
-            category: "Best Practices",
-            recommended: false
-        },
-
-        schema: [
-            {
-                type: "object",
-                properties: {
-                    allowShortCircuit: {
-                        type: "boolean"
-                    },
-                    allowTernary: {
-                        type: "boolean"
-                    },
-                    allowTaggedTemplates: {
-                        type: "boolean"
-                    }
-                },
-                additionalProperties: false
-            }
-        ]
-    },
-
-    create(context) {
-        const config = context.options[0] || {},
-            allowShortCircuit = config.allowShortCircuit || false,
-            allowTernary = config.allowTernary || false,
-            allowTaggedTemplates = config.allowTaggedTemplates || false;
-
-        /**
-         * @param {ASTNode} node - any node
-         * @returns {boolean} whether the given node structurally represents a directive
-         */
-        function looksLikeDirective(node) {
-            return node.type === "ExpressionStatement" &&
-                node.expression.type === "Literal" && typeof node.expression.value === "string";
-        }
-
-        /**
-         * @param {Function} predicate - ([a] -> Boolean) the function used to make the determination
-         * @param {a[]} list - the input list
-         * @returns {a[]} the leading sequence of members in the given list that pass the given predicate
-         */
-        function takeWhile(predicate, list) {
-            for (let i = 0; i < list.length; ++i) {
-                if (!predicate(list[i])) {
-                    return list.slice(0, i);
-                }
-            }
-            return list.slice();
-        }
-
-        /**
-         * @param {ASTNode} node - a Program or BlockStatement node
-         * @returns {ASTNode[]} the leading sequence of directive nodes in the given node's body
-         */
-        function directives(node) {
-            return takeWhile(looksLikeDirective, node.body);
-        }
-
-        /**
-         * @param {ASTNode} node - any node
-         * @param {ASTNode[]} ancestors - the given node's ancestors
-         * @returns {boolean} whether the given node is considered a directive in its current position
-         */
-        function isDirective(node, ancestors) {
-            const parent = ancestors[ancestors.length - 1],
-                grandparent = ancestors[ancestors.length - 2];
-
-            return (parent.type === "Program" || parent.type === "BlockStatement" &&
-                    (/Function/.test(grandparent.type))) &&
-                    directives(parent).indexOf(node) >= 0;
-        }
-
-        /**
-         * Determines whether or not a given node is a valid expression. Recurses on short circuit eval and ternary nodes if enabled by flags.
-         * @param {ASTNode} node - any node
-         * @returns {boolean} whether the given node is a valid expression
-         */
-        function isValidExpression(node) {
-            if (allowTernary) {
-
-                // Recursive check for ternary and logical expressions
-                if (node.type === "ConditionalExpression") {
-                    return isValidExpression(node.consequent) && isValidExpression(node.alternate);
-                }
-            }
-
-            if (allowShortCircuit) {
-                if (node.type === "LogicalExpression") {
-                    return isValidExpression(node.right);
-                }
-            }
-
-            if (allowTaggedTemplates && node.type === "TaggedTemplateExpression") {
-                return true;
-            }
-
-            return /^(?:Assignment|Call|New|Update|Yield|Await)Expression$/.test(node.type) ||
-                (node.type === "UnaryExpression" && ["delete", "void"].indexOf(node.operator) >= 0);
-        }
-
-        return {
-            ExpressionStatement(node) {
-                if (!isValidExpression(node.expression) && !isDirective(node, context.getAncestors())) {
-                    context.report({ node, message: "Expected an assignment or function call and instead saw an expression." });
-                }
-            }
-        };
-
-    }
-};