eslint-plugin-absolute 0.2.2 → 0.2.3

package/dist/index.js

@@ -1114,7 +1114,7 @@ var sortExports = {
       });
       return unsorted ? messageId : null;
     };
-    const checkForwardDependencies = (items) => {
+    const hasForwardDependenciesInOrder = (items) => {
       const exportNames = items.map((item) => item.name);
       return items.some((item, idx) => {
         const laterNames = new Set(exportNames.slice(idx + 1));
@@ -1130,6 +1130,27 @@ var sortExports = {
         return false;
       });
     };
+    const wouldCreateForwardDependencies = (items, sortedItems) => {
+      const sortedIndices = new Map(sortedItems.map((item, idx) => [item.name, idx]));
+      const exportNames = new Set(items.map((item) => item.name));
+      return items.some((item) => {
+        const itemIndex = sortedIndices.get(item.name);
+        if (itemIndex === undefined) {
+          return false;
+        }
+        const dependencies = getImmediateDependencyNames(item.node);
+        for (const dependency of dependencies) {
+          if (!exportNames.has(dependency)) {
+            continue;
+          }
+          const dependencyIndex = sortedIndices.get(dependency);
+          if (dependencyIndex !== undefined && itemIndex < dependencyIndex) {
+            return true;
+          }
+        }
+        return false;
+      });
+    };
     const processExportBlock = (block) => {
       if (block.length < minKeys) {
         return;
@@ -1142,10 +1163,13 @@ var sortExports = {
       if (!messageId) {
         return;
       }
-      if (checkForwardDependencies(items)) {
+      if (hasForwardDependenciesInOrder(items)) {
         return;
       }
       const sortedItems = items.slice().sort(sortComparator);
+      if (wouldCreateForwardDependencies(items, sortedItems)) {
+        return;
+      }
       const expectedOrder = sortedItems.map((item) => item.name).join(", ");
       const [firstNode] = block;
       const lastNode = block[block.length - 1];

package/package.json

@@ -30,5 +30,5 @@
 		"typecheck": "bun run tsc --noEmit"
 	},
 	"type": "module",
-	"version": "0.2.2"
+	"version": "0.2.3"
 }

package/src/rules/sort-exports.ts

@@ -388,7 +388,7 @@ export const sortExports: TSESLint.RuleModule<MessageIds, Options> = {
 			return unsorted ? messageId : null;
 		};
 
-		const checkForwardDependencies = (items: ExportItem[]) => {
+		const hasForwardDependenciesInOrder = (items: ExportItem[]) => {
 			const exportNames = items.map((item) => item.name);
 			return items.some((item, idx) => {
 				const laterNames = new Set(exportNames.slice(idx + 1));
@@ -406,6 +406,37 @@ export const sortExports: TSESLint.RuleModule<MessageIds, Options> = {
 			});
 		};
 
+		const wouldCreateForwardDependencies = (
+			items: ExportItem[],
+			sortedItems: ExportItem[]
+		) => {
+			const sortedIndices = new Map(
+				sortedItems.map((item, idx) => [item.name, idx])
+			);
+			const exportNames = new Set(items.map((item) => item.name));
+
+			return items.some((item) => {
+				const itemIndex = sortedIndices.get(item.name);
+				if (itemIndex === undefined) {
+					return false;
+				}
+
+				const dependencies = getImmediateDependencyNames(item.node);
+				for (const dependency of dependencies) {
+					if (!exportNames.has(dependency)) {
+						continue;
+					}
+
+					const dependencyIndex = sortedIndices.get(dependency);
+					if (dependencyIndex !== undefined && itemIndex < dependencyIndex) {
+						return true;
+					}
+				}
+
+				return false;
+			});
+		};
+
 		const processExportBlock = (
 			block: TSESTree.ExportNamedDeclaration[]
 		) => {
@@ -424,12 +455,16 @@ export const sortExports: TSESLint.RuleModule<MessageIds, Options> = {
 				return;
 			}
 
-			if (checkForwardDependencies(items)) {
+			if (hasForwardDependenciesInOrder(items)) {
 				return;
 			}
 
 			const sortedItems = items.slice().sort(sortComparator);
 
+			if (wouldCreateForwardDependencies(items, sortedItems)) {
+				return;
+			}
+
 			const expectedOrder = sortedItems
 				.map((item) => item.name)
 				.join(", ");