eslint-plugin-absolute 0.2.0 → 0.2.1

package/src/rules/spring-naming-convention.ts

@@ -7,33 +7,92 @@ type MessageIds =
 	| "secondMustMatch"
 	| "pluralRequired";
 
+const SPRINGS_SUFFIX = "Springs";
+
+const checkUseSpring = (
+	context: TSESLint.RuleContext<MessageIds, Options>,
+	firstElem: TSESTree.Identifier,
+	secondElem: TSESTree.Identifier
+) => {
+	const firstName = firstElem.name;
+	const secondName = secondElem.name;
+
+	if (!firstName.endsWith(SPRINGS_SUFFIX)) {
+		context.report({
+			messageId: "firstMustEndWithSprings",
+			node: firstElem
+		});
+		return;
+	}
+
+	const base = firstName.slice(0, -SPRINGS_SUFFIX.length);
+	if (!base) {
+		context.report({
+			messageId: "firstMustHaveBase",
+			node: firstElem
+		});
+		return;
+	}
+
+	const expectedSecond = `${base}Api`;
+	if (secondName !== expectedSecond) {
+		context.report({
+			data: { expected: expectedSecond },
+			messageId: "secondMustMatch",
+			node: secondElem
+		});
+	}
+};
+
+const checkUseSprings = (
+	context: TSESLint.RuleContext<MessageIds, Options>,
+	firstElem: TSESTree.Identifier,
+	secondElem: TSESTree.Identifier
+) => {
+	const firstName = firstElem.name;
+	const secondName = secondElem.name;
+
+	if (!firstName.endsWith(SPRINGS_SUFFIX)) {
+		context.report({
+			messageId: "firstMustEndWithSprings",
+			node: firstElem
+		});
+		return;
+	}
+
+	const basePlural = firstName.slice(0, -SPRINGS_SUFFIX.length);
+	if (!basePlural) {
+		context.report({
+			messageId: "firstMustHaveBase",
+			node: firstElem
+		});
+		return;
+	}
+
+	if (!basePlural.endsWith("s")) {
+		context.report({
+			messageId: "pluralRequired",
+			node: firstElem
+		});
+		return;
+	}
+
+	const expectedSecond = `${basePlural}Api`;
+	if (secondName !== expectedSecond) {
+		context.report({
+			data: { expected: expectedSecond },
+			messageId: "secondMustMatch",
+			node: secondElem
+		});
+	}
+};
+
 export const springNamingConvention: TSESLint.RuleModule<MessageIds, Options> =
 	{
-		meta: {
-			type: "problem",
-			docs: {
-				description:
-					"Enforce correct naming for useSpring and useSprings hook destructuring"
-			},
-			schema: [],
-			messages: {
-				firstMustEndWithSprings:
-					"The first variable must end with 'Springs'.",
-				firstMustHaveBase:
-					"The first variable must have a non-empty name before 'Springs'.",
-				secondMustMatch:
-					"The second variable must be named '{{expected}}'.",
-				pluralRequired:
-					"The first variable for useSprings should be plural (ending with 's') before 'Springs'."
-			}
-		},
-
-		defaultOptions: [],
-
 		create(context) {
 			return {
 				VariableDeclarator(node: TSESTree.VariableDeclarator) {
-					const init = node.init;
+					const { init } = node;
 
 					if (
 						!init ||
@@ -52,13 +111,12 @@ export const springNamingConvention: TSESLint.RuleModule<MessageIds, Options> =
 						return;
 					}
 
-					const elements = node.id.elements;
+					const { elements } = node.id;
 					if (elements.length < 2) {
 						return;
 					}
 
-					const firstElem = elements[0];
-					const secondElem = elements[1];
+					const [firstElem, secondElem] = elements;
 
 					if (
 						!firstElem ||
@@ -69,77 +127,34 @@ export const springNamingConvention: TSESLint.RuleModule<MessageIds, Options> =
 						return;
 					}
 
-					const firstName = firstElem.name;
-					const secondName = secondElem.name;
-
 					if (hookName === "useSpring") {
-						if (!firstName.endsWith("Springs")) {
-							context.report({
-								node: firstElem,
-								messageId: "firstMustEndWithSprings"
-							});
-							return;
-						}
-
-						const base = firstName.slice(0, -"Springs".length);
-						if (!base) {
-							context.report({
-								node: firstElem,
-								messageId: "firstMustHaveBase"
-							});
-							return;
-						}
-
-						const expectedSecond = `${base}Api`;
-						if (secondName !== expectedSecond) {
-							context.report({
-								node: secondElem,
-								messageId: "secondMustMatch",
-								data: { expected: expectedSecond }
-							});
-						}
+						checkUseSpring(context, firstElem, secondElem);
 						return;
 					}
 
 					if (hookName === "useSprings") {
-						if (!firstName.endsWith("Springs")) {
-							context.report({
-								node: firstElem,
-								messageId: "firstMustEndWithSprings"
-							});
-							return;
-						}
-
-						const basePlural = firstName.slice(
-							0,
-							-"Springs".length
-						);
-						if (!basePlural) {
-							context.report({
-								node: firstElem,
-								messageId: "firstMustHaveBase"
-							});
-							return;
-						}
-
-						if (!basePlural.endsWith("s")) {
-							context.report({
-								node: firstElem,
-								messageId: "pluralRequired"
-							});
-							return;
-						}
-
-						const expectedSecond = `${basePlural}Api`;
-						if (secondName !== expectedSecond) {
-							context.report({
-								node: secondElem,
-								messageId: "secondMustMatch",
-								data: { expected: expectedSecond }
-							});
-						}
+						checkUseSprings(context, firstElem, secondElem);
 					}
 				}
 			};
+		},
+		defaultOptions: [],
+		meta: {
+			docs: {
+				description:
+					"Enforce correct naming for useSpring and useSprings hook destructuring"
+			},
+			messages: {
+				firstMustEndWithSprings:
+					"The first variable must end with 'Springs'.",
+				firstMustHaveBase:
+					"The first variable must have a non-empty name before 'Springs'.",
+				pluralRequired:
+					"The first variable for useSprings should be plural (ending with 's') before 'Springs'.",
+				secondMustMatch:
+					"The second variable must be named '{{expected}}'."
+			},
+			schema: [],
+			type: "problem"
 		}
 	};

package/tsconfig.json

@@ -10,6 +10,8 @@
 		"strict": true,
 		"target": "ESNext",
 		"noUncheckedIndexedAccess": true,
+		"incremental": true,
+		"tsBuildInfoFile": ".absolutejs/tsconfig.tsbuildinfo",
 		"types": ["bun-types"]
 	}
 }