eslint-plugin-absolute 0.1.0 → 0.1.2

package/dist/index.js

@@ -1155,7 +1155,7 @@ var no_button_navigation_default = {
   meta: {
     type: "suggestion",
     docs: {
-      description: "Enforce using anchor tags for navigation instead of buttons with onClick handlers that use window navigation methods (e.g., window.location, window.open)",
+      description: "Enforce using anchor tags for navigation instead of buttons whose onClick handlers change the path. Allow only query/hash updates via window.location.search or history.replaceState(window.location.pathname + \u2026).",
       category: "Best Practices",
       recommended: false
     },
@@ -1164,25 +1164,74 @@ var no_button_navigation_default = {
   create(context) {
     function containsWindowNavigation(node) {
       let found = false;
-      function inspect(n) {
+      function inspect(n, parent) {
         if (found || !n || typeof n !== "object")
           return;
-        if (n.type === "MemberExpression" && n.object.type === "Identifier" && n.object.name === "window" && n.property.type === "Identifier" && (n.property.name === "open" || n.property.name === "location")) {
+        if (n.type === "MemberExpression" && n.object.type === "Identifier" && n.object.name === "window" && n.property.type === "Identifier" && n.property.name === "open") {
           found = true;
           return;
         }
+        if (n.type === "AssignmentExpression" && n.left.type === "MemberExpression") {
+          const left = n.left;
+          if (left.object.type === "Identifier" && left.object.name === "window" && left.property.type === "Identifier" && left.property.name === "location") {
+            found = true;
+            return;
+          }
+          if (left.object.type === "MemberExpression" && left.object.object.type === "Identifier" && left.object.object.name === "window" && left.object.property.type === "Identifier" && left.object.property.name === "location") {
+            found = true;
+            return;
+          }
+        }
+        if (n.type === "MemberExpression" && n.object.type === "MemberExpression" && n.object.object.type === "Identifier" && n.object.object.name === "window" && n.object.property.type === "Identifier" && n.object.property.name === "location" && n.property.type === "Identifier" && n.property.name === "replace") {
+          if (parent && parent.type === "CallExpression") {
+            found = true;
+            return;
+          }
+        }
+        if (n.type === "MemberExpression" && n.object.type === "MemberExpression" && n.object.object.type === "Identifier" && n.object.object.name === "window" && n.object.property.type === "Identifier" && n.object.property.name === "history" && n.property.type === "Identifier" && (n.property.name === "pushState" || n.property.name === "replaceState")) {
+          if (parent && parent.type === "CallExpression" && Array.isArray(parent.arguments) && parent.arguments.length >= 3) {
+            const urlArg = parent.arguments[2];
+            if (!urlUsesAllowedLocation(urlArg)) {
+              found = true;
+              return;
+            }
+          }
+        }
         for (const key of Object.keys(n)) {
           if (key === "parent")
             continue;
           const child = n[key];
           if (Array.isArray(child)) {
-            child.forEach(inspect);
+            child.forEach((c) => inspect(c, n));
           } else {
-            inspect(child);
+            inspect(child, n);
+          }
+        }
+      }
+      function urlUsesAllowedLocation(argNode) {
+        let allowed = false;
+        function check(n) {
+          if (allowed || !n || typeof n !== "object")
+            return;
+          if (n.type === "MemberExpression" && n.object.type === "MemberExpression" && n.object.object.type === "Identifier" && n.object.object.name === "window" && n.object.property.type === "Identifier" && n.object.property.name === "location" && n.property.type === "Identifier" && (n.property.name === "pathname" || n.property.name === "search" || n.property.name === "hash")) {
+            allowed = true;
+            return;
+          }
+          for (const key of Object.keys(n)) {
+            if (key === "parent")
+              continue;
+            const c = n[key];
+            if (Array.isArray(c)) {
+              c.forEach(check);
+            } else {
+              check(c);
+            }
           }
         }
+        check(argNode);
+        return allowed;
       }
-      inspect(node.type === "ArrowFunctionExpression" || node.type === "FunctionExpression" ? node.body : node);
+      inspect(node.type === "ArrowFunctionExpression" || node.type === "FunctionExpression" ? node.body : node, null);
       return found;
     }
     return {
@@ -1195,7 +1244,7 @@ var no_button_navigation_default = {
               if ((expr.type === "ArrowFunctionExpression" || expr.type === "FunctionExpression") && containsWindowNavigation(expr)) {
                 context.report({
                   node: attr,
-                  message: "Use an anchor tag for navigation instead of a button with an onClick handler that uses window navigation methods."
+                  message: "Use an anchor tag for navigation instead of a button with an onClick handler that changes the path. Only query/hash updates are allowed."
                 });
               }
             }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-absolute",
-	"version": "0.1.0",
+	"version": "0.1.2",
 	"description": "ESLint plugin for AbsoluteJS",
 	"repository": {
 		"type": "git",

package/src/rules/no-button-navigation.js

@@ -3,50 +3,162 @@ export default {
 		type: "suggestion",
 		docs: {
 			description:
-				"Enforce using anchor tags for navigation instead of buttons with onClick handlers that use window navigation methods (e.g., window.location, window.open)",
+				"Enforce using anchor tags for navigation instead of buttons whose onClick handlers change the path. Allow only query/hash updates via window.location.search or history.replaceState(window.location.pathname + …).",
 			category: "Best Practices",
 			recommended: false
 		},
 		schema: []
 	},
 	create(context) {
-		/**
-		 * Inspects an AST node *only* for MemberExpressions where
-		 * the object is literally `window` and the property is `open` or `location`.
-		 */
 		function containsWindowNavigation(node) {
 			let found = false;
-			function inspect(n) {
+
+			function inspect(n, parent) {
 				if (found || !n || typeof n !== "object") return;
-				// Only match MemberExpressions on the global window identifier
+
+				// 1) window.open(...)
 				if (
 					n.type === "MemberExpression" &&
 					n.object.type === "Identifier" &&
 					n.object.name === "window" &&
 					n.property.type === "Identifier" &&
-					(n.property.name === "open" ||
-						n.property.name === "location")
+					n.property.name === "open"
 				) {
 					found = true;
 					return;
 				}
-				// recurse into children—but skip walking back up via `parent`
+
+				// 2) Assignment to window.location or window.location.something (e.g. window.location = "...", window.location.href = "...")
+				if (
+					n.type === "AssignmentExpression" &&
+					n.left.type === "MemberExpression"
+				) {
+					const left = n.left;
+
+					// window.location = ...
+					if (
+						left.object.type === "Identifier" &&
+						left.object.name === "window" &&
+						left.property.type === "Identifier" &&
+						left.property.name === "location"
+					) {
+						found = true;
+						return;
+					}
+
+					// window.location.href = ...  OR  window.location.pathname = ...
+					if (
+						left.object.type === "MemberExpression" &&
+						left.object.object.type === "Identifier" &&
+						left.object.object.name === "window" &&
+						left.object.property.type === "Identifier" &&
+						left.object.property.name === "location"
+					) {
+						// any assignment to a sub-property of window.location (href, pathname, etc.) = navigation
+						found = true;
+						return;
+					}
+				}
+
+				// 3) window.location.replace(...)  (or any call on window.location.* besides .search/.hash)
+				if (
+					n.type === "MemberExpression" &&
+					n.object.type === "MemberExpression" &&
+					n.object.object.type === "Identifier" &&
+					n.object.object.name === "window" &&
+					n.object.property.type === "Identifier" &&
+					n.object.property.name === "location" &&
+					n.property.type === "Identifier" &&
+					n.property.name === "replace"
+				) {
+					// parent should be a CallExpression
+					if (parent && parent.type === "CallExpression") {
+						found = true;
+						return;
+					}
+				}
+
+				// 4) window.history.pushState(...) or window.history.replaceState(...)
+				if (
+					n.type === "MemberExpression" &&
+					n.object.type === "MemberExpression" &&
+					n.object.object.type === "Identifier" &&
+					n.object.object.name === "window" &&
+					n.object.property.type === "Identifier" &&
+					n.object.property.name === "history" &&
+					n.property.type === "Identifier" &&
+					(n.property.name === "pushState" ||
+						n.property.name === "replaceState")
+				) {
+					if (
+						parent &&
+						parent.type === "CallExpression" &&
+						Array.isArray(parent.arguments) &&
+						parent.arguments.length >= 3
+					) {
+						const urlArg = parent.arguments[2];
+						if (!urlUsesAllowedLocation(urlArg)) {
+							found = true;
+							return;
+						}
+						// If urlArg references window.location.pathname/search/hash → allowed
+					}
+				}
+
+				// Recurse into all child nodes
 				for (const key of Object.keys(n)) {
 					if (key === "parent") continue;
 					const child = n[key];
 					if (Array.isArray(child)) {
-						child.forEach(inspect);
+						child.forEach((c) => inspect(c, n));
 					} else {
-						inspect(child);
+						inspect(child, n);
 					}
 				}
 			}
-			// If it's a function, start at its body; otherwise start at the node itself
+
+			function urlUsesAllowedLocation(argNode) {
+				let allowed = false;
+
+				function check(n) {
+					if (allowed || !n || typeof n !== "object") return;
+					// Look for window.location.pathname, .search, or .hash anywhere
+					if (
+						n.type === "MemberExpression" &&
+						n.object.type === "MemberExpression" &&
+						n.object.object.type === "Identifier" &&
+						n.object.object.name === "window" &&
+						n.object.property.type === "Identifier" &&
+						n.object.property.name === "location" &&
+						n.property.type === "Identifier" &&
+						(n.property.name === "pathname" ||
+							n.property.name === "search" ||
+							n.property.name === "hash")
+					) {
+						allowed = true;
+						return;
+					}
+					for (const key of Object.keys(n)) {
+						if (key === "parent") continue;
+						const c = n[key];
+						if (Array.isArray(c)) {
+							c.forEach(check);
+						} else {
+							check(c);
+						}
+					}
+				}
+
+				check(argNode);
+				return allowed;
+			}
+
 			inspect(
 				node.type === "ArrowFunctionExpression" ||
 					node.type === "FunctionExpression"
 					? node.body
-					: node
+					: node,
+				null
 			);
 			return found;
 		}
@@ -54,7 +166,6 @@ export default {
 		return {
 			JSXElement(node) {
 				const { openingElement } = node;
-				// only care about <button ...>
 				if (
 					openingElement.name.type === "JSXIdentifier" &&
 					openingElement.name.name === "button"
@@ -66,7 +177,6 @@ export default {
 							attr.value?.type === "JSXExpressionContainer"
 						) {
 							const expr = attr.value.expression;
-							// only inspect the inline function, not any Identifier calls
 							if (
 								(expr.type === "ArrowFunctionExpression" ||
 									expr.type === "FunctionExpression") &&
@@ -75,7 +185,7 @@ export default {
 								context.report({
 									node: attr,
 									message:
-										"Use an anchor tag for navigation instead of a button with an onClick handler that uses window navigation methods."
+										"Use an anchor tag for navigation instead of a button with an onClick handler that changes the path. Only query/hash updates are allowed."
 								});
 							}
 						}