eslint-plugin-absolute 0.0.1 → 0.0.2

package/dist/index.js

@@ -1553,7 +1553,7 @@ var max_depth_extended_default = {
   meta: {
     type: "suggestion",
     docs: {
-      description: "disallow too many nested blocks except when the block only contains an early return",
+      description: "disallow too many nested blocks except when the block only contains an early exit (return or throw)",
       category: "Best Practices",
       recommended: false
     },
@@ -1575,14 +1575,14 @@ var max_depth_extended_default = {
       }
       return ancestors;
     }
-    function isEarlyReturnBlock(node) {
-      return node.body.length === 1 && node.body[0].type === "ReturnStatement";
+    function isEarlyExitBlock(node) {
+      return node.body.length === 1 && (node.body[0].type === "ReturnStatement" || node.body[0].type === "ThrowStatement");
     }
     function checkDepth(node, depth) {
       if (depth > maxDepth) {
         context.report({
           node,
-          message: "Blocks are nested too deeply ({{depth}}). Maximum allowed is {{maxDepth}} or an early return.",
+          message: "Blocks are nested too deeply ({{depth}}). Maximum allowed is {{maxDepth}} or an early exit.",
           data: { depth, maxDepth }
         });
       }
@@ -1603,7 +1603,7 @@ var max_depth_extended_default = {
         if (parent && (parent.type === "FunctionDeclaration" || parent.type === "FunctionExpression" || parent.type === "ArrowFunctionExpression") && node === parent.body) {
           return;
         }
-        if (isEarlyReturnBlock(node)) {
+        if (isEarlyExitBlock(node)) {
           return;
         }
         if (functionStack.length > 0) {
@@ -1617,7 +1617,7 @@ var max_depth_extended_default = {
         if (parent && (parent.type === "FunctionDeclaration" || parent.type === "FunctionExpression" || parent.type === "ArrowFunctionExpression") && node === parent.body) {
           return;
         }
-        if (isEarlyReturnBlock(node)) {
+        if (isEarlyExitBlock(node)) {
           return;
         }
         if (functionStack.length > 0) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-absolute",
-	"version": "0.0.1",
+	"version": "0.0.2",
 	"description": "ESLint plugin for AbsoluteJS",
 	"repository": {
 		"type": "git",

package/src/rules/max-depth-extended.js

@@ -3,7 +3,7 @@ export default {
 		type: "suggestion",
 		docs: {
 			description:
-				"disallow too many nested blocks except when the block only contains an early return",
+				"disallow too many nested blocks except when the block only contains an early exit (return or throw)",
 			category: "Best Practices",
 			recommended: false
 		},
@@ -30,11 +30,12 @@ export default {
 			return ancestors;
 		}
 
-		// Check if a block only contains a single return statement.
-		function isEarlyReturnBlock(node) {
+		// Check if a block only contains a single early exit: return or throw.
+		function isEarlyExitBlock(node) {
 			return (
 				node.body.length === 1 &&
-				node.body[0].type === "ReturnStatement"
+				(node.body[0].type === "ReturnStatement" ||
+					node.body[0].type === "ThrowStatement")
 			);
 		}
 
@@ -44,7 +45,7 @@ export default {
 				context.report({
 					node,
 					message:
-						"Blocks are nested too deeply ({{depth}}). Maximum allowed is {{maxDepth}} or an early return.",
+						"Blocks are nested too deeply ({{depth}}). Maximum allowed is {{maxDepth}} or an early exit.",
 					data: { depth, maxDepth }
 				});
 			}
@@ -60,9 +61,11 @@ export default {
 			ArrowFunctionExpression() {
 				functionStack.push(0);
 			},
+
 			BlockStatement(node) {
 				const ancestors = getAncestors(node);
 				const parent = ancestors[0];
+
 				// Do not count if this block is the body of a function.
 				if (
 					parent &&
@@ -73,15 +76,18 @@ export default {
 				) {
 					return;
 				}
-				// Skip blocks that only have an early return.
-				if (isEarlyReturnBlock(node)) {
+
+				// Skip blocks that only have an early exit.
+				if (isEarlyExitBlock(node)) {
 					return;
 				}
+
 				if (functionStack.length > 0) {
 					functionStack[functionStack.length - 1]++;
 					checkDepth(node, functionStack[functionStack.length - 1]);
 				}
 			},
+
 			"BlockStatement:exit"(node) {
 				const ancestors = getAncestors(node);
 				const parent = ancestors[0];
@@ -94,13 +100,16 @@ export default {
 				) {
 					return;
 				}
-				if (isEarlyReturnBlock(node)) {
+
+				if (isEarlyExitBlock(node)) {
 					return;
 				}
+
 				if (functionStack.length > 0) {
 					functionStack[functionStack.length - 1]--;
 				}
 			},
+
 			"FunctionDeclaration:exit"() {
 				functionStack.pop();
 			},