eslint-linter-browserify 10.0.3 → 10.1.0

package/linter.cjs

@@ -4216,7 +4216,7 @@ function requireEslintVisitorKeys$2 () {
 	return eslintVisitorKeys$2;
 }
 
-var version = "10.0.3";
+var version = "10.1.0";
 var require$$3$1 = {
 	version: version};
 
@@ -8346,7 +8346,6 @@ function requireUtils$1 () {
 		for (
 			let minIndex = 0, maxIndex = tokens.length - 1;
 			minIndex <= maxIndex;
-
 		) {
 			/*
 			 * Calculate the index in the middle between minIndex and maxIndex.
@@ -45111,24 +45110,24 @@ function requireEspree () {
 		 * Normalize sourceType from the initial config
 		 * @param {string} sourceType to normalize
 		 * @throws {Error} throw an error if sourceType is invalid
-		 * @returns {"script"|"module"} normalized sourceType
+		 * @returns {"script"|"module"|"commonjs"} normalized sourceType
 		 */
 		function normalizeSourceType(sourceType = "script") {
-			if (sourceType === "script" || sourceType === "module") {
+			if (
+				sourceType === "script" ||
+				sourceType === "module" ||
+				sourceType === "commonjs"
+			) {
 				return sourceType;
 			}
 
-			if (sourceType === "commonjs") {
-				return "script";
-			}
-
 			throw new Error("Invalid sourceType.");
 		}
 
 		/**
 		 * @typedef {{
 		 *   ecmaVersion: NormalizedEcmaVersion,
-		 *   sourceType: "script"|"module",
+		 *   sourceType: "script"|"module"|"commonjs",
 		 *   range?: boolean,
 		 *   loc?: boolean,
 		 *   allowReserved: boolean | "never",
@@ -45933,7 +45932,7 @@ function requireEspree () {
 		//------------------------------------------------------------------------------
 
 		/** @type {string} */
-		const version = "11.1.1"; // x-release-please-version
+		const version = "11.2.0"; // x-release-please-version
 		const name = "espree";
 
 		// Derive node types from VisitorKeys
@@ -46419,9 +46418,9 @@ function requireAstUtils () {
 			if (left.regex || right.regex) {
 				return Boolean(
 					left.regex &&
-						right.regex &&
-						left.regex.pattern === right.regex.pattern &&
-						left.regex.flags === right.regex.flags,
+					right.regex &&
+					left.regex.pattern === right.regex.pattern &&
+					left.regex.flags === right.regex.flags,
 				);
 			}
 
@@ -47062,9 +47061,9 @@ function requireAstUtils () {
 
 			return Boolean(
 				reference &&
-					reference.resolved &&
-					reference.resolved.scope.type === "global" &&
-					reference.resolved.defs.length === 0,
+				reference.resolved &&
+				reference.resolved.scope.type === "global" &&
+				reference.resolved.defs.length === 0,
 			);
 		}
 
@@ -53154,9 +53153,9 @@ function requireCapitalizedComments () {
 
 				return Boolean(
 					previousToken &&
-						nextToken &&
-						comment.loc.start.line === previousToken.loc.end.line &&
-						comment.loc.end.line === nextToken.loc.start.line,
+					nextToken &&
+					comment.loc.start.line === previousToken.loc.end.line &&
+					comment.loc.end.line === nextToken.loc.start.line,
 				);
 			}
 
@@ -53172,7 +53171,7 @@ function requireCapitalizedComments () {
 
 				return Boolean(
 					previousTokenOrComment &&
-						["Block", "Line"].includes(previousTokenOrComment.type),
+					["Block", "Line"].includes(previousTokenOrComment.type),
 				);
 			}
 
@@ -82358,11 +82357,11 @@ function requireNoExtendNative () {
 			function isPrototypePropertyAccessed(identifierNode) {
 				return Boolean(
 					identifierNode &&
-						identifierNode.parent &&
-						identifierNode.parent.type === "MemberExpression" &&
-						identifierNode.parent.object === identifierNode &&
-						astUtils.getStaticPropertyName(identifierNode.parent) ===
-							"prototype",
+					identifierNode.parent &&
+					identifierNode.parent.type === "MemberExpression" &&
+					identifierNode.parent.object === identifierNode &&
+					astUtils.getStaticPropertyName(identifierNode.parent) ===
+						"prototype",
 				);
 			}
 
@@ -99723,9 +99722,7 @@ function requireNoThisBeforeSuper () {
 							isConstructor: true,
 							hasExtends: Boolean(
 								classNode.superClass &&
-									!astUtils.isNullOrUndefined(
-										classNode.superClass,
-									),
+								!astUtils.isNullOrUndefined(classNode.superClass),
 							),
 							codePath,
 							currentSegments: new Set(),
@@ -101278,11 +101275,11 @@ function requireNoUnmodifiedLoopCondition () {
 					condition.isInLoop(modifier) ||
 					Boolean(
 						(funcNode = getEncloseFunctionDeclaration(modifier)) &&
-							(funcVar = astUtils.getVariableByName(
-								modifier.from.upper,
-								funcNode.id.name,
-							)) &&
-							funcVar.references.some(condition.isInLoop),
+						(funcVar = astUtils.getVariableByName(
+							modifier.from.upper,
+							funcNode.id.name,
+						)) &&
+						funcVar.references.some(condition.isInLoop),
 					);
 
 				condition.modified = inLoop;
@@ -108558,6 +108555,28 @@ function requireNoVar () {
 		return variable.name === "let";
 	}
 
+	/**
+	 * Checks whether a given variable has any references before its declaration.
+	 * This is important because var allows hoisting, but let/const do not.
+	 * @param {Variable} variable The variable to check.
+	 * @returns {boolean} `true` if the variable is referenced before its declaration.
+	 */
+	function hasReferenceBeforeDeclaration(variable) {
+		const declarationStart = variable.defs[0].node.range[0];
+
+		return variable.references.some(reference => {
+			const referenceStart = reference.identifier.range[0];
+
+			/*
+			 * Check if the reference occurs before the declaration.
+			 * We don't need to check scopes because all references to this variable
+			 * are already in variable.references (which only includes references
+			 * that resolve to this specific variable binding).
+			 */
+			return !reference.init && referenceStart < declarationStart;
+		});
+	}
+
 	//------------------------------------------------------------------------------
 	// Rule Definition
 	//------------------------------------------------------------------------------
@@ -108611,6 +108630,7 @@ function requireNoVar () {
 			 * - A variable is used from a closure within a loop.
 			 * - A variable might be used before it is assigned within a loop.
 			 * - A variable might be used in TDZ.
+			 * - A variable is referenced before its declaration.
 			 * - A variable is declared in statement position (e.g. a single-line `IfStatement`)
 			 * - A variable has name that is disallowed for `let` declarations.
 			 *
@@ -108655,6 +108675,10 @@ function requireNoVar () {
 			function canFix(node) {
 				const variables = sourceCode.getDeclaredVariables(node);
 				const scopeNode = getScopeNode(node);
+				const parentStatementList = new Set([
+					...astUtils.STATEMENT_LIST_PARENTS,
+					"TSModuleBlock",
+				]);
 
 				if (
 					node.parent.type === "SwitchCase" ||
@@ -108662,7 +108686,8 @@ function requireNoVar () {
 					variables.some(isGlobal) ||
 					variables.some(isRedeclared) ||
 					variables.some(isUsedFromOutsideOf(scopeNode)) ||
-					variables.some(hasNameDisallowedForLetDeclarations)
+					variables.some(hasNameDisallowedForLetDeclarations) ||
+					variables.some(hasReferenceBeforeDeclaration)
 				) {
 					return false;
 				}
@@ -108682,7 +108707,7 @@ function requireNoVar () {
 						node.parent.type === "ForStatement" &&
 						node.parent.init === node
 					) &&
-					!astUtils.STATEMENT_LIST_PARENTS.has(node.parent.type)
+					!parentStatementList.has(node.parent.type)
 				) {
 					// If the declaration is not in a block, e.g. `if (foo) var bar = 1;`, then it can't be fixed.
 					return false;
@@ -112985,11 +113010,11 @@ function requirePaddingLineBetweenStatements () {
 		const nextToken = sourceCode.getTokenAfter(semiToken);
 		const isSemicolonLessStyle = Boolean(
 			prevToken &&
-				nextToken &&
-				prevToken.range[0] >= node.range[0] &&
-				astUtils.isSemicolonToken(semiToken) &&
-				semiToken.loc.start.line !== prevToken.loc.end.line &&
-				semiToken.loc.end.line === nextToken.loc.start.line,
+			nextToken &&
+			prevToken.range[0] >= node.range[0] &&
+			astUtils.isSemicolonToken(semiToken) &&
+			semiToken.loc.start.line !== prevToken.loc.end.line &&
+			semiToken.loc.end.line === nextToken.loc.start.line,
 		);
 
 		return isSemicolonLessStyle ? prevToken : semiToken;

package/linter.js

@@ -4218,7 +4218,7 @@
 		return eslintVisitorKeys$2;
 	}
 
-	var version = "10.0.3";
+	var version = "10.1.0";
 	var require$$3$1 = {
 		version: version};
 
@@ -8348,7 +8348,6 @@
 			for (
 				let minIndex = 0, maxIndex = tokens.length - 1;
 				minIndex <= maxIndex;
-
 			) {
 				/*
 				 * Calculate the index in the middle between minIndex and maxIndex.
@@ -45113,24 +45112,24 @@
 			 * Normalize sourceType from the initial config
 			 * @param {string} sourceType to normalize
 			 * @throws {Error} throw an error if sourceType is invalid
-			 * @returns {"script"|"module"} normalized sourceType
+			 * @returns {"script"|"module"|"commonjs"} normalized sourceType
 			 */
 			function normalizeSourceType(sourceType = "script") {
-				if (sourceType === "script" || sourceType === "module") {
+				if (
+					sourceType === "script" ||
+					sourceType === "module" ||
+					sourceType === "commonjs"
+				) {
 					return sourceType;
 				}
 
-				if (sourceType === "commonjs") {
-					return "script";
-				}
-
 				throw new Error("Invalid sourceType.");
 			}
 
 			/**
 			 * @typedef {{
 			 *   ecmaVersion: NormalizedEcmaVersion,
-			 *   sourceType: "script"|"module",
+			 *   sourceType: "script"|"module"|"commonjs",
 			 *   range?: boolean,
 			 *   loc?: boolean,
 			 *   allowReserved: boolean | "never",
@@ -45935,7 +45934,7 @@
 			//------------------------------------------------------------------------------
 
 			/** @type {string} */
-			const version = "11.1.1"; // x-release-please-version
+			const version = "11.2.0"; // x-release-please-version
 			const name = "espree";
 
 			// Derive node types from VisitorKeys
@@ -46421,9 +46420,9 @@
 				if (left.regex || right.regex) {
 					return Boolean(
 						left.regex &&
-							right.regex &&
-							left.regex.pattern === right.regex.pattern &&
-							left.regex.flags === right.regex.flags,
+						right.regex &&
+						left.regex.pattern === right.regex.pattern &&
+						left.regex.flags === right.regex.flags,
 					);
 				}
 
@@ -47064,9 +47063,9 @@
 
 				return Boolean(
 					reference &&
-						reference.resolved &&
-						reference.resolved.scope.type === "global" &&
-						reference.resolved.defs.length === 0,
+					reference.resolved &&
+					reference.resolved.scope.type === "global" &&
+					reference.resolved.defs.length === 0,
 				);
 			}
 
@@ -53156,9 +53155,9 @@
 
 					return Boolean(
 						previousToken &&
-							nextToken &&
-							comment.loc.start.line === previousToken.loc.end.line &&
-							comment.loc.end.line === nextToken.loc.start.line,
+						nextToken &&
+						comment.loc.start.line === previousToken.loc.end.line &&
+						comment.loc.end.line === nextToken.loc.start.line,
 					);
 				}
 
@@ -53174,7 +53173,7 @@
 
 					return Boolean(
 						previousTokenOrComment &&
-							["Block", "Line"].includes(previousTokenOrComment.type),
+						["Block", "Line"].includes(previousTokenOrComment.type),
 					);
 				}
 
@@ -82360,11 +82359,11 @@
 				function isPrototypePropertyAccessed(identifierNode) {
 					return Boolean(
 						identifierNode &&
-							identifierNode.parent &&
-							identifierNode.parent.type === "MemberExpression" &&
-							identifierNode.parent.object === identifierNode &&
-							astUtils.getStaticPropertyName(identifierNode.parent) ===
-								"prototype",
+						identifierNode.parent &&
+						identifierNode.parent.type === "MemberExpression" &&
+						identifierNode.parent.object === identifierNode &&
+						astUtils.getStaticPropertyName(identifierNode.parent) ===
+							"prototype",
 					);
 				}
 
@@ -99725,9 +99724,7 @@
 								isConstructor: true,
 								hasExtends: Boolean(
 									classNode.superClass &&
-										!astUtils.isNullOrUndefined(
-											classNode.superClass,
-										),
+									!astUtils.isNullOrUndefined(classNode.superClass),
 								),
 								codePath,
 								currentSegments: new Set(),
@@ -101280,11 +101277,11 @@
 						condition.isInLoop(modifier) ||
 						Boolean(
 							(funcNode = getEncloseFunctionDeclaration(modifier)) &&
-								(funcVar = astUtils.getVariableByName(
-									modifier.from.upper,
-									funcNode.id.name,
-								)) &&
-								funcVar.references.some(condition.isInLoop),
+							(funcVar = astUtils.getVariableByName(
+								modifier.from.upper,
+								funcNode.id.name,
+							)) &&
+							funcVar.references.some(condition.isInLoop),
 						);
 
 					condition.modified = inLoop;
@@ -108560,6 +108557,28 @@
 			return variable.name === "let";
 		}
 
+		/**
+		 * Checks whether a given variable has any references before its declaration.
+		 * This is important because var allows hoisting, but let/const do not.
+		 * @param {Variable} variable The variable to check.
+		 * @returns {boolean} `true` if the variable is referenced before its declaration.
+		 */
+		function hasReferenceBeforeDeclaration(variable) {
+			const declarationStart = variable.defs[0].node.range[0];
+
+			return variable.references.some(reference => {
+				const referenceStart = reference.identifier.range[0];
+
+				/*
+				 * Check if the reference occurs before the declaration.
+				 * We don't need to check scopes because all references to this variable
+				 * are already in variable.references (which only includes references
+				 * that resolve to this specific variable binding).
+				 */
+				return !reference.init && referenceStart < declarationStart;
+			});
+		}
+
 		//------------------------------------------------------------------------------
 		// Rule Definition
 		//------------------------------------------------------------------------------
@@ -108613,6 +108632,7 @@
 				 * - A variable is used from a closure within a loop.
 				 * - A variable might be used before it is assigned within a loop.
 				 * - A variable might be used in TDZ.
+				 * - A variable is referenced before its declaration.
 				 * - A variable is declared in statement position (e.g. a single-line `IfStatement`)
 				 * - A variable has name that is disallowed for `let` declarations.
 				 *
@@ -108657,6 +108677,10 @@
 				function canFix(node) {
 					const variables = sourceCode.getDeclaredVariables(node);
 					const scopeNode = getScopeNode(node);
+					const parentStatementList = new Set([
+						...astUtils.STATEMENT_LIST_PARENTS,
+						"TSModuleBlock",
+					]);
 
 					if (
 						node.parent.type === "SwitchCase" ||
@@ -108664,7 +108688,8 @@
 						variables.some(isGlobal) ||
 						variables.some(isRedeclared) ||
 						variables.some(isUsedFromOutsideOf(scopeNode)) ||
-						variables.some(hasNameDisallowedForLetDeclarations)
+						variables.some(hasNameDisallowedForLetDeclarations) ||
+						variables.some(hasReferenceBeforeDeclaration)
 					) {
 						return false;
 					}
@@ -108684,7 +108709,7 @@
 							node.parent.type === "ForStatement" &&
 							node.parent.init === node
 						) &&
-						!astUtils.STATEMENT_LIST_PARENTS.has(node.parent.type)
+						!parentStatementList.has(node.parent.type)
 					) {
 						// If the declaration is not in a block, e.g. `if (foo) var bar = 1;`, then it can't be fixed.
 						return false;
@@ -112987,11 +113012,11 @@
 			const nextToken = sourceCode.getTokenAfter(semiToken);
 			const isSemicolonLessStyle = Boolean(
 				prevToken &&
-					nextToken &&
-					prevToken.range[0] >= node.range[0] &&
-					astUtils.isSemicolonToken(semiToken) &&
-					semiToken.loc.start.line !== prevToken.loc.end.line &&
-					semiToken.loc.end.line === nextToken.loc.start.line,
+				nextToken &&
+				prevToken.range[0] >= node.range[0] &&
+				astUtils.isSemicolonToken(semiToken) &&
+				semiToken.loc.start.line !== prevToken.loc.end.line &&
+				semiToken.loc.end.line === nextToken.loc.start.line,
 			);
 
 			return isSemicolonLessStyle ? prevToken : semiToken;