eslint-config-xo 3.0.1 → 3.0.2

package/index.d.ts

@@ -5,6 +5,8 @@ export const jsExtensions: string[];
 export const frameworkExtensions: string[];
 export const htmlExtensions: string[];
 export const mdExtensions: string[];
+export const jsonExtensions: string[];
+export const cssExtensions: string[];
 export const allExtensions: string[];
 
 export const tsFilesGlob: string;

package/index.js

@@ -38,6 +38,7 @@ try {
 	}
 }
 
+// TODO: Drop `cts` in the next major version, as CommonJS is no longer supported.
 export const tsExtensions = [
 	'ts',
 	'tsx',
@@ -45,6 +46,7 @@ export const tsExtensions = [
 	'cts',
 ];
 
+// TODO: Drop `cjs` in the next major version, as CommonJS is no longer supported.
 export const jsExtensions = [
 	'js',
 	'jsx',
@@ -66,6 +68,16 @@ export const mdExtensions = [
 	'md',
 ];
 
+export const jsonExtensions = [
+	'json',
+	'jsonc',
+	'json5',
+];
+
+export const cssExtensions = [
+	'css',
+];
+
 export const allExtensions = [
 	...jsExtensions,
 	...tsExtensions,
@@ -94,9 +106,12 @@ export const defaultIgnores = [
 	'coverage/**',
 	'{tmp,temp}/**',
 	'**/*.min.js',
+	'**/*.min.css',
 	'vendor/**',
 	'dist/**',
 	'tap-snapshots/*.{cjs,js}',
+	'**/package-lock.json',
+	'**/npm-shrinkwrap.json',
 ];
 
 const pluginNoUseExtendNative = {
@@ -117,6 +132,21 @@ const missingTypeScriptParser = {
 	},
 };
 
+const missingTypeScriptConfig = {
+	name: 'xo/missing-typescript',
+	files: [
+		tsFilesGlob,
+	],
+	ignores: [
+		'**/*.d.ts',
+		'**/*.d.mts',
+		'**/*.d.cts',
+	],
+	languageOptions: {
+		parser: missingTypeScriptParser,
+	},
+};
+
 function isMissingTypeScriptError(error) {
 	return error instanceof Error
 		&& (error.code === 'ERR_MODULE_NOT_FOUND' || error.code === 'MODULE_NOT_FOUND')
@@ -136,11 +166,7 @@ function getGitignoreConfig(configUrl) {
 	const gitignorePath = fileURLToPath(new URL('.gitignore', configUrl));
 
 	// Skip silently when there is no `.gitignore`, so opting in never crashes.
-	if (!fs.existsSync(gitignorePath)) {
-		return undefined;
-	}
-
-	return includeIgnoreFile(gitignorePath, {name: 'xo/gitignore', gitignoreResolution: true});
+	return fs.existsSync(gitignorePath) ? includeIgnoreFile(gitignorePath, {name: 'xo/gitignore', gitignoreResolution: true}) : undefined;
 }
 
 function getOptionRules({
@@ -343,24 +369,6 @@ export default function eslintConfigXo({
 		optionRules: getOptionRules({space, semicolon, typescript: true}),
 		tsExtensions,
 	}) ?? [];
-	const missingTypeScriptConfig = [];
-	if (!ts) {
-		missingTypeScriptConfig.push({
-			name: 'xo/missing-typescript',
-			files: [
-				tsFilesGlob,
-			],
-			ignores: [
-				'**/*.d.ts',
-				'**/*.d.mts',
-				'**/*.d.cts',
-			],
-			languageOptions: {
-				parser: missingTypeScriptParser,
-			},
-		});
-	}
-
 	// `eslint-plugin-ava` bundles its own `@eslint/json` copy for its `**/package.json` config, which clashes with our `json` plugin registration on the same files (ESLint forbids defining the same plugin name with two different objects). Reuse our `json` instance so the references match.
 	const avaConfigs = pluginAva.configs.recommended.map(avaConfig => {
 		const namedAvaConfig = {
@@ -418,7 +426,7 @@ export default function eslintConfigXo({
 		}),
 		getHtmlConfig({space, prettier}),
 		getMarkdownConfig(),
-		...missingTypeScriptConfig,
+		...(ts ? [] : [missingTypeScriptConfig]),
 
 		{
 			name: 'xo/css',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-config-xo",
-	"version": "3.0.1",
+	"version": "3.0.2",
 	"description": "ESLint shareable config for XO",
 	"license": "MIT",
 	"repository": "xojs/eslint-config-xo",

package/source/rules/no-use-extend-native.js

@@ -211,21 +211,11 @@ const nativeObjectDefinitions = [
 const nativeObjects = new Map();
 
 for (const nativeObjectDefinition of nativeObjectDefinitions) {
-	const nativeObjectInfo = {};
-
-	if (nativeObjectDefinition.instance) {
-		nativeObjectInfo.instance = createPropertyInfo(nativeObjectDefinition.instance, nativeObjectDefinition.instanceProperties);
-	}
-
-	if (nativeObjectDefinition.prototype) {
-		nativeObjectInfo.prototype = createPropertyInfo(nativeObjectDefinition.prototype);
-	}
-
-	if (nativeObjectDefinition.static) {
-		nativeObjectInfo.static = createPropertyInfo(nativeObjectDefinition.static);
-	}
-
-	nativeObjects.set(nativeObjectDefinition.typeName, nativeObjectInfo);
+	nativeObjects.set(nativeObjectDefinition.typeName, {
+		instance: nativeObjectDefinition.instance ? createPropertyInfo(nativeObjectDefinition.instance, nativeObjectDefinition.instanceProperties) : undefined,
+		prototype: nativeObjectDefinition.prototype ? createPropertyInfo(nativeObjectDefinition.prototype) : undefined,
+		static: nativeObjectDefinition.static ? createPropertyInfo(nativeObjectDefinition.static) : undefined,
+	});
 }
 
 const getPropertyName = memberExpression => {