eslint-config-xo 0.22.2 → 0.24.2

package/esnext.js

@@ -13,17 +13,31 @@ module.exports = {
 				destructuring: 'all'
 			}
 		],
-		'prefer-numeric-literals': 2,
+		'prefer-numeric-literals': 'error',
 		'prefer-rest-params': 'error',
 		'prefer-spread': 'error',
+		// TODO: Enable this when targeting Node.js 8
+		// 'prefer-object-spread': 'error',
 		'prefer-destructuring': [
 			'error',
 			{
-				// Disabled because it forces destructuring on
+				// `array` is disabled because it forces destructuring on
 				// stupid stuff like `foo.bar = process.argv[2];`
 				// TODO: Open ESLint issue about this
-				// array: true,
-				object: true
+				VariableDeclarator: {
+					array: false,
+					object: true
+				},
+				AssignmentExpression: {
+					array: false,
+
+					// Disabled because object assignment destructuring requires parens wrapping:
+					// `let foo; ({foo} = object);`
+					object: false
+				}
+			},
+			{
+				enforceForRenamedProperties: false
 			}
 		]
 	}

package/index.js

@@ -16,6 +16,7 @@ module.exports = {
 		'comma-dangle': ['error', 'never'],
 		'for-direction': 'error',
 		'getter-return': 'error',
+		'no-async-promise-executor': 'error',
 		'no-await-in-loop': 'error',
 		'no-compare-neg-zero': 'error',
 		'no-cond-assign': 'error',
@@ -41,6 +42,7 @@ module.exports = {
 		'no-inner-declarations': 'error',
 		'no-invalid-regexp': 'error',
 		'no-irregular-whitespace': 'error',
+		'no-misleading-character-class': 'error',
 		'no-obj-calls': 'error',
 		'no-prototype-builtins': 'error',
 		'no-regex-spaces': 'error',
@@ -49,6 +51,7 @@ module.exports = {
 		'no-unreachable': 'error',
 		'no-unsafe-finally': 'error',
 		'no-unsafe-negation': 'error',
+		'require-atomic-updates': 'error',
 		'use-isnan': 'error',
 		'valid-typeof': ['error', {requireStringLiterals: false}],
 		'no-unexpected-multiline': 'error',
@@ -112,6 +115,12 @@ module.exports = {
 		'no-with': 'error',
 		'prefer-promise-reject-errors': ['error', {allowEmptyReject: true}],
 		radix: 'error',
+
+		// Disabled for now as it causes too much churn
+		// TODO: Enable it in the future when I have time to deal with
+		// the churn and the rule is stable and has an autofixer
+		// 'require-unicode-regexp': 'error',
+
 		'wrap-iife': ['error', 'inside', {functionPrototypeMethods: true}],
 		yoda: 'error',
 		'no-delete-var': 'error',
@@ -141,6 +150,7 @@ module.exports = {
 		'no-restricted-modules': ['error', 'domain', 'freelist', 'smalloc', 'sys', 'colors'],
 		'array-bracket-newline': ['error', 'consistent'],
 		'array-bracket-spacing': ['error', 'never'],
+		'array-element-newline': ['error', 'consistent'],
 		'brace-style': ['error', '1tbs', {
 			allowSingleLine: false
 		}],
@@ -161,7 +171,7 @@ module.exports = {
 		'computed-property-spacing': ['error', 'never'],
 		'eol-last': 'error',
 		'func-call-spacing': ['error', 'never'],
-		'func-name-matching': 'error',
+		'func-name-matching': ['error', {considerPropertyDescriptor: true}],
 		'func-names': ['error', 'never'],
 		indent: ['error', 'tab', {
 			SwitchCase: 1

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-config-xo",
-	"version": "0.22.2",
+	"version": "0.24.2",
 	"description": "ESLint shareable config for XO",
 	"license": "MIT",
 	"repository": "xojs/eslint-config-xo",
@@ -51,11 +51,11 @@
 	],
 	"devDependencies": {
 		"ava": "*",
-		"eslint": "^4.9.0",
+		"eslint": "^5.3.0",
 		"is-plain-obj": "^1.0.0",
 		"temp-write": "^3.1.0"
 	},
 	"peerDependencies": {
-		"eslint": ">=4.9.0"
+		"eslint": ">=5.3.0"
 	}
 }