eslint-config-webpack 4.9.4 → 4.9.6

package/configs/javascript.js

@@ -690,6 +690,8 @@ const unicornRules = {
 	// No need
 	// "unicorn/consistent-function-scoping": "off",
 
+	"unicorn/consistent-template-literal-escape": "error",
+
 	// No need
 	// "unicorn/custom-error-definition": "off",
 
@@ -706,7 +708,7 @@ const unicornRules = {
 	// No need
 	// "unicorn/explicit-length-check": "off",
 
-	// TODO
+	// TODO enable in future?
 	"unicorn/filename-case": [
 		"off",
 		{
@@ -834,7 +836,7 @@ const unicornRules = {
 	// No need
 	// "unicorn/no-this-assignment": "off",
 
-	// TODO - enable in future?
+	// TODO enable in future? Need to check performance
 	// "unicorn/no-typeof-undefined": "off",
 
 	"unicorn/no-unnecessary-array-flat-depth": "error",
@@ -862,6 +864,8 @@ const unicornRules = {
 
 	"unicorn/no-useless-fallback-in-spread": "error",
 
+	"unicorn/no-useless-iterator-to-array": "error",
+
 	"unicorn/no-useless-length-check": "error",
 
 	"unicorn/no-useless-promise-resolve-reject": "error",
@@ -993,6 +997,9 @@ const unicornRules = {
 	// No need
 	// "unicorn/prefer-set-size": "off",
 
+	// TODO enable in the next major release
+	// "unicorn/prefer-simple-condition-first": "error",
+
 	// No need
 	// "unicorn/prefer-single-call": "off",
 
@@ -1045,6 +1052,10 @@ const unicornRules = {
 	// No need
 	// "unicorn/switch-case-braces": "off",
 
+	// TODO maybe?
+	// No need
+	// "unicorn/switch-case-break-position": "off",
+
 	// No need
 	// "unicorn/template-indent": "off",
 
@@ -1230,7 +1241,7 @@ const baseConfig = {
 		import: importPlugin,
 	},
 	linterOptions: {
-		reportUnusedDisableDirectives: true,
+		reportUnusedDisableDirectives: "error",
 		reportUnusedInlineConfigs: "error",
 	},
 	rules: {

package/configs/markdown.js

@@ -12,6 +12,7 @@ async function getMarkdownRecommendedConfig() {
 			files: ["**/*.md"],
 			processor: "markdown/markdown",
 			plugins: {
+				// @ts-expect-error bad types
 				markdown: markdownPlugin,
 			},
 		},

package/configs/node.js

@@ -73,8 +73,7 @@ const commonRules = {
 	// No need
 	// "n/no-top-level-await": "error",
 
-	// From recommended
-	// "n/no-unpublished-bin": "error",
+	"n/no-unpublished-bin": "error",
 
 	// From recommended
 	// "n/no-unpublished-import": "error",
@@ -95,8 +94,53 @@ const commonRules = {
 
 	// "n/no-unsupported-features/es-syntax": "error",
 
-	// From recommended
-	// "n/no-unsupported-features/node-builtins": "error",
+	// From recommended (override to ignore test module)
+	"n/no-unsupported-features/node-builtins": [
+		"error",
+		{
+			ignores: [
+				"test",
+				"test.after",
+				"test.afterEach",
+				"test.assert",
+				"test.assert.register",
+				"test.before",
+				"test.beforeEach",
+				"test.describe",
+				"test.describe.only",
+				"test.describe.skip",
+				"test.describe.todo",
+				"test.it",
+				"test.it.only",
+				"test.it.skip",
+				"test.it.todo",
+				"test.mock",
+				"test.mock.fn",
+				"test.mock.getter",
+				"test.mock.method",
+				"test.mock.module",
+				"test.mock.reset",
+				"test.mock.restoreAll",
+				"test.mock.setter",
+				"test.mock.timers",
+				"test.mock.timers.enable",
+				"test.mock.timers.reset",
+				"test.mock.timers.tick",
+				"test.only",
+				"test.run",
+				"test.snapshot",
+				"test.snapshot.setDefaultSnapshotSerializers",
+				"test.snapshot.setResolveSnapshotPath",
+				"test.skip",
+				"test.suite",
+				"test.test",
+				"test.test.only",
+				"test.test.skip",
+				"test.test.todo",
+				"test.todo",
+			],
+		},
+	],
 
 	"n/prefer-global/buffer": ["error", "always"],
 

package/configs/utils/get-es-version-from-node.js

@@ -0,0 +1,83 @@
+import semver from "semver";
+
+/**
+ * @typedef {2016 | 2017 | 2018 | 2019 | 2020 | 2021 | 2022 | 2023 | 2024 | 2025} EsVersion
+ */
+
+/**
+ * Ordered table from Node version ranges to the highest ES version every
+ * release in the range fully supports.
+ *
+ * The table respects minor versions where they shift the supported feature
+ * set, e.g. async/await landed in Node 7.6 (ES2017), and `Object.hasOwn`
+ * landed in Node 16.11 (ES2022) — the last ES2022 feature to ship on the
+ * Node 16 line.
+ *
+ * Sources: https://node.green/ and the Node.js/V8 release notes. Entries
+ * are sorted newest-to-oldest; the first matching entry wins.
+ * @type {ReadonlyArray<{ range: string, esVersion: EsVersion }>}
+ */
+const ranges = [
+	// ES2025: Node 22.0 ships all ES2025 syntax — import attributes
+	// (`with { type: "json" }`), the RegExp `/v` flag, and duplicate named
+	// capturing groups. Stdlib gaps (e.g. Promise.try lands at 22.5) are
+	// caught by eslint-plugin-n's `no-unsupported-features/node-builtins`,
+	// so we don't need a separate ES2024 row here.
+	{ range: ">=22.0.0", esVersion: 2025 },
+	// ES2023: Array-by-copy (toSorted/toReversed/toSpliced/with), findLast/findLastIndex.
+	{ range: ">=20.0.0", esVersion: 2023 },
+	// ES2022: Object.hasOwn is the last ES2022 feature to land on the Node 16 line.
+	// Earlier 16.x has top-level await (>=14.8), `.at()` (>=16.6) and Error cause (>=16.9)
+	// but not Object.hasOwn, so it can't safely claim full ES2022.
+	{ range: ">=16.11.0", esVersion: 2022 },
+	// ES2021: logical assignment operators, String#replaceAll, Promise.any, WeakRef.
+	{ range: ">=15.0.0", esVersion: 2021 },
+	// ES2020: optional chaining, nullish coalescing, BigInt, Promise.allSettled, globalThis.
+	{ range: ">=14.0.0", esVersion: 2020 },
+	// ES2019: Object.fromEntries, Array#flat/flatMap, String#trimStart/trimEnd.
+	{ range: ">=12.0.0", esVersion: 2019 },
+	// ES2018: object rest/spread, async iteration, RegExp lookbehind, Promise#finally.
+	{ range: ">=10.0.0", esVersion: 2018 },
+	// ES2017: async/await is the gating feature — landed in 7.6, not 7.0.
+	{ range: ">=7.6.0", esVersion: 2017 },
+	// ES2016: ** exponentiation operator and Array#includes (both require >=7.0).
+	{ range: ">=7.0.0", esVersion: 2016 },
+];
+
+/**
+ * Resolves the highest ES version every Node release matched by
+ * `nodeRange` fully supports.
+ *
+ * Returns `undefined` when the lower bound is older than our oldest entry
+ * (Node 7.0), so callers can apply project-specific fallbacks — for example
+ * Node 6, which has `Array#includes` (from 6.5) but never gained the `**`
+ * operator and so doesn't map cleanly to a single ES year.
+ * @param {string} nodeRange a semver range, typically `package.json#engines.node`
+ * @returns {EsVersion | undefined} matching ES version, or `undefined`
+ */
+function getEsVersionFromNode(nodeRange) {
+	// `semver.minVersion` throws on unparseable input. Guard against a
+	// malformed `engines.node` so loading the ESLint config never crashes
+	// the consuming project — we just fall back to the caller's default.
+	let minVersion;
+	try {
+		minVersion = semver.minVersion(nodeRange);
+		// eslint-disable-next-line unicorn/prefer-optional-catch-binding
+	} catch (_err) {
+		return undefined;
+	}
+
+	if (!minVersion) {
+		return undefined;
+	}
+
+	for (const { range, esVersion } of ranges) {
+		if (semver.satisfies(minVersion, range)) {
+			return esVersion;
+		}
+	}
+
+	return undefined;
+}
+
+export default getEsVersionFromNode;

package/configs.js

@@ -1,6 +1,7 @@
 import { globalIgnores } from "eslint/config";
 import semver from "semver";
 import configs from "./configs/index.js";
+import getEsVersionFromNode from "./configs/utils/get-es-version-from-node.js";
 import getJsonFile from "./configs/utils/get-json-file.js";
 import ignorePaths from "./ignore-paths.js";
 
@@ -15,73 +16,56 @@ const isModule =
  * @returns {import("eslint").Linter.Config} javascript configuration
  */
 function getJavascriptConfig() {
-	if (packageJson.engines && packageJson.engines.node) {
-		const minVersion = semver.minVersion(packageJson.engines.node);
-		const minMajorVersion = minVersion ? minVersion.major : undefined;
-
-		// https://node.green/
-		// https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
-		switch (minMajorVersion) {
-			case 6: {
-				const config = {
-					...configs["javascript/es2016"],
-					rules: { ...configs["javascript/es2016"].rules },
-				};
-
-				config.rules["prefer-exponentiation-operator"] = "off";
-
-				return config;
-			}
-			case 7:
-				return configs["javascript/es2016"];
-			case 8:
-			case 9:
-				return configs["javascript/es2017"];
-			case 10:
-			case 11:
-				return configs["javascript/es2018"];
-			case 12:
-			case 13: {
-				/** @type {import("eslint").Linter.Config["languageOptions"]} */
-				const original = configs["javascript/es2019"].languageOptions;
-				/** @type {import("eslint").Linter.Config["languageOptions"]} */
-				const languageOptions = {
-					...original,
-					globals: {
-						// @ts-expect-error always exist
-						...original.globals,
-						Promise: false,
-						BigInt: false,
-					},
-				};
-
-				return { ...configs["javascript/es2019"], languageOptions };
-			}
-			case 14:
-				return configs["javascript/es2020"];
-
-			case 15:
-				return configs["javascript/es2021"];
-			case 16:
-			case 17:
-			case 18:
-			case 19:
-				return configs["javascript/es2022"];
-			case 20:
-			case 21:
-				return configs["javascript/es2023"];
-			case 22:
-			case 23:
-				return configs["javascript/es2024"];
-			case 24:
-			case 25:
-				return configs["javascript/es2025"];
-			default:
-				return configs["javascript/recommended"];
-		}
+	if (!packageJson.engines || !packageJson.engines.node) {
+		return configs["javascript/recommended"];
 	}
 
-	return configs["javascript/recommended"];
+	const nodeRange = packageJson.engines.node;
+	const minVersion = semver.minVersion(nodeRange);
+
+	// Node 6 has Array#includes (from 6.5) but never gained the `**` operator,
+	// so it doesn't map cleanly to a single ES year — handle it inline.
+	// https://node.green/
+	if (minVersion && minVersion.major === 6) {
+		const base = configs["javascript/es2016"];
+		return {
+			...base,
+			rules: {
+				...base.rules,
+				"prefer-exponentiation-operator": "off",
+			},
+		};
+	}
+
+	const esVersion = getEsVersionFromNode(nodeRange);
+
+	if (esVersion === undefined) {
+		return configs["javascript/recommended"];
+	}
+
+	const config = configs[`javascript/es${esVersion}`];
+
+	// The `globals.es2019` set from the `globals` package doesn't declare
+	// `Promise` or `BigInt`, but both are available at runtime on Node 12+.
+	// Re-add them as readonly globals so `no-undef` doesn't flag usage.
+	if (esVersion === 2019) {
+		/** @type {import("eslint").Linter.Config["languageOptions"]} */
+		const original = config.languageOptions;
+		/** @type {import("eslint").Linter.Config["languageOptions"]} */
+		const languageOptions = {
+			...original,
+			globals: {
+				// @ts-expect-error always exist
+				...original.globals,
+				Promise: false,
+				BigInt: false,
+			},
+		};
+
+		return { ...config, languageOptions };
+	}
+
+	return config;
 }
 
 const javascriptConfig = getJavascriptConfig();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-webpack",
-  "version": "4.9.4",
+  "version": "4.9.6",
   "description": "Provides Webpack's eslint rules as an extensible shared config",
   "keywords": [
     "eslint",
@@ -40,36 +40,36 @@
   },
   "dependencies": {
     "@eslint/js": "^9.39.2",
-    "@eslint/markdown": "^7.5.1",
+    "@eslint/markdown": "^8.0.1",
     "@stylistic/eslint-plugin": "^5.10.0",
     "detect-indent": "^7.0.2",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-import": "^2.32.0",
-    "eslint-plugin-jest": "^29.15.0",
-    "eslint-plugin-jsdoc": "^62.8.0",
-    "eslint-plugin-n": "^17.24.0",
+    "eslint-plugin-jest": "^29.15.2",
+    "eslint-plugin-jsdoc": "^62.9.0",
+    "eslint-plugin-n": "^18.0.1",
     "eslint-plugin-prettier": "^5.5.5",
     "eslint-plugin-react": "^7.37.5",
-    "eslint-plugin-react-hooks": "^7.0.1",
-    "eslint-plugin-unicorn": "^63.0.0",
-    "globals": "^17.4.0",
+    "eslint-plugin-react-hooks": "^7.1.1",
+    "eslint-plugin-unicorn": "^64.0.0",
+    "globals": "^17.6.0",
     "jsonc-eslint-parser": "^3.1.0",
-    "semver": "^7.7.4",
+    "semver": "^7.8.0",
     "sort-package-json": "^3.6.0",
-    "typescript-eslint": "^8.57.2"
+    "typescript-eslint": "^8.59.3"
   },
   "devDependencies": {
-    "@changesets/cli": "^2.30.0",
+    "@changesets/cli": "^2.31.0",
     "@changesets/get-github-info": "^0.8.0",
     "@types/semver": "^7.7.1",
     "eslint": "^9.39.2",
     "eslint-find-rules": "^5.0.0",
-    "jest": "^30.3.0",
-    "prettier": "^3.8.1",
-    "react": "^19.2.3",
-    "react-dom": "^19.2.3",
-    "type-fest": "^5.5.0",
-    "typescript": "^5.9.3"
+    "jest": "^30.4.2",
+    "prettier": "^3.8.3",
+    "react": "^19.2.6",
+    "react-dom": "^19.2.6",
+    "type-fest": "^5.6.0",
+    "typescript": "^6.0.3"
   },
   "peerDependencies": {
     "eslint": ">= 9.28.0",