eslint-config-webpack 4.9.3 → 4.9.5

package/configs/browser.js

@@ -2,6 +2,7 @@ import importPlugin from "eslint-plugin-import";
 import unicornPlugin from "eslint-plugin-unicorn";
 import globals from "globals";
 
+/** @type {import("eslint").Linter.Config} */
 const recommendedBrowserOutdatedScriptConfig = {
 	name: "browser/recommended-outdated-script",
 	languageOptions: {
@@ -12,6 +13,7 @@ const recommendedBrowserOutdatedScriptConfig = {
 	},
 };
 
+/** @type {import("eslint").Linter.Config} */
 const recommendedBrowserOutdatedCommonjsConfig = {
 	name: "browser/recommended-outdated-commonjs",
 	languageOptions: {
@@ -22,6 +24,7 @@ const recommendedBrowserOutdatedCommonjsConfig = {
 	},
 };
 
+/** @type {import("eslint").Linter.Config} */
 const recommendedBrowserOutdatedModuleConfig = {
 	name: "browser/recommended-outdated-module",
 	languageOptions: {
@@ -32,6 +35,7 @@ const recommendedBrowserOutdatedModuleConfig = {
 	},
 };
 
+/** @type {import("eslint").Linter.Config} */
 const recommendedBrowserConfig = {
 	name: "browser/recommended",
 	languageOptions: {

package/configs/index.js

@@ -9,17 +9,43 @@ import stylisticConfig from "./stylistic.js";
 import typescriptConfig from "./typescript.js";
 import webpackSpecial from "./webpack-special.js";
 
-const configs = {
-	...browserConfig,
-	...javascriptConfig,
-	...jestConfig,
-	...markdownConfig,
-	...nodeConfig,
-	...stylisticConfig,
-	...typescriptConfig,
-	...reactConfig,
-	...packageJSON,
-	...webpackSpecial,
-};
+// TODO merge this file with config.js into one to avoid problems with types
+
+/** @typedef {typeof browserConfig & typeof javascriptConfig & typeof jestConfig & typeof markdownConfig & typeof nodeConfig & typeof stylisticConfig & typeof typescriptConfig & typeof reactConfig & typeof packageJSON & typeof webpackSpecial} BasicConfigs */
+/** @typedef {import("eslint").Linter.Config} Config */
+/** @typedef {(Config | Config[])[]} NestedConfig */
+/**
+ * @typedef {{
+ * recommended: NestedConfig,
+ * "node-recommended": NestedConfig,
+ * "recommended-module": NestedConfig,
+ * "node-recommended-module": NestedConfig,
+ * "recommended-commonjs": NestedConfig,
+ * "node-recommended-commonjs": NestedConfig,
+ * "recommended-dirty": NestedConfig,
+ * "node-recommended-dirty": NestedConfig,
+ * "browser-recommended": NestedConfig,
+ * "browser-outdated-recommended-script": NestedConfig,
+ * "browser-outdated-recommended-commonjs": NestedConfig,
+ * "browser-outdated-recommended-module": NestedConfig,
+ * "browser-outdated-recommended": NestedConfig,
+ * "universal-recommended": NestedConfig,
+ }} AddvancedConfigs */
+
+/** @type {BasicConfigs & AddvancedConfigs} */
+const configs =
+	/** @type {BasicConfigs & AddvancedConfigs} */
+	({
+		...browserConfig,
+		...javascriptConfig,
+		...jestConfig,
+		...markdownConfig,
+		...nodeConfig,
+		...stylisticConfig,
+		...typescriptConfig,
+		...reactConfig,
+		...packageJSON,
+		...webpackSpecial,
+	});
 
 export default configs;

package/configs/javascript.js

@@ -5,6 +5,7 @@ import globals from "globals";
 import { allExtensions, javascriptExtensions } from "./utils/extensions.js";
 import isTypescriptInstalled from "./utils/is-typescript-installed.js";
 
+/** @type {import("eslint").Linter.Config["rules"]} */
 const possibleProblems = {
 	"array-callback-return": [
 		"error",
@@ -195,6 +196,7 @@ const possibleProblems = {
 	// "valid-typeof": "error",
 };
 
+/** @type {import("eslint").Linter.Config["rules"]} */
 const suggestions = {
 	"accessor-pairs": "error",
 
@@ -336,7 +338,8 @@ const suggestions = {
 	// No need
 	// "max-statements": "off",
 
-	"new-cap": "error",
+	// For `prop-types`
+	"new-cap": ["error", { capIsNewExceptionPattern: "^.+Type$" }],
 
 	"no-alert": "error",
 
@@ -658,10 +661,12 @@ const suggestions = {
 	yoda: "error",
 };
 
+/** @type {import("eslint").Linter.Config["rules"]} */
 const layoutAndFormatting = {
 	"unicode-bom": ["error", "never"],
 };
 
+/** @type {import("eslint").Linter.Config["rules"]} */
 const unicornRules = {
 	// No need
 	// "unicorn/better-regex": "off",
@@ -685,6 +690,8 @@ const unicornRules = {
 	// No need
 	// "unicorn/consistent-function-scoping": "off",
 
+	"unicorn/consistent-template-literal-escape": "error",
+
 	// No need
 	// "unicorn/custom-error-definition": "off",
 
@@ -701,7 +708,7 @@ const unicornRules = {
 	// No need
 	// "unicorn/explicit-length-check": "off",
 
-	// TODO
+	// TODO enable in future?
 	"unicorn/filename-case": [
 		"off",
 		{
@@ -730,6 +737,9 @@ const unicornRules = {
 	// No need
 	// "unicorn/import-style": "off",
 
+	// No need
+	// "unicorn/isolated-functions": "off",
+
 	"unicorn/new-for-builtins": "error",
 
 	"unicorn/no-abusive-eslint-disable": "error",
@@ -826,7 +836,7 @@ const unicornRules = {
 	// No need
 	// "unicorn/no-this-assignment": "off",
 
-	// TODO - enable in future?
+	// TODO enable in future? Need to check performance
 	// "unicorn/no-typeof-undefined": "off",
 
 	"unicorn/no-unnecessary-array-flat-depth": "error",
@@ -854,6 +864,8 @@ const unicornRules = {
 
 	"unicorn/no-useless-fallback-in-spread": "error",
 
+	"unicorn/no-useless-iterator-to-array": "error",
+
 	"unicorn/no-useless-length-check": "error",
 
 	"unicorn/no-useless-promise-resolve-reject": "error",
@@ -985,6 +997,9 @@ const unicornRules = {
 	// No need
 	// "unicorn/prefer-set-size": "off",
 
+	// TODO enable in the next major release
+	// "unicorn/prefer-simple-condition-first": "error",
+
 	// No need
 	// "unicorn/prefer-single-call": "off",
 
@@ -1037,6 +1052,10 @@ const unicornRules = {
 	// No need
 	// "unicorn/switch-case-braces": "off",
 
+	// TODO maybe?
+	// No need
+	// "unicorn/switch-case-break-position": "off",
+
 	// No need
 	// "unicorn/template-indent": "off",
 
@@ -1045,6 +1064,7 @@ const unicornRules = {
 	"unicorn/throw-new-error": "error",
 };
 
+/** @type {import("eslint").Linter.Config["rules"]} */
 const importRules = {
 	...importPlugin.flatConfigs.recommended.rules,
 
@@ -1196,52 +1216,62 @@ const importRules = {
 	// "import/prefer-default-export": "off",
 };
 
+const needTypescriptSupport = isTypescriptInstalled();
+const extensions = needTypescriptSupport ? allExtensions : javascriptExtensions;
+
+/** @type {import("eslint").Linter.Config} */
+const baseConfig = {
+	...javascriptConfig.configs.recommended,
+	files: [`**/*.{${extensions.map((item) => item.slice(1)).join(",")}}`],
+	ignores: ["**/*.d.ts"],
+	settings: {
+		"import/extensions": extensions,
+		"import/ignore": [
+			"eslint-plugin-.*",
+			"\\.(coffee|scss|css|less|hbs|svg|md|jpg|jpeg|png|gif|webp|avif)$",
+		],
+		"import/resolver": {
+			node: {
+				extensions: [...extensions],
+			},
+		},
+	},
+	plugins: {
+		unicorn: unicornPlugin,
+		import: importPlugin,
+	},
+	linterOptions: {
+		reportUnusedDisableDirectives: true,
+		reportUnusedInlineConfigs: "error",
+	},
+	rules: {
+		...javascriptConfig.configs.recommended.rules,
+		...possibleProblems,
+		...suggestions,
+		...layoutAndFormatting,
+		...unicornRules,
+		...importRules,
+	},
+};
+
+/** @typedef {2015 | 2016 | 2017 | 2018 | 2019 | 2020 | 2021 | 2022 | 2023 | 2024 | 2025 | 2026} Year */
+
 /**
- * @param {number} esVersion es version
- * @returns {Record<string, string | number>} config
+ * @param {Year | 5} esVersion es version
+ * @returns {import("eslint").Linter.Config} config
  */
 function getConfig(esVersion) {
-	const extensions = isTypescriptInstalled()
-		? allExtensions
-		: javascriptExtensions;
 	const config = {
-		...javascriptConfig.configs.recommended,
+		...baseConfig,
 		name: `javascript/es${esVersion}`,
-		files: [`**/*.{${extensions.map((item) => item.slice(1)).join(",")}}`],
-		ignores: ["**/*.d.ts"],
-		settings: {
-			"import/extensions": extensions,
-			"import/ignore": [
-				"eslint-plugin-.*",
-				"\\.(coffee|scss|css|less|hbs|svg|md|jpg|jpeg|png|gif|webp|avif)$",
-			],
-			"import/resolver": {
-				node: {
-					extensions: [...extensions],
-				},
-			},
-		},
-		plugins: {
-			unicorn: unicornPlugin,
-			import: importPlugin,
-		},
 		languageOptions: {
 			ecmaVersion: esVersion,
 			globals: {
 				...globals[`es${esVersion}`],
 			},
 		},
-		linterOptions: {
-			reportUnusedDisableDirectives: true,
-			reportUnusedInlineConfigs: "error",
-		},
 		rules: {
-			...javascriptConfig.configs.recommended.rules,
-			...possibleProblems,
-			...suggestions,
-			...layoutAndFormatting,
-			...unicornRules,
-			...importRules,
+			...baseConfig.rules,
 		},
 	};
 
@@ -1301,11 +1331,12 @@ function getConfig(esVersion) {
 	return config;
 }
 
+/** @type {Record<"javascript/es5" | "javascript/recommended" | `javascript/es${Year}`, import("eslint").Linter.Config>} */
 const configs = {};
-const esVersions = Array.from({ length: 11 }, (_x, i) => 15 + i);
+const esVersions = Array.from({ length: 12 }, (_x, i) => 15 + i);
 
 for (const [i, esVersion] of esVersions.entries()) {
-	const year = 2000 + esVersion;
+	const year = /** @type {Year} */ (2000 + esVersion);
 	const config = getConfig(year);
 
 	configs[`javascript/es${year}`] = config;

package/configs/jest.js

@@ -1,20 +1,33 @@
 import globals from "globals";
+import getJsonFile from "./utils/get-json-file.js";
+
+/** @type {import("type-fest").PackageJson | null} */
+const packageJson = getJsonFile("package.json");
 
 /**
- * @returns {Promise<Record<string, string>>} config
+ * @returns {Promise<import("eslint").Linter.Config>} config
  */
 async function getJestRecommendedConfig() {
-	let jestPlugin;
+	if (packageJson === null) {
+		return {
+			name: "jest/please-install-jest-to-enable-it",
+		};
+	}
+
+	const dependencies = packageJson.dependencies || {};
+	const devDependencies = packageJson.devDependencies || {};
 
-	try {
-		jestPlugin = (await import("eslint-plugin-jest")).default;
-		// eslint-disable-next-line unicorn/prefer-optional-catch-binding
-	} catch (_err) {
-		// Nothing
+	if (
+		typeof dependencies.jest === "undefined" &&
+		typeof devDependencies.jest === "undefined"
+	) {
+		return {
+			name: "jest/please-install-jest-to-enable-it",
+		};
 	}
 
-	const jsdocConfig =
-		(jestPlugin && jestPlugin.configs["flat/recommended"]) || {};
+	const jestPlugin = (await import("eslint-plugin-jest")).default;
+	const jsdocConfig = jestPlugin.configs["flat/recommended"];
 
 	return {
 		...jsdocConfig,

package/configs/markdown.js

@@ -1,17 +1,10 @@
 import isTypescriptInstalled from "./utils/is-typescript-installed.js";
 
 /**
- * @returns {Promise<Record<string, string>>} config
+ * @returns {Promise<import("eslint").Linter.Config[]>} config
  */
 async function getMarkdownRecommendedConfig() {
-	let markdownPlugin;
-
-	try {
-		markdownPlugin = (await import("@eslint/markdown")).default;
-		// eslint-disable-next-line unicorn/prefer-optional-catch-binding
-	} catch (_err) {
-		// Nothing
-	}
+	const markdownPlugin = (await import("@eslint/markdown")).default;
 
 	return [
 		{
@@ -19,6 +12,7 @@ async function getMarkdownRecommendedConfig() {
 			files: ["**/*.md"],
 			processor: "markdown/markdown",
 			plugins: {
+				// @ts-expect-error bad types
 				markdown: markdownPlugin,
 			},
 		},

package/configs/node.js

@@ -2,6 +2,7 @@ import importPlugin from "eslint-plugin-import";
 import globals from "globals";
 import isTypescriptInstalled from "./utils/is-typescript-installed.js";
 
+/** @type {import("eslint").Linter.Config["rules"]} */
 const commonRules = {
 	// No need
 	// "n/callback-return": "error",
@@ -101,12 +102,16 @@ const commonRules = {
 
 	"n/prefer-global/console": ["error", "always"],
 
+	"n/prefer-global/crypto": ["error", "always"],
+
 	"n/prefer-global/process": ["error", "always"],
 
 	"n/prefer-global/text-decoder": ["error", "always"],
 
 	"n/prefer-global/text-encoder": ["error", "always"],
 
+	"n/prefer-global/timers": ["error", "always"],
+
 	"n/prefer-global/url": ["error", "always"],
 
 	"n/prefer-global/url-search-params": ["error", "always"],
@@ -123,25 +128,14 @@ const commonRules = {
 	// "n/process-exit-as-throw": "error",
 };
 
-let nodePlugin;
-
 const ignores = ["**/*.d.ts"];
 
 /**
- * @returns {Promise<Record<string, string>>} config
+ * @returns {Promise<import("eslint").Linter.Config>} config
  */
 async function getCommonJSConfig() {
-	if (!nodePlugin) {
-		try {
-			nodePlugin = (await import("eslint-plugin-n")).default;
-			// eslint-disable-next-line unicorn/prefer-optional-catch-binding
-		} catch (_err) {
-			// Nothing
-		}
-	}
-
-	const nodeConfig =
-		(nodePlugin && nodePlugin.configs["flat/recommended-script"]) || {};
+	const nodePlugin = (await import("eslint-plugin-n")).default;
+	const nodeConfig = nodePlugin.configs["flat/recommended-script"];
 
 	return {
 		...nodeConfig,
@@ -183,22 +177,11 @@ async function getCommonJSConfig() {
 }
 
 /**
- * @returns {Promise<Record<string, string>>} config
+ * @returns {Promise<import("eslint").Linter.Config>} config
  */
 async function getModuleConfig() {
-	let nodePlugin;
-
-	if (!nodePlugin) {
-		try {
-			nodePlugin = (await import("eslint-plugin-n")).default;
-			// eslint-disable-next-line unicorn/prefer-optional-catch-binding
-		} catch (_err) {
-			// Nothing
-		}
-	}
-
-	const nodeConfig =
-		(nodePlugin && nodePlugin.configs["flat/recommended-module"]) || {};
+	const nodePlugin = (await import("eslint-plugin-n")).default;
+	const nodeConfig = nodePlugin.configs["flat/recommended-module"];
 
 	return {
 		...nodeConfig,
@@ -230,19 +213,10 @@ const commonjsConfig = await getCommonJSConfig();
 const moduleConfig = await getModuleConfig();
 
 /**
- * @returns {Promise<Record<string, string>>} config
+ * @returns {Promise<import("eslint").Linter.Config>} config
  */
 async function getDirtyConfig() {
-	let nodePlugin;
-
-	if (!nodePlugin) {
-		try {
-			nodePlugin = (await import("eslint-plugin-n")).default;
-			// eslint-disable-next-line unicorn/prefer-optional-catch-binding
-		} catch (_err) {
-			// Nothing
-		}
-	}
+	const nodePlugin = (await import("eslint-plugin-n")).default;
 
 	return {
 		name: "node/dirty",
@@ -250,7 +224,12 @@ async function getDirtyConfig() {
 			n: nodePlugin,
 			import: importPlugin,
 		},
-		ignores: [...new Set([...commonjsConfig.ignores, ...moduleConfig.ignores])],
+		ignores: [
+			...new Set([
+				...(commonjsConfig.ignores || []),
+				...(moduleConfig.ignores || []),
+			]),
+		],
 		languageOptions: {
 			sourceType: "module",
 			parserOptions: {

package/configs/package-json.js

@@ -1,8 +1,7 @@
 import { configs } from "../plugins/package-json/index.js";
 
-const recommendedBrowserConfig = {
-	...configs.recommended,
-};
+/** @type {import("eslint").Linter.Config} */
+const recommendedBrowserConfig = configs.recommended;
 
 export default {
 	"package-json/recommended": recommendedBrowserConfig,

package/configs/react.js

@@ -1,36 +1,42 @@
+import getJsonFile from "./utils/get-json-file.js";
+
+/** @type {import("type-fest").PackageJson | null} */
+const packageJson = getJsonFile("package.json");
+
 /**
- * @returns {Promise<Record<string, string>>} config
+ * @returns {Promise<import("eslint").Linter.Config>} config
  */
 async function getReactRecommendedConfig() {
-	let reactPlugin;
-
-	try {
-		reactPlugin = (await import("eslint-plugin-react")).default;
-		// eslint-disable-next-line unicorn/prefer-optional-catch-binding
-	} catch (_err) {
-		// Nothing
+	if (packageJson === null) {
+		return {
+			name: "react/please-install-react-to-enable-it",
+		};
 	}
 
-	let reactHooksPlugin;
+	const dependencies = packageJson.dependencies || {};
+	const devDependencies = packageJson.devDependencies || {};
 
-	try {
-		reactHooksPlugin = (await import("eslint-plugin-react-hooks")).default;
-		// eslint-disable-next-line unicorn/prefer-optional-catch-binding
-	} catch (_err) {
-		// Nothing
+	if (
+		typeof dependencies.react === "undefined" &&
+		typeof dependencies.preact === "undefined" &&
+		typeof devDependencies.react === "undefined" &&
+		typeof devDependencies.preact === "undefined"
+	) {
+		return {
+			name: "react/please-install-react-to-enable-it",
+		};
 	}
 
-	const { recommended, "jsx-runtime": jsxRuntime } = (reactPlugin &&
-		reactPlugin.configs &&
-		reactPlugin.configs.flat) || { recommended: {}, "jsx-runtime": {} };
+	const reactPlugin = (await import("eslint-plugin-react")).default;
+	const { recommended, "jsx-runtime": jsxRuntime } = reactPlugin.configs.flat;
 
-	const { recommended: recommendedHooks } = (reactHooksPlugin &&
-		reactHooksPlugin.configs &&
-		reactHooksPlugin.configs.flat) || { recommended: {} };
+	const reactHooksPlugin = (await import("eslint-plugin-react-hooks")).default;
+	const { recommended: recommendedHooks } = reactHooksPlugin.configs.flat;
 
 	return {
 		...recommended,
 		...recommendedHooks,
+		name: "react/recommended",
 		plugins: {
 			...recommended.plugins,
 			...recommendedHooks.plugins,

package/configs/stylistic.js

@@ -2,6 +2,7 @@ import stylisticPlugin from "@stylistic/eslint-plugin";
 import prettierPlugin from "eslint-plugin-prettier";
 import prettierConfig from "eslint-plugin-prettier/recommended";
 
+/** @type {import("eslint").Linter.Config} */
 const recommendedConfig = {
 	...prettierConfig,
 	name: "stylistic/recommended",