eslint-config-webpack 4.6.2 → 4.7.0

package/configs/browser.js

@@ -45,6 +45,8 @@ const recommendedBrowserConfig = {
 		import: importPlugin,
 	},
 	rules: {
+		"unicorn/prefer-classlist-toggle": "error",
+
 		"unicorn/prefer-dom-node-append": "error",
 
 		"unicorn/prefer-dom-node-dataset": "error",

package/configs/javascript.js

@@ -2,7 +2,8 @@ import javascriptConfig from "@eslint/js";
 import importPlugin from "eslint-plugin-import";
 import unicornPlugin from "eslint-plugin-unicorn";
 import globals from "globals";
-import { allExtensions } from "./utils/extensions.js";
+import { allExtensions, javascriptExtensions } from "./utils/extensions.js";
+import isTypescriptInstalled from "./utils/is-typescript-installed.js";
 
 const possibleProblems = {
 	"array-callback-return": [
@@ -625,6 +626,8 @@ const suggestions = {
 
 	"prefer-template": "error",
 
+	"preserve-caught-error": "error",
+
 	radix: ["error", "always"],
 
 	// `require-await` doesn't work when the function returns Promise<any>
@@ -749,6 +752,8 @@ const unicornRules = {
 	// No need
 	// "unicorn/no-array-reverse": "off",
 
+	"unicorn/no-array-sort": "error",
+
 	// No need
 	// "unicorn/no-await-expression-member": "off",
 
@@ -767,6 +772,9 @@ const unicornRules = {
 
 	"unicorn/no-hex-escape": "error",
 
+	// No need
+	// "unicorn/no-immediate-mutation": "error",
+
 	"unicorn/no-instanceof-builtins": "error",
 
 	"unicorn/no-invalid-fetch-options": "error",
@@ -840,6 +848,8 @@ const unicornRules = {
 	// No need
 	// "unicorn/no-unused-properties": "off",
 
+	"unicorn/no-useless-collection-argument": "error",
+
 	"unicorn/no-useless-error-capture-stack-trace": "error",
 
 	"unicorn/no-useless-fallback-in-spread": "error",
@@ -881,10 +891,15 @@ const unicornRules = {
 	// No need
 	// "unicorn/prefer-at": "off",
 
+	"unicorn/prefer-bigint-literals": "error",
+
 	"unicorn/prefer-blob-reading-methods": "error",
 
 	"unicorn/prefer-class-fields": "error",
 
+	// Not here, define only for `browsers`
+	// "unicorn/prefer-classlist-toggle": "error",
+
 	// No need
 	// "unicorn/prefer-code-point": "error",
 
@@ -962,6 +977,8 @@ const unicornRules = {
 
 	"unicorn/prefer-regexp-test": "error",
 
+	"unicorn/prefer-response-static-json": "error",
+
 	// No need
 	// "unicorn/prefer-set-has": "off",
 
@@ -1004,6 +1021,8 @@ const unicornRules = {
 	// No need
 	// "unicorn/require-array-join-separator": "error",
 
+	"unicorn/require-module-attributes": "error",
+
 	"unicorn/require-module-specifiers": "error",
 
 	// No need
@@ -1182,20 +1201,23 @@ const importRules = {
  * @returns {Record<string, string | number>} config
  */
 function getConfig(esVersion) {
+	const extensions = isTypescriptInstalled()
+		? allExtensions
+		: javascriptExtensions;
 	const config = {
 		...javascriptConfig.configs.recommended,
 		name: `javascript/es${esVersion}`,
-		files: [`**/*.{${allExtensions.map((item) => item.slice(1)).join(",")}}`],
+		files: [`**/*.{${extensions.map((item) => item.slice(1)).join(",")}}`],
 		ignores: ["**/*.d.ts"],
 		settings: {
-			"import/extensions": allExtensions,
+			"import/extensions": extensions,
 			"import/ignore": [
 				"eslint-plugin-.*",
 				"\\.(coffee|scss|css|less|hbs|svg|md|jpg|jpeg|png|gif|webp|avif)$",
 			],
 			"import/resolver": {
 				node: {
-					extensions: [...allExtensions],
+					extensions: [...extensions],
 				},
 			},
 		},
@@ -1245,8 +1267,6 @@ function getConfig(esVersion) {
 		config.rules["prefer-object-spread"] = "off";
 	}
 
-	// unicorn/prefer-class-fields
-
 	if (esVersion < 2019) {
 		config.rules["unicorn/prefer-object-from-entries"] = "off";
 		config.rules["unicorn/prefer-array-flat"] = "off";
@@ -1256,6 +1276,7 @@ function getConfig(esVersion) {
 	}
 
 	if (esVersion < 2020) {
+		config.rules["unicorn/prefer-bigint-literals"] = "off";
 		config.rules["unicorn/prefer-global-this"] = "off";
 		config.rules["unicorn/prefer-logical-operator-over-ternary"] = "off";
 	}

package/configs/jest.js

@@ -102,6 +102,8 @@ async function getJestRecommendedConfig() {
 			// No need
 			// "jest/no-test-return-statement": "error",
 
+			"jest/no-unneeded-async-expect-function": "error",
+
 			// No need
 			// "jest/no-untyped-mock-factory": "error",
 
@@ -164,6 +166,10 @@ async function getJestRecommendedConfig() {
 
 			"jest/prefer-to-contain": "error",
 
+			"jest/prefer-to-have-been-called": "error",
+
+			"jest/prefer-to-have-been-called-times": "error",
+
 			"jest/prefer-to-have-length": "error",
 
 			// No need
@@ -186,6 +192,9 @@ async function getJestRecommendedConfig() {
 			// From recommended
 			// "jest/valid-expect-in-promise": "error",
 
+			// No need
+			// "valid-mock-module-path": "off",
+
 			// From recommended
 			"jest/valid-title": [
 				"error",

package/configs/markdown.js

@@ -24,7 +24,7 @@ async function getMarkdownRecommendedConfig() {
 		},
 		{
 			name: "markdown/code-blocks/js",
-			files: isTypescriptInstalled
+			files: isTypescriptInstalled()
 				? ["**/*.md/*.js", "**/*.md/*.ts"]
 				: ["**/*.md/*.js"],
 			languageOptions: {

package/configs/node.js

@@ -1,5 +1,6 @@
 import importPlugin from "eslint-plugin-import";
 import globals from "globals";
+import isTypescriptInstalled from "./utils/is-typescript-installed.js";
 
 const commonRules = {
 	// No need
@@ -263,6 +264,16 @@ async function getDirtyConfig() {
 
 const dirtyConfig = await getDirtyConfig();
 
+const jsExtensions = isTypescriptInstalled()
+	? ["**/*.{js,jsx,ts,tsx}"]
+	: ["**/*.{js,jsx}"];
+const cjsExtensions = isTypescriptInstalled()
+	? ["**/*.{cjs,cts}"]
+	: ["**/*.{cjs}"];
+const mjsExtensions = isTypescriptInstalled()
+	? ["**/*.{mjs,mts}"]
+	: ["**/*.{mjs}"];
+
 export default {
 	"node/dirty": dirtyConfig,
 	"node/commonjs": commonjsConfig,
@@ -270,43 +281,43 @@ export default {
 	"node/recommended": moduleConfig,
 	"node/mixed-dirty": [
 		{
-			files: ["**/*.{js,jsx,ts,tsx}"],
+			files: jsExtensions,
 			...dirtyConfig,
 		},
 		{
-			files: ["**/*.{cjs,cts}"],
+			files: cjsExtensions,
 			...commonjsConfig,
 		},
 		{
-			files: ["**/*.{mjs,mts}"],
+			files: mjsExtensions,
 			...moduleConfig,
 		},
 	],
 	"node/mixed-module-and-commonjs": [
 		{
-			files: ["**/*.{js,jsx,ts,tsx}"],
+			files: jsExtensions,
 			...moduleConfig,
 		},
 		{
-			files: ["**/*.{cjs,cts}"],
+			files: cjsExtensions,
 			...commonjsConfig,
 		},
 		{
-			files: ["**/*.{mjs,mts}"],
+			files: mjsExtensions,
 			...moduleConfig,
 		},
 	],
 	"node/mixed-commonjs-and-module": [
 		{
-			files: ["**/*.{js,jsx,ts,tsx}"],
+			files: jsExtensions,
 			...commonjsConfig,
 		},
 		{
-			files: ["**/*.{cjs,cts}"],
+			files: cjsExtensions,
 			...commonjsConfig,
 		},
 		{
-			files: ["**/*.{mjs,mts}"],
+			files: mjsExtensions,
 			...moduleConfig,
 		},
 	],

package/configs/typescript.js

@@ -105,6 +105,9 @@ async function getTypescriptJSDocRecommendedConfig() {
 			// From recommended
 			// "jsdoc/empty-tags": "error",
 
+			// From recommended
+			// "jsdoc/escape-inline-tags": "error",
+
 			// "jsdoc/implements-on-classes": "error",
 
 			// No need
@@ -154,28 +157,11 @@ async function getTypescriptJSDocRecommendedConfig() {
 							message:
 								"Please use `@property {string=} property`/`@param {string=} arg` instead `[arg]` for optional properties and parameters",
 						},
-						// No `*` type
-						{
-							comment: "JsdocBlock:has(JsdocTypeAny)",
-							message: "Please use `any` or `EXPECTED_ANY` type.",
-						},
 						// No `?` type
 						{
 							comment: "JsdocBlock:has(JsdocTypeUnknown)",
 							message: "Please use `unknown` or `any` (or `EXPECTED_ANY`) type",
 						},
-						// No `any` type
-						{
-							comment: "JsdocBlock:has(JsdocTypeName[value=/^any$/])",
-							message: "Please use provide types instead `any`",
-						},
-						// No `Function` type
-						{
-							comment:
-								"JsdocBlock:has(JsdocTypeName[value=/^(function|Function)$/])",
-							message:
-								"Please use provide types for function  - `(a: number, b: number) -> number` instead `Function`/`function` or use `EXPECTED_FUNCTION` type",
-						},
 						// No `Object`
 						{
 							comment:
@@ -199,6 +185,13 @@ async function getTypescriptJSDocRecommendedConfig() {
 			// No need
 			// "jsdoc/no-undefined-types": "error",
 
+			// TODO enable me in future
+			// "jsdoc/prefer-import-tag": "error",
+
+			"jsdoc/reject-any-type": "error",
+
+			"jsdoc/reject-function-type": "error",
+
 			"jsdoc/require-asterisk-prefix": "error",
 
 			// No need
@@ -219,6 +212,12 @@ async function getTypescriptJSDocRecommendedConfig() {
 			// From recommended
 			// "jsdoc/require-jsdoc": "error",
 
+			// No need
+			// "jsdoc/require-next-description":"error",
+
+			// No need
+			// "jsdoc/require-next-type": "error",
+
 			// From recommended
 			// "jsdoc/require-param": "error",
 
@@ -252,14 +251,32 @@ async function getTypescriptJSDocRecommendedConfig() {
 			// From recommended
 			// "jsdoc/require-returns-type": "error",
 
+			// No need
+			// "jsdoc/require-tags": "error",
+
 			"jsdoc/require-template": "error",
 
+			// No need
+			// "jsdoc/require-template-description": "error",
+
 			// No need
 			// "jsdoc/require-throws": "error",
 
+			// No need
+			// "jsdoc/require-throws-description": "error",
+
+			// No need
+			// "jsdoc/require-throws-type": "error",
+
 			// From recommended
 			// "jsdoc/require-yields": "error",
 
+			// No need
+			// "jsdoc/require-yields-description": "error",
+
+			// No need
+			// "jsdoc/require-yields-type": "error",
+
 			// From recommended
 			// "jsdoc/require-yields-check": "error",
 
@@ -272,6 +289,9 @@ async function getTypescriptJSDocRecommendedConfig() {
 			// No need
 			// "jsdoc/text-escaping": "error",
 
+			// TODO enable after https://github.com/gajus/eslint-plugin-jsdoc/issues/1615
+			// "jsdoc/type-formatting": "error",
+
 			// Doesn't support function overloading/tuples/`readonly`/module keyword/etc
 			// Also `typescript` reports this itself
 			"jsdoc/valid-types": "off",
@@ -279,8 +299,6 @@ async function getTypescriptJSDocRecommendedConfig() {
 	};
 }
 
-const allExtensions = [...typescriptExtensions, ...javascriptExtensions];
-
 /**
  * @returns {Promise<Record<string, string>>} config
  */
@@ -311,6 +329,8 @@ async function getTypescriptRecommendedConfig() {
 		(item) => item.name === "typescript-eslint/stylistic",
 	);
 
+	const allExtensions = [...typescriptExtensions, ...javascriptExtensions];
+
 	return {
 		...baseConfig,
 		name: "typescript/recommended",
@@ -598,6 +618,9 @@ async function getTypescriptRecommendedConfig() {
 			// From recommended
 			// "@typescript-eslint/no-unused-expressions": "error",
 
+			"no-unused-private-class-members": "off",
+			"@typescript-eslint/no-unused-private-class-members": "error",
+
 			// Provide better options
 			"no-unused-vars": "off",
 			"@typescript-eslint/no-unused-vars": [
@@ -633,6 +656,9 @@ async function getTypescriptRecommendedConfig() {
 			// No need
 			// "@typescript-eslint/no-useless-constructor": "error",
 
+			// No need
+			// "@typescript-eslint/no-useless-default-assignment": "error",
+
 			"@typescript-eslint/no-useless-empty-export": "error",
 
 			// From recommended

package/configs/utils/is-typescript-installed.js

@@ -15,7 +15,7 @@ function isTypescriptInstalled() {
 
 	return Boolean(
 		typeof dependencies.typescript !== "undefined" ||
-			typeof devDependencies.typescript !== "undefined",
+		typeof devDependencies.typescript !== "undefined",
 	);
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-webpack",
-  "version": "4.6.2",
+  "version": "4.7.0",
   "description": "Provides Webpack's eslint rules as an extensible shared config",
   "keywords": [
     "eslint",
@@ -37,32 +37,32 @@
     "release": "standard-version"
   },
   "dependencies": {
-    "detect-indent": "^7.0.1",
-    "jsonc-eslint-parser": "^2.4.0",
-    "semver": "^7.7.2",
-    "sort-package-json": "^3.4.0"
+    "detect-indent": "^7.0.2",
+    "jsonc-eslint-parser": "^2.4.2",
+    "semver": "^7.7.3",
+    "sort-package-json": "^3.6.0"
   },
   "devDependencies": {
-    "@eslint/js": "^9.31.0",
-    "@eslint/markdown": "^7.1.0",
-    "@stylistic/eslint-plugin": "^5.2.2",
-    "eslint": "^9.31.0",
+    "@eslint/js": "^9.39.2",
+    "@eslint/markdown": "^7.5.1",
+    "@stylistic/eslint-plugin": "^5.6.1",
+    "eslint": "^9.39.2",
     "eslint-find-rules": "^5.0.0",
     "eslint-plugin-import": "^2.32.0",
-    "eslint-plugin-jest": "^29.0.1",
-    "eslint-plugin-jsdoc": "^54.1.1",
-    "eslint-plugin-n": "^17.21.0",
+    "eslint-plugin-jest": "^29.5.0",
+    "eslint-plugin-jsdoc": "^61.5.0",
+    "eslint-plugin-n": "^17.23.1",
     "eslint-plugin-prettier": "^5.5.3",
     "eslint-plugin-react": "^7.37.5",
-    "eslint-plugin-unicorn": "^60.0.0",
-    "globals": "^16.3.0",
-    "jest": "^30.0.5",
-    "prettier": "^3.6.2",
-    "react": "^19.1.0",
-    "react-dom": "^19.1.0",
+    "eslint-plugin-unicorn": "^62.0.0",
+    "globals": "^16.5.0",
+    "jest": "^30.2.0",
+    "prettier": "^3.7.4",
+    "react": "^19.2.3",
+    "react-dom": "^19.2.3",
     "standard-version": "^9.5.0",
-    "typescript": "^5.8.3",
-    "typescript-eslint": "^8.38.0"
+    "typescript": "^5.9.3",
+    "typescript-eslint": "^8.50.0"
   },
   "peerDependencies": {
     "@eslint/js": ">= 9.28.0",
@@ -77,10 +77,10 @@
     "eslint-plugin-prettier": ">= 5.5.3",
     "eslint-plugin-react": ">= 7.37.5",
     "eslint-plugin-unicorn": ">= 60.0.0",
-    "globals": ">= 16.2.0",
+    "globals": ">= 16.5.0",
     "prettier": ">= 3.5.3",
     "typescript": ">= 5.0.0",
-    "typescript-eslint": ">= 8.34.0"
+    "typescript-eslint": ">= 8.50.0"
   },
   "peerDependenciesMeta": {
     "@eslint/markdown": {

package/plugins/package-json/rules/order-properties.js

@@ -30,7 +30,7 @@ function detectNewlineGraceful(string) {
 	return detectNewline(string) || "\n";
 }
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+// eslint-disable-next-line jsdoc/reject-any-type
 /** @typedef {Record<string, any>} ObjectToSort */
 
 /**
@@ -50,7 +50,7 @@ function sortObjectKeys(object, sortWith) {
 
 	const objectKeys = Object.keys(object);
 
-	return (keys || [...objectKeys.sort(sortFn)]).reduce((total, key) => {
+	return (keys || objectKeys.toSorted(sortFn)).reduce((total, key) => {
 		if (Object.hasOwn(object, key)) {
 			total[key] = object[key];
 		}
@@ -66,11 +66,12 @@ function sortObjectKeys(object, sortWith) {
 export const isPackageJson = (filePath) =>
 	/(?:^|[/\\])package.json$/.test(filePath);
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+/* eslint-disable jsdoc/reject-any-type */
 /**
  * @typedef {import("eslint").AST.Program} PackageJsonAst
  * @property {[any]} body body
  */
+/* eslint-enable jsdoc/reject-any-type */
 
 /**
  * @typedef {import("eslint").SourceCode} PackageJsonSourceCode