eslint-config-webpack 4.2.2 → 4.3.1

package/configs/index.js

@@ -4,8 +4,10 @@ import jestConfig from "./jest.js";
 import markdownConfig from "./markdown.js";
 import nodeConfig from "./node.js";
 import packageJSON from "./package-json.js";
+import reactConfig from "./react.js";
 import stylisticConfig from "./stylistic.js";
 import typescriptConfig from "./typescript.js";
+import webpackSpecial from "./webpack-special.js";
 
 const configs = {
 	...browserConfig,
@@ -15,7 +17,9 @@ const configs = {
 	...nodeConfig,
 	...stylisticConfig,
 	...typescriptConfig,
+	...reactConfig,
 	...packageJSON,
+	...webpackSpecial,
 };
 
 export default configs;

package/configs/markdown.js

@@ -71,6 +71,8 @@ async function getMarkdownRecommendedConfig() {
 				"import/no-extraneous-dependencies": "off",
 
 				"jsdoc/require-jsdoc": "off",
+
+				"@typescript-eslint/no-unused-vars": "off",
 			},
 		},
 	];

package/configs/react.js

@@ -0,0 +1,26 @@
+import reactPlugin from "eslint-plugin-react";
+
+const { recommended, "jsx-runtime": jsxRuntime } = reactPlugin.configs.flat;
+
+const recommendedReactConfig = {
+	...reactPlugin.configs.flat.recommended,
+	files: ["**/*.{jsx,tsx}"],
+	settings: {
+		react: {
+			version: "detect",
+			defaultVersion: "19",
+		},
+	},
+	languageOptions: {
+		...recommended.languageOptions,
+		...jsxRuntime.languageOptions,
+	},
+	rules: {
+		...recommended.rules,
+		...jsxRuntime.rules,
+	},
+};
+
+export default {
+	"react/recommended": recommendedReactConfig,
+};

package/configs/typescript.js

@@ -274,6 +274,8 @@ async function getTypescriptJSDocRecommendedConfig() {
 	};
 }
 
+const allExtensions = [...typescriptExtensions, ...javascriptExtensions];
+
 /**
  * @returns {Promise<Record<string, string>>} config
  */
@@ -317,6 +319,18 @@ async function getTypescriptRecommendedConfig() {
 		plugins: {
 			...baseConfig.plugins,
 		},
+		settings: {
+			"import/extensions": allExtensions,
+			"import/external-module-folders": ["node_modules", "node_modules/@types"],
+			"import/parsers": {
+				"@typescript-eslint/parser": typescriptExtensions,
+			},
+			"import/resolver": {
+				node: {
+					extensions: allExtensions,
+				},
+			},
+		},
 		rules: {
 			...eslintRecommendedConfig.rules,
 			...recommendedConfig.rules,
@@ -721,6 +735,9 @@ async function getTypescriptRecommendedConfig() {
 			// No need
 			// "use-unknown-in-catch-callback-variable": "error",
 
+			// TypeScript compilation already ensures that named imports exist in the referenced module
+			"import/named": "off",
+
 			// TypeScript handles this for us
 			"import/no-unresolved": "off",
 		},

package/configs/utils/extensions.js

@@ -1,5 +1,5 @@
-const javascriptExtensions = [".js", ".cjs", ".mjs", ".jsx"];
-const typescriptExtensions = [".ts", ".cts", ".mts", ".tsx"];
+const javascriptExtensions = [".js", ".jsx", ".cjs", ".mjs"];
+const typescriptExtensions = [".ts", ".tsx", ".cts", ".mts"];
 const allExtensions = [...javascriptExtensions, ...typescriptExtensions];
 
 export { allExtensions, javascriptExtensions, typescriptExtensions };

package/configs/webpack-special.js

@@ -0,0 +1,9 @@
+import { configs } from "../plugins/webpack/index.js";
+
+const recommendedWebpackSpecialConfig = {
+	...configs.recommended,
+};
+
+export default {
+	"webpack/special": recommendedWebpackSpecialConfig,
+};

package/configs.js

@@ -216,20 +216,6 @@ function getTypescriptJSdocConfig() {
  * @returns {Promise<Record<string, string>>} config
  */
 function getTypescriptConfig() {
-	if (packageJson === null) {
-		return [];
-	}
-
-	const dependencies = packageJson.dependencies || [];
-	const devDependencies = packageJson.devDependencies || [];
-
-	if (
-		typeof dependencies.typescript === "undefined" &&
-		typeof devDependencies.typescript === "undefined"
-	) {
-		return [];
-	}
-
 	const tsconfigJson = getJsonFile("tsconfig.json");
 
 	const isNoEmitEnabled =
@@ -262,6 +248,23 @@ function getTypescriptConfig() {
 	];
 }
 
+/**
+ * @returns {Promise<Record<string, string>>} config
+ */
+function getReactConfig() {
+	if (packageJson === null) {
+		return [];
+	}
+
+	const dependencies = packageJson.dependencies || [];
+	const devDependencies = packageJson.devDependencies || [];
+
+	return typeof dependencies.react !== "undefined" ||
+		typeof devDependencies.react !== "undefined"
+		? configs["react/recommended"]
+		: [];
+}
+
 /**
  * @returns {Promise<Record<string, string>>} config
  */
@@ -282,6 +285,7 @@ function getJestConfig() {
 const javascriptConfig = getJavascriptConfig();
 const typescriptJSDocConfig = getTypescriptJSdocConfig();
 const typescriptConfig = getTypescriptConfig();
+const reactConfig = getReactConfig();
 const jestConfig = getJestConfig();
 
 configs.recommended = [
@@ -292,6 +296,7 @@ configs.recommended = [
 	javascriptConfig,
 	typescriptJSDocConfig,
 	typescriptConfig,
+	reactConfig,
 	jestConfig,
 	configs["markdown/recommended"],
 	configs["stylistic/recommended"],
@@ -304,6 +309,7 @@ configs["recommended-module"] = [
 	javascriptConfig,
 	typescriptJSDocConfig,
 	typescriptConfig,
+	reactConfig,
 	jestConfig,
 	configs["markdown/recommended"],
 	configs["stylistic/recommended"],
@@ -316,6 +322,7 @@ configs["recommended-commonjs"] = [
 	javascriptConfig,
 	typescriptJSDocConfig,
 	typescriptConfig,
+	reactConfig,
 	jestConfig,
 	configs["markdown/recommended"],
 	configs["stylistic/recommended"],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-webpack",
-  "version": "4.2.2",
+  "version": "4.3.1",
   "description": "Provides Webpack's eslint rules as an extensible shared config",
   "keywords": [
     "eslint",
@@ -53,10 +53,13 @@
     "eslint-plugin-jsdoc": "^51.2.3",
     "eslint-plugin-n": "^17.20.0",
     "eslint-plugin-prettier": "^5.5.0",
+    "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-unicorn": "^59.0.1",
     "globals": "^16.2.0",
     "jest": "^30.0.2",
     "prettier": "^3.6.0",
+    "react": "^19.1.0",
+    "react-dom": "^19.1.0",
     "standard-version": "^9.5.0",
     "typescript": "^5.8.3",
     "typescript-eslint": "^8.35.0"
@@ -72,6 +75,7 @@
     "eslint-plugin-jsdoc": ">= 50.7.1",
     "eslint-plugin-n": ">= 17.19.0",
     "eslint-plugin-prettier": ">= 5.4.1",
+    "eslint-plugin-react": ">= 7.37.5",
     "eslint-plugin-unicorn": ">= 59.0.1",
     "globals": ">= 16.2.0",
     "prettier": ">= 3.5.3",
@@ -88,6 +92,9 @@
     "eslint-plugin-jsdoc": {
       "optional": true
     },
+    "eslint-plugin-react": {
+      "optional": true
+    },
     "eslint-plugin-n": {
       "optional": true
     },

package/plugins/webpack/index.js

@@ -0,0 +1,45 @@
+import { createRequire } from "node:module";
+import { allExtensions } from "../../configs/utils/extensions.js";
+import { rule as requireLicenseComment } from "./rules/require-license-comment.js";
+
+const require = createRequire(import.meta.url);
+
+const { version } = require("../../package.json");
+
+const rules = {
+	"require-license-comment": requireLicenseComment,
+};
+
+const recommendedRules = {
+	...Object.fromEntries(
+		Object.entries(rules)
+			.filter(([, rule]) => rule.meta.docs?.recommended)
+			.map(([name]) => [`webpack/${name}`, "error"]),
+	),
+};
+
+const configs = {
+	recommended: {
+		name: "webpack/recommended",
+		files: [`**/*.{${allExtensions.map((item) => item.slice(1)).join(",")}}`],
+		plugins: {
+			get webpack() {
+				// eslint-disable-next-line no-use-before-define
+				return plugin;
+			},
+		},
+		rules: recommendedRules,
+	},
+};
+
+const plugin = {
+	configs,
+	meta: {
+		version,
+	},
+	rules,
+};
+
+export { configs, rules };
+
+export default plugin;

package/plugins/webpack/rules/require-license-comment.js

@@ -0,0 +1,59 @@
+/**
+ * @type {import("eslint").Rule} rule
+ */
+export const rule = {
+	create(context) {
+		const sourceCode = context.getSourceCode();
+
+		return {
+			"Program:exit"(program) {
+				const comments = sourceCode.getAllComments();
+				const licenseComment = comments.find(
+					(comment) =>
+						comment.type === "Block" &&
+						/\n\s*MIT License http:\/\/www\.opensource\.org\/licenses\/mit-license\.php\n\s*(?:(Authors? .+)\n)?\s*/g.test(
+							comment.value,
+						),
+				);
+
+				if (!licenseComment) {
+					context.report({
+						loc: program.loc,
+						message: "Expected license comment.",
+					});
+
+					return;
+				}
+
+				const afterComment = sourceCode.text[licenseComment.end];
+
+				if (afterComment !== "\n") {
+					context.report({
+						loc: licenseComment.loc,
+						message: "Expected newline after license comment.",
+					});
+
+					return;
+				}
+
+				const afterAfterComment = sourceCode.text[licenseComment.end + 1];
+
+				if (afterAfterComment !== "\n") {
+					context.report({
+						loc: licenseComment.loc,
+						message: "Expected newline after license comment.",
+					});
+				}
+			},
+		};
+	},
+	meta: {
+		docs: {
+			category: "Best Practices",
+			description: "Require license comment",
+			recommended: true,
+		},
+		fixable: "code",
+		type: "layout",
+	},
+};