eslint-config-webpack 4.2.0 → 4.2.2

package/configs/browser.js

@@ -11,6 +11,20 @@ const recommendedBrowserConfig = {
 		import: importPlugin,
 	},
 	rules: {
+		"unicorn/prefer-dom-node-append": "error",
+
+		"unicorn/prefer-dom-node-dataset": "error",
+
+		"unicorn/prefer-dom-node-remove": "error",
+
+		"unicorn/prefer-dom-node-text-content": "error",
+
+		"unicorn/prefer-modern-dom-apis": "error",
+
+		"unicorn/prefer-keyboard-event-key": "error",
+
+		"unicorn/prefer-query-selector": "error",
+
 		"import/extensions": ["error", "always", { ignorePackages: true }],
 	},
 };

package/configs/javascript.js

@@ -885,13 +885,17 @@ const unicornRules = {
 
 	"unicorn/prefer-default-parameters": "error",
 
-	"unicorn/prefer-dom-node-append": "error",
+	// Not here, define only for `browsers`
+	// "unicorn/prefer-dom-node-append": "error",
 
-	"unicorn/prefer-dom-node-dataset": "error",
+	// Not here, define only for `browsers`
+	// "unicorn/prefer-dom-node-dataset": "error",
 
-	"unicorn/prefer-dom-node-remove": "error",
+	// Not here, define only for `browsers`
+	// "unicorn/prefer-dom-node-remove": "error",
 
-	"unicorn/prefer-dom-node-text-content": "error",
+	// Not here, define only for `browsers`
+	// "unicorn/prefer-dom-node-text-content": "error",
 
 	"unicorn/prefer-event-target": "error",
 
@@ -907,7 +911,8 @@ const unicornRules = {
 	// No need
 	// "unicorn/prefer-json-parse-buffer": "off",
 
-	"unicorn/prefer-keyboard-event-key": "error",
+	// Not here, define only for `browsers`
+	// "unicorn/prefer-keyboard-event-key": "error",
 
 	"unicorn/prefer-logical-operator-over-ternary": "error",
 
@@ -918,7 +923,8 @@ const unicornRules = {
 	// `| 0` is faster
 	// "unicorn/prefer-math-trunc": "off",
 
-	"unicorn/prefer-modern-dom-apis": "error",
+	// Not here, define only for `browsers`
+	// "unicorn/prefer-modern-dom-apis": "error",
 
 	"unicorn/prefer-modern-math-apis": "error",
 
@@ -941,7 +947,8 @@ const unicornRules = {
 
 	"unicorn/prefer-prototype-methods": "error",
 
-	"unicorn/prefer-query-selector": "error",
+	// Not here, define only for `browsers`
+	// "unicorn/prefer-query-selector": "error",
 
 	// No need
 	// "unicorn/prefer-reflect-apply": "off",

package/configs/jest.js

@@ -206,6 +206,21 @@ async function getJestRecommendedConfig() {
 			// Allow to output information in tests
 			"no-console": "off",
 
+			// Allow to use `eval` for tests
+			"no-eval": "off",
+
+			// Allow to have any regexps in tests, useful to clean up/etc
+			"no-control-regex": "off",
+
+			// Allow to use any builtins, syntax and node API in tests
+			"n/no-unsupported-features/es-builtins": "off",
+			"n/no-unsupported-features/es-syntax": "off",
+			"n/no-unsupported-features/node-builtins": "off",
+
+			// Allow to `require` and `import` any things in tests
+			"n/no-unpublished-require": "off",
+			"n/no-unpublished-import": "off",
+
 			// Doesn't require jsdoc for tests, they are either redundant or we have a separate task for checking types of tests
 			"jsdoc/require-jsdoc": "off",
 		},

package/configs/markdown.js

@@ -60,6 +60,12 @@ async function getMarkdownRecommendedConfig() {
 
 				"n/no-unpublished-import": "off",
 
+				"n/no-missing-import": "off",
+
+				"n/no-missing-require": "off",
+
+				"n/no-process-exit": "off",
+
 				"import/no-unresolved": "off",
 
 				"import/no-extraneous-dependencies": "off",

package/configs/node.js

@@ -38,11 +38,11 @@ const commonRules = {
 	// Deprecated
 	// "n/no-hide-core-modules": "error",
 
-	// From recommended
-	// "n/no-missing-import": "error",
+	// We have `import/no-unresolved` rule
+	"n/no-missing-import": "off",
 
-	// From recommended
-	// "n/no-missing-require": "error",
+	// We have `import/no-unresolved` rule
+	"n/no-missing-require": "off",
 
 	// No need
 	// "n/no-mixed-requires": "error",
@@ -144,6 +144,7 @@ async function getCommonJSConfig() {
 			import: importPlugin,
 		},
 		rules: {
+			...nodeConfig.rules,
 			...commonRules,
 			"n/exports-style": "error",
 			"n/no-path-concat": "error",
@@ -200,6 +201,7 @@ async function getModuleConfig() {
 			import: importPlugin,
 		},
 		rules: {
+			...nodeConfig.rules,
 			...commonRules,
 			"import/extensions": [
 				"error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-webpack",
-  "version": "4.2.0",
+  "version": "4.2.2",
   "description": "Provides Webpack's eslint rules as an extensible shared config",
   "keywords": [
     "eslint",