eslint-config-typed 7.3.0 → 7.3.1

package/dist/plugins/total-functions/rules/no-partial-division.d.mts

@@ -1,5 +1,8 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-/** An ESLint rule to ban partial division. */
+/**
+ * An ESLint rule to ban partial division: `x / y` and `x /= y` whose
+ * denominator is not provably non-zero.
+ */
 export declare const noPartialDivision: ESLintUtils.RuleModule<string, readonly unknown[], unknown, ESLintUtils.RuleListener> & {
     name: string;
 };

package/dist/plugins/total-functions/rules/no-partial-division.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"no-partial-division.d.mts","sourceRoot":"","sources":["../../../../src/plugins/total-functions/rules/no-partial-division.mts"],"names":[],"mappings":"AAAA,OAAO,EAAkB,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAMvE,8CAA8C;AAE9C,eAAO,MAAM,iBAAiB;;CA+EnB,CAAC"}
+{"version":3,"file":"no-partial-division.d.mts","sourceRoot":"","sources":["../../../../src/plugins/total-functions/rules/no-partial-division.mts"],"names":[],"mappings":"AAAA,OAAO,EAEL,WAAW,EAEZ,MAAM,0BAA0B,CAAC;AAMlC;;;GAGG;AAEH,eAAO,MAAM,iBAAiB;;CAiFnB,CAAC"}

package/dist/plugins/total-functions/rules/no-partial-division.mjs

@@ -1,8 +1,11 @@
-import { AST_NODE_TYPES, ESLintUtils } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, ESLintUtils, } from '@typescript-eslint/utils';
 import { Arr, isNonNullObject } from 'ts-data-forge';
 import { intersectionTypeParts, unionTypeParts } from 'tsutils';
 import { createRule } from './common.mjs';
 
+
+
+
 export const noPartialDivision = createRule({
     name: 'no-partial-division',
     meta: {
@@ -31,26 +34,27 @@ export const noPartialDivision = createRule({
             return ((type.isNumberLiteral() && type.value !== 0) ||
                 (isBigIntLiteral(type) && type.value.base10Value !== '0'));
         };
+        const isProvablySafeDenominator = (denominator) => {
+            if (denominator.type === AST_NODE_TYPES.Literal &&
+                denominator.value !== 0 &&
+                denominator.value !== 0n) {
+
+                return true;
+            }
+            if (denominator.type === AST_NODE_TYPES.Identifier) {
+                const denominatorNode = parserServices.esTreeNodeToTSNodeMap.get(denominator);
+                return isSafeDenominator(checker.getTypeAtLocation(denominatorNode));
+            }
+
+            return false;
+        };
         return {
-            BinaryExpression: (node) => {
-                if (node.operator !== '/') {
 
-                    return;
-                }
-                if (node.right.type === AST_NODE_TYPES.Literal &&
-                    node.right.value !== 0 &&
-                    node.right.value !== 0n) {
 
+            'BinaryExpression[operator="/"], AssignmentExpression[operator="/="]': (node) => {
+                if (isProvablySafeDenominator(node.right)) {
                     return;
                 }
-                if (node.right.type === AST_NODE_TYPES.Identifier) {
-                    const denominatorNode = parserServices.esTreeNodeToTSNodeMap.get(node.right);
-                    const denominatorNodeType = checker.getTypeAtLocation(denominatorNode);
-                    if (isSafeDenominator(denominatorNodeType)) {
-                        return;
-                    }
-                }
-
                 context.report({
                     node,
                     messageId: 'errorStringGeneric',

package/dist/plugins/total-functions/rules/no-partial-division.mjs.map

@@ -1 +1 @@
-{"version":3,"file":"no-partial-division.mjs","sourceRoot":"","sources":["../../../../src/plugins/total-functions/rules/no-partial-division.mts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AACvE,OAAO,EAAE,GAAG,EAAE,eAAe,EAAE,MAAM,eAAe,CAAC;AACrD,OAAO,EAAE,qBAAqB,EAAE,cAAc,EAAE,MAAM,SAAS,CAAC;AAEhE,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAC;AAE1C,8CAA8C;AAE9C,MAAM,CAAC,MAAM,iBAAiB,GAAG,UAAU,CAAC;IAC1C,IAAI,EAAE,qBAAqB;IAC3B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,wBAAwB;SACtC;QACD,QAAQ,EAAE;YACR,kBAAkB,EAChB,2GAA2G;SAC9G;QACD,MAAM,EAAE,EAAE;QACV,cAAc,EAAE,EAAE;KACnB;IACD,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,cAAc,GAAG,WAAW,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;QAE9D,MAAM,OAAO,GAAG,cAAc,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC;QAExD,MAAM,iBAAiB,GAAG,CAAC,IAAU,EAAW,EAAE;YAChD,IAAI,IAAI,CAAC,cAAc,EAAE,EAAE,CAAC;gBAC1B,MAAM,kBAAkB,GAAG,qBAAqB,CAAC,IAAI,CAAC,CAAC,MAAM,CAC3D,CAAC,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,eAAe,EAAE,CACjD,CAAC;gBAEF,OAAO,CACL,GAAG,CAAC,UAAU,CAAC,kBAAkB,CAAC;oBAClC,kBAAkB,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAC5C,CAAC;YACJ,CAAC;YAED,IAAI,IAAI,CAAC,OAAO,EAAE,EAAE,CAAC;gBACnB,OAAO,cAAc,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC;YACvD,CAAC;YAED,OAAO,CACL,CAAC,IAAI,CAAC,eAAe,EAAE,IAAI,IAAI,CAAC,KAAK,KAAK,CAAC,CAAC;gBAC5C,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,KAAK,CAAC,WAAW,KAAK,GAAG,CAAC,CAC1D,CAAC;QACJ,CAAC,CAAC;QAEF,OAAO;YACL,gBAAgB,EAAE,CAAC,IAAI,EAAE,EAAE;gBACzB,IAAI,IAAI,CAAC,QAAQ,KAAK,GAAG,EAAE,CAAC;oBAC1B,mDAAmD;oBACnD,OAAO;gBACT,CAAC;gBAED,IACE,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;oBAC1C,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,CAAC;oBACtB,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,EAAE,EACvB,CAAC;oBACD,iDAAiD;oBACjD,OAAO;gBACT,CAAC;gBAED,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAAE,CAAC;oBAClD,MAAM,eAAe,GAAG,cAAc,CAAC,qBAAqB,CAAC,GAAG,CAC9D,IAAI,CAAC,KAAK,CACX,CAAC;oBAEF,MAAM,mBAAmB,GACvB,OAAO,CAAC,iBAAiB,CAAC,eAAe,CAAC,CAAC;oBAE7C,IAAI,iBAAiB,CAAC,mBAAmB,CAAC,EAAE,CAAC;wBAC3C,OAAO;oBACT,CAAC;gBACH,CAAC;gBAED,2CAA2C;gBAE3C,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAE,oBAAoB;iBACvB,CAAC,CAAC;YACd,CAAC;SACF,CAAC;IACJ,CAAC;CACO,CAAC,CAAC;AAEZ,+EAA+E;AAC/E,6DAA6D;AAC7D,+CAA+C;AAC/C,MAAM,cAAc,GAAG,CAAC,GAAY,EAAuB,EAAE;IAC3D,MAAM,iBAAiB,GAAG,eAAe,CAAC,GAAG,CAAC;QAC5C,CAAC,CAAE,GAA6B;QAChC,CAAC,CAAC,SAAS,CAAC;IAEd,OAAO,CACL,iBAAiB,KAAK,SAAS;QAC/B,OAAO,iBAAiB,CAAC,WAAW,KAAK,QAAQ;QACjD,OAAO,iBAAiB,CAAC,QAAQ,KAAK,SAAS,CAChD,CAAC;AACJ,CAAC,CAAC;AAEF,MAAM,eAAe,GAAG,CAAC,IAAU,EAA6B,EAAE;AAChE,uEAAuE;AACvE,cAAc,CAAE,IAAmC,EAAE,KAAK,CAAC,CAAC"}
+{"version":3,"file":"no-partial-division.mjs","sourceRoot":"","sources":["../../../../src/plugins/total-functions/rules/no-partial-division.mts"],"names":[],"mappings":"AAAA,OAAO,EACL,cAAc,EACd,WAAW,GAEZ,MAAM,0BAA0B,CAAC;AAClC,OAAO,EAAE,GAAG,EAAE,eAAe,EAAE,MAAM,eAAe,CAAC;AACrD,OAAO,EAAE,qBAAqB,EAAE,cAAc,EAAE,MAAM,SAAS,CAAC;AAEhE,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAC;AAE1C;;;GAGG;AAEH,MAAM,CAAC,MAAM,iBAAiB,GAAG,UAAU,CAAC;IAC1C,IAAI,EAAE,qBAAqB;IAC3B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,wBAAwB;SACtC;QACD,QAAQ,EAAE;YACR,kBAAkB,EAChB,2GAA2G;SAC9G;QACD,MAAM,EAAE,EAAE;QACV,cAAc,EAAE,EAAE;KACnB;IACD,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,cAAc,GAAG,WAAW,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;QAE9D,MAAM,OAAO,GAAG,cAAc,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC;QAExD,MAAM,iBAAiB,GAAG,CAAC,IAAU,EAAW,EAAE;YAChD,IAAI,IAAI,CAAC,cAAc,EAAE,EAAE,CAAC;gBAC1B,MAAM,kBAAkB,GAAG,qBAAqB,CAAC,IAAI,CAAC,CAAC,MAAM,CAC3D,CAAC,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,eAAe,EAAE,CACjD,CAAC;gBAEF,OAAO,CACL,GAAG,CAAC,UAAU,CAAC,kBAAkB,CAAC;oBAClC,kBAAkB,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAC5C,CAAC;YACJ,CAAC;YAED,IAAI,IAAI,CAAC,OAAO,EAAE,EAAE,CAAC;gBACnB,OAAO,cAAc,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,iBAAiB,CAAC,CAAC;YACvD,CAAC;YAED,OAAO,CACL,CAAC,IAAI,CAAC,eAAe,EAAE,IAAI,IAAI,CAAC,KAAK,KAAK,CAAC,CAAC;gBAC5C,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,KAAK,CAAC,WAAW,KAAK,GAAG,CAAC,CAC1D,CAAC;QACJ,CAAC,CAAC;QAEF,MAAM,yBAAyB,GAAG,CAChC,WAAgC,EACvB,EAAE;YACX,IACE,WAAW,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;gBAC3C,WAAW,CAAC,KAAK,KAAK,CAAC;gBACvB,WAAW,CAAC,KAAK,KAAK,EAAE,EACxB,CAAC;gBACD,iDAAiD;gBACjD,OAAO,IAAI,CAAC;YACd,CAAC;YAED,IAAI,WAAW,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAAE,CAAC;gBACnD,MAAM,eAAe,GACnB,cAAc,CAAC,qBAAqB,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;gBAExD,OAAO,iBAAiB,CAAC,OAAO,CAAC,iBAAiB,CAAC,eAAe,CAAC,CAAC,CAAC;YACvE,CAAC;YAED,2CAA2C;YAC3C,OAAO,KAAK,CAAC;QACf,CAAC,CAAC;QAEF,OAAO;YACL,0EAA0E;YAC1E,mEAAmE;YACnE,qEAAqE,EAAE,CACrE,IAA+D,EAC/D,EAAE;gBACF,IAAI,yBAAyB,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC;oBAC1C,OAAO;gBACT,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAE,oBAAoB;iBACvB,CAAC,CAAC;YACd,CAAC;SACF,CAAC;IACJ,CAAC;CACO,CAAC,CAAC;AAEZ,+EAA+E;AAC/E,6DAA6D;AAC7D,+CAA+C;AAC/C,MAAM,cAAc,GAAG,CAAC,GAAY,EAAuB,EAAE;IAC3D,MAAM,iBAAiB,GAAG,eAAe,CAAC,GAAG,CAAC;QAC5C,CAAC,CAAE,GAA6B;QAChC,CAAC,CAAC,SAAS,CAAC;IAEd,OAAO,CACL,iBAAiB,KAAK,SAAS;QAC/B,OAAO,iBAAiB,CAAC,WAAW,KAAK,QAAQ;QACjD,OAAO,iBAAiB,CAAC,QAAQ,KAAK,SAAS,CAChD,CAAC;AACJ,CAAC,CAAC;AAEF,MAAM,eAAe,GAAG,CAAC,IAAU,EAA6B,EAAE;AAChE,uEAAuE;AACvE,cAAc,CAAE,IAAmC,EAAE,KAAK,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-typed",
-  "version": "7.3.0",
+  "version": "7.3.1",
   "private": false,
   "keywords": [
     "typescript"
@@ -75,7 +75,7 @@
     "is-glob": "^4.0.3",
     "is-immutable-type": "^5.0.4",
     "micromatch": "^4.0.8",
-    "ts-data-forge": "^14.10.1",
+    "ts-data-forge": "^14.10.2",
     "ts-type-forge": "^9.2.2",
     "tsutils": "^3.21.0"
   },
@@ -90,8 +90,8 @@
     "@vitest/ui": "5.0.5",
     "cspell": "10.4.0",
     "dedent": "1.7.2",
-    "eslint-config-typed": "7.3.0",
-    "eslint-plugin-ts-data-forge": "0.10.7",
+    "eslint-config-typed": "7.3.1",
+    "eslint-plugin-ts-data-forge": "0.10.8",
     "eslint-plugin-ts-fortress": "1.3.12",
     "eslint-plugin-ts-type-forge": "0.8.17",
     "immer": "11.2.7",
@@ -105,7 +105,7 @@
     "prettier-plugin-organize-imports": "4.3.0",
     "prettier-plugin-packagejson": "3.0.2",
     "react": "19.3.1",
-    "ts-codemod-lib": "4.0.0",
+    "ts-codemod-lib": "4.0.1",
     "ts-repo-utils": "10.7.1",
     "tsx": "4.23.15",
     "typescript": "6.0.3",

package/src/plugins/total-functions/rules/no-partial-division.mts

@@ -1,10 +1,17 @@
-import { AST_NODE_TYPES, ESLintUtils } from '@typescript-eslint/utils';
+import {
+  AST_NODE_TYPES,
+  ESLintUtils,
+  type TSESTree,
+} from '@typescript-eslint/utils';
 import { Arr, isNonNullObject } from 'ts-data-forge';
 import { intersectionTypeParts, unionTypeParts } from 'tsutils';
 import type { BigIntLiteralType, PseudoBigInt, Type } from 'typescript';
 import { createRule } from './common.mjs';
 
-/** An ESLint rule to ban partial division. */
+/**
+ * An ESLint rule to ban partial division: `x / y` and `x /= y` whose
+ * denominator is not provably non-zero.
+ */
 
 export const noPartialDivision = createRule({
   name: 'no-partial-division',
@@ -47,37 +54,39 @@ export const noPartialDivision = createRule({
       );
     };
 
-    return {
-      BinaryExpression: (node) => {
-        if (node.operator !== '/') {
-          // Binary expressions other than division are safe.
-          return;
-        }
+    const isProvablySafeDenominator = (
+      denominator: TSESTree.Expression,
+    ): boolean => {
+      if (
+        denominator.type === AST_NODE_TYPES.Literal &&
+        denominator.value !== 0 &&
+        denominator.value !== 0n
+      ) {
+        // Division by a literal that isn't zero is safe.
+        return true;
+      }
 
-        if (
-          node.right.type === AST_NODE_TYPES.Literal &&
-          node.right.value !== 0 &&
-          node.right.value !== 0n
-        ) {
-          // Division by a literal that isn't zero is safe.
-          return;
-        }
+      if (denominator.type === AST_NODE_TYPES.Identifier) {
+        const denominatorNode =
+          parserServices.esTreeNodeToTSNodeMap.get(denominator);
 
-        if (node.right.type === AST_NODE_TYPES.Identifier) {
-          const denominatorNode = parserServices.esTreeNodeToTSNodeMap.get(
-            node.right,
-          );
+        return isSafeDenominator(checker.getTypeAtLocation(denominatorNode));
+      }
 
-          const denominatorNodeType =
-            checker.getTypeAtLocation(denominatorNode);
+      // All other division is not provably safe.
+      return false;
+    };
 
-          if (isSafeDenominator(denominatorNodeType)) {
-            return;
-          }
+    return {
+      // `x /= y` divides as `x = x / y` does, and `unicorn/operator-assignment`
+      // autofixes the latter into the former, so both are checked alike.
+      'BinaryExpression[operator="/"], AssignmentExpression[operator="/="]': (
+        node: TSESTree.AssignmentExpression | TSESTree.BinaryExpression,
+      ) => {
+        if (isProvablySafeDenominator(node.right)) {
+          return;
         }
 
-        // All other division is not provably safe.
-
         context.report({
           node,
           messageId: 'errorStringGeneric',

package/src/plugins/total-functions/rules/no-partial-division.test.mts

@@ -86,6 +86,35 @@ ruleTester.run('no-partial-division', noPartialDivision, {
         const bar = 1n / foo;
       `,
     },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        let mut_x = 6;
+        mut_x /= 2;
+      `,
+    },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        let mut_x = 6n;
+        mut_x /= 2n;
+      `,
+    },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        declare const foo: 42 | 43;
+        let mut_x = 6;
+        mut_x /= foo;
+      `,
+    },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        let mut_x = 6;
+        mut_x *= 0;
+      `,
+    },
   ],
   invalid: [
     {
@@ -218,5 +247,68 @@ ruleTester.run('no-partial-division', noPartialDivision, {
         },
       ],
     },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        let mut_x = 6;
+        mut_x /= 0;
+      `,
+      errors: [
+        {
+          messageId: 'errorStringGeneric',
+        },
+      ],
+    },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        let mut_x = 6n;
+        mut_x /= 0n;
+      `,
+      errors: [
+        {
+          messageId: 'errorStringGeneric',
+        },
+      ],
+    },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        declare const y: number;
+        let mut_x = 6;
+        mut_x /= y;
+      `,
+      errors: [
+        {
+          messageId: 'errorStringGeneric',
+        },
+      ],
+    },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        declare const foo: 42 | 0;
+        let mut_x = 6;
+        mut_x /= foo;
+      `,
+      errors: [
+        {
+          messageId: 'errorStringGeneric',
+        },
+      ],
+    },
+    {
+      filename: 'file.ts',
+      code: dedent`
+        declare const obj: { readonly n: number };
+        let mut_x = 6;
+        mut_x /= obj.n;
+      `,
+      errors: [
+        {
+          messageId: 'errorStringGeneric',
+        },
+      ],
+    },
   ],
 } as const);