eslint-config-typed 4.9.1 → 4.9.2

package/dist/plugins/ts-restrictions/rules/check-destructuring-completeness.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"check-destructuring-completeness.d.mts","sourceRoot":"","sources":["../../../../src/plugins/ts-restrictions/rules/check-destructuring-completeness.mts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,QAAQ,EAEd,MAAM,0BAA0B,CAAC;AAGlC,KAAK,OAAO,GAAG,SAAS;IACtB,QAAQ,CAAC;QACP,8BAA8B,CAAC,EAAE,OAAO,CAAC;QACzC,gBAAgB,CAAC,EAAE,MAAM,CAAC;KAC3B,CAAC,CAAC;CACJ,CAAC;AAEF,KAAK,UAAU,GAAG,yBAAyB,CAAC;AAI5C,eAAO,MAAM,8BAA8B,EAAE,QAAQ,CAAC,UAAU,CAC9D,UAAU,EACV,OAAO,CAmPC,CAAC"}
+{"version":3,"file":"check-destructuring-completeness.d.mts","sourceRoot":"","sources":["../../../../src/plugins/ts-restrictions/rules/check-destructuring-completeness.mts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,QAAQ,EAEd,MAAM,0BAA0B,CAAC;AAGlC,KAAK,OAAO,GAAG,SAAS;IACtB,QAAQ,CAAC;QACP,8BAA8B,CAAC,EAAE,OAAO,CAAC;QACzC,gBAAgB,CAAC,EAAE,MAAM,CAAC;KAC3B,CAAC,CAAC;CACJ,CAAC;AAEF,KAAK,UAAU,GAAG,yBAAyB,CAAC;AAI5C,eAAO,MAAM,8BAA8B,EAAE,QAAQ,CAAC,UAAU,CAC9D,UAAU,EACV,OAAO,CAwMC,CAAC"}

package/dist/plugins/ts-restrictions/rules/check-destructuring-completeness.mjs

@@ -90,38 +90,27 @@ const checkDestructuringCompleteness = {
             }
             return false;
         };
-        const checkNode = (node) => {
-            if (node.id.type !== AST_NODE_TYPES.ObjectPattern)
-                return;
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-            if (node.init === undefined || node.init === null)
-                return;
-            const shouldCheck = hasDirectiveComment(node) || isReactComponentPropsDestructuring(node);
-            if (!shouldCheck)
-                return;
-            // If rest element is used, skip completeness check
-            const hasRestElement = node.id.properties.some((prop) => prop.type === AST_NODE_TYPES.RestElement);
+        const checkObjectPatternCompleteness = (objectPattern, tsSourceNode) => {
+            const hasRestElement = objectPattern.properties.some((prop) => prop.type === AST_NODE_TYPES.RestElement);
             if (hasRestElement)
                 return;
             // eslint-disable-next-line total-functions/no-unsafe-type-assertion
-            const tsNode = esTreeNodeToTSNodeMap.get(node.init);
+            const tsNode = esTreeNodeToTSNodeMap.get(tsSourceNode);
             // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
             if (tsNode === undefined)
                 return;
             const type = typeChecker.getTypeAtLocation(tsNode);
             const objectProps = getObjectTypeProperties(type);
-            const mut_destructuredProps = new Set();
-            for (const prop of node.id.properties) {
-                if (prop.type === AST_NODE_TYPES.Property &&
-                    prop.key.type === AST_NODE_TYPES.Identifier) {
-                    mut_destructuredProps.add(prop.key.name);
-                }
-            }
-            const missingProps = objectProps.filter((prop) => !mut_destructuredProps.has(prop));
+            const collected = collectDestructuredPropNames(objectPattern.properties);
+            // Dynamic computed properties cannot be resolved statically,
+            // so skip completeness check when they are present.
+            if (collected.hasDynamicComputedKey)
+                return;
+            const missingProps = objectProps.filter((prop) => !collected.names.has(prop));
             if (missingProps.length > 0) {
                 context.report({
                     // eslint-disable-next-line total-functions/no-unsafe-type-assertion
-                    node: node.id,
+                    node: objectPattern,
                     messageId: 'incompleteDestructuring',
                     data: {
                         missingProps: missingProps.join(', '),
@@ -130,7 +119,17 @@ const checkDestructuringCompleteness = {
             }
         };
         return {
-            VariableDeclarator: checkNode,
+            VariableDeclarator: (node) => {
+                if (node.id.type !== AST_NODE_TYPES.ObjectPattern)
+                    return;
+                // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+                if (node.init === undefined || node.init === null)
+                    return;
+                const shouldCheck = hasDirectiveComment(node) || isReactComponentPropsDestructuring(node);
+                if (!shouldCheck)
+                    return;
+                checkObjectPatternCompleteness(node.id, node.init);
+            },
             ArrowFunctionExpression: (node) => {
                 if (!alwaysCheckReactComponentProps)
                     return;
@@ -138,34 +137,7 @@ const checkDestructuringCompleteness = {
                     return;
                 for (const param of node.params) {
                     if (param.type === AST_NODE_TYPES.ObjectPattern) {
-                        // If rest element is used, skip completeness check
-                        const hasRestElement = param.properties.some((prop) => prop.type === AST_NODE_TYPES.RestElement);
-                        if (hasRestElement)
-                            continue;
-                        // eslint-disable-next-line total-functions/no-unsafe-type-assertion
-                        const tsNode = esTreeNodeToTSNodeMap.get(param);
-                        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-                        if (tsNode === undefined)
-                            continue;
-                        const type = typeChecker.getTypeAtLocation(tsNode);
-                        const objectProps = getObjectTypeProperties(type);
-                        const mut_destructuredProps = new Set();
-                        for (const prop of param.properties) {
-                            if (prop.type === AST_NODE_TYPES.Property &&
-                                prop.key.type === AST_NODE_TYPES.Identifier) {
-                                mut_destructuredProps.add(prop.key.name);
-                            }
-                        }
-                        const missingProps = objectProps.filter((prop) => !mut_destructuredProps.has(prop));
-                        if (missingProps.length > 0) {
-                            context.report({
-                                node: param,
-                                messageId: 'incompleteDestructuring',
-                                data: {
-                                    missingProps: missingProps.join(', '),
-                                },
-                            });
-                        }
+                        checkObjectPatternCompleteness(param, param);
                     }
                 }
             },
@@ -195,6 +167,43 @@ const getObjectTypeProperties = (type) => {
         return [];
     }
 };
+const collectDestructuredPropNames = (properties) => {
+    const mut_names = new Set();
+    let mut_hasDynamicComputedKey = false;
+    for (const prop of properties) {
+        if (prop.type !== AST_NODE_TYPES.Property)
+            continue;
+        if (!prop.computed) {
+            switch (prop.key.type) {
+                case AST_NODE_TYPES.Identifier: {
+                    mut_names.add(prop.key.name);
+                    break;
+                }
+                case AST_NODE_TYPES.Literal: {
+                    if (typeof prop.key.value === 'string') {
+                        mut_names.add(prop.key.value);
+                    }
+                    else if (typeof prop.key.value === 'number') {
+                        mut_names.add(String(prop.key.value));
+                    }
+                    break;
+                }
+            }
+        }
+        else if (prop.key.type === AST_NODE_TYPES.Literal &&
+            (typeof prop.key.value === 'string' || typeof prop.key.value === 'number')) {
+            // Computed key with a static literal value, e.g. { ['data-id']: val }
+            mut_names.add(typeof prop.key.value === 'string'
+                ? prop.key.value
+                : String(prop.key.value));
+        }
+        else {
+            // Dynamic computed key — cannot resolve statically
+            mut_hasDynamicComputedKey = true;
+        }
+    }
+    return { names: mut_names, hasDynamicComputedKey: mut_hasDynamicComputedKey };
+};
 const isReactComponentFunction = (node) => {
     if (node === undefined || node === null)
         return false;

package/dist/plugins/ts-restrictions/rules/check-destructuring-completeness.mjs.map

@@ -1 +1 @@
-{"version":3,"file":"check-destructuring-completeness.mjs","sources":["../../../../src/plugins/ts-restrictions/rules/check-destructuring-completeness.mts"],"sourcesContent":[null],"names":[],"mappings":";;AAgBA,MAAM,yBAAyB,GAAG,mCAAmC;AAE9D,MAAM,8BAA8B,GAGvC;AACF,IAAA,IAAI,EAAE;AACJ,QAAA,IAAI,EAAE,YAAY;AAClB,QAAA,IAAI,EAAE;AACJ,YAAA,WAAW,EACT,iFAAiF;AACpF,SAAA;AACD,QAAA,MAAM,EAAE;AACN,YAAA;AACE,gBAAA,IAAI,EAAE,QAAQ;AACd,gBAAA,UAAU,EAAE;AACV,oBAAA,8BAA8B,EAAE;AAC9B,wBAAA,IAAI,EAAE,SAAS;AACf,wBAAA,WAAW,EACT,4EAA4E;AAC/E,qBAAA;AACD,oBAAA,gBAAgB,EAAE;AAChB,wBAAA,IAAI,EAAE,QAAQ;AACd,wBAAA,WAAW,EACT,4FAA4F;AAC/F,qBAAA;AACF,iBAAA;AACD,gBAAA,oBAAoB,EAAE,KAAK;AAC5B,aAAA;AACF,SAAA;AACD,QAAA,QAAQ,EAAE;AACR,YAAA,uBAAuB,EACrB,gEAAgE;AACnE,SAAA;AACF,KAAA;AAED,IAAA,MAAM,EAAE,CAAC,OAAO,KAAI;AAClB,QAAA,MAAM,cAAc,GAAG,OAAO,CAAC,UAAU,CAAC,cAAc;AAExD,QAAA,IACE,cAAc,EAAE,OAAO,KAAK,SAAS;YACrC,cAAc,CAAC,OAAO,KAAK,IAAI;AAC/B,YAAA,cAAc,CAAC,qBAAqB,KAAK,SAAS,EAClD;AACA,YAAA,OAAO,EAAE;QACX;QAEA,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,EAAE;AAExC,QAAA,MAAM,8BAA8B,GAClC,OAAO,CAAC,8BAA8B,IAAI,IAAI;AAEhD,QAAA,MAAM,gBAAgB,GACpB,OAAO,CAAC,gBAAgB,IAAI,yBAAyB;QAEvD,MAAM,WAAW,GAAG,cAAc,CAAC,OAAO,CAAC,cAAc,EAAE;AAE3D,QAAA,MAAM,qBAAqB,GAAG,cAAc,CAAC,qBAAqB;AAElE,QAAA,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU;AAErC,QAAA,MAAM,mBAAmB,GAAG,CAC1B,IAA+C,KACpC;;AAEX,YAAA,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM;;YAG1B,IAAI,MAAM,EAAE,IAAI,KAAK,cAAc,CAAC,mBAAmB,EAAE;AACvD,gBAAA,OAAO,KAAK;YACd;;YAGA,MAAM,QAAQ,GAAG,UAAU,CAAC,iBAAiB,CAAC,MAAe,CAAC;AAE9D,YAAA,OAAO,QAAQ,CAAC,IAAI,CAAC,CAAC,OAAO,KAC3B,OAAO,CAAC,KAAK,CAAC,QAAQ,CAAC,gBAAgB,CAAC,CACzC;AACH,QAAA,CAAC;AAED,QAAA,MAAM,kCAAkC,GAAG,CACzC,IAA+C,KACpC;AACX,YAAA,IAAI,CAAC,8BAA8B;AAAE,gBAAA,OAAO,KAAK;AAEjD,YAAA,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM;;YAG1B,IAAI,MAAM,KAAK,SAAS;AAAE,gBAAA,OAAO,KAAK;;;YAItC,IAAI,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,mBAAmB,EAAE;AACtD,gBAAA,MAAM,WAAW,GAAG,MAAM,CAAC,MAAM;;gBAGjC,IAAI,WAAW,KAAK,SAAS;AAAE,oBAAA,OAAO,KAAK;;gBAG3C,IAAI,WAAW,CAAC,IAAI,KAAK,cAAc,CAAC,cAAc,EAAE;AACtD,oBAAA,MAAM,gBAAgB,GAAG,WAAW,CAAC,MAAM;AAE3C,oBAAA;;AAEE,oBAAA,gBAAgB,EAAE,IAAI,KAAK,cAAc,CAAC,uBAAuB;wBACjE,IAAI,CAAC,IAAI,EAAE,IAAI,KAAK,cAAc,CAAC,UAAU,EAC7C;AACA,wBAAA,MAAM,QAAQ;;AAEZ,wBAAA,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC;AAChC,8BAAE,IAAI,CAAC,IAAI,CAAC;8BACV,SAAS;wBAEf,IACE,QAAQ,KAAK,SAAS;AACtB,4BAAA,gBAAgB,CAAC,MAAM,CAAC,IAAI,CAC1B,CAAC,KAAK,KACJ,KAAK,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU;AACxC,gCAAA,KAAK,CAAC,IAAI,KAAK,QAAQ,CAC1B,EACD;AACA,4BAAA,OAAO,wBAAwB,CAAC,gBAAgB,CAAC;wBACnD;oBACF;gBACF;gBAEA,IAAI,WAAW,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB,EAAE;AAC/D,oBAAA,OAAO,wBAAwB,CAAC,WAAW,CAAC;gBAC9C;YACF;AAEA,YAAA,OAAO,KAAK;AACd,QAAA,CAAC;AAED,QAAA,MAAM,SAAS,GAAG,CAChB,IAA+C,KACvC;YACR,IAAI,IAAI,CAAC,EAAE,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;gBAAE;;YAGnD,IAAI,IAAI,CAAC,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,IAAI,KAAK,IAAI;gBAAE;YAEnD,MAAM,WAAW,GACf,mBAAmB,CAAC,IAAI,CAAC,IAAI,kCAAkC,CAAC,IAAI,CAAC;AAEvE,YAAA,IAAI,CAAC,WAAW;gBAAE;;YAGlB,MAAM,cAAc,GAAG,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,IAAI,CAC5C,CAAC,IAAI,KAAK,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,WAAW,CACnD;AAED,YAAA,IAAI,cAAc;gBAAE;;YAGpB,MAAM,MAAM,GAAG,qBAAqB,CAAC,GAAG,CAAC,IAAI,CAAC,IAAa,CAAC;;YAG5D,IAAI,MAAM,KAAK,SAAS;gBAAE;YAE1B,MAAM,IAAI,GAAG,WAAW,CAAC,iBAAiB,CAAC,MAAM,CAAC;AAElD,YAAA,MAAM,WAAW,GAAG,uBAAuB,CAAC,IAAI,CAAC;AAEjD,YAAA,MAAM,qBAAqB,GAAG,IAAI,GAAG,EAAU;YAE/C,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,EAAE,CAAC,UAAU,EAAE;AACrC,gBAAA,IACE,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,QAAQ;oBACrC,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAC3C;oBACA,qBAAqB,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;gBAC1C;YACF;AAEA,YAAA,MAAM,YAAY,GAAG,WAAW,CAAC,MAAM,CACrC,CAAC,IAAI,KAAK,CAAC,qBAAqB,CAAC,GAAG,CAAC,IAAI,CAAC,CAC3C;AAED,YAAA,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE;gBAC3B,OAAO,CAAC,MAAM,CAAC;;oBAEb,IAAI,EAAE,IAAI,CAAC,EAAW;AACtB,oBAAA,SAAS,EAAE,yBAAyB;AACpC,oBAAA,IAAI,EAAE;AACJ,wBAAA,YAAY,EAAE,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;AACtC,qBAAA;AACF,iBAAA,CAAC;YACJ;AACF,QAAA,CAAC;QAED,OAAO;AACL,YAAA,kBAAkB,EAAE,SAAS;AAC7B,YAAA,uBAAuB,EAAE,CAAC,IAAI,KAAI;AAChC,gBAAA,IAAI,CAAC,8BAA8B;oBAAE;AAErC,gBAAA,IAAI,CAAC,wBAAwB,CAAC,IAAI,CAAC;oBAAE;AAErC,gBAAA,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,MAAM,EAAE;oBAC/B,IAAI,KAAK,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa,EAAE;;wBAE/C,MAAM,cAAc,GAAG,KAAK,CAAC,UAAU,CAAC,IAAI,CAC1C,CAAC,IAAI,KAAK,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,WAAW,CACnD;AAED,wBAAA,IAAI,cAAc;4BAAE;;wBAGpB,MAAM,MAAM,GAAG,qBAAqB,CAAC,GAAG,CAAC,KAAc,CAAC;;wBAGxD,IAAI,MAAM,KAAK,SAAS;4BAAE;wBAE1B,MAAM,IAAI,GAAG,WAAW,CAAC,iBAAiB,CAAC,MAAM,CAAC;AAElD,wBAAA,MAAM,WAAW,GAAG,uBAAuB,CAAC,IAAI,CAAC;AAEjD,wBAAA,MAAM,qBAAqB,GAAG,IAAI,GAAG,EAAU;AAE/C,wBAAA,KAAK,MAAM,IAAI,IAAI,KAAK,CAAC,UAAU,EAAE;AACnC,4BAAA,IACE,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,QAAQ;gCACrC,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAC3C;gCACA,qBAAqB,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;4BAC1C;wBACF;AAEA,wBAAA,MAAM,YAAY,GAAG,WAAW,CAAC,MAAM,CACrC,CAAC,IAAI,KAAK,CAAC,qBAAqB,CAAC,GAAG,CAAC,IAAI,CAAC,CAC3C;AAED,wBAAA,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE;4BAC3B,OAAO,CAAC,MAAM,CAAC;AACb,gCAAA,IAAI,EAAE,KAAK;AACX,gCAAA,SAAS,EAAE,yBAAyB;AACpC,gCAAA,IAAI,EAAE;AACJ,oCAAA,YAAY,EAAE,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;AACtC,iCAAA;AACF,6BAAA,CAAC;wBACJ;oBACF;gBACF;YACF,CAAC;SACF;IACH,CAAC;AACD,IAAA,cAAc,EAAE,CAAC,EAAE,8BAA8B,EAAE,IAAI,EAAE,CAAC;;AAG5D;AACA,MAAM,uBAAuB,GAAG,CAAC,IAAa,KAAuB;AACnE,IAAA,IAAI;AACF,QAAA,MAAM,UAAU,GAAG,IAAI,CAAC,aAAa,EAAE;;AAGvC,QAAA,IAAI,UAAU,CAAC,MAAM,GAAG,IAAI,EAAE;AAC5B,YAAA,OAAO,EAAE;QACX;AAEA,QAAA,OAAO;aACJ,GAAG,CAAC,CAAC,IAAI,KAAK,IAAI,CAAC,IAAI;AACvB,aAAA,MAAM,CACL,CAAC,IAAI;;AAEH,QAAA,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC;;YAEtB,OAAO,IAAI,KAAK,QAAQ;AACxB,YAAA,IAAI,CAAC,MAAM,GAAG,CAAC,CAClB;IACL;AAAE,IAAA,MAAM;;AAEN,QAAA,OAAO,EAAE;IACX;AACF,CAAC;AAED,MAAM,wBAAwB,GAAG,CAC/B,IAAoD,KACzC;AACX,IAAA,IAAI,IAAI,KAAK,SAAS,IAAI,IAAI,KAAK,IAAI;AAAE,QAAA,OAAO,KAAK;;IAGrD,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB,EAAE;AACxD,QAAA,MAAM,EAAE,IAAI,EAAE,GAAG,IAAI;QAErB,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,cAAc,EAAE;YAC/C,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,SAAS,KAAI;AAClC,gBAAA,IAAI,SAAS,CAAC,IAAI,KAAK,cAAc,CAAC,eAAe;AAAE,oBAAA,OAAO,KAAK;AAEnE,gBAAA,MAAM,EAAE,QAAQ,EAAE,GAAG,SAAS;;AAG9B,gBAAA,IAAI,QAAQ,KAAK,IAAI,IAAI,QAAQ,KAAK,SAAS;AAAE,oBAAA,OAAO,KAAK;AAE7D,gBAAA,MAAM,OAAO,GAAI,QAAwC,CAAC,IAAI;AAE9D,gBAAA,OAAO,OAAO,KAAK,YAAY,IAAI,OAAO,KAAK,aAAa;AAC9D,YAAA,CAAC,CAAC;QACJ;AAEA,QAAA,MAAM,QAAQ,GAAI,IAAoC,CAAC,IAAI;AAE3D,QAAA,OAAO,QAAQ,KAAK,YAAY,IAAI,QAAQ,KAAK,aAAa;IAChE;AAEA,IAAA,OAAO,KAAK;AACd,CAAC;;;;"}
+{"version":3,"file":"check-destructuring-completeness.mjs","sources":["../../../../src/plugins/ts-restrictions/rules/check-destructuring-completeness.mts"],"sourcesContent":[null],"names":[],"mappings":";;AAgBA,MAAM,yBAAyB,GAAG,mCAAmC;AAE9D,MAAM,8BAA8B,GAGvC;AACF,IAAA,IAAI,EAAE;AACJ,QAAA,IAAI,EAAE,YAAY;AAClB,QAAA,IAAI,EAAE;AACJ,YAAA,WAAW,EACT,iFAAiF;AACpF,SAAA;AACD,QAAA,MAAM,EAAE;AACN,YAAA;AACE,gBAAA,IAAI,EAAE,QAAQ;AACd,gBAAA,UAAU,EAAE;AACV,oBAAA,8BAA8B,EAAE;AAC9B,wBAAA,IAAI,EAAE,SAAS;AACf,wBAAA,WAAW,EACT,4EAA4E;AAC/E,qBAAA;AACD,oBAAA,gBAAgB,EAAE;AAChB,wBAAA,IAAI,EAAE,QAAQ;AACd,wBAAA,WAAW,EACT,4FAA4F;AAC/F,qBAAA;AACF,iBAAA;AACD,gBAAA,oBAAoB,EAAE,KAAK;AAC5B,aAAA;AACF,SAAA;AACD,QAAA,QAAQ,EAAE;AACR,YAAA,uBAAuB,EACrB,gEAAgE;AACnE,SAAA;AACF,KAAA;AAED,IAAA,MAAM,EAAE,CAAC,OAAO,KAAI;AAClB,QAAA,MAAM,cAAc,GAAG,OAAO,CAAC,UAAU,CAAC,cAAc;AAExD,QAAA,IACE,cAAc,EAAE,OAAO,KAAK,SAAS;YACrC,cAAc,CAAC,OAAO,KAAK,IAAI;AAC/B,YAAA,cAAc,CAAC,qBAAqB,KAAK,SAAS,EAClD;AACA,YAAA,OAAO,EAAE;QACX;QAEA,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,EAAE;AAExC,QAAA,MAAM,8BAA8B,GAClC,OAAO,CAAC,8BAA8B,IAAI,IAAI;AAEhD,QAAA,MAAM,gBAAgB,GACpB,OAAO,CAAC,gBAAgB,IAAI,yBAAyB;QAEvD,MAAM,WAAW,GAAG,cAAc,CAAC,OAAO,CAAC,cAAc,EAAE;AAE3D,QAAA,MAAM,qBAAqB,GAAG,cAAc,CAAC,qBAAqB;AAElE,QAAA,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU;AAErC,QAAA,MAAM,mBAAmB,GAAG,CAC1B,IAA+C,KACpC;;AAEX,YAAA,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM;;YAG1B,IAAI,MAAM,EAAE,IAAI,KAAK,cAAc,CAAC,mBAAmB,EAAE;AACvD,gBAAA,OAAO,KAAK;YACd;;YAGA,MAAM,QAAQ,GAAG,UAAU,CAAC,iBAAiB,CAAC,MAAe,CAAC;AAE9D,YAAA,OAAO,QAAQ,CAAC,IAAI,CAAC,CAAC,OAAO,KAC3B,OAAO,CAAC,KAAK,CAAC,QAAQ,CAAC,gBAAgB,CAAC,CACzC;AACH,QAAA,CAAC;AAED,QAAA,MAAM,kCAAkC,GAAG,CACzC,IAA+C,KACpC;AACX,YAAA,IAAI,CAAC,8BAA8B;AAAE,gBAAA,OAAO,KAAK;AAEjD,YAAA,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM;;YAG1B,IAAI,MAAM,KAAK,SAAS;AAAE,gBAAA,OAAO,KAAK;;;YAItC,IAAI,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,mBAAmB,EAAE;AACtD,gBAAA,MAAM,WAAW,GAAG,MAAM,CAAC,MAAM;;gBAGjC,IAAI,WAAW,KAAK,SAAS;AAAE,oBAAA,OAAO,KAAK;;gBAG3C,IAAI,WAAW,CAAC,IAAI,KAAK,cAAc,CAAC,cAAc,EAAE;AACtD,oBAAA,MAAM,gBAAgB,GAAG,WAAW,CAAC,MAAM;AAE3C,oBAAA;;AAEE,oBAAA,gBAAgB,EAAE,IAAI,KAAK,cAAc,CAAC,uBAAuB;wBACjE,IAAI,CAAC,IAAI,EAAE,IAAI,KAAK,cAAc,CAAC,UAAU,EAC7C;AACA,wBAAA,MAAM,QAAQ;;AAEZ,wBAAA,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC;AAChC,8BAAE,IAAI,CAAC,IAAI,CAAC;8BACV,SAAS;wBAEf,IACE,QAAQ,KAAK,SAAS;AACtB,4BAAA,gBAAgB,CAAC,MAAM,CAAC,IAAI,CAC1B,CAAC,KAAK,KACJ,KAAK,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU;AACxC,gCAAA,KAAK,CAAC,IAAI,KAAK,QAAQ,CAC1B,EACD;AACA,4BAAA,OAAO,wBAAwB,CAAC,gBAAgB,CAAC;wBACnD;oBACF;gBACF;gBAEA,IAAI,WAAW,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB,EAAE;AAC/D,oBAAA,OAAO,wBAAwB,CAAC,WAAW,CAAC;gBAC9C;YACF;AAEA,YAAA,OAAO,KAAK;AACd,QAAA,CAAC;AAED,QAAA,MAAM,8BAA8B,GAAG,CACrC,aAAmD,EACnD,YAAyC,KACjC;YACR,MAAM,cAAc,GAAG,aAAa,CAAC,UAAU,CAAC,IAAI,CAClD,CAAC,IAAI,KAAK,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,WAAW,CACnD;AAED,YAAA,IAAI,cAAc;gBAAE;;YAGpB,MAAM,MAAM,GAAG,qBAAqB,CAAC,GAAG,CAAC,YAAqB,CAAC;;YAG/D,IAAI,MAAM,KAAK,SAAS;gBAAE;YAE1B,MAAM,IAAI,GAAG,WAAW,CAAC,iBAAiB,CAAC,MAAM,CAAC;AAElD,YAAA,MAAM,WAAW,GAAG,uBAAuB,CAAC,IAAI,CAAC;YAEjD,MAAM,SAAS,GAAG,4BAA4B,CAAC,aAAa,CAAC,UAAU,CAAC;;;YAIxE,IAAI,SAAS,CAAC,qBAAqB;gBAAE;YAErC,MAAM,YAAY,GAAG,WAAW,CAAC,MAAM,CACrC,CAAC,IAAI,KAAK,CAAC,SAAS,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,CACrC;AAED,YAAA,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE;gBAC3B,OAAO,CAAC,MAAM,CAAC;;AAEb,oBAAA,IAAI,EAAE,aAAsB;AAC5B,oBAAA,SAAS,EAAE,yBAAyB;AACpC,oBAAA,IAAI,EAAE;AACJ,wBAAA,YAAY,EAAE,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;AACtC,qBAAA;AACF,iBAAA,CAAC;YACJ;AACF,QAAA,CAAC;QAED,OAAO;AACL,YAAA,kBAAkB,EAAE,CAAC,IAAI,KAAI;gBAC3B,IAAI,IAAI,CAAC,EAAE,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;oBAAE;;gBAGnD,IAAI,IAAI,CAAC,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,IAAI,KAAK,IAAI;oBAAE;gBAEnD,MAAM,WAAW,GACf,mBAAmB,CAAC,IAAI,CAAC,IAAI,kCAAkC,CAAC,IAAI,CAAC;AAEvE,gBAAA,IAAI,CAAC,WAAW;oBAAE;gBAElB,8BAA8B,CAAC,IAAI,CAAC,EAAE,EAAE,IAAI,CAAC,IAAI,CAAC;YACpD,CAAC;AACD,YAAA,uBAAuB,EAAE,CAAC,IAAI,KAAI;AAChC,gBAAA,IAAI,CAAC,8BAA8B;oBAAE;AAErC,gBAAA,IAAI,CAAC,wBAAwB,CAAC,IAAI,CAAC;oBAAE;AAErC,gBAAA,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,MAAM,EAAE;oBAC/B,IAAI,KAAK,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa,EAAE;AAC/C,wBAAA,8BAA8B,CAAC,KAAK,EAAE,KAAK,CAAC;oBAC9C;gBACF;YACF,CAAC;SACF;IACH,CAAC;AACD,IAAA,cAAc,EAAE,CAAC,EAAE,8BAA8B,EAAE,IAAI,EAAE,CAAC;;AAG5D;AACA,MAAM,uBAAuB,GAAG,CAAC,IAAa,KAAuB;AACnE,IAAA,IAAI;AACF,QAAA,MAAM,UAAU,GAAG,IAAI,CAAC,aAAa,EAAE;;AAGvC,QAAA,IAAI,UAAU,CAAC,MAAM,GAAG,IAAI,EAAE;AAC5B,YAAA,OAAO,EAAE;QACX;AAEA,QAAA,OAAO;aACJ,GAAG,CAAC,CAAC,IAAI,KAAK,IAAI,CAAC,IAAI;AACvB,aAAA,MAAM,CACL,CAAC,IAAI;;AAEH,QAAA,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC;;YAEtB,OAAO,IAAI,KAAK,QAAQ;AACxB,YAAA,IAAI,CAAC,MAAM,GAAG,CAAC,CAClB;IACL;AAAE,IAAA,MAAM;;AAEN,QAAA,OAAO,EAAE;IACX;AACF,CAAC;AAED,MAAM,4BAA4B,GAAG,CACnC,UAA8D,KAI3D;AACH,IAAA,MAAM,SAAS,GAAG,IAAI,GAAG,EAAU;IAEnC,IAAI,yBAAyB,GAAG,KAAK;AAErC,IAAA,KAAK,MAAM,IAAI,IAAI,UAAU,EAAE;AAC7B,QAAA,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,QAAQ;YAAE;AAE3C,QAAA,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE;AAClB,YAAA,QAAQ,IAAI,CAAC,GAAG,CAAC,IAAI;AACnB,gBAAA,KAAK,cAAc,CAAC,UAAU,EAAE;oBAC9B,SAAS,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;oBAE5B;gBACF;AAEA,gBAAA,KAAK,cAAc,CAAC,OAAO,EAAE;oBAC3B,IAAI,OAAO,IAAI,CAAC,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE;wBACtC,SAAS,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC;oBAC/B;yBAAO,IAAI,OAAO,IAAI,CAAC,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE;AAC7C,wBAAA,SAAS,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;oBACvC;oBAEA;gBACF;;QAEJ;aAAO,IACL,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;AACxC,aAAC,OAAO,IAAI,CAAC,GAAG,CAAC,KAAK,KAAK,QAAQ,IAAI,OAAO,IAAI,CAAC,GAAG,CAAC,KAAK,KAAK,QAAQ,CAAC,EAC1E;;YAEA,SAAS,CAAC,GAAG,CACX,OAAO,IAAI,CAAC,GAAG,CAAC,KAAK,KAAK;AACxB,kBAAE,IAAI,CAAC,GAAG,CAAC;kBACT,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,CAAC,CAC3B;QACH;aAAO;;YAEL,yBAAyB,GAAG,IAAI;QAClC;IACF;IAEA,OAAO,EAAE,KAAK,EAAE,SAAS,EAAE,qBAAqB,EAAE,yBAAyB,EAAE;AAC/E,CAAC;AAED,MAAM,wBAAwB,GAAG,CAC/B,IAAoD,KACzC;AACX,IAAA,IAAI,IAAI,KAAK,SAAS,IAAI,IAAI,KAAK,IAAI;AAAE,QAAA,OAAO,KAAK;;IAGrD,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB,EAAE;AACxD,QAAA,MAAM,EAAE,IAAI,EAAE,GAAG,IAAI;QAErB,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,cAAc,EAAE;YAC/C,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,SAAS,KAAI;AAClC,gBAAA,IAAI,SAAS,CAAC,IAAI,KAAK,cAAc,CAAC,eAAe;AAAE,oBAAA,OAAO,KAAK;AAEnE,gBAAA,MAAM,EAAE,QAAQ,EAAE,GAAG,SAAS;;AAG9B,gBAAA,IAAI,QAAQ,KAAK,IAAI,IAAI,QAAQ,KAAK,SAAS;AAAE,oBAAA,OAAO,KAAK;AAE7D,gBAAA,MAAM,OAAO,GAAI,QAAwC,CAAC,IAAI;AAE9D,gBAAA,OAAO,OAAO,KAAK,YAAY,IAAI,OAAO,KAAK,aAAa;AAC9D,YAAA,CAAC,CAAC;QACJ;AAEA,QAAA,MAAM,QAAQ,GAAI,IAAoC,CAAC,IAAI;AAE3D,QAAA,OAAO,QAAQ,KAAK,YAAY,IAAI,QAAQ,KAAK,aAAa;IAChE;AAEA,IAAA,OAAO,KAAK;AACd,CAAC;;;;"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-typed",
-  "version": "4.9.1",
+  "version": "4.9.2",
   "private": false,
   "keywords": [
     "typescript"

package/src/plugins/ts-restrictions/rules/check-destructuring-completeness.mts

@@ -148,28 +148,18 @@ export const checkDestructuringCompleteness: TSESLint.RuleModule<
       return false;
     };
 
-    const checkNode = (
-      node: DeepReadonly<TSESTree.VariableDeclarator>,
+    const checkObjectPatternCompleteness = (
+      objectPattern: DeepReadonly<TSESTree.ObjectPattern>,
+      tsSourceNode: DeepReadonly<TSESTree.Node>,
     ): void => {
-      if (node.id.type !== AST_NODE_TYPES.ObjectPattern) return;
-
-      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-      if (node.init === undefined || node.init === null) return;
-
-      const shouldCheck =
-        hasDirectiveComment(node) || isReactComponentPropsDestructuring(node);
-
-      if (!shouldCheck) return;
-
-      // If rest element is used, skip completeness check
-      const hasRestElement = node.id.properties.some(
+      const hasRestElement = objectPattern.properties.some(
         (prop) => prop.type === AST_NODE_TYPES.RestElement,
       );
 
       if (hasRestElement) return;
 
       // eslint-disable-next-line total-functions/no-unsafe-type-assertion
-      const tsNode = esTreeNodeToTSNodeMap.get(node.init as never);
+      const tsNode = esTreeNodeToTSNodeMap.get(tsSourceNode as never);
 
       // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
       if (tsNode === undefined) return;
@@ -178,25 +168,20 @@ export const checkDestructuringCompleteness: TSESLint.RuleModule<
 
       const objectProps = getObjectTypeProperties(type);
 
-      const mut_destructuredProps = new Set<string>();
+      const collected = collectDestructuredPropNames(objectPattern.properties);
 
-      for (const prop of node.id.properties) {
-        if (
-          prop.type === AST_NODE_TYPES.Property &&
-          prop.key.type === AST_NODE_TYPES.Identifier
-        ) {
-          mut_destructuredProps.add(prop.key.name);
-        }
-      }
+      // Dynamic computed properties cannot be resolved statically,
+      // so skip completeness check when they are present.
+      if (collected.hasDynamicComputedKey) return;
 
       const missingProps = objectProps.filter(
-        (prop) => !mut_destructuredProps.has(prop),
+        (prop) => !collected.names.has(prop),
       );
 
       if (missingProps.length > 0) {
         context.report({
           // eslint-disable-next-line total-functions/no-unsafe-type-assertion
-          node: node.id as never,
+          node: objectPattern as never,
           messageId: 'incompleteDestructuring',
           data: {
             missingProps: missingProps.join(', '),
@@ -206,7 +191,19 @@ export const checkDestructuringCompleteness: TSESLint.RuleModule<
     };
 
     return {
-      VariableDeclarator: checkNode,
+      VariableDeclarator: (node) => {
+        if (node.id.type !== AST_NODE_TYPES.ObjectPattern) return;
+
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+        if (node.init === undefined || node.init === null) return;
+
+        const shouldCheck =
+          hasDirectiveComment(node) || isReactComponentPropsDestructuring(node);
+
+        if (!shouldCheck) return;
+
+        checkObjectPatternCompleteness(node.id, node.init);
+      },
       ArrowFunctionExpression: (node) => {
         if (!alwaysCheckReactComponentProps) return;
 
@@ -214,47 +211,7 @@ export const checkDestructuringCompleteness: TSESLint.RuleModule<
 
         for (const param of node.params) {
           if (param.type === AST_NODE_TYPES.ObjectPattern) {
-            // If rest element is used, skip completeness check
-            const hasRestElement = param.properties.some(
-              (prop) => prop.type === AST_NODE_TYPES.RestElement,
-            );
-
-            if (hasRestElement) continue;
-
-            // eslint-disable-next-line total-functions/no-unsafe-type-assertion
-            const tsNode = esTreeNodeToTSNodeMap.get(param as never);
-
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-            if (tsNode === undefined) continue;
-
-            const type = typeChecker.getTypeAtLocation(tsNode);
-
-            const objectProps = getObjectTypeProperties(type);
-
-            const mut_destructuredProps = new Set<string>();
-
-            for (const prop of param.properties) {
-              if (
-                prop.type === AST_NODE_TYPES.Property &&
-                prop.key.type === AST_NODE_TYPES.Identifier
-              ) {
-                mut_destructuredProps.add(prop.key.name);
-              }
-            }
-
-            const missingProps = objectProps.filter(
-              (prop) => !mut_destructuredProps.has(prop),
-            );
-
-            if (missingProps.length > 0) {
-              context.report({
-                node: param,
-                messageId: 'incompleteDestructuring',
-                data: {
-                  missingProps: missingProps.join(', '),
-                },
-              });
-            }
+            checkObjectPatternCompleteness(param, param);
           }
         }
       },
@@ -289,6 +246,56 @@ const getObjectTypeProperties = (type: ts.Type): readonly string[] => {
   }
 };
 
+const collectDestructuredPropNames = (
+  properties: DeepReadonly<TSESTree.ObjectPattern['properties']>,
+): Readonly<{
+  names: ReadonlySet<string>;
+  hasDynamicComputedKey: boolean;
+}> => {
+  const mut_names = new Set<string>();
+
+  let mut_hasDynamicComputedKey = false;
+
+  for (const prop of properties) {
+    if (prop.type !== AST_NODE_TYPES.Property) continue;
+
+    if (!prop.computed) {
+      switch (prop.key.type) {
+        case AST_NODE_TYPES.Identifier: {
+          mut_names.add(prop.key.name);
+
+          break;
+        }
+
+        case AST_NODE_TYPES.Literal: {
+          if (typeof prop.key.value === 'string') {
+            mut_names.add(prop.key.value);
+          } else if (typeof prop.key.value === 'number') {
+            mut_names.add(String(prop.key.value));
+          }
+
+          break;
+        }
+      }
+    } else if (
+      prop.key.type === AST_NODE_TYPES.Literal &&
+      (typeof prop.key.value === 'string' || typeof prop.key.value === 'number')
+    ) {
+      // Computed key with a static literal value, e.g. { ['data-id']: val }
+      mut_names.add(
+        typeof prop.key.value === 'string'
+          ? prop.key.value
+          : String(prop.key.value),
+      );
+    } else {
+      // Dynamic computed key — cannot resolve statically
+      mut_hasDynamicComputedKey = true;
+    }
+  }
+
+  return { names: mut_names, hasDynamicComputedKey: mut_hasDynamicComputedKey };
+};
+
 const isReactComponentFunction = (
   node: DeepReadonly<TSESTree.Node> | undefined | null,
 ): boolean => {

package/src/plugins/ts-restrictions/rules/check-destructuring-completeness.test.mts

@@ -125,6 +125,64 @@ describe('check-destructuring-completeness', () => {
             };
           `,
         },
+        {
+          name: 'handles string literal keys with directive - complete',
+          code: dedent`
+            const obj: { a: number; 'data-e2eId': string } = { a: 1, 'data-e2eId': 'test' };
+            // @check-destructuring-completeness
+            const { a, 'data-e2eId': e2eId } = obj;
+          `,
+        },
+        {
+          name: 'handles string literal keys in React component props - parameter destructuring',
+          code: dedent`
+            type Props = { a: number; b: string; 'data-e2eId': string };
+            const MyComponent = ({ a, b, 'data-e2eId': e2eId }: Props) => <div>{a}{b}{e2eId}</div>;
+          `,
+        },
+        {
+          name: 'handles string literal keys in React component props - internal destructuring',
+          code: dedent`
+            type Props = { a: number; b: string; 'data-e2eId': string };
+            const MyComponent = (props: Props) => {
+              const { a, b, 'data-e2eId': e2eId } = props;
+              return <div>{a}{b}{e2eId}</div>;
+            };
+          `,
+        },
+        {
+          name: 'handles number literal keys with directive - complete',
+          code: dedent`
+            const obj: { 0: string; 1: number } = { 0: 'a', 1: 2 };
+            // @check-destructuring-completeness
+            const { 0: first, 1: second } = obj;
+          `,
+        },
+        {
+          name: 'skips check when dynamic computed key is present with directive',
+          code: dedent`
+            const key = 'a' as string;
+            const obj: { a: number; b: string } = { a: 1, b: 'hello' };
+            // @check-destructuring-completeness
+            const { [key]: val } = obj;
+          `,
+        },
+        {
+          name: 'skips check when dynamic computed key is present in React component props',
+          code: dedent`
+            const key = 'a' as string;
+            type Props = { a: number; b: string };
+            const MyComponent = ({ [key]: val }: Props) => <div>{val}</div>;
+          `,
+        },
+        {
+          name: 'handles computed key with static string literal',
+          code: dedent`
+            const obj: { a: number; 'data-id': string } = { a: 1, 'data-id': 'test' };
+            // @check-destructuring-completeness
+            const { a, ['data-id']: dataId } = obj;
+          `,
+        },
         {
           name: 'does not check React component props when disabled - parameter',
           code: dedent`
@@ -165,6 +223,43 @@ describe('check-destructuring-completeness', () => {
           options: [{ directiveKeyword: '@custom-check' }],
           errors: [{ messageId: 'incompleteDestructuring' }],
         },
+        {
+          name: 'reports missing string literal key with directive',
+          code: dedent`
+            const obj: { a: number; 'data-e2eId': string } = { a: 1, 'data-e2eId': 'test' };
+            // @check-destructuring-completeness
+            const { a } = obj;
+          `,
+          errors: [{ messageId: 'incompleteDestructuring' }],
+        },
+        {
+          name: 'reports missing string literal key in React component props - parameter',
+          code: dedent`
+            type Props = { a: number; 'data-e2eId': string };
+            const MyComponent = ({ a }: Props) => <div>{a}</div>;
+          `,
+          errors: [{ messageId: 'incompleteDestructuring' }],
+        },
+        {
+          name: 'reports missing string literal key in React component props - internal',
+          code: dedent`
+            type Props = { a: number; 'data-e2eId': string };
+            const MyComponent = (props: Props) => {
+              const { a } = props;
+              return <div>{a}</div>;
+            };
+          `,
+          errors: [{ messageId: 'incompleteDestructuring' }],
+        },
+        {
+          name: 'reports missing number literal key with directive',
+          code: dedent`
+            const obj: { 0: string; 1: number } = { 0: 'a', 1: 2 };
+            // @check-destructuring-completeness
+            const { 0: first } = obj;
+          `,
+          errors: [{ messageId: 'incompleteDestructuring' }],
+        },
         {
           name: 'checks React component props - parameter destructuring incomplete',
           code: dedent`