eslint-config-typed 4.3.1 → 4.4.1

package/src/plugins/react-coding-style/rules/import-style.mts

@@ -84,8 +84,8 @@ export const importStyleRule: TSESLint.RuleModule<MessageIds, Options> = {
             const [firstSpecifier] = node.specifiers;
 
             if (
-              firstSpecifier === undefined ||
-              firstSpecifier.type !== AST_NODE_TYPES.ImportNamespaceSpecifier ||
+              firstSpecifier?.type !==
+                AST_NODE_TYPES.ImportNamespaceSpecifier ||
               node.specifiers.length !== 1
             ) {
               context.report({

package/src/plugins/react-coding-style/rules/props-type-annotation-style.mts

@@ -31,19 +31,13 @@ export const propsTypeAnnotationStyleRule: TSESLint.RuleModule<MessageIds> = {
 
       const arrowFunction = getReactMemoArrowFunction(node);
 
-      if (
-        arrowFunction === undefined ||
-        arrowFunction.body.type !== AST_NODE_TYPES.BlockStatement
-      ) {
+      if (arrowFunction?.body.type !== AST_NODE_TYPES.BlockStatement) {
         return;
       }
 
       const [firstParam] = arrowFunction.params;
 
-      if (
-        firstParam === undefined ||
-        firstParam.type !== AST_NODE_TYPES.Identifier
-      ) {
+      if (firstParam?.type !== AST_NODE_TYPES.Identifier) {
         return;
       }
 

package/src/plugins/react-coding-style/rules/react-memo-props-argument-name.mts

@@ -36,10 +36,7 @@ export const reactMemoPropsArgumentNameRule: TSESLint.RuleModule<MessageIds> = {
       const arrowFunction = getReactMemoArrowFunction(node);
 
       // Detect `React.memo<Props>(({ prop1, prop2 }) => { ... })`
-      if (
-        arrowFunction === undefined ||
-        arrowFunction.body.type !== AST_NODE_TYPES.BlockStatement
-      ) {
+      if (arrowFunction?.body.type !== AST_NODE_TYPES.BlockStatement) {
         return;
       }
 

package/src/plugins/strict-dependencies/rules/resolve-import-path.test.mts

@@ -118,13 +118,13 @@ const useFixture = (fixtureName: FixtureName | undefined): void => {
 
   const compilerOptions = compilerOptionsByFixture[fixtureName];
 
-  mockFindConfigFile.mockImplementation(() => 'tsconfig.json');
+  mockFindConfigFile.mockReturnValue('tsconfig.json');
 
-  mockGetParsedCommandLine.mockImplementation(() => ({
+  mockGetParsedCommandLine.mockReturnValue({
     options: { ...compilerOptions },
     fileNames: [],
     errors: [],
-  }));
+  });
 };
 
 const aliasCases = [

package/src/plugins/total-functions/rules/no-partial-url-constructor.mts

@@ -49,8 +49,7 @@ export const noPartialUrlConstructor = createRule({
         ) {
           if (
             node.arguments.length === 1 &&
-            node.arguments[0] !== undefined &&
-            node.arguments[0].type === AST_NODE_TYPES.Literal &&
+            node.arguments[0]?.type === AST_NODE_TYPES.Literal &&
             typeof node.arguments[0].value === 'string'
           ) {
             if (!isValidUrl(node.arguments[0].value)) {
@@ -65,11 +64,9 @@ export const noPartialUrlConstructor = createRule({
 
           if (
             node.arguments.length === 2 &&
-            node.arguments[0] !== undefined &&
-            node.arguments[0].type === AST_NODE_TYPES.Literal &&
+            node.arguments[0]?.type === AST_NODE_TYPES.Literal &&
             typeof node.arguments[0].value === 'string' &&
-            node.arguments[1] !== undefined &&
-            node.arguments[1].type === AST_NODE_TYPES.Literal &&
+            node.arguments[1]?.type === AST_NODE_TYPES.Literal &&
             typeof node.arguments[1].value === 'string'
           ) {
             if (!isValidUrl(node.arguments[0].value, node.arguments[1].value)) {

package/src/plugins/ts-data-forge/rules/prefer-range-for-loop.mts

@@ -48,8 +48,7 @@ export const preferRangeForLoop: TSESLint.RuleModule<MessageIds, Options> = {
       ForStatement: (node) => {
         // Check init: let i = begin
         if (
-          node.init === null ||
-          node.init.type !== AST_NODE_TYPES.VariableDeclaration ||
+          node.init?.type !== AST_NODE_TYPES.VariableDeclaration ||
           node.init.kind !== 'let' ||
           !Arr.isArrayOfLength(node.init.declarations, 1)
         ) {
@@ -71,8 +70,7 @@ export const preferRangeForLoop: TSESLint.RuleModule<MessageIds, Options> = {
 
         // Check test: i < end
         if (
-          node.test === null ||
-          node.test.type !== AST_NODE_TYPES.BinaryExpression ||
+          node.test?.type !== AST_NODE_TYPES.BinaryExpression ||
           node.test.operator !== '<' ||
           node.test.left.type !== AST_NODE_TYPES.Identifier ||
           node.test.left.name !== varName

package/src/plugins/ts-restrictions/rules/check-destructuring-completeness.mts

@@ -161,6 +161,13 @@ export const checkDestructuringCompleteness: TSESLint.RuleModule<
 
       if (!shouldCheck) return;
 
+      // If rest element is used, skip completeness check
+      const hasRestElement = node.id.properties.some(
+        (prop) => prop.type === AST_NODE_TYPES.RestElement,
+      );
+
+      if (hasRestElement) return;
+
       // eslint-disable-next-line total-functions/no-unsafe-type-assertion
       const tsNode = esTreeNodeToTSNodeMap.get(node.init as never);
 
@@ -207,6 +214,13 @@ export const checkDestructuringCompleteness: TSESLint.RuleModule<
 
         for (const param of node.params) {
           if (param.type === AST_NODE_TYPES.ObjectPattern) {
+            // If rest element is used, skip completeness check
+            const hasRestElement = param.properties.some(
+              (prop) => prop.type === AST_NODE_TYPES.RestElement,
+            );
+
+            if (hasRestElement) continue;
+
             // eslint-disable-next-line total-functions/no-unsafe-type-assertion
             const tsNode = esTreeNodeToTSNodeMap.get(param as never);
 

package/src/plugins/ts-restrictions/rules/check-destructuring-completeness.test.mts

@@ -93,6 +93,38 @@ describe('check-destructuring-completeness', () => {
             };
           `,
         },
+        {
+          name: 'allows rest parameter without directive comment',
+          code: dedent`
+            const obj = { a: 1, b: 2, c: 3 };
+            const { a, ...rest } = obj;
+          `,
+        },
+        {
+          name: 'allows rest parameter with directive comment',
+          code: dedent`
+            const obj = { a: 1, b: 2, c: 3 };
+            // @check-destructuring-completeness
+            const { a, ...rest } = obj;
+          `,
+        },
+        {
+          name: 'allows rest parameter in React component props',
+          code: dedent`
+            type Props = { a: number; b: string; c: boolean };
+            const MyComponent = ({ a, ...rest }: Props) => <div>{a}</div>;
+          `,
+        },
+        {
+          name: 'allows rest parameter in internal destructuring',
+          code: dedent`
+            type Props = { a: number; b: string; c: boolean };
+            const MyComponent = (props: Props) => {
+              const { a, ...rest } = props;
+              return <div>{a}</div>;
+            };
+          `,
+        },
         {
           name: 'does not check React component props when disabled - parameter',
           code: dedent`

package/src/rules/eslint-jest-rules.mts

@@ -60,6 +60,7 @@ export const eslintJestRules = {
   'jest/prefer-snapshot-hint': withDefaultOption('error'),
   'jest/prefer-spy-on': 'error',
   'jest/prefer-todo': 'error',
+  'jest/prefer-mock-return-shorthand': 'error',
 
   /* eslint-plugin-jest specific rules */
 

package/src/rules/eslint-vitest-rules.mts

@@ -61,6 +61,7 @@ export const eslintVitestRules = {
   'vitest/prefer-snapshot-hint': withDefaultOption('error'),
   'vitest/prefer-spy-on': 'error',
   'vitest/prefer-todo': 'error',
+  'vitest/prefer-mock-return-shorthand': 'error',
 
   /* eslint-plugin-vitest specific rules */