eslint-config-tungsten-flat 0.2.2 → 0.2.4

package/NOTES.md

@@ -0,0 +1,91 @@
+# eslint-config-tungsten-flat — maintenance notes
+
+## `eslint-plugin-no-type-assertion` peer warning
+
+### Symptom
+
+Every project that installs this config gets a pnpm peer warning:
+
+```
+✕ unmet peer eslint
+  Installed: 9.39.5
+  Wanted:
+    "^7.0.0 || ^8.0.0":
+      eslint-plugin-no-type-assertion@1.3.0
+```
+
+### Why it happens
+
+This package depends on `eslint-plugin-no-type-assertion@^1.3.0`, whose declared
+peer range stops at ESLint 8. The plugin is unmaintained — 1.3.0 is the last
+release (~2021) — so the range was never bumped for ESLint 9.
+
+### Is it a real incompatibility?
+
+No. The plugin is a leaf plugin with no version-coupled ESLint API. Its entire
+entry point is:
+
+```js
+module.exports.rules = {
+  "no-type-assertion": require("./rules/no-type-assertion"),
+};
+```
+
+and the rule itself is ~55 lines using only `meta` + `create(context)` with
+`context.report({ node, messageId })` and three AST visitors (`TSTypeAssertion`,
+`TSAsExpression`, `TSNonNullExpression`). All of that is unchanged in ESLint 9.
+The rule is already enabled and firing under ESLint 9 — see
+[`src/index.ts`](src/index.ts), which registers the plugin under the
+`no-type-assertion` namespace and sets
+`"no-type-assertion/no-type-assertion": "warn"`.
+
+So the warning is stale metadata, not a broken install.
+
+### Workaround for consumers (current fix)
+
+Suppress it in the consuming project. **Note for pnpm 10+/11:** the `pnpm` field
+in `package.json` is no longer read — pnpm warns and ignores it. These settings
+now live in `pnpm-workspace.yaml`:
+
+```yaml
+peerDependencyRules:
+  allowedVersions:
+    # Unmaintained leaf plugin; its peer range stops at eslint 8 but the rule
+    # uses no version-coupled API and works fine on 9.
+    'eslint-plugin-no-type-assertion>eslint': '9'
+```
+
+Applied in `qtc-2` on 2026-07-22.
+
+### Proper fix (not yet done)
+
+Vendor the rule into this package and drop the dependency. That fixes the
+warning at source for every consumer instead of requiring each one to suppress
+it. Steps:
+
+1. Copy the rule body into `src/rules/noTypeAssertion.ts` (it is ~55 lines of
+   plain JS; typing it against `Rule.RuleModule` is optional).
+2. Register it inline in `src/index.ts` in place of the imported plugin —
+   `{ rules: { 'no-type-assertion': noTypeAssertion } }` — keeping the same
+   `no-type-assertion/no-type-assertion` rule id so consumer configs and inline
+   disable comments keep working.
+3. Remove `eslint-plugin-no-type-assertion` from `dependencies` and delete its
+   entry from `src/modules.d.ts` (which only exists to silence the missing-types
+   error for the untyped plugin).
+4. Consumers can then drop the `peerDependencyRules` entry above.
+
+Licence is MIT (Kirill Korolyov,
+<https://github.com/Dremora/eslint-plugin-no-type-assertion>), so vendoring is
+fine — preserve the copyright notice in the vendored file.
+
+### Possible alternative (unevaluated)
+
+`typescript-eslint` has a built-in rule that may cover the same ground:
+
+- <https://typescript-eslint.io/rules/consistent-type-assertions/>
+
+`typescript-eslint` is already a dependency of this package, so adopting it
+would remove the third-party plugin without vendoring anything. Not yet
+reviewed — the rule's options and exactly how its behaviour compares to
+`no-type-assertion` (particularly the `as const` and non-null `!` cases the
+current rule special-cases) still need checking.

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AACA,OAAO,EAA+B,MAAM,EAAE,MAAM,eAAe,CAAA;;AAMnE,wBAoFE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AACA,OAAO,EAA+B,MAAM,EAAE,MAAM,eAAe,CAAA;;AAMnE,wBA+FE"}

package/dist/index.js

@@ -61,7 +61,9 @@ export default defineConfig([
             "@typescript-eslint/no-explicit-any": "off",
             // would like to change to _unused or unused_, but conflicts with the camel case rule
             //"@typescript-eslint/no-unused-vars": ["warn", { "varsIgnorePattern": "^__*$|^unused$|^unused|.+unused$", "argsIgnorePattern": "^__*$|^unused$|^unused_.+|.+_unused$|^reject$" }],
-            "@typescript-eslint/no-unused-vars": ["warn", { "varsIgnorePattern": "^__*$|unused$", "argsIgnorePattern": "^__*$|unused$|^reject$" }],
+            // "^_" (any leading underscore) subsumes the older "^__*$" (which only matched a
+            // name that was entirely underscores), and covers the `_name` convention too
+            "@typescript-eslint/no-unused-vars": ["warn", { "varsIgnorePattern": "^_|unused$", "argsIgnorePattern": "^_|unused$|^reject$" }],
             "@typescript-eslint/switch-exhaustiveness-check": "warn",
             "@typescript-eslint/require-await": "warn",
             "@typescript-eslint/no-unsafe-member-access": "warn",
@@ -69,6 +71,13 @@ export default defineConfig([
             "@typescript-eslint/no-unused-expressions": "warn",
             // added TS rules
             '@typescript-eslint/no-misused-spread': 'warn',
+            // fires on every event handler and JSX prop taking an async function,
+            // which is the normal shape in a tungsten app
+            '@typescript-eslint/no-misused-promises': 'off',
+            '@typescript-eslint/no-for-in-array': 'off',
+            '@typescript-eslint/no-floating-promises': 'warn',
+            // these can give false positives due to eslint info being stale
+            '@typescript-eslint/no-unsafe-assignment': 'warn',
             // plugin-no-type-assertion
             "no-type-assertion/no-type-assertion": "warn",
             // was using this in a project, but doesn't seem to change the underlying config

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "eslint-config-tungsten-flat",
-  "version": "0.2.2",
+  "version": "0.2.4",
   "description": "",
   "type": "module",
   "main": "dist/index.js",
   "keywords": [],
   "author": "",
-  "license": "UNLICENSED",
+  "license": "ISC",
   "dependencies": {
     "@typescript-eslint/parser": "^8.57.1",
     "eslint": "^9.39.4",
@@ -31,6 +31,6 @@
   "scripts": {
     "compile": "tsc",
     "build": "tsc --watch",
-    "prepublish": "tsc"
+    "prepublishonly": "tsc"
   }
 }

package/src/index.ts

@@ -70,7 +70,9 @@ export default defineConfig([
             "@typescript-eslint/no-explicit-any": "off",
             // would like to change to _unused or unused_, but conflicts with the camel case rule
             //"@typescript-eslint/no-unused-vars": ["warn", { "varsIgnorePattern": "^__*$|^unused$|^unused|.+unused$", "argsIgnorePattern": "^__*$|^unused$|^unused_.+|.+_unused$|^reject$" }],
-            "@typescript-eslint/no-unused-vars": ["warn", { "varsIgnorePattern": "^__*$|unused$", "argsIgnorePattern": "^__*$|unused$|^reject$" }],
+            // "^_" (any leading underscore) subsumes the older "^__*$" (which only matched a
+            // name that was entirely underscores), and covers the `_name` convention too
+            "@typescript-eslint/no-unused-vars": ["warn", { "varsIgnorePattern": "^_|unused$", "argsIgnorePattern": "^_|unused$|^reject$" }],
             "@typescript-eslint/switch-exhaustiveness-check": "warn",
             "@typescript-eslint/require-await": "warn",
             "@typescript-eslint/no-unsafe-member-access": "warn",
@@ -80,6 +82,15 @@ export default defineConfig([
             // added TS rules
             '@typescript-eslint/no-misused-spread': 'warn',
 
+            // fires on every event handler and JSX prop taking an async function,
+            // which is the normal shape in a tungsten app
+            '@typescript-eslint/no-misused-promises': 'off',
+            '@typescript-eslint/no-for-in-array': 'off',
+            '@typescript-eslint/no-floating-promises': 'warn',
+
+            // these can give false positives due to eslint info being stale
+            '@typescript-eslint/no-unsafe-assignment': 'warn',
+
             // plugin-no-type-assertion
             "no-type-assertion/no-type-assertion": "warn",