eslint-config-simplesense 4.0.5 → 5.0.0

package/rules/node.js

@@ -1,43 +1,33 @@
-(() => {
-  'use strict';
-
-  module.exports = {
-    'n/callback-return': [
-      'error', [
-        'callback',
-        'cb',
-        'done',
-        'next',
-      ],
+export default {
+  'n/callback-return': [
+    'error',
+    [
+      'callback',
+      'cb',
+      'done',
+      'next',
     ],
-    // not used because it does not support IIFE
-    // 'n/global-require': ['error'],
-    'n/handle-callback-err': ['error'],
-    'n/no-deprecated-api': ['error'],
-    'n/no-missing-import': ['error'],
-    'n/no-missing-require': ['off'],
-    'n/no-mixed-requires': [
-      'error', {
-        allowCall: true,
-        grouping: true,
-      },
-    ],
-    'n/no-new-require': ['error'],
-    'n/no-path-concat': ['error'],
-    'n/no-unsupported-features/es-builtins': ['error'],
-    'n/no-unsupported-features/es-syntax': ['off'],
-    'n/no-unsupported-features/node-builtins': ['error'],
-    'n/no-unpublished-bin': ['error'],
-    'n/no-unpublished-import': ['error'],
-    'n/no-unpublished-require': ['error'],
-    'n/prefer-global/buffer': [ 'error', 'always' ],
-    'n/prefer-global/console': [ 'error', 'always' ],
-    'n/prefer-global/process': [ 'error', 'always' ],
-    'n/prefer-global/text-decoder': [ 'error', 'never' ],
-    'n/prefer-global/text-encoder': [ 'error', 'never' ],
-    'n/prefer-global/url-search-params': [ 'error', 'never' ],
-    'n/prefer-global/url': [ 'error', 'never' ],
-    'n/prefer-promises/dns': ['error'],
-    'n/prefer-promises/fs': ['error'],
-  };
-})();
+  ],
+  'n/file-extension-in-import': [ 'error', 'always' ],
+  'n/handle-callback-err': ['error'],
+  'n/no-deprecated-api': ['error'],
+  'n/no-extraneous-import': ['error'],
+  'n/no-missing-import': ['error'],
+  'n/no-path-concat': ['error'],
+  'n/no-sync': ['error'],
+  'n/no-unpublished-bin': ['error'],
+  'n/no-unpublished-import': ['error'],
+  'n/no-unsupported-features/es-builtins': ['error'],
+  'n/no-unsupported-features/es-syntax': ['error'],
+  'n/no-unsupported-features/node-builtins': ['error'],
+  'n/prefer-global/buffer': [ 'error', 'always' ],
+  'n/prefer-global/console': [ 'error', 'always' ],
+  'n/prefer-global/process': [ 'error', 'always' ],
+  'n/prefer-global/text-decoder': [ 'error', 'never' ],
+  'n/prefer-global/text-encoder': [ 'error', 'never' ],
+  'n/prefer-global/url-search-params': [ 'error', 'never' ],
+  'n/prefer-global/url': [ 'error', 'never' ],
+  'n/prefer-node-protocol': ['error'],
+  'n/prefer-promises/dns': ['error'],
+  'n/prefer-promises/fs': ['error'],
+};

package/rules/security.js

@@ -1,16 +1,15 @@
-(() => {
-  'use strict';
-
-  module.exports = {
-    'security/detect-buffer-noassert': ['error'],
-    'security/detect-disable-mustache-escape': ['error'],
-    'security/detect-eval-with-expression': ['error'],
-    'security/detect-no-csrf-before-method-override': ['error'],
-    'security/detect-non-literal-fs-filename': ['error'],
-    'security/detect-non-literal-regexp': ['error'],
-    'security/detect-non-literal-require': ['error'],
-    'security/detect-possible-timing-attacks': ['error'],
-    'security/detect-pseudoRandomBytes': ['error'],
-    'security/detect-unsafe-regex': ['error'],
-  };
-})();
+export default {
+  'security/detect-bidi-characters': ['error'],
+  'security/detect-buffer-noassert': ['error'],
+  'security/detect-child-process': ['error'],
+  'security/detect-disable-mustache-escape': ['error'],
+  'security/detect-eval-with-expression': ['error'],
+  'security/detect-new-buffer': ['error'],
+  'security/detect-no-csrf-before-method-override': ['error'],
+  'security/detect-non-literal-fs-filename': ['error'],
+  'security/detect-non-literal-regexp': ['error'],
+  'security/detect-non-literal-require': ['error'],
+  'security/detect-possible-timing-attacks': ['error'],
+  'security/detect-pseudoRandomBytes': ['error'],
+  'security/detect-unsafe-regex': ['error'],
+};

package/rules/sonarjs.js

@@ -1,12 +1,8 @@
-(() => {
-  'use strict';
-
-  module.exports = {
-    'sonarjs/cognitive-complexity': ['off'],
-    // this rule does has a lot of false positives
-    'sonarjs/no-duplicate-string': ['off'],
-    'sonarjs/no-inverted-boolean-check': ['off'],
-    'sonarjs/no-nested-template-literals': ['off'],
-    'sonarjs/prefer-single-boolean-return': ['off'],
-  };
-})();
+export default {
+  // this rule does has a lot of false positives
+  'sonarjs/no-duplicate-string': ['off'],
+  'sonarjs/no-inverted-boolean-check': ['off'],
+  'sonarjs/no-nested-template-literals': ['off'],
+  'sonarjs/no-redundant-boolean': ['off'],
+  'sonarjs/prefer-single-boolean-return': ['off'],
+};

package/rules/stylistic.js

@@ -0,0 +1,240 @@
+const PADDING_STATEMENT = {
+  DIRECTIVES: ['directive'],
+  EXPORTS: ['export'],
+  IMPORTS: ['import'],
+  VARIABLES: [ 'const', 'let' ],
+};
+
+export default {
+  '@stylistic/js/array-bracket-newline': [
+    'error',
+    {
+      multiline: true,
+    },
+  ],
+  '@stylistic/js/array-bracket-spacing': [
+    'error',
+    'always',
+    {
+      arraysInArrays: false,
+      objectsInArrays: false,
+      singleValue: false,
+    },
+  ],
+  '@stylistic/js/array-element-newline': [
+    'error',
+    {
+      minItems: 3,
+      multiline: true,
+    },
+  ],
+  '@stylistic/js/arrow-parens': [ 'error', 'always' ],
+  '@stylistic/js/arrow-spacing': [
+    'error',
+    {
+      after: true,
+      before: true,
+    },
+  ],
+  '@stylistic/js/block-spacing': [ 'error', 'always' ],
+  '@stylistic/js/brace-style': [ 'error', '1tbs' ],
+  '@stylistic/js/comma-dangle': [ 'error', 'always-multiline' ],
+  '@stylistic/js/comma-spacing': ['error'],
+  '@stylistic/js/comma-style': ['error'],
+  '@stylistic/js/computed-property-spacing': [ 'error', 'never' ],
+  '@stylistic/js/dot-location': [ 'error', 'property' ],
+  '@stylistic/js/eol-last': [ 'error', 'always' ],
+  '@stylistic/js/function-call-argument-newline': [ 'error', 'consistent' ],
+  '@stylistic/js/func-call-spacing': [ 'error', 'never' ],
+  '@stylistic/js/function-paren-newline': [ 'error', 'multiline' ],
+  '@stylistic/js/generator-star-spacing': [
+    'error',
+    {
+      after: false,
+      before: true,
+    },
+  ],
+  '@stylistic/js/implicit-arrow-linebreak': [ 'error', 'beside' ],
+  '@stylistic/js/indent': [
+    'error',
+    2,
+    {
+      ArrayExpression: 1,
+      CallExpression: {
+        arguments: 1,
+      },
+      flatTernaryExpressions: true,
+      FunctionDeclaration: {
+        body: 1,
+        parameters: 1,
+      },
+      FunctionExpression: {
+        body: 1,
+        parameters: 1,
+      },
+      ignoredNodes: ['ConditionalExpression'],
+      ImportDeclaration: 1,
+      ObjectExpression: 1,
+      StaticBlock: {
+        body: 1,
+      },
+      SwitchCase: 1,
+      MemberExpression: 1,
+    },
+  ],
+  '@stylistic/js/key-spacing': [
+    'error',
+    {
+      afterColon: true,
+      beforeColon: false,
+      mode: 'strict',
+    },
+  ],
+  '@stylistic/js/keyword-spacing': [
+    'error',
+    {
+      after: true,
+      before: true,
+    },
+  ],
+  '@stylistic/js/linebreak-style': [ 'error', 'unix' ],
+  '@stylistic/js/lines-between-class-members': [ 'error', 'always' ],
+  '@stylistic/js/max-len': ['off'],
+  '@stylistic/js/multiline-comment-style': [ 'error', 'separate-lines' ],
+  '@stylistic/js/new-parens': ['error'],
+  '@stylistic/js/newline-per-chained-call': [
+    'error',
+    {
+      ignoreChainWithDepth: 2,
+    },
+  ],
+  '@stylistic/js/no-confusing-arrow': ['error'],
+  '@stylistic/js/no-extra-semi': ['error'],
+  '@stylistic/js/no-floating-decimal': ['error'],
+  '@stylistic/js/no-mixed-operators': ['error'],
+  '@stylistic/js/no-mixed-spaces-and-tabs': ['error'],
+  '@stylistic/js/no-multi-spaces': ['error'],
+  '@stylistic/js/no-multiple-empty-lines': [
+    'error',
+    {
+      max: 2,
+      maxEOF: 1,
+    },
+  ],
+  '@stylistic/js/no-tabs': ['error'],
+  '@stylistic/js/no-trailing-spaces': ['error'],
+  '@stylistic/js/no-whitespace-before-property': ['error'],
+  '@stylistic/js/nonblock-statement-body-position': [ 'error', 'beside' ],
+  '@stylistic/js/object-curly-newline': [
+    'error',
+    {
+      ObjectExpression: {
+        multiline: true,
+        minProperties: 1,
+      },
+      ObjectPattern: {
+        consistent: true,
+        minProperties: 1,
+      },
+      ImportDeclaration: 'always',
+      ExportDeclaration: 'always',
+    },
+  ],
+  '@stylistic/js/object-curly-spacing': [
+    'error',
+    'always',
+    {
+      arraysInObjects: false,
+      objectsInObjects: false,
+    },
+  ],
+  '@stylistic/js/object-property-newline': ['error'],
+  '@stylistic/js/one-var-declaration-per-line': ['error'],
+  '@stylistic/js/operator-linebreak': [ 'error', 'before' ],
+  '@stylistic/js/padded-blocks': [ 'error', 'never' ],
+  '@stylistic/js/padding-line-between-statements': [
+    'error',
+    {
+      blankLine: 'always',
+      prev: PADDING_STATEMENT.DIRECTIVES,
+      next: '*',
+    },
+    {
+      blankLine: 'any',
+      prev: PADDING_STATEMENT.DIRECTIVES,
+      next: PADDING_STATEMENT.DIRECTIVES,
+    },
+    {
+      blankLine: 'always',
+      prev: PADDING_STATEMENT.VARIABLES,
+      next: '*',
+    },
+    {
+      blankLine: 'any',
+      prev: PADDING_STATEMENT.VARIABLES,
+      next: PADDING_STATEMENT.VARIABLES,
+    },
+    {
+      blankLine: 'always',
+      prev: PADDING_STATEMENT.IMPORTS,
+      next: '*',
+    },
+    {
+      blankLine: 'any',
+      prev: PADDING_STATEMENT.IMPORTS,
+      next: PADDING_STATEMENT.IMPORTS,
+    },
+    {
+      blankLine: 'always',
+      prev: '*',
+      next: PADDING_STATEMENT.EXPORTS,
+    },
+    {
+      blankLine: 'any',
+      prev: PADDING_STATEMENT.EXPORTS,
+      next: PADDING_STATEMENT.EXPORTS,
+    },
+  ],
+  '@stylistic/js/quote-props': [ 'error', 'as-needed' ],
+  '@stylistic/js/quotes': [ 'error', 'single' ],
+  '@stylistic/js/rest-spread-spacing': [ 'error', 'never' ],
+  '@stylistic/js/semi': [ 'error', 'always' ],
+  '@stylistic/js/semi-spacing': [
+    'error',
+    {
+      after: true,
+      before: false,
+    },
+  ],
+  '@stylistic/js/semi-style': [ 'error', 'last' ],
+  '@stylistic/js/space-before-blocks': [ 'error', 'always' ],
+  '@stylistic/js/space-before-function-paren': [ 'error', 'never' ],
+  '@stylistic/js/space-in-parens': [ 'error', 'never' ],
+  '@stylistic/js/space-infix-ops': ['error'],
+  '@stylistic/js/space-unary-ops': [
+    'error',
+    {
+      nonwords: true,
+      words: true,
+      overrides: {
+        '!': false,
+        '+': false,
+        '-': false,
+        '++': false,
+        '--': false,
+      },
+    },
+  ],
+  '@stylistic/js/spaced-comment': [ 'error', 'always' ],
+  '@stylistic/js/switch-colon-spacing': [
+    'error',
+    {
+      after: true,
+      before: false,
+    },
+  ],
+  '@stylistic/js/template-curly-spacing': [ 'error', 'always' ],
+  '@stylistic/js/template-tag-spacing': [ 'error', 'always' ],
+  '@stylistic/js/wrap-regex': ['error'],
+  '@stylistic/js/yield-star-spacing': [ 'error', 'after' ],
+};

package/rules/unicorn.js

@@ -1,55 +1,92 @@
-(() => {
-  'use strict';
-
-  module.exports = {
-    'unicorn/better-regex': ['error'],
-    'unicorn/catch-error-name': [
-      'error', {
-        name: 'err',
-      },
-    ],
-    'unicorn/consistent-function-scoping': ['error'],
-    'unicorn/custom-error-definition': ['error'],
-    'unicorn/empty-brace-spaces': ['error'],
-    'unicorn/error-message': ['error'],
-    'unicorn/filename-case': ['error'],
-    'unicorn/new-for-builtins': ['error'],
-    'unicorn/no-abusive-eslint-disable': ['error'],
-    'unicorn/no-array-push-push': ['error'],
-    'unicorn/no-document-cookie': ['error'],
-    'unicorn/no-for-loop': ['error'],
-    'unicorn/no-hex-escape': ['error'],
-    'unicorn/no-instanceof-array': ['error'],
-    'unicorn/no-new-array': ['error'],
-    'unicorn/no-process-exit': ['error'],
-    'unicorn/no-thenable': ['error'],
-    'unicorn/no-this-assignment': ['error'],
-    'unicorn/no-unused-properties': ['error'],
-    'unicorn/no-useless-promise-resolve-reject': ['error'],
-    'unicorn/no-useless-undefined': ['error'],
-    'unicorn/no-zero-fractions': ['error'],
-    'unicorn/number-literal-case': ['error'],
-    'unicorn/prefer-array-flat-map': ['error'],
-    'unicorn/prefer-array-flat': ['error'],
-    'unicorn/prefer-date-now': ['error'],
-    'unicorn/prefer-dom-node-append': ['error'],
-    'unicorn/prefer-dom-node-dataset': ['error'],
-    'unicorn/prefer-dom-node-remove': ['error'],
-    'unicorn/prefer-dom-node-text-content': ['error'],
-    'unicorn/prefer-keyboard-event-key': ['error'],
-    'unicorn/prefer-modern-dom-apis': ['error'],
-    // turn this back on when we move to pure ESM
-    'unicorn/prefer-node-protocol': ['off'],
-    'unicorn/prefer-number-properties': ['error'],
-    'unicorn/prefer-query-selector': ['error'],
-    'unicorn/prefer-regexp-test': ['error'],
-    'unicorn/prefer-string-replace-all': ['error'],
-    'unicorn/prefer-string-slice': ['error'],
-    'unicorn/prefer-string-starts-ends-with': ['error'],
-    'unicorn/prefer-string-trim-start-end': ['error'],
-    'unicorn/prefer-type-error': ['error'],
-    'unicorn/require-array-join-separator': ['error'],
-    'unicorn/require-number-to-fixed-digits-argument': ['error'],
-    'unicorn/throw-new-error': ['error'],
-  };
-})();
+export default {
+  'unicorn/better-regex': ['error'],
+  'unicorn/catch-error-name': [
+    'error',
+    {
+      name: 'err',
+    },
+  ],
+  'unicorn/consistent-empty-array-spread': ['error'],
+  'unicorn/consistent-function-scoping': ['error'],
+  'unicorn/custom-error-definition': ['error'],
+  'unicorn/empty-brace-spaces': ['error'],
+  'unicorn/error-message': ['error'],
+  'unicorn/escape-case': ['error'],
+  'unicorn/filename-case': ['error'],
+  'unicorn/new-for-builtins': ['error'],
+  'unicorn/no-abusive-eslint-disable': ['error'],
+  'unicorn/no-array-for-each': ['error'],
+  'unicorn/no-array-method-this-argument': ['error'],
+  'unicorn/no-array-push-push': ['error'],
+  'unicorn/no-document-cookie': ['error'],
+  'unicorn/no-empty-file': ['error'],
+  'unicorn/no-for-loop': ['error'],
+  'unicorn/no-hex-escape': ['error'],
+  'unicorn/no-instanceof-array': ['error'],
+  'unicorn/no-invalid-fetch-options': ['error'],
+  'unicorn/no-invalid-remove-event-listener': ['error'],
+  'unicorn/no-length-as-slice-end': ['error'],
+  'unicorn/no-magic-array-flat-depth': ['error'],
+  'unicorn/no-new-array': ['error'],
+  'unicorn/no-new-buffer': ['error'],
+  'unicorn/no-process-exit': ['error'],
+  'unicorn/no-single-promise-in-promise-methods': ['error'],
+  'unicorn/no-static-only-class': ['error'],
+  'unicorn/no-thenable': ['error'],
+  'unicorn/no-this-assignment': ['error'],
+  'unicorn/no-typeof-undefined': ['error'],
+  'unicorn/no-unreadable-array-destructuring': ['error'],
+  'unicorn/no-unreadable-iife': ['error'],
+  'unicorn/no-unused-properties': ['error'],
+  'unicorn/no-useless-length-check': ['error'],
+  'unicorn/no-useless-promise-resolve-reject': ['error'],
+  'unicorn/no-useless-spread': ['error'],
+  'unicorn/no-useless-switch-case': ['error'],
+  'unicorn/no-useless-undefined': ['error'],
+  'unicorn/no-zero-fractions': ['error'],
+  'unicorn/number-literal-case': ['error'],
+  'unicorn/prefer-add-event-listener': ['error'],
+  'unicorn/prefer-array-find': ['error'],
+  'unicorn/prefer-array-flat-map': ['error'],
+  'unicorn/prefer-array-flat': ['error'],
+  'unicorn/prefer-array-some': ['error'],
+  'unicorn/prefer-blob-reading-methods': ['error'],
+  'unicorn/prefer-code-point': ['error'],
+  'unicorn/prefer-date-now': ['error'],
+  'unicorn/prefer-dom-node-append': ['error'],
+  'unicorn/prefer-dom-node-dataset': ['error'],
+  'unicorn/prefer-dom-node-remove': ['error'],
+  'unicorn/prefer-dom-node-text-content': ['error'],
+  'unicorn/prefer-event-target': ['error'],
+  'unicorn/prefer-export-from': ['error'],
+  'unicorn/prefer-includes': ['error'],
+  'unicorn/prefer-keyboard-event-key': ['error'],
+  'unicorn/prefer-logical-operator-over-ternary': ['error'],
+  'unicorn/prefer-math-trunc': ['error'],
+  'unicorn/prefer-modern-dom-apis': ['error'],
+  'unicorn/prefer-modern-math-apis': ['error'],
+  'unicorn/prefer-module': ['error'],
+  'unicorn/prefer-node-protocol': ['error'],
+  'unicorn/prefer-number-properties': ['error'],
+  'unicorn/prefer-object-from-entries': ['error'],
+  'unicorn/prefer-prototype-methods': ['error'],
+  'unicorn/prefer-query-selector': ['error'],
+  'unicorn/prefer-reflect-apply': ['error'],
+  'unicorn/prefer-regexp-test': ['error'],
+  'unicorn/prefer-set-has': ['error'],
+  'unicorn/prefer-set-size': ['error'],
+  'unicorn/prefer-spread': ['error'],
+  'unicorn/prefer-string-raw': ['error'],
+  'unicorn/prefer-string-replace-all': ['error'],
+  'unicorn/prefer-string-slice': ['error'],
+  'unicorn/prefer-string-starts-ends-with': ['error'],
+  'unicorn/prefer-string-trim-start-end': ['error'],
+  'unicorn/prefer-structured-clone': ['error'],
+  'unicorn/prefer-switch': ['error'],
+  'unicorn/prefer-type-error': ['error'],
+  'unicorn/require-array-join-separator': ['error'],
+  'unicorn/require-number-to-fixed-digits-argument': ['error'],
+  'unicorn/require-post-message-target-origin': ['error'],
+  'unicorn/text-encoding-identifier-case': ['error'],
+  'unicorn/throw-new-error': ['error'],
+};

package/rules/vue.js

@@ -1,14 +1,11 @@
-(() => {
-  'use strict';
-
-  module.exports = {
-    'unicorn/filename-case': [
-      'error', {
-        case: 'pascalCase',
-      },
-    ],
-    'vue/component-name-in-template-casing': [ 'error', 'kebab-case' ],
-    'vue/component-definition-name-casing': [ 'error', 'kebab-case' ],
-    'vue/singleline-html-element-content-newline': 'off',
-  };
-})();
+export default {
+  'unicorn/filename-case': [
+    'error',
+    {
+      case: 'pascalCase',
+    },
+  ],
+  'vue/component-name-in-template-casing': [ 'error', 'kebab-case' ],
+  'vue/component-definition-name-casing': [ 'error', 'kebab-case' ],
+  'vue/singleline-html-element-content-newline': 'off',
+};

package/rules/yaml.js

@@ -1,27 +1,24 @@
-(() => {
-  'use strict';
-
-  module.exports = {
-    'yml/block-sequence': [ 'error', 'always' ],
-    'yml/file-extension': [
-      'error',
-      {
-        extension: 'yaml',
-        caseSensitive: true,
-      },
-    ],
-    'yml/indent': [
-      'error',
-      2,
-      {
-        indentBlockSequences: true,
-      },
-    ],
-    'yml/no-empty-document': ['off'],
-    'yml/quotes': [
-      'error', {
-        prefer: 'single',
-      },
-    ],
-  };
-})();
+export default {
+  'yml/block-sequence': [ 'error', 'always' ],
+  'yml/file-extension': [
+    'error',
+    {
+      extension: 'yaml',
+      caseSensitive: true,
+    },
+  ],
+  'yml/indent': [
+    'error',
+    2,
+    {
+      indentBlockSequences: true,
+    },
+  ],
+  'yml/no-empty-document': ['off'],
+  'yml/quotes': [
+    'error',
+    {
+      prefer: 'single',
+    },
+  ],
+};

package/config/no-use-extend-native.js

@@ -1,13 +0,0 @@
-(() => {
-  'use strict';
-
-  const plugin = require('eslint-plugin-no-use-extend-native');
-
-  module.exports = {
-    name: 'simplesense/no-use-extend-native',
-    plugins: {
-      'no-use-extend-native': plugin,
-    },
-    rules: plugin.configs.recommended.rules,
-  };
-})();