eslint-config-setup 0.4.0 → 0.5.1

package/dist/modules.js

@@ -837,6 +837,8 @@ function prettierCompatConfig() {
 import eslintReactPlugin2 from "@eslint-react/eslint-plugin";
 import stylisticPlugin from "@stylistic/eslint-plugin";
 import jsxA11yPlugin from "eslint-plugin-jsx-a11y";
+import reactHooksPlugin from "eslint-plugin-react-hooks";
+import reactPerfPlugin from "eslint-plugin-react-perf";
 import reactRefreshPlugin from "eslint-plugin-react-refresh";
 import globals2 from "globals";
 
@@ -872,10 +874,6 @@ var LEGACY_ALIASES = {
   "no-array-index-key": [coreRules, "no-array-index-key"],
   "no-children-prop": [jsxRules, "no-children-prop"],
   "no-direct-mutation-state": [coreRules, "no-direct-mutation-state"],
-  "no-redundant-should-component-update": [
-    coreRules,
-    "no-redundant-should-component-update"
-  ],
   "no-unused-class-component-members": [
     coreRules,
     "no-unused-class-component-members"
@@ -898,7 +896,6 @@ var LEGACY_ALIASES = {
   ],
   "display-name": [coreRules, "no-missing-component-display-name"],
   "forward-ref-uses-ref": [coreRules, "no-forward-ref"],
-  "destructuring-assignment": [coreRules, "prefer-destructuring-assignment"],
   "no-did-mount-set-state": [
     coreRules,
     "no-set-state-in-component-did-mount"
@@ -1017,17 +1014,49 @@ var reactCompatPlugin = {
 
 // src/configs/react.ts
 var typedConfigs = eslintReactPlugin2.configs;
-var recommendedRules = typedConfigs.recommended.rules;
-var strictRules = typedConfigs.strict.rules;
-var presetRules = translatePresetRules({ ...recommendedRules, ...strictRules });
+var strictTypeCheckedRules = typedConfigs["strict-type-checked"].rules;
+var REACT_HOOKS_REPLACED_ESLINT_REACT_RULES = [
+  "error-boundaries",
+  "exhaustive-deps",
+  "purity",
+  "rules-of-hooks",
+  "set-state-in-effect",
+  "set-state-in-render",
+  "static-components",
+  "unsupported-syntax",
+  "use-memo"
+];
+var reactHooksReplacedRules = new Set(
+  REACT_HOOKS_REPLACED_ESLINT_REACT_RULES
+);
+function filterReactHooksRules(rules) {
+  const filtered = {};
+  for (const [ruleName, value] of Object.entries(rules)) {
+    const shortName = ruleName.replace(/^@eslint-react\//, "");
+    if (!reactHooksReplacedRules.has(shortName)) {
+      filtered[ruleName] = value;
+    }
+  }
+  return filtered;
+}
+var presetRules = translatePresetRules(filterReactHooksRules(strictTypeCheckedRules));
+var reactHooksRecommendedLatest = reactHooksPlugin.configs.flat["recommended-latest"];
+var reactHooksPluginForEslint = reactHooksPlugin;
 var EXTRA_REACT_RULES = {
-  "react/jsx-no-leaked-render": "error",
   "react/no-duplicate-key": "error",
   "react/no-implicit-key": "error",
-  "react/no-unused-props": "warn",
   "react/no-unknown-property": "error",
   "react/style-prop-object": "error"
 };
+var AI_ADDED_REACT_RULES = {
+  "react/no-unused-state": "error"
+};
+var AI_REACT_PERF_RULES = {
+  "react-perf/jsx-no-jsx-as-prop": "error",
+  "react-perf/jsx-no-new-array-as-prop": "error",
+  "react-perf/jsx-no-new-function-as-prop": "error",
+  "react-perf/jsx-no-new-object-as-prop": "error"
+};
 var JSX_A11Y_ERROR_RULES = {
   "jsx-a11y/alt-text": "error",
   "jsx-a11y/anchor-has-content": "error",
@@ -1059,7 +1088,6 @@ var AI_PROMOTED_REACT_RULES = [
   "react/jsx-no-constructed-context-values",
   "react/no-array-index-key",
   "react/no-object-type-as-default-prop",
-  "react/no-unused-state",
   "react/jsx-no-target-blank",
   "react/button-has-type",
   "react/iframe-missing-sandbox",
@@ -1105,6 +1133,8 @@ function applyAiReactRules(builder) {
   for (const ruleName of AI_PROMOTED_REACT_RULES) {
     builder.overrideSeverity(ruleName, "error");
   }
+  addRules2(builder, AI_ADDED_REACT_RULES);
+  addRules2(builder, AI_REACT_PERF_RULES);
   for (const ruleName of AI_A11Y_RULES) {
     builder.addRule(ruleName, "error");
   }
@@ -1126,10 +1156,13 @@ function reactConfig(opts) {
   const isAi = opts?.ai ?? false;
   const builder = createConfig({
     name: "eslint-config-setup/react",
-    presets: [{ rules: presetRules }],
+    presets: [{ rules: presetRules }, reactHooksRecommendedLatest],
     plugins: {
       react: reactCompatPlugin,
       "@stylistic": stylisticPlugin,
+      "react-hooks": reactHooksPluginForEslint,
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- Plugin from untyped module
+      "react-perf": reactPerfPlugin,
       "react-refresh": reactRefreshPlugin,
       // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- Plugin from untyped module
       "jsx-a11y": jsxA11yPlugin
@@ -1187,12 +1220,12 @@ function reactEffectConfig() {
         // Disallow passing fetched data to parent via effect — fetch in parent instead
         // https://github.com/nickjvandyke/eslint-plugin-react-you-might-not-need-an-effect
         "react-you-might-not-need-an-effect/no-pass-data-to-parent": "error",
-        // Disallow initializing state in an effect — pass initial value to useState
+        // Disallow external-store subscriptions in an effect — use useSyncExternalStore
         // https://github.com/nickjvandyke/eslint-plugin-react-you-might-not-need-an-effect
-        "react-you-might-not-need-an-effect/no-initialize-state": "error",
-        // Disallow empty effects — dead code, remove them
+        "react-you-might-not-need-an-effect/no-external-store-subscription": "error",
+        // Disallow initializing state in an effect — pass initial value to useState
         // https://github.com/nickjvandyke/eslint-plugin-react-you-might-not-need-an-effect
-        "react-you-might-not-need-an-effect/no-empty-effect": "error"
+        "react-you-might-not-need-an-effect/no-initialize-state": "error"
       }
     }
   ];
@@ -1738,7 +1771,8 @@ function unicornConfig(opts) {
               camelCase: true,
               pascalCase: true,
               kebabCase: true
-            }
+            },
+            ignore: ["__tests__"]
           }
         ],
         // Discourage Array.reduce() — hard to read for many developers, prefer for...of or other methods
@@ -1844,7 +1878,7 @@ function unicornConfig(opts) {
         "unicorn/numeric-separators-style": "error",
         // Prefer `export { x } from 'y'` over import then re-export
         // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-export-from.md
-        "unicorn/prefer-export-from": ["error", { ignoreUsedVariables: true }],
+        "unicorn/prefer-export-from": ["error", { checkUsedVariables: false }],
         // Prefer built-in coercion (String, Number, Boolean) over wrapper functions
         // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-native-coercion-functions.md
         "unicorn/prefer-native-coercion-functions": "error",
@@ -1886,10 +1920,9 @@ function unicornConfig(opts) {
     builder.overrideSeverity("unicorn/consistent-function-scoping", "error");
     builder.overrideSeverity("unicorn/no-array-reduce", "error");
     builder.overrideSeverity("unicorn/no-for-loop", "error");
-    builder.addRule("unicorn/no-array-for-each", "error");
+    builder.addRule("unicorn/no-for-each", "error");
     builder.addRule("unicorn/prefer-ternary", ["error", "only-single-line"]);
     builder.addRule("unicorn/prefer-switch", ["error", { minimumCases: 3 }]);
-    builder.addRule("unicorn/prevent-abbreviations", "error");
     builder.addRule("unicorn/no-useless-switch-case", "error");
     builder.addRule("unicorn/custom-error-definition", "error");
     builder.addRule("unicorn/prefer-default-parameters", "error");
@@ -2270,28 +2303,37 @@ function testsOverride() {
 
 // src/oxlint/integration.ts
 import oxlintPlugin from "eslint-plugin-oxlint";
+var typedPlugin = oxlintPlugin;
+function addOxlintConfig(configs, configName, blockName) {
+  const raw = typedPlugin.configs[configName];
+  const items = Array.isArray(raw) ? raw : [raw];
+  for (const [index, item] of items.entries()) {
+    const suffix = items.length > 1 ? `-${index + 1}` : "";
+    configs.push({ ...item, name: `eslint-config-setup/${blockName}${suffix}` });
+  }
+}
+function addReactOxlintConfigs(configs, opts) {
+  if (!opts.react) {
+    return;
+  }
+  addOxlintConfig(configs, "flat/react", "oxlint-react");
+  addOxlintConfig(configs, "flat/jsx-a11y", "oxlint-jsx-a11y");
+  addOxlintConfig(configs, "flat/react-hooks", "oxlint-react-hooks");
+  if (opts.ai) {
+    addOxlintConfig(configs, "flat/react-perf", "oxlint-react-perf");
+  }
+}
 function oxlintIntegration(opts) {
-  const typedPlugin = oxlintPlugin;
   const configs = [];
-  const add = (configName, blockName) => {
-    const raw = typedPlugin.configs[configName];
-    const items = Array.isArray(raw) ? raw : [raw];
-    for (const item of items) {
-      configs.push({ name: `eslint-config-setup/${blockName}`, ...item });
-    }
-  };
-  add("flat/recommended", "oxlint");
-  if (opts.react) {
-    add("flat/react", "oxlint-react");
-    add("flat/jsx-a11y", "oxlint-jsx-a11y");
-  }
+  addOxlintConfig(configs, "flat/recommended", "oxlint");
+  addReactOxlintConfigs(configs, opts);
   if (opts.node) {
-    add("flat/node", "oxlint-node");
+    addOxlintConfig(configs, "flat/node", "oxlint-node");
   }
-  add("flat/typescript", "oxlint-typescript");
-  add("flat/unicorn", "oxlint-unicorn");
-  add("flat/import", "oxlint-import");
-  add("flat/jsdoc", "oxlint-jsdoc");
+  addOxlintConfig(configs, "flat/typescript", "oxlint-typescript");
+  addOxlintConfig(configs, "flat/unicorn", "oxlint-unicorn");
+  addOxlintConfig(configs, "flat/import", "oxlint-import");
+  addOxlintConfig(configs, "flat/jsdoc", "oxlint-jsdoc");
   return configs;
 }