eslint-config-seekingalpha-react 7.49.0 → 9.0.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Change Log
 
+## 9.0.0 - 2025-03-09
+
+- [breaking] migrate to ESM and make flat config default
+
+## 8.0.0 - 2025-03-07
+
+- [new] expose flat config
+
 ## 7.49.0 - 2025-03-01
 
 - [deps] upgrade `eslint-plugin-react-hooks` to version `5.2.0`

package/README.md

@@ -10,26 +10,31 @@ Install ESLint and all [Peer Dependencies](https://nodejs.org/en/blog/npm/peer-d
 
 Install SeekingAlpha shareable ESLint:
 
-    npm install eslint-config-seekingalpha-react --save-dev
+    npm install eslint-config-seekingalpha-react@latest --save-dev
 
 ## Usage
 
-This shareable config includes all ESLint rules including ECMAScript 6 features, set of [legacy rules](https://eslint.org/docs/rules/#deprecated) and additional rules for `React` We also extend our configuration with following plugins:
+This shareable config includes all rules from following plugins:
 
 - [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react)
 - [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y)
 - [eslint-plugin-react-hooks](https://www.npmjs.com/package/eslint-plugin-react-hooks)
 
-If you don't need configuration extended with `React` rules, check out our [base config](https://www.npmjs.com/package/eslint-config-seekingalpha-base).
-
-Simply [extend](https://eslint.org/docs/user-guide/configuring#extending-configuration-files) the relevant .eslintrc.js configuration in your project with `seekingalpha-react` rules:
+Simply [use](https://eslint.org/docs/latest/extend/shareable-configs) the eslint.config.js in your project with the configuration:
 
 ```javascript
-{
-  extends: [
-    'seekingalpha-react'
-  ]
-}
+import reactConfig from 'eslint-config-seekingalpha-react';
+
+export default [
+  {
+    plugins: {
+      ...reactConfig.plugins,
+    },
+    rules: {
+      ...reactConfig.rules,
+    },
+  },
+];
 ```
 
 ## License

package/index.js

@@ -1,22 +1,16 @@
-module.exports = {
-  extends: [
-    // https://github.com/yannickcr/eslint-plugin-react
-    './rules/eslint-plugin-react/index.js',
+import jsxA11yConfig from './rules/eslint-plugin-jsx-a11y/index.js';
+import reactConfig from './rules/eslint-plugin-react/index.js';
+import reactHooksConfig from './rules/eslint-plugin-react-hooks/index.js';
 
-    // https://github.com/evcohen/eslint-plugin-jsx-a11y
-    './rules/eslint-plugin-jsx-a11y/index.js',
-
-    // https://reactjs.org/docs/hooks-rules.html
-    './rules/eslint-plugin-react-hooks/index.js',
-  ],
-
-  parserOptions: {
-    ecmaVersion: 12,
-    sourceType: 'module',
-    ecmaFeatures: {
-      impliedStrict: true,
-      globalReturn: false,
-      jsx: true,
-    },
+export default {
+  plugins: {
+    ...jsxA11yConfig.plugins,
+    ...reactConfig.plugins,
+    ...reactHooksConfig.plugins,
+  },
+  rules: {
+    ...jsxA11yConfig.rules,
+    ...reactConfig.rules,
+    ...reactHooksConfig.rules,
   },
 };

package/package.json

@@ -1,8 +1,9 @@
 {
   "name": "eslint-config-seekingalpha-react",
-  "version": "7.49.0",
+  "version": "9.0.0",
   "description": "SeekingAlpha's sharable React.js ESLint config",
   "main": "index.js",
+  "type": "module",
   "scripts": {
     "eslint-find-rules": "eslint-find-rules -u ./index.js",
     "test": "echo \"Error: no test specified\" && exit 1"

package/rules/config.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   jsxIndent: 2,
   jsxIndentProps: 2,
   jsxMaxDepth: 10,

package/rules/eslint-plugin-jsx-a11y/index.js

@@ -1,8 +1,9 @@
-//
-
-module.exports = {
-  plugins: ['jsx-a11y'],
+import jsxA11y from 'eslint-plugin-jsx-a11y';
 
+export default {
+  plugins: {
+    'jsx-a11y': jsxA11y,
+  },
   rules: {
     // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/alt-text.md
     'jsx-a11y/alt-text': [

package/rules/eslint-plugin-react/index.js

@@ -1,5 +1,14 @@
-module.exports = {
-  plugins: ['react'],
+import reactPlugin from 'eslint-plugin-react';
 
-  extends: ['./react.js', './jsx.js'],
+import jsxConfig from './jsx.js';
+import reactConfig from './react.js';
+
+export default {
+  plugins: {
+    react: reactPlugin,
+  },
+  rules: {
+    ...jsxConfig.rules,
+    ...reactConfig.rules,
+  },
 };

package/rules/eslint-plugin-react/jsx.js

@@ -1,251 +1,242 @@
-const config = require('../config');
+import config from '../config';
 
 // https://github.com/yannickcr/eslint-plugin-react#jsx-specific-rules
-
-module.exports = {
-  rules: {
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md
-    'react/jsx-boolean-value': [
-      'error',
-      'never',
-      {
-        always: [],
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-child-element-spacing.md
-    'react/jsx-child-element-spacing': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-closing-bracket-location.md
-    'react/jsx-closing-bracket-location': [
-      'error',
-      {
-        selfClosing: 'tag-aligned',
-        nonEmpty: 'tag-aligned',
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-closing-tag-location.md
-    'react/jsx-closing-tag-location': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-spacing.md
-    'react/jsx-curly-spacing': [
-      'error',
-      {
-        when: 'never',
-        allowMultiline: true,
-        spacing: {
-          objectLiterals: 'always',
-        },
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-equals-spacing.md
-    'react/jsx-equals-spacing': ['error', 'never'],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md
-    'react/jsx-filename-extension': [
-      'error',
-      {
-        extensions: ['.tsx'],
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-first-prop-new-line.md
-    'react/jsx-first-prop-new-line': ['error', 'multiline-multiprop'],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-fragments.md
-    'react/jsx-fragments': ['error', 'syntax'],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-handler-names.md
-    'react/jsx-handler-names': ['off'],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent.md
-    'react/jsx-indent': ['error', config.jsxIndent],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent-props.md
-    'react/jsx-indent-props': ['error', config.jsxIndentProps],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-key.md
-    'react/jsx-key': [
-      'error',
-      {
-        checkFragmentShorthand: true,
-        checkKeyMustBeforeSpread: true,
-        warnOnDuplicates: true,
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-max-depth.md
-    'react/jsx-max-depth': [
-      'error',
-      {
-        max: config.jsxMaxDepth,
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-max-props-per-line.md
-    'react/jsx-max-props-per-line': [
-      'error',
-      {
-        maximum: config.jsxMaxPropsPerLine,
-        when: 'always',
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-newline.md
-    'react/jsx-newline': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md
-    'react/jsx-no-bind': 'off',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-comment-textnodes.md
-    'react/jsx-no-comment-textnodes': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-constructed-context-values.md
-    'react/jsx-no-constructed-context-values': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-duplicate-props.md
-    'react/jsx-no-duplicate-props': [
-      'error',
-      {
-        ignoreCase: true,
-      },
-    ],
-
-    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-leaked-render.md
-    'react/jsx-no-leaked-render': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-literals.md
-    'react/jsx-no-literals': [
-      'off',
-      {
-        noStrings: true,
-      },
-    ],
-
-    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spread-multi.md
-    'react/jsx-props-no-spread-multi': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md
-    'react/jsx-no-target-blank': [
-      'error',
-      {
-        enforceDynamicLinks: 'always',
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-undef.md
-    'react/jsx-no-undef': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-one-expression-per-line.md
-    'react/jsx-one-expression-per-line': [
-      'error',
-      {
-        allow: 'literal',
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-brace-presence.md
-    'react/jsx-curly-brace-presence': [
-      'error',
-      {
-        props: 'never',
-        children: 'never',
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-pascal-case.md
-    'react/jsx-pascal-case': [
-      'error',
-      {
-        allowAllCaps: false,
-        ignore: [],
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-multi-spaces.md
-    'react/jsx-props-no-multi-spaces': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-default-props.md
-    'react/sort-default-props': 'off',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md
-    'react/jsx-sort-props': [
-      'error',
-      {
-        ignoreCase: true,
-        callbacksLast: true,
-        shorthandFirst: true,
-        shorthandLast: false,
-        noSortAlphabetically: false,
-        reservedFirst: false,
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-tag-spacing.md
-    'react/jsx-tag-spacing': [
-      'error',
-      {
-        closingSlash: 'never',
-        beforeSelfClosing: 'always',
-        afterOpening: 'never',
-        beforeClosing: 'never',
-      },
-    ],
-
-    /*
-     * off after update to 16.4
-     * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-react.md
-     */
-    'react/jsx-uses-react': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-vars.md
-    'react/jsx-uses-vars': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-wrap-multilines.md
-    'react/jsx-wrap-multilines': [
-      'error',
-      {
-        declaration: 'parens-new-line',
-        assignment: 'parens-new-line',
-        return: 'parens-new-line',
-        arrow: 'parens-new-line',
-        condition: 'parens-new-line',
-        logical: 'parens-new-line',
-        prop: 'parens-new-line',
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-danger.md
-    'react/no-danger': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spreading.md
-    'react/jsx-props-no-spreading': 'off',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-read-only-props.md
-    'react/prefer-read-only-props': 'error',
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-newline.md
-    'react/jsx-curly-newline': [
-      'error',
-      {
-        multiline: 'consistent',
-        singleline: 'consistent',
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-useless-fragment.md
-    'react/jsx-no-useless-fragment': [
-      'error',
-      {
-        allowExpressions: true,
-      },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-script-url.md
-    'react/jsx-no-script-url': 'error',
-
-    'react/no-object-type-as-default-prop': 'error',
-  },
+export default {
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md
+  'react/jsx-boolean-value': [
+    'error',
+    'never',
+    {
+      always: [],
+    },
+  ],
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-child-element-spacing.md
+   * Disabled to work with prettier
+   */
+  'react/jsx-child-element-spacing': 'off',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-closing-bracket-location.md
+   * disable to work with prettier
+   */
+  'react/jsx-closing-bracket-location': 'off',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-closing-tag-location.md
+   * disable to work with prettier
+   */
+  'react/jsx-closing-tag-location': 'off',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-spacing.md
+   * disable to work with prettier
+   */
+  'react/jsx-curly-spacing': 'off',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-equals-spacing.md
+   * disable to work with prettier
+   */
+  'react/jsx-equals-spacing': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md
+  'react/jsx-filename-extension': [
+    'error',
+    {
+      extensions: ['.tsx'],
+    },
+  ],
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-first-prop-new-line.md
+   * disable to work with prettier
+   */
+  'react/jsx-first-prop-new-line': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-fragments.md
+  'react/jsx-fragments': ['error', 'syntax'],
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-handler-names.md
+  'react/jsx-handler-names': 'off',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent.md
+   * disable to work with prettier
+   */
+  'react/jsx-indent': 'off',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent-props.md
+   * disable ti work with prettier
+   */
+  'react/jsx-indent-props': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-key.md
+  'react/jsx-key': [
+    'error',
+    {
+      checkFragmentShorthand: true,
+      checkKeyMustBeforeSpread: true,
+      warnOnDuplicates: true,
+    },
+  ],
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-max-depth.md
+  'react/jsx-max-depth': [
+    'error',
+    {
+      max: config.jsxMaxDepth,
+    },
+  ],
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-max-props-per-line.md
+   * disable to work with prettier
+   */
+  'react/jsx-max-props-per-line': 'off',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-newline.md
+   * disable to work with prettier
+   */
+  'react/jsx-newline': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md
+  'react/jsx-no-bind': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-comment-textnodes.md
+  'react/jsx-no-comment-textnodes': 'error',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-constructed-context-values.md
+  'react/jsx-no-constructed-context-values': 'error',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-duplicate-props.md
+  'react/jsx-no-duplicate-props': [
+    'error',
+    {
+      ignoreCase: true,
+    },
+  ],
+
+  // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-leaked-render.md
+  'react/jsx-no-leaked-render': 'error',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-literals.md
+  'react/jsx-no-literals': [
+    'off',
+    {
+      noStrings: true,
+    },
+  ],
+
+  // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spread-multi.md
+  'react/jsx-props-no-spread-multi': 'error',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md
+  'react/jsx-no-target-blank': [
+    'error',
+    {
+      enforceDynamicLinks: 'always',
+    },
+  ],
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-undef.md
+  'react/jsx-no-undef': 'error',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-one-expression-per-line.md
+   * disable to worl with prettier
+   */
+  'react/jsx-one-expression-per-line': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-brace-presence.md
+  'react/jsx-curly-brace-presence': [
+    'error',
+    {
+      props: 'never',
+      children: 'never',
+    },
+  ],
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-pascal-case.md
+  'react/jsx-pascal-case': [
+    'error',
+    {
+      allowAllCaps: false,
+      ignore: [],
+    },
+  ],
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-multi-spaces.md
+   * disable to work with prettier
+   */
+  'react/jsx-props-no-multi-spaces': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-default-props.md
+  'react/sort-default-props': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md
+  'react/jsx-sort-props': [
+    'error',
+    {
+      ignoreCase: true,
+      callbacksLast: true,
+      shorthandFirst: true,
+      shorthandLast: false,
+      noSortAlphabetically: false,
+      reservedFirst: false,
+    },
+  ],
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-tag-spacing.md
+   * disable to work with prettier
+   */
+  'react/jsx-tag-spacing': 'off',
+
+  /*
+   * off after update to 16.4
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-react.md
+   */
+  'react/jsx-uses-react': 'error',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-vars.md
+  'react/jsx-uses-vars': 'error',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-wrap-multilines.md
+   * disable to work with prettier
+   */
+  'react/jsx-wrap-multilines': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-danger.md
+  'react/no-danger': 'error',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spreading.md
+  'react/jsx-props-no-spreading': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-read-only-props.md
+  'react/prefer-read-only-props': 'error',
+
+  /*
+   * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-newline.md
+   * disable to work with prettier
+   */
+  'react/jsx-curly-newline': 'off',
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-useless-fragment.md
+  'react/jsx-no-useless-fragment': [
+    'error',
+    {
+      allowExpressions: true,
+    },
+  ],
+
+  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-script-url.md
+  'react/jsx-no-script-url': 'error',
+
+  'react/no-object-type-as-default-prop': 'error',
 };