eslint-config-seekingalpha-react 5.1.0 → 5.5.0

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Change Log
 
+## 5.5.0 - 2021-01-16
+  - [breaking] separate `eslint-plugin-jest` plugin to `eslint-config-seekingalpha-tests` sharable config
+
+## 5.4.0 - 2021-01-16
+  - [deps] upgrade `eslint` to version `8.6.0`
+  - [deps] upgrade `eslint-plugin-jest` to version `25.3.4`
+  - [breaking] enable `jest/prefer-comparison-matcher` rule
+  - [breaking] enable `jest/prefer-equality-matcher` rule
+
+## 5.3.0 - 2021-01-06
+  - [deps] update `eslint-find-rules` to version `4.1.0`
+
+## 5.2.0 - 2021-01-01
+  - [deps] upgrade `eslint` to version `8.6.0`
+  - [deps] upgrade `eslint-plugin-jest` to version `25.3.4`
+
 ## 5.1.0 - 2021-12-23
   - [deps] upgrade `eslint-plugin-react` to version `7.28.0`
 

package/README.md

@@ -6,7 +6,7 @@ This package includes the shareable ESLint config used by [SeekingAlpha](https:/
 
 Install ESLint and all [Peer Dependencies](https://nodejs.org/en/blog/npm/peer-dependencies/):
 
-    npm install eslint@8.5.0 eslint-plugin-flowtype@8.0.3 eslint-plugin-jest@25.3.0 eslint-plugin-jsx-a11y@6.5.1 eslint-plugin-react@7.28.0 eslint-plugin-react-hooks@4.3.0 --save-dev
+    npm install eslint@8.7.0 eslint-plugin-flowtype@8.0.3 eslint-plugin-jsx-a11y@6.5.1 eslint-plugin-react@7.28.0 eslint-plugin-react-hooks@4.3.0 --save-dev
 
 Install SeekingAlpha shareable ESLint:
 
@@ -19,7 +19,6 @@ This shareable config includes all ESLint rules including ECMAScript 6 features,
 * [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react)
 * [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y)
 * [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype)
-* [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest)
 * [eslint-plugin-react-hooks](https://www.npmjs.com/package/eslint-plugin-react-hooks)
 
 If you don't need configuration extended with `React` rules, check out our [base config](https://www.npmjs.com/package/eslint-config-seekingalpha-base).

package/index.js

@@ -14,9 +14,6 @@ module.exports = {
     // https://github.com/gajus/eslint-plugin-flowtype
     './rules/eslint-plugin-flowtype/index.js',
 
-    // https://github.com/jest-community/eslint-plugin-jest
-    './rules/eslint-plugin-jest/index.js',
-
     // https://reactjs.org/docs/hooks-rules.html
     './rules/eslint-plugin-react-hooks/index.js',
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-seekingalpha-react",
-  "version": "5.1.0",
+  "version": "5.5.0",
   "description": "SeekingAlpha's sharable React.js ESLint config",
   "main": "index.js",
   "scripts": {
@@ -49,18 +49,16 @@
     "node": ">= 14"
   },
   "peerDependencies": {
-    "eslint": "8.5.0",
+    "eslint": "8.7.0",
     "eslint-plugin-flowtype": "8.0.3",
-    "eslint-plugin-jest": "25.3.0",
     "eslint-plugin-jsx-a11y": "6.5.1",
     "eslint-plugin-react": "7.28.0",
     "eslint-plugin-react-hooks": "4.3.0"
   },
   "devDependencies": {
-    "eslint": "8.5.0",
-    "eslint-find-rules": "4.0.0",
+    "eslint": "8.7.0",
+    "eslint-find-rules": "4.1.0",
     "eslint-plugin-flowtype": "8.0.3",
-    "eslint-plugin-jest": "25.3.0",
     "eslint-plugin-jsx-a11y": "6.5.1",
     "eslint-plugin-react": "7.28.0",
     "eslint-plugin-react-hooks": "4.3.0"

package/rules/eslint-plugin-flowtype/index.js

@@ -46,6 +46,12 @@ module.exports = {
       'never',
     ],
 
+    // https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-interface-id-match
+    'flowtype/interface-id-match': [
+      'error',
+      '^I([A-Z][a-z0-9]*)+',
+    ],
+
     // https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-newline-after-flow-annotation
     'flowtype/newline-after-flow-annotation': [
       'error',
@@ -55,6 +61,9 @@ module.exports = {
     // https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-no-dupe-keys
     'flowtype/no-dupe-keys': 'error',
 
+    // https://github.com/gajus/eslint-plugin-flowtype#no-duplicate-type-union-intersection-members
+    'flowtype/no-duplicate-type-union-intersection-members': 'error',
+
     /*
      * https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-no-existential-type
      * should be disabled to support recompose flow types
@@ -160,6 +169,9 @@ module.exports = {
     // https://github.com/gajus/eslint-plugin-flowtype#sort-keys
     'flowtype/sort-keys': 'off',
 
+    // https://github.com/gajus/eslint-plugin-flowtype#sort-type-union-intersection-members
+    'flowtype/sort-type-union-intersection-members': 'off',
+
     // https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype-rules-space-after-type-colon
     'flowtype/space-after-type-colon': [
       'error',

package/rules/eslint-plugin-react/react.js

@@ -165,6 +165,9 @@ module.exports = {
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-array-index-key.md
     'react/no-array-index-key': 'error',
 
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-arrow-function-lifecycle.md
+    'react/no-arrow-function-lifecycle': 'error',
+
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-children-prop.md
     'react/no-children-prop': 'error',
 
@@ -186,6 +189,9 @@ module.exports = {
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-find-dom-node.md
     'react/no-find-dom-node': 'error',
 
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-invalid-html-attribute.md
+    'react/no-invalid-html-attribute': 'error',
+
     /*
      * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-is-mounted.md
      * https://reactjs.org/blog/2015/12/16/ismounted-antipattern.html
@@ -234,6 +240,12 @@ module.exports = {
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unsafe.md
     'react/no-unsafe': 'error',
 
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unstable-nested-components.md
+    'react/no-unstable-nested-components': 'error',
+
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unused-class-component-methods.md
+    'react/no-unused-class-component-methods': 'error',
+
     /*
      * no prop types usage
      * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unused-prop-types.md

package/rules/eslint-plugin-jest/index.js

@@ -1,154 +0,0 @@
-module.exports = {
-
-  plugins: ['jest'],
-
-  rules: {
-    // Jest Plugin https://github.com/jest-community/eslint-plugin-jest
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/consistent-test-it.md
-    'jest/consistent-test-it': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/expect-expect.md
-    'jest/expect-expect': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-lowercase-title.md
-    'jest/prefer-lowercase-title': 'off',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/max-nested-describe.md
-    'jest/max-nested-describe': [
-      'error',
-      {
-        max: 2,
-      },
-    ],
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/HEAD/docs/rules/no-alias-methods.md
-    'jest/no-alias-methods': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-commented-out-tests.md
-    'jest/no-commented-out-tests': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-conditional-expect.md
-    'jest/no-conditional-expect': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-deprecated-functions.md
-    'jest/no-deprecated-functions': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-disabled-tests.md
-    'jest/no-disabled-tests': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-duplicate-hooks.md
-    'jest/no-duplicate-hooks': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-export.md
-    'jest/no-export': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-focused-tests.md
-    'jest/no-focused-tests': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-hooks.md
-    'jest/no-hooks': 'off',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-identical-title.md
-    'jest/no-identical-title': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-if.md
-    'jest/no-if': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-interpolation-in-snapshots.md
-    'jest/no-interpolation-in-snapshots': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-jasmine-globals.md
-    'jest/no-jasmine-globals': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-jest-import.md
-    'jest/no-jest-import': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-large-snapshots.md
-    'jest/no-large-snapshots': [
-      'error',
-      {
-        maxSize: 50,
-      },
-    ],
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-mocks-import.md
-    'jest/no-mocks-import': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-restricted-matchers.md
-    'jest/no-restricted-matchers': [
-      'error',
-      {
-        toBeFalsy: 'Use `toBe(false)` instead.',
-        toBeTruthy: 'Use `toBe(true)` instead.',
-      },
-    ],
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-standalone-expect.md
-    'jest/no-standalone-expect': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/HEAD/docs/rules/no-test-callback.md
-    'jest/no-done-callback': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-test-prefixes.md
-    'jest/no-test-prefixes': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-test-return-statement.md
-    'jest/no-test-return-statement': 'off',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-called-with.md
-    'jest/prefer-called-with': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-expect-assertions.md
-    'jest/prefer-expect-assertions': 'off',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-expect-resolves.md
-    'jest/prefer-expect-resolves': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-hooks-on-top.md
-    'jest/prefer-hooks-on-top': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/HEAD/docs/rules/prefer-spy-on.md
-    'jest/prefer-spy-on': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-strict-equal.md
-    'jest/prefer-strict-equal': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-to-be.md
-    'jest/prefer-to-be': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/HEAD/docs/rules/prefer-to-contain.md
-    'jest/prefer-to-contain': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-to-have-length.md
-    'jest/prefer-to-have-length': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/HEAD/docs/rules/prefer-todo.md
-    'jest/prefer-todo': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/HEAD/docs/rules/require-tothrow-message.md
-    'jest/require-to-throw-message': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/require-top-level-describe.md
-    'jest/require-top-level-describe': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/valid-describe-callback.md
-    'jest/valid-describe-callback': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/valid-expect.md
-    'jest/valid-expect': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/valid-expect-in-promise.md
-    'jest/valid-expect-in-promise': 'error',
-
-    // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/valid-title.md
-    'jest/valid-title': 'error',
-
-    /*
-     * only relevant for TypeScript
-     * https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/unbound-method.md
-     */
-    'jest/unbound-method': 'off',
-  },
-
-};