eslint-config-seekingalpha-base 9.1.0 → 11.0.0

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Change Log
 
+## 11.0.0 - 2025-03-09
+
+- [deps] update `eslint` to version `9.22.0`
+- [breaking] enable `unicorn/prefer-math-min-max` rule
+- [breaking] enable `no-useless-assignment` rule
+
+## 10.0.0 - 2025-03-09
+
+- [breaking] migrate to ESM and make flat config default
+
 ## 9.1.0 - 2025-03-06
 
 - [deps] update `eslint-plugin-array-func` to version `5.0.2`

package/README.md

@@ -6,36 +6,39 @@ This package includes the shareable ESLint config used by [SeekingAlpha](https:/
 
 Install ESLint and all [Peer Dependencies](https://nodejs.org/en/blog/npm/peer-dependencies/):
 
-    npm install eslint@8.57.1 eslint-plugin-array-func@5.0.2 eslint-plugin-import@2.31.0 eslint-plugin-promise@7.2.1 eslint-plugin-unicorn@56.0.1 --save-dev
+    npm install eslint@9.22.0 eslint-plugin-array-func@5.0.2 eslint-plugin-import@2.31.0 eslint-plugin-promise@7.2.1 eslint-plugin-unicorn@56.0.1 --save-dev
 
 Install SeekingAlpha shareable ESLint:
 
-    npm install eslint-config-seekingalpha-base --save-dev
+    npm install eslint-config-seekingalpha-base@latest --save-dev
 
 ## Usage
 
-This shareable config includes all ESLint rules including ECMAScript 6 features and set of [legacy rules](https://eslint.org/docs/rules/#deprecated). We also extend our configuration with following plugins:
+This shareable config includes all ESLint rules. We also extend our configuration with following plugins:
 
 - [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import)
 - [eslint-plugin-array-func](https://github.com/freaktechnik/eslint-plugin-array-func)
 - [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise)
 - [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn)
 
-We expose three configurations:
-
-- `seekingalpha-base` - exports all avaliable ESLint [rules](https://eslint.org/docs/rules/) and all rules of plugins above.
-- `seekingalpha-base/browser` - exports only browser related rules for ESLint and mentioned plugins. It also sets `browser` as [default environment](https://eslint.org/docs/user-guide/configuring#specifying-environments).
-- `seekingalpha-base/node` - exports only Node.js related rules for ESLint and mentioned plugins. It also sets `node` as [default environment](https://eslint.org/docs/user-guide/configuring#specifying-environments).
-
-Simply [extend](https://eslint.org/docs/user-guide/configuring#extending-configuration-files) the .eslintrc.js in your project with relevant configuration:
+Simply [use](https://eslint.org/docs/latest/extend/shareable-configs) the eslint.config.js in your project with the configuration:
 
 ```javascript
-// for seekingalpha-base
-{
-  extends: [
-    'seekingalpha-base'
-  ]
-}
+import baseConfig from 'eslint-config-seekingalpha-base';
+
+export default [
+  {
+    plugins: {
+      ...baseConfig.plugins,
+    },
+    rules: {
+      ...baseConfig.rules,
+    },
+    settings: {
+      ...baseConfig.settings,
+    },
+  },
+];
 ```
 
 ## License

package/index.js

@@ -1,27 +1,24 @@
-module.exports = {
-  extends: [
-    // ESLint rules (https://eslint.org/docs/rules/)
-    './rules/eslint/index.js',
+import esLintConfig from './rules/eslint/index.js';
+import esLintPluginArrayFuncConfig from './rules/eslint-plugin-array-func/index.js';
+import esLintPluginImport from './rules/eslint-plugin-import/index.js';
+import esLintPluginPromise from './rules/eslint-plugin-promise/index.js';
+import esLintPluginUnicorn from './rules/eslint-plugin-unicorn/index.js';
 
-    // eslint-plugin-import rules (https://github.com/benmosher/eslint-plugin-import)
-    './rules/eslint-plugin-import/index.js',
-
-    // eslint-plugin-array-func rules (https://github.com/freaktechnik/eslint-plugin-array-func)
-    './rules/eslint-plugin-array-func/index.js',
-
-    // eslint-plugin-promise rules (https://github.com/xjamundx/eslint-plugin-promise)
-    './rules/eslint-plugin-promise/index.js',
-
-    // eslint-plugin-unicorn rules (https://github.com/sindresorhus/eslint-plugin-unicorn)
-    './rules/eslint-plugin-unicorn/index.js',
-  ],
-
-  parserOptions: {
-    ecmaVersion: 12,
-    sourceType: 'module',
-    ecmaFeatures: {
-      impliedStrict: true,
-      globalReturn: false,
-    },
+export default {
+  plugins: {
+    ...esLintPluginArrayFuncConfig.plugins,
+    ...esLintPluginImport.plugins,
+    ...esLintPluginPromise.plugins,
+    ...esLintPluginUnicorn.plugins,
+  },
+  rules: {
+    ...esLintConfig.rules,
+    ...esLintPluginArrayFuncConfig.rules,
+    ...esLintPluginImport.rules,
+    ...esLintPluginPromise.rules,
+    ...esLintPluginUnicorn.rules,
+  },
+  settings: {
+    ...esLintPluginImport.settings,
   },
 };

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "eslint-config-seekingalpha-base",
-  "version": "9.1.0",
+  "version": "11.0.0",
   "description": "SeekingAlpha's sharable base ESLint config",
   "main": "index.js",
+  "type": "module",
   "scripts": {
-    "eslint-find-rules": "eslint-find-rules -u ./index.js",
-    "lint": "eslint --ext .js .",
+    "eslint-find-rules": "eslint-find-rules --flatConfig -u ./index.js",
     "test": "echo \"Error: no test specified\" && exit 1"
   },
   "repository": {
@@ -48,14 +48,14 @@
     "node": ">= 22"
   },
   "peerDependencies": {
-    "eslint": "8.57.1",
+    "eslint": "9.22.0",
     "eslint-plugin-array-func": "5.0.2",
     "eslint-plugin-import": "2.31.0",
     "eslint-plugin-promise": "7.2.1",
     "eslint-plugin-unicorn": "56.0.1"
   },
   "devDependencies": {
-    "eslint": "8.57.1",
+    "eslint": "9.22.0",
     "eslint-find-rules": "5.0.0",
     "eslint-plugin-array-func": "5.0.2",
     "eslint-plugin-import": "2.31.0",

package/rules/config.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   complexity: 10,
   maxClassesPerFile: 1,
   arrayElementNewlineMinItems: 5,

package/rules/eslint/index.js

@@ -1,7 +1,11 @@
-module.exports = {
-  extends: [
-    './possible-problems.js',
-    './suggestions.js',
-    './layout-and-formatting.js',
-  ],
+import layout from './layout-and-formatting.js';
+import problems from './possible-problems.js';
+import suggestions from './suggestions.js';
+
+export default {
+  rules: {
+    ...layout,
+    ...problems,
+    ...suggestions,
+  },
 };

package/rules/eslint/layout-and-formatting.js

@@ -1,21 +1,8 @@
-module.exports = {
-  // https://eslint.org/docs/rules/#layout-formatting
-
-  rules: {
-    // https://eslint.org/docs/rules/line-comment-position
-    'line-comment-position': [
-      'error',
-      {
-        position: 'above',
-        ignorePattern: '',
-        applyDefaultPatterns: true,
-      },
-    ],
-
-    /*
-     * https://eslint.org/docs/rules/unicode-bom
-     * disabled to work with prettier
-     */
-    'unicode-bom': 'off',
-  },
+// https://eslint.org/docs/rules/#layout-formatting
+export default {
+  /*
+   * https://eslint.org/docs/rules/unicode-bom
+   * disabled to work with prettier
+   */
+  'unicode-bom': 'off',
 };

package/rules/eslint/possible-problems.js

@@ -1,223 +1,223 @@
-module.exports = {
-  // https://eslint.org/docs/rules/#possible-problems
+// https://eslint.org/docs/rules/#possible-problems
+export default {
+  // https://eslint.org/docs/rules/array-callback-return
+  'array-callback-return': 'error',
 
-  rules: {
-    // https://eslint.org/docs/rules/array-callback-return
-    'array-callback-return': 'error',
+  // https://eslint.org/docs/rules/constructor-super
+  'constructor-super': 'error',
 
-    // https://eslint.org/docs/rules/constructor-super
-    'constructor-super': 'error',
+  // https://eslint.org/docs/rules/for-direction
+  'for-direction': 'error',
 
-    // https://eslint.org/docs/rules/for-direction
-    'for-direction': 'error',
+  // https://eslint.org/docs/rules/getter-return
+  'getter-return': [
+    'error',
+    {
+      allowImplicit: false,
+    },
+  ],
 
-    // https://eslint.org/docs/rules/getter-return
-    'getter-return': [
-      'error',
-      {
-        allowImplicit: false,
-      },
-    ],
+  // https://eslint.org/docs/rules/no-async-promise-executor
+  'no-async-promise-executor': 'error',
 
-    // https://eslint.org/docs/rules/no-async-promise-executor
-    'no-async-promise-executor': 'error',
+  // https://eslint.org/docs/rules/no-await-in-loop
+  'no-await-in-loop': 'error',
 
-    // https://eslint.org/docs/rules/no-await-in-loop
-    'no-await-in-loop': 'error',
+  // https://eslint.org/docs/rules/no-class-assign
+  'no-class-assign': 'error',
 
-    // https://eslint.org/docs/rules/no-class-assign
-    'no-class-assign': 'error',
+  // https://eslint.org/docs/rules/no-compare-neg-zero
+  'no-compare-neg-zero': 'error',
 
-    // https://eslint.org/docs/rules/no-compare-neg-zero
-    'no-compare-neg-zero': 'error',
+  // https://eslint.org/docs/rules/no-cond-assign
+  'no-cond-assign': 'error',
 
-    // https://eslint.org/docs/rules/no-cond-assign
-    'no-cond-assign': 'error',
+  // https://eslint.org/docs/rules/no-const-assign
+  'no-const-assign': 'error',
 
-    // https://eslint.org/docs/rules/no-const-assign
-    'no-const-assign': 'error',
+  // https://eslint.org/docs/rules/no-constant-binary-expression
+  'no-constant-binary-expression': 'error',
 
-    // https://eslint.org/docs/rules/no-constant-binary-expression
-    'no-constant-binary-expression': 'error',
+  // https://eslint.org/docs/rules/no-constant-condition
+  'no-constant-condition': 'error',
 
-    // https://eslint.org/docs/rules/no-constant-condition
-    'no-constant-condition': 'error',
+  // https://eslint.org/docs/rules/no-constructor-return
+  'no-constructor-return': 'error',
 
-    // https://eslint.org/docs/rules/no-constructor-return
-    'no-constructor-return': 'error',
+  // https://eslint.org/docs/rules/no-control-regex
+  'no-control-regex': 'error',
 
-    // https://eslint.org/docs/rules/no-control-regex
-    'no-control-regex': 'error',
+  // https://eslint.org/docs/rules/no-debugger
+  'no-debugger': 'error',
 
-    // https://eslint.org/docs/rules/no-debugger
-    'no-debugger': 'error',
+  // https://eslint.org/docs/rules/no-dupe-args
+  'no-dupe-args': 'error',
 
-    // https://eslint.org/docs/rules/no-dupe-args
-    'no-dupe-args': 'error',
+  // https://eslint.org/docs/rules/no-dupe-class-members
+  'no-dupe-class-members': 'error',
 
-    // https://eslint.org/docs/rules/no-dupe-class-members
-    'no-dupe-class-members': 'error',
+  // https://eslint.org/docs/rules/no-dupe-else-if
+  'no-dupe-else-if': 'error',
 
-    // https://eslint.org/docs/rules/no-dupe-else-if
-    'no-dupe-else-if': 'error',
+  // https://eslint.org/docs/rules/no-dupe-keys
+  'no-dupe-keys': 'error',
 
-    // https://eslint.org/docs/rules/no-dupe-keys
-    'no-dupe-keys': 'error',
+  // https://eslint.org/docs/rules/no-duplicate-case
+  'no-duplicate-case': 'error',
 
-    // https://eslint.org/docs/rules/no-duplicate-case
-    'no-duplicate-case': 'error',
+  // https://eslint.org/docs/rules/no-duplicate-imports
+  'no-duplicate-imports': 'off',
 
-    // https://eslint.org/docs/rules/no-duplicate-imports
-    'no-duplicate-imports': 'off',
+  // https://eslint.org/docs/rules/no-empty-character-class
+  'no-empty-character-class': 'error',
 
-    // https://eslint.org/docs/rules/no-empty-character-class
-    'no-empty-character-class': 'error',
+  // https://eslint.org/docs/rules/no-empty-pattern
+  'no-empty-pattern': 'error',
 
-    // https://eslint.org/docs/rules/no-empty-pattern
-    'no-empty-pattern': 'error',
+  /*
+   * https://eslint.org/docs/rules/no-ex-assign
+   * https://bocoup.com/blog/the-catch-with-try-catch
+   */
+  'no-ex-assign': 'error',
 
-    /*
-     * https://eslint.org/docs/rules/no-ex-assign
-     * https://bocoup.com/blog/the-catch-with-try-catch
-     */
-    'no-ex-assign': 'error',
+  // https://eslint.org/docs/rules/no-fallthrough
+  'no-fallthrough': 'error',
 
-    // https://eslint.org/docs/rules/no-fallthrough
-    'no-fallthrough': 'error',
+  // https://eslint.org/docs/rules/no-func-assign
+  'no-func-assign': 'error',
 
-    // https://eslint.org/docs/rules/no-func-assign
-    'no-func-assign': 'error',
+  // https://eslint.org/docs/rules/no-import-assign
+  'no-import-assign': 'error',
 
-    // https://eslint.org/docs/rules/no-import-assign
-    'no-import-assign': 'error',
+  // https://eslint.org/docs/rules/no-inner-declarations
+  'no-inner-declarations': 'error',
 
-    // https://eslint.org/docs/rules/no-inner-declarations
-    'no-inner-declarations': 'error',
+  // https://eslint.org/docs/rules/no-invalid-regexp
+  'no-invalid-regexp': 'error',
 
-    // https://eslint.org/docs/rules/no-invalid-regexp
-    'no-invalid-regexp': 'error',
+  // https://eslint.org/docs/rules/no-irregular-whitespace
+  'no-irregular-whitespace': 'error',
 
-    // https://eslint.org/docs/rules/no-irregular-whitespace
-    'no-irregular-whitespace': 'error',
+  // https://eslint.org/docs/rules/no-loss-of-precision
+  'no-loss-of-precision': 'error',
 
-    // https://eslint.org/docs/rules/no-loss-of-precision
-    'no-loss-of-precision': 'error',
+  // https://eslint.org/docs/rules/no-misleading-character-class
+  'no-misleading-character-class': 'error',
 
-    // https://eslint.org/docs/rules/no-misleading-character-class
-    'no-misleading-character-class': 'error',
+  // https://eslint.org/docs/latest/rules/no-new-native-nonconstructor
+  'no-new-native-nonconstructor': 'error',
 
-    // https://eslint.org/docs/latest/rules/no-new-native-nonconstructor
-    'no-new-native-nonconstructor': 'error',
+  // https://eslint.org/docs/rules/no-new-symbol
+  'no-new-symbol': 'error',
 
-    // https://eslint.org/docs/rules/no-new-symbol
-    'no-new-symbol': 'error',
+  // https://eslint.org/docs/rules/no-obj-calls
+  'no-obj-calls': 'error',
 
-    // https://eslint.org/docs/rules/no-obj-calls
-    'no-obj-calls': 'error',
+  // https://eslint.org/docs/rules/no-promise-executor-return
+  'no-promise-executor-return': 'error',
 
-    // https://eslint.org/docs/rules/no-promise-executor-return
-    'no-promise-executor-return': 'error',
+  // https://eslint.org/docs/rules/no-prototype-builtins
+  'no-prototype-builtins': 'error',
 
-    // https://eslint.org/docs/rules/no-prototype-builtins
-    'no-prototype-builtins': 'error',
+  // https://eslint.org/docs/rules/no-self-assign
+  'no-self-assign': [
+    'error',
+    {
+      props: false,
+    },
+  ],
 
-    // https://eslint.org/docs/rules/no-self-assign
-    'no-self-assign': [
-      'error',
-      {
-        props: false,
-      },
-    ],
+  // https://eslint.org/docs/rules/no-self-compare
+  'no-self-compare': 'error',
 
-    // https://eslint.org/docs/rules/no-self-compare
-    'no-self-compare': 'error',
+  // https://eslint.org/docs/rules/no-setter-return
+  'no-setter-return': 'error',
 
-    // https://eslint.org/docs/rules/no-setter-return
-    'no-setter-return': 'error',
+  /*
+   * https://eslint.org/docs/rules/no-sparse-arrays
+   * https://humanwhocodes.com/blog/2007/09/09/inconsistent-array-literals/
+   */
+  'no-sparse-arrays': 'error',
 
-    /*
-     * https://eslint.org/docs/rules/no-sparse-arrays
-     * https://humanwhocodes.com/blog/2007/09/09/inconsistent-array-literals/
-     */
-    'no-sparse-arrays': 'error',
+  // https://eslint.org/docs/rules/no-template-curly-in-string
+  'no-template-curly-in-string': 'error',
 
-    // https://eslint.org/docs/rules/no-template-curly-in-string
-    'no-template-curly-in-string': 'error',
+  // https://eslint.org/docs/rules/no-this-before-super
+  'no-this-before-super': 'error',
 
-    // https://eslint.org/docs/rules/no-this-before-super
-    'no-this-before-super': 'error',
+  // https://eslint.org/docs/rules/no-undef
+  'no-undef': 'error',
 
-    // https://eslint.org/docs/rules/no-undef
-    'no-undef': 'error',
+  // https://eslint.org/docs/rules/no-unexpected-multiline
+  'no-unexpected-multiline': 'error',
 
-    // https://eslint.org/docs/rules/no-unexpected-multiline
-    'no-unexpected-multiline': 'error',
+  // https://eslint.org/docs/rules/no-unmodified-loop-condition
+  'no-unmodified-loop-condition': 'error',
 
-    // https://eslint.org/docs/rules/no-unmodified-loop-condition
-    'no-unmodified-loop-condition': 'error',
+  // https://eslint.org/docs/rules/no-unreachable
+  'no-unreachable': 'error',
 
-    // https://eslint.org/docs/rules/no-unreachable
-    'no-unreachable': 'error',
+  // https://eslint.org/docs/rules/no-unreachable-loop
+  'no-unreachable-loop': 'error',
 
-    // https://eslint.org/docs/rules/no-unreachable-loop
-    'no-unreachable-loop': 'error',
+  // https://eslint.org/docs/rules/no-unsafe-finally
+  'no-unsafe-finally': 'error',
 
-    // https://eslint.org/docs/rules/no-unsafe-finally
-    'no-unsafe-finally': 'error',
-
-    // https://eslint.org/docs/rules/no-unsafe-negation
-    'no-unsafe-negation': 'error',
-
-    // https://eslint.org/docs/rules/no-unsafe-optional-chaining
-    'no-unsafe-optional-chaining': [
-      'error',
-      {
-        disallowArithmeticOperators: true,
-      },
-    ],
-
-    // https://eslint.org/docs/rules/no-unused-private-class-members
-    'no-unused-private-class-members': 'error',
-
-    // https://eslint.org/docs/rules/no-unused-vars
-    'no-unused-vars': [
-      'error',
-      {
-        args: 'after-used',
-        argsIgnorePattern: '[iI]gnored',
-        caughtErrors: 'all',
-        caughtErrorsIgnorePattern: '[iI]gnored',
-        ignoreRestSiblings: false,
-        vars: 'all',
-        varsIgnorePattern: '[iI]gnored',
-      },
-    ],
-
-    // https://eslint.org/docs/rules/no-use-before-define
-    'no-use-before-define': [
-      'error',
-      {
-        functions: true,
-        classes: true,
-        variables: true,
-      },
-    ],
-
-    // https://eslint.org/docs/rules/no-useless-backreference
-    'no-useless-backreference': 'error',
-
-    // https://eslint.org/docs/rules/require-atomic-updates
-    'require-atomic-updates': 'error',
-
-    // https://eslint.org/docs/rules/use-isnan
-    'use-isnan': 'error',
-
-    // https://eslint.org/docs/rules/valid-typeof
-    'valid-typeof': [
-      'error',
-      {
-        requireStringLiterals: true,
-      },
-    ],
-  },
+  // https://eslint.org/docs/rules/no-unsafe-negation
+  'no-unsafe-negation': 'error',
+
+  // https://eslint.org/docs/rules/no-unsafe-optional-chaining
+  'no-unsafe-optional-chaining': [
+    'error',
+    {
+      disallowArithmeticOperators: true,
+    },
+  ],
+
+  // https://eslint.org/docs/rules/no-unused-private-class-members
+  'no-unused-private-class-members': 'error',
+
+  // https://eslint.org/docs/rules/no-unused-vars
+  'no-unused-vars': [
+    'error',
+    {
+      args: 'after-used',
+      argsIgnorePattern: '[iI]gnored',
+      caughtErrors: 'all',
+      caughtErrorsIgnorePattern: '[iI]gnored',
+      ignoreRestSiblings: false,
+      vars: 'all',
+      varsIgnorePattern: '[iI]gnored',
+    },
+  ],
+
+  // https://eslint.org/docs/rules/no-use-before-define
+  'no-use-before-define': [
+    'error',
+    {
+      functions: true,
+      classes: true,
+      variables: true,
+    },
+  ],
+
+  // https://eslint.org/docs/latest/rules/no-useless-assignment
+  'no-useless-assignment': 'error',
+
+  // https://eslint.org/docs/rules/no-useless-backreference
+  'no-useless-backreference': 'error',
+
+  // https://eslint.org/docs/rules/require-atomic-updates
+  'require-atomic-updates': 'error',
+
+  // https://eslint.org/docs/rules/use-isnan
+  'use-isnan': 'error',
+
+  // https://eslint.org/docs/rules/valid-typeof
+  'valid-typeof': [
+    'error',
+    {
+      requireStringLiterals: true,
+    },
+  ],
 };