eslint-config-seekingalpha-base 8.0.0 → 8.2.0

package/CHANGELOG.md

@@ -1,6 +1,19 @@
 # Change Log
 
-## 8.0.0 - 2024-04-00
+## 8.2.0 - 2024-05-12
+
+- [breaking] enable `logical-assignment-operators` rule
+
+## 8.1.0 - 2024-05-12
+
+- [deps] update `eslint-plugin-unicorn` to version `53.0.0`
+- [breaking] enable `unicorn/consistent-empty-array-spread` rule
+- [breaking] enable `unicorn/no-invalid-fetch-options` rule
+- [breaking] enable `unicorn/no-magic-array-flat-depth` rule
+- [breaking] enable `unicorn/prefer-string-raw` rule
+- [breaking] enable `unicorn/prefer-structured-clone` rule
+
+## 8.0.0 - 2024-04-08
 
 - [breaking] removed `@stylistic/eslint-plugin-js`
 

package/README.md

@@ -6,7 +6,7 @@ This package includes the shareable ESLint config used by [SeekingAlpha](https:/
 
 Install ESLint and all [Peer Dependencies](https://nodejs.org/en/blog/npm/peer-dependencies/):
 
-    npm install eslint@8.57.0 eslint-plugin-array-func@4.0.0 eslint-plugin-import@2.29.1 eslint-plugin-no-use-extend-native@0.5.0 eslint-plugin-promise@6.1.1 eslint-plugin-unicorn@52.0.0 --save-dev
+    npm install eslint@8.57.0 eslint-plugin-array-func@4.0.0 eslint-plugin-import@2.29.1 eslint-plugin-no-use-extend-native@0.5.0 eslint-plugin-promise@6.1.1 eslint-plugin-unicorn@53.0.0 --save-dev
 
 Install SeekingAlpha shareable ESLint:
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-seekingalpha-base",
-  "version": "8.0.0",
+  "version": "8.2.0",
   "description": "SeekingAlpha's sharable base ESLint config",
   "main": "index.js",
   "scripts": {
@@ -53,7 +53,7 @@
     "eslint-plugin-import": "2.29.1",
     "eslint-plugin-no-use-extend-native": "0.5.0",
     "eslint-plugin-promise": "6.1.1",
-    "eslint-plugin-unicorn": "52.0.0"
+    "eslint-plugin-unicorn": "53.0.0"
   },
   "devDependencies": {
     "eslint": "8.57.0",
@@ -62,6 +62,6 @@
     "eslint-plugin-import": "2.29.1",
     "eslint-plugin-no-use-extend-native": "0.5.0",
     "eslint-plugin-promise": "6.1.1",
-    "eslint-plugin-unicorn": "52.0.0"
+    "eslint-plugin-unicorn": "53.0.0"
   }
 }

package/rules/eslint/index.js

@@ -1,3 +1,7 @@
 module.exports = {
-  extends: ['./possible-problems.js', './suggestions.js', './layout-and-formatting.js'],
+  extends: [
+    './possible-problems.js',
+    './suggestions.js',
+    './layout-and-formatting.js',
+  ],
 };

package/rules/eslint/suggestions.js

@@ -145,6 +145,9 @@ module.exports = {
     // https://eslint.org/docs/rules/init-declarations
     'init-declarations': ['off', 'always'],
 
+    // https://eslint.org/docs/latest/rules/logical-assignment-operators
+    'logical-assignment-operators': ['error', 'always'],
+
     // https://eslint.org/docs/rules/max-classes-per-file
     'max-classes-per-file': ['error', config.maxClassesPerFile],
 
@@ -437,7 +440,8 @@ module.exports = {
     'no-restricted-syntax': [
       'error',
       {
-        selector: 'CallExpression[callee.name="setTimeout"][arguments.length!=2]',
+        selector:
+          'CallExpression[callee.name="setTimeout"][arguments.length!=2]',
         message: 'setTimeout must always be invoked with two arguments.',
       },
       {
@@ -446,7 +450,8 @@ module.exports = {
       },
       {
         selector: 'LabeledStatement',
-        message: 'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.',
+        message:
+          'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.',
       },
       {
         selector: 'WithStatement',

package/rules/eslint-plugin-import/index.js

@@ -1,7 +1,12 @@
 // eslint-plugin-import rules (https://github.com/benmosher/eslint-plugin-import)
 
 module.exports = {
-  extends: ['./helpful-warnings.js', './module-systems.js', './static-analysis.js', './style-guide.js'],
+  extends: [
+    './helpful-warnings.js',
+    './module-systems.js',
+    './static-analysis.js',
+    './style-guide.js',
+  ],
 
   plugins: ['import'],
 

package/rules/eslint-plugin-import/style-guide.js

@@ -32,7 +32,16 @@ module.exports = {
     'import/order': [
       'error',
       {
-        groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'unknown', 'index', 'type'],
+        groups: [
+          'builtin',
+          'external',
+          'internal',
+          'parent',
+          'sibling',
+          'unknown',
+          'index',
+          'type',
+        ],
 
         'newlines-between': 'always',
       },

package/rules/eslint-plugin-unicorn/index.js

@@ -18,6 +18,9 @@ module.exports = {
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/consistent-destructuring.md
     'unicorn/consistent-destructuring': 'error',
 
+    // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/consistent-empty-array-spread.md
+    'unicorn/consistent-empty-array-spread': 'error',
+
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/consistent-function-scoping.md
     'unicorn/consistent-function-scoping': 'error',
 
@@ -102,6 +105,9 @@ module.exports = {
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-instanceof-array.md
     'unicorn/no-instanceof-array': 'error',
 
+    // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-invalid-fetch-options.md
+    'unicorn/no-invalid-fetch-options': 'error',
+
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-invalid-remove-event-listener.md
     'unicorn/no-invalid-remove-event-listener': 'error',
 
@@ -117,6 +123,9 @@ module.exports = {
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-lonely-if.md
     'unicorn/no-lonely-if': 'error',
 
+    // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-magic-array-flat-depth.md
+    'unicorn/no-magic-array-flat-depth': 'error',
+
     /*
      * Disabled in favour of native ESLint no-negated-condition rule
      * https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-negated-condition.md
@@ -327,6 +336,9 @@ module.exports = {
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-spread.md
     'unicorn/prefer-spread': 'off',
 
+    // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-string-raw.md
+    'unicorn/prefer-string-raw': 'error',
+
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-string-replace-all.md
     'unicorn/prefer-string-replace-all': 'error',
 
@@ -339,6 +351,9 @@ module.exports = {
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-string-trim-start-end.md
     'unicorn/prefer-string-trim-start-end': 'error',
 
+    // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-structured-clone.md
+    'unicorn/prefer-structured-clone': 'error',
+
     // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-switch.md
     'unicorn/prefer-switch': 'error',