eslint-config-seek 9.0.0-beta.0 → 9.0.0

package/.eslintrc.js

@@ -70,7 +70,10 @@ const baseRules = {
   'prefer-const': ERROR,
   'prefer-spread': ERROR,
   'prefer-template': ERROR,
-  'no-return-await': ERROR,
+  // Allow devs to choose between performance and richer stack traces
+  // https://eslint.org/docs/rules/no-return-await#when-not-to-use-it
+  // https://github.com/goldbergyoni/nodebestpractices/blob/master@%7B2022-01-01T00:00:00Z%7D/sections/errorhandling/returningpromises.md
+  'no-return-await': OFF,
 };
 
 const reactRules = {

package/.github/workflows/release.yml

@@ -15,6 +15,10 @@ jobs:
     steps:
       - name: Check out repo
         uses: actions/checkout@main
+        with:
+          # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
+          fetch-depth: 0
+          token: ${{ secrets.SEEK_OSS_CI_GITHUB_TOKEN }}
 
       - name: Set up Node.js 16.x
         uses: actions/setup-node@main

package/CHANGELOG.md

@@ -1,10 +1,10 @@
 # eslint-config-seek
 
-## 9.0.0-beta.0
+## 9.0.0
 
 ### Major Changes
 
-- Support ESLint 8.x (15e26ec)
+- Support ESLint 8.x ([#73](https://github.com/seek-oss/eslint-config-seek/pull/73))
 
   We've upgraded the parsers and plugins bundled in `eslint-config-seek` for ESLint 8.x compatibility. Some linting rules have changed and may require manual triage. In particular, we've applied the following major upgrades:
 
@@ -26,6 +26,12 @@
 
   [`eslint-plugin-cypress`](https://github.com/cypress-io/eslint-plugin-cypress/issues/89) is currently incompatible with ESLint 8.x. Projects that utilise Cypress should remain on ESLint 7.x.
 
+### Minor Changes
+
+- Turn off [`no-return-await`](https://eslint.org/docs/rules/no-return-await) ([#74](https://github.com/seek-oss/eslint-config-seek/pull/74))
+
+  `return await` produces [richer stack traces with a marginal performance penalty](https://github.com/goldbergyoni/nodebestpractices/blob/master@%7B2022-01-01T00:00:00Z%7D/sections/errorhandling/returningpromises.md) in recent Node.js versions. This tradeoff is now left to individual consumers to weigh up and optionally enforce.
+
 ## 8.0.0
 
 ### Major Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-seek",
-  "version": "9.0.0-beta.0",
+  "version": "9.0.0",
   "description": "ESLint configuration used by SEEK",
   "main": ".eslintrc.js",
   "repository": {
@@ -36,7 +36,7 @@
   "devDependencies": {
     "@changesets/cli": "2.17.0",
     "@changesets/get-github-info": "0.5.0",
-    "eslint": "7.32.0",
+    "eslint": "8.11.0",
     "prettier": "2.4.1",
     "typescript": "^4.1.2"
   },

package/.changeset/olive-seas-collect.md

@@ -1,25 +0,0 @@
----
-'eslint-config-seek': major
----
-
-Support ESLint 8.x
-
-We've upgraded the parsers and plugins bundled in `eslint-config-seek` for ESLint 8.x compatibility. Some linting rules have changed and may require manual triage. In particular, we've applied the following major upgrades:
-
-- [TypeScript ESLint v5](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0)
-
-  This includes changes to the recommended rule set.
-
-- [`babel-eslint`](https://www.npmjs.com/package/babel-eslint) → [`@babel/eslint-parser`](https://www.npmjs.com/package/@babel/eslint-parser)
-
-  This resolves the following installation warning:
-
-  ```console
-  babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
-  ```
-
-- [`eslint-config-prettier` v8](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md?rgh-link-date=2021-10-18T05%3A10%3A39Z#version-800-2021-02-21)
-
-  This unifies on a single `prettier` config.
-
-[`eslint-plugin-cypress`](https://github.com/cypress-io/eslint-plugin-cypress/issues/89) is currently incompatible with ESLint 8.x. Projects that utilise Cypress should remain on ESLint 7.x.

package/.changeset/pre.json

@@ -1,10 +0,0 @@
-{
-  "mode": "pre",
-  "tag": "beta",
-  "initialVersions": {
-    "eslint-config-seek": "8.0.0"
-  },
-  "changesets": [
-    "olive-seas-collect"
-  ]
-}