eslint-config-seek 13.0.0 → 13.1.0

package/base.js

@@ -1,12 +1,8 @@
-const path = require('path');
 const root = require('find-root')(process.cwd());
 
 const OFF = 0;
 const ERROR = 2;
 
-const rulesDirPlugin = require('eslint-plugin-rulesdir');
-rulesDirPlugin.RULES_DIR = path.join(__dirname, 'rules');
-
 const baseRules = {
   // Possible Errors
   'no-console': ERROR,
@@ -24,6 +20,7 @@ const baseRules = {
   'no-eval': ERROR,
   'no-extend-native': ERROR,
   'no-extra-bind': ERROR,
+  'no-fallthrough': ERROR,
   'no-floating-decimal': ERROR,
   'no-implicit-coercion': ERROR,
   'no-implied-eval': ERROR,
@@ -131,6 +128,7 @@ const baseConfig = {
       },
       rules: {
         '@typescript-eslint/array-type': [ERROR, { default: 'array-simple' }],
+        '@typescript-eslint/consistent-type-definitions': OFF,
         '@typescript-eslint/no-unused-expressions': ERROR,
         '@typescript-eslint/no-unused-vars': [
           ERROR,
@@ -217,17 +215,11 @@ const baseConfig = {
     {
       // Cypress config
       files: [`**/cypress/**/*.{${allExtensions}}`],
-      // eslint-plugin-cypress doesn't support ESLint v8.
-      // Use fork by `@finsit` until this is solved.
-      // https://github.com/cypress-io/eslint-plugin-cypress/issues/89
-      extends: ['plugin:@finsit/cypress/recommended'],
+      extends: ['plugin:cypress/recommended'],
       env: {
-        '@finsit/cypress/globals': true,
-      },
-      plugins: ['@finsit/cypress', 'rulesdir'],
-      rules: {
-        'rulesdir/unsafe-to-chain-command': ERROR,
+        'cypress/globals': true,
       },
+      plugins: ['cypress'],
     },
   ],
 };

package/package.json

@@ -1,13 +1,12 @@
 {
   "name": "eslint-config-seek",
-  "version": "13.0.0",
+  "version": "13.1.0",
   "description": "ESLint configuration used by SEEK",
   "main": "index.js",
   "files": [
     "index.js",
     "base.js",
-    "extensions.js",
-    "rules/*"
+    "extensions.js"
   ],
   "repository": {
     "type": "git",
@@ -23,7 +22,7 @@
     "@babel/core": "^7.22.6",
     "@babel/eslint-parser": "^7.22.6",
     "@babel/preset-react": "^7.22.5",
-    "@finsit/eslint-plugin-cypress": "^3.1.1",
+    "eslint-plugin-cypress": "^3.0.0",
     "@typescript-eslint/eslint-plugin": "^7.2.0",
     "@typescript-eslint/parser": "^7.2.0",
     "eslint-config-prettier": "^8.8.0",
@@ -32,7 +31,6 @@
     "eslint-plugin-jest": "^27.9.0",
     "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-react-hooks": "^4.6.0",
-    "eslint-plugin-rulesdir": "^0.2.2",
     "find-root": "^1.1.0"
   },
   "devDependencies": {

package/rules/unsafe-to-chain-command.js

@@ -1,96 +0,0 @@
-/** This rule was copied from the original `eslint-plugin-cypress` so we can use the fork (which
- * supports eslint 8) while having the same recommended rules as the upstream
- * https://github.com/foretagsplatsen/eslint-plugin-cypress
- * https://github.com/cypress-io/eslint-plugin-cypress/blob/c626ad543f65babf1def5caabd1bc9bb9900d2c7/lib/rules/unsafe-to-chain-command.js
- */
-// eslint-disable-next-line strict
-'use strict';
-
-/** @type {import("eslint").Rule.RuleModule} */
-module.exports = {
-  meta: {
-    type: 'problem',
-    docs: {
-      description: 'Actions should be at the end of chains, not in the middle',
-      category: 'Possible Errors',
-      recommended: true,
-      url: 'https://docs.cypress.io/guides/core-concepts/retry-ability#Actions-should-be-at-the-end-of-chains-not-the-middle',
-    },
-    schema: [],
-    fixable: 'code',
-    messages: {
-      unexpected:
-        'It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in the next command.',
-    },
-  },
-  create(context) {
-    return {
-      CallExpression(node) {
-        if (
-          isRootCypress(node) &&
-          isActionUnsafeToChain(node) &&
-          node.parent.type === 'MemberExpression'
-        ) {
-          context.report({
-            node,
-            messageId: 'unexpected',
-          });
-        }
-      },
-    };
-  },
-};
-
-/** @param {import("eslint").Rule.Node} node */
-function isRootCypress(node) {
-  while (node.type === 'CallExpression') {
-    if (node.callee.type !== 'MemberExpression') {
-      return false;
-    }
-
-    if (
-      node.callee.object.type === 'Identifier' &&
-      node.callee.object.name === 'cy'
-    ) {
-      return true;
-    }
-
-    // eslint-disable-next-line no-param-reassign
-    node = node.callee.object;
-  }
-
-  return false;
-}
-
-/** @param {import("eslint").Rule.Node} node */
-function isActionUnsafeToChain(node) {
-  // commands listed in the documentation with text: 'It is unsafe to chain further commands that rely on the subject after xxx'
-  const unsafeToChainActions = [
-    'blur',
-    'clear',
-    'click',
-    'check',
-    'dblclick',
-    'each',
-    'focus',
-    'rightclick',
-    'screenshot',
-    'scrollIntoView',
-    'scrollTo',
-    'select',
-    'selectFile',
-    'spread',
-    'submit',
-    'type',
-    'trigger',
-    'uncheck',
-    'within',
-  ];
-
-  return (
-    node.callee &&
-    node.callee.property &&
-    node.callee.property.type === 'Identifier' &&
-    unsafeToChainActions.includes(node.callee.property.name)
-  );
-}