eslint-config-seek 0.0.0-import-x-again-20250318050943 → 0.0.0-master-20251111232905

package/base.js

@@ -1,11 +1,12 @@
 const importX = require('eslint-plugin-import-x');
 const globals = require('globals');
 const jestPlugin = require('eslint-plugin-jest');
-const cypress = require('eslint-plugin-cypress/flat');
+const cypress = require('eslint-plugin-cypress');
 const eslintConfigPrettier = require('eslint-config-prettier');
 const tseslint = require('typescript-eslint');
 
 const OFF = 0;
+const WARN = 1;
 const ERROR = 2;
 
 const baseRules = {
@@ -13,7 +14,6 @@ const baseRules = {
   'no-console': ERROR,
   'no-unexpected-multiline': ERROR,
   'block-scoped-var': ERROR,
-  curly: [ERROR, 'all'],
   'default-case': ERROR,
   'dot-notation': ERROR,
   eqeqeq: [ERROR, 'always', { null: 'ignore' }],
@@ -63,6 +63,29 @@ const baseRules = {
   'no-path-concat': ERROR,
   'no-process-exit': ERROR,
   'no-restricted-modules': ERROR,
+  'no-restricted-syntax': [
+    ERROR,
+    {
+      selector: 'MethodDefinition[kind = "get"]',
+      message:
+        'Custom getters can cause confusion, particularly if they throw errors. Remove the `get` syntax to specify a regular method instead.',
+    },
+    {
+      selector: 'MethodDefinition[kind = "set"]',
+      message:
+        'Custom setters can cause confusion, particularly if they throw errors. Remove the `set` syntax to specify a regular method instead.',
+    },
+    {
+      selector: 'Property[kind = "get"]',
+      message:
+        'Custom getters can cause confusion, particularly if they throw errors. Remove the `get` syntax to specify a regular property instead.',
+    },
+    {
+      selector: 'Property[kind = "set"]',
+      message:
+        'Custom setters can cause confusion, particularly if they throw errors. Remove the `set` syntax to specify a regular property instead.',
+    },
+  ],
   'no-sync': ERROR,
   'linebreak-style': [ERROR, 'unix'],
   'new-cap': ERROR,
@@ -81,6 +104,10 @@ const baseRules = {
   'no-return-await': OFF,
 };
 
+const eslintConfigPrettierOverrideRules = {
+  curly: [ERROR, 'all'],
+};
+
 const { js: jsExtensions, ts: tsExtensions } = require('./extensions');
 const allExtensions = [...jsExtensions, ...tsExtensions];
 
@@ -94,7 +121,6 @@ const settings = {
 module.exports = [
   {
     plugins: {
-      'import-x': importX,
       jest: jestPlugin,
       cypress,
       '@typescript-eslint': tseslint.plugin,
@@ -125,6 +151,21 @@ module.exports = [
     rules: baseRules,
   },
   eslintConfigPrettier,
+  {
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+
+      parserOptions: {
+        requireConfigFile: false,
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+      },
+    },
+    settings,
+    rules: eslintConfigPrettierOverrideRules,
+  },
   ...[...tseslint.configs.recommended, ...tseslint.configs.stylistic].map(
     ({ plugins, ...config }) => ({
       ...config,
@@ -156,6 +197,21 @@ module.exports = [
       '@typescript-eslint/ban-ts-comment': OFF,
       '@typescript-eslint/no-explicit-any': OFF,
       '@typescript-eslint/explicit-function-return-type': OFF,
+      '@typescript-eslint/naming-convention': [
+        // TODO - upgrade to ERROR in next major version
+        WARN,
+        {
+          selector: 'typeLike',
+          format: ['PascalCase'],
+          leadingUnderscore: 'allow',
+        },
+        // 'typeLike' includes enums
+        // This selector opts out of the rule for enums
+        {
+          selector: 'enum',
+          format: null,
+        },
+      ],
       '@typescript-eslint/no-empty-function': OFF,
       '@typescript-eslint/no-empty-interface': OFF,
       '@typescript-eslint/no-inferrable-types': [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-seek",
-  "version": "0.0.0-import-x-again-20250318050943",
+  "version": "0.0.0-master-20251111232905",
   "description": "ESLint configuration used by SEEK",
   "main": "index.js",
   "files": [
@@ -21,10 +21,10 @@
   "dependencies": {
     "typescript-eslint": "^8.6.0",
     "eslint-config-prettier": "^10.0.0",
-    "eslint-import-resolver-typescript": "^3.6.3",
-    "eslint-plugin-cypress": "^4.0.0",
-    "eslint-plugin-import-x": "4.6.1",
-    "eslint-plugin-jest": "^28.8.0",
+    "eslint-import-resolver-typescript": "^4.0.0",
+    "eslint-plugin-cypress": "^5.0.0",
+    "eslint-plugin-import-x": "^4.9.0",
+    "eslint-plugin-jest": "^29.0.0",
     "eslint-plugin-react": "^7.35.0",
     "eslint-plugin-react-hooks": "^5.0.0",
     "globals": "^16.0.0"
@@ -34,7 +34,7 @@
     "@changesets/get-github-info": "^0.6.0",
     "eslint": "^9.8.0",
     "prettier": "^3.3.3",
-    "typescript": "~5.7.0"
+    "typescript": "~5.9.0"
   },
   "peerDependencies": {
     "eslint": ">=9.9.1",
@@ -43,9 +43,6 @@
   "engines": {
     "node": ">=18.18.0"
   },
-  "volta": {
-    "node": "22.14.0"
-  },
   "scripts": {
     "release": "changeset publish",
     "test": "eslint --config index.js . && eslint --config base.js .",