eslint-config-seek 0.0.0-cypress-fork-20230524064546 → 0.0.0-fix-curly-braces-20231115033054

package/base.js

@@ -4,6 +4,9 @@ const root = require('find-root')(process.cwd());
 const OFF = 0;
 const ERROR = 2;
 
+const rulesDirPlugin = require('eslint-plugin-rulesdir');
+rulesDirPlugin.RULES_DIR = path.join(__dirname, 'rules');
+
 const baseRules = {
   // Possible Errors
   'no-console': ERROR,
@@ -107,13 +110,16 @@ const baseConfig = {
       files: [`**/*.{${tsExtensions}}`],
       parser: '@typescript-eslint/parser',
       parserOptions: {
-        ecmaVersion: 2018,
-        sourceType: 'module',
+        // https://github.com/typescript-eslint/typescript-eslint/issues/6544
+        allowAutomaticSingleRunInference: true,
+        ecmaVersion: 2022,
         project: true,
+        sourceType: 'module',
+        warnOnUnsupportedTypeScriptVersion: false,
       },
       extends: [
-        'plugin:@typescript-eslint/eslint-recommended',
         'plugin:@typescript-eslint/recommended',
+        'plugin:@typescript-eslint/stylistic',
         'prettier',
       ],
       settings: {
@@ -124,6 +130,7 @@ const baseConfig = {
         },
       },
       rules: {
+        '@typescript-eslint/array-type': [ERROR, { default: 'array-simple' }],
         '@typescript-eslint/no-unused-expressions': ERROR,
         '@typescript-eslint/no-unused-vars': [
           ERROR,
@@ -180,7 +187,7 @@ const baseConfig = {
       settings: {
         'import/resolver': {
           node: {
-            moduleDirectory: [root, path.join(root, 'node_modules')],
+            moduleDirectory: [root, 'node_modules'],
           },
         },
       },
@@ -210,13 +217,16 @@ const baseConfig = {
     {
       // Cypress config
       files: [`**/cypress/**/*.{${allExtensions}}`],
+      // eslint-plugin-cypress doesn't support ESLint v8.
+      // Use fork by `@finsit` until this is solved.
+      // https://github.com/cypress-io/eslint-plugin-cypress/issues/89
+      extends: ['plugin:@finsit/cypress/recommended'],
       env: {
         '@finsit/cypress/globals': true,
       },
-      extends: ['plugin:@finsit/cypress/recommended'],
-      plugins: ['@finsit/cypress', 'eslint-plugin-local-rules'],
+      plugins: ['@finsit/cypress', 'rulesdir'],
       rules: {
-        'local-rules/unsafe-to-chain-command': ERROR,
+        'rulesdir/unsafe-to-chain-command': ERROR,
       },
     },
   ],

package/index.js

@@ -10,6 +10,10 @@ const reactRules = {
   'react/no-children-prop': ERROR,
   'react/display-name': OFF,
   'react/prop-types': OFF,
+  'react/jsx-curly-brace-presence': [
+    ERROR,
+    { props: 'never', children: 'ignore', propElementValues: 'always' },
+  ],
 };
 
 /** @type {import('eslint').Linter.Config} */
@@ -23,7 +27,11 @@ const eslintConfig = {
     },
   },
   plugins: ['react', 'react-hooks'],
-  extends: ['plugin:react/recommended', './base.js'],
+  extends: [
+    'plugin:react/recommended',
+    'plugin:react/jsx-runtime',
+    './base.js',
+  ],
   parserOptions: {
     babelOptions: {
       presets: [require.resolve('@babel/preset-react')],
@@ -32,6 +40,22 @@ const eslintConfig = {
   rules: {
     ...reactRules,
   },
+  overrides: [
+    {
+      // temporary override until everybody removes the React import
+      files: [`**/*.tsx`],
+      rules: {
+        '@typescript-eslint/no-unused-vars': [
+          ERROR,
+          {
+            argsIgnorePattern: '^_',
+            ignoreRestSiblings: true,
+            varsIgnorePattern: '^React$',
+          },
+        ],
+      },
+    },
+  ],
 };
 
 module.exports = eslintConfig;

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "eslint-config-seek",
-  "version": "0.0.0-cypress-fork-20230524064546",
+  "version": "0.0.0-fix-curly-braces-20231115033054",
   "description": "ESLint configuration used by SEEK",
   "main": "index.js",
   "files": [
     "index.js",
     "base.js",
     "extensions.js",
-    "eslint-local-rules/*"
+    "rules/*"
   ],
   "repository": {
     "type": "git",
@@ -20,39 +20,39 @@
   },
   "homepage": "https://github.com/seek-oss/eslint-config-seek#readme",
   "dependencies": {
-    "@babel/core": "^7.21.0",
-    "@babel/eslint-parser": "^7.19.1",
-    "@babel/preset-react": "^7.18.6",
+    "@babel/core": "^7.22.6",
+    "@babel/eslint-parser": "^7.22.6",
+    "@babel/preset-react": "^7.22.5",
     "@finsit/eslint-plugin-cypress": "^3.1.1",
-    "@typescript-eslint/eslint-plugin": "^5.53.0",
-    "@typescript-eslint/parser": "^5.53.0",
-    "eslint-config-prettier": "^8.6.0",
-    "eslint-import-resolver-typescript": "3.5.3",
+    "@typescript-eslint/eslint-plugin": "^6.0.0",
+    "@typescript-eslint/parser": "^6.0.0",
+    "eslint-config-prettier": "^8.8.0",
+    "eslint-import-resolver-typescript": "3.5.5",
     "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-jest": "^27.2.1",
-    "eslint-plugin-local-rules": "^1.3.2",
+    "eslint-plugin-jest": "^27.2.3",
     "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-rulesdir": "^0.2.2",
     "find-root": "^1.1.0"
   },
   "devDependencies": {
-    "@changesets/cli": "^2.26.0",
+    "@changesets/cli": "^2.26.2",
     "@changesets/get-github-info": "^0.5.2",
-    "eslint": "^8.34.0",
+    "eslint": "^8.44.0",
     "prettier": "^2.8.4",
-    "typescript": "~4.9.5"
+    "typescript": "~5.1.6"
   },
   "peerDependencies": {
-    "eslint": ">=6",
+    "eslint": ">=7",
     "typescript": ">=4.5"
   },
-  "packageManager": "pnpm@8.5.1",
+  "packageManager": "pnpm@8.6.6",
   "volta": {
-    "node": "16.19.1"
+    "node": "18.12.1"
   },
   "scripts": {
     "release": "changeset publish",
-    "test": "eslint --config index.js . && eslint --config base.js .",
+    "test": "eslint . && eslint --config base.js .",
     "changeset-version": "changeset version && prettier --write ."
   }
 }

package/{eslint-local-rules → rules}/unsafe-to-chain-command.js

@@ -1,4 +1,4 @@
-/** This rule is copied from the original `eslint-plugin-cypress` so we can use the fork (which
+/** This rule was copied from the original `eslint-plugin-cypress` so we can use the fork (which
  * supports eslint 8) while having the same recommended rules as the upstream
  * https://github.com/foretagsplatsen/eslint-plugin-cypress
  * https://github.com/cypress-io/eslint-plugin-cypress/blob/c626ad543f65babf1def5caabd1bc9bb9900d2c7/lib/rules/unsafe-to-chain-command.js
@@ -6,18 +6,21 @@
 // eslint-disable-next-line strict
 'use strict';
 
+/** @type {import("eslint").Rule.RuleModule} */
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
-      description: 'Actions should be in the end of chains, not in the middle',
+      description: 'Actions should be at the end of chains, not in the middle',
       category: 'Possible Errors',
       recommended: true,
       url: 'https://docs.cypress.io/guides/core-concepts/retry-ability#Actions-should-be-at-the-end-of-chains-not-the-middle',
     },
     schema: [],
+    fixable: 'code',
     messages: {
       unexpected:
-        'It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in a next command line.',
+        'It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from `cy.` in the next command.',
     },
   },
   create(context) {
@@ -28,13 +31,17 @@ module.exports = {
           isActionUnsafeToChain(node) &&
           node.parent.type === 'MemberExpression'
         ) {
-          context.report({ node, messageId: 'unexpected' });
+          context.report({
+            node,
+            messageId: 'unexpected',
+          });
         }
       },
     };
   },
 };
 
+/** @param {import("eslint").Rule.Node} node */
 function isRootCypress(node) {
   while (node.type === 'CallExpression') {
     if (node.callee.type !== 'MemberExpression') {
@@ -55,6 +62,7 @@ function isRootCypress(node) {
   return false;
 }
 
+/** @param {import("eslint").Rule.Node} node */
 function isActionUnsafeToChain(node) {
   // commands listed in the documentation with text: 'It is unsafe to chain further commands that rely on the subject after xxx'
   const unsafeToChainActions = [

package/eslint-local-rules/index.js

@@ -1,3 +0,0 @@
-module.exports = {
-  'unsafe-to-chain-command': require('./unsafe-to-chain-command.js'),
-};