eslint-config-scratch 11.0.52 → 12.0.0

package/test/__snapshots__/eslint.test.mjs.snap

@@ -1,6 +1,49 @@
 // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
 
-exports[`'recommended' > Plain TS (bad) 1`] = `
+exports[`'legacy' > Plain JS (bad) 1`] = `
+[
+  {
+    "column": 7,
+    "endColumn": 10,
+    "endLine": 4,
+    "line": 4,
+    "messageId": "unusedVar",
+    "nodeType": "Identifier",
+    "ruleId": "no-unused-vars",
+  },
+  {
+    "column": 26,
+    "endColumn": 31,
+    "endLine": 13,
+    "line": 13,
+    "messageId": "notInScope",
+    "nodeType": "JSXOpeningElement",
+    "ruleId": "react/react-in-jsx-scope",
+  },
+  {
+    "column": 26,
+    "endColumn": 46,
+    "endLine": 13,
+    "line": 13,
+    "messageId": "noJSXWithExtension",
+    "nodeType": "JSXElement",
+    "ruleId": "react/jsx-filename-extension",
+  },
+  {
+    "column": 20,
+    "endColumn": 24,
+    "endLine": 16,
+    "line": 16,
+    "messageId": "undef",
+    "nodeType": "Identifier",
+    "ruleId": "no-undef",
+  },
+]
+`;
+
+exports[`'legacy' > Plain JS (good) 1`] = `[]`;
+
+exports[`'legacy' > Plain TS (bad) 1`] = `
 [
   {
     "column": 7,
@@ -21,44 +64,35 @@ exports[`'recommended' > Plain TS (bad) 1`] = `
     "ruleId": "@typescript-eslint/no-unused-vars",
   },
   {
-    "column": 10,
-    "endColumn": 13,
+    "column": 7,
+    "endColumn": 10,
     "endLine": 8,
     "line": 8,
     "messageId": "unusedVar",
     "nodeType": null,
     "ruleId": "@typescript-eslint/no-unused-vars",
   },
-  {
-    "column": 14,
-    "endColumn": 26,
-    "endLine": 17,
-    "line": 17,
-    "messageId": "anyAssignment",
-    "nodeType": "VariableDeclarator",
-    "ruleId": "@typescript-eslint/no-unsafe-assignment",
-  },
   {
     "column": 20,
     "endColumn": 24,
-    "endLine": 17,
-    "line": 17,
-    "messageId": "unsafeCall",
+    "endLine": 16,
+    "line": 16,
+    "messageId": "undef",
     "nodeType": "Identifier",
-    "ruleId": "@typescript-eslint/no-unsafe-call",
+    "ruleId": "no-undef",
   },
 ]
 `;
 
-exports[`'recommended' > Plain TS (good) 1`] = `[]`;
+exports[`'legacy' > Plain TS (good) 1`] = `[]`;
 
-exports[`'recommended' > React JSX (bad) 1`] = `
+exports[`'legacy' > React JSX (bad) 1`] = `
 [
   {
-    "column": 10,
-    "endColumn": 13,
-    "endLine": 4,
-    "line": 4,
+    "column": 7,
+    "endColumn": 10,
+    "endLine": 5,
+    "line": 5,
     "messageId": "unusedVar",
     "nodeType": "Identifier",
     "ruleId": "no-unused-vars",
@@ -66,8 +100,8 @@ exports[`'recommended' > React JSX (bad) 1`] = `
   {
     "column": 20,
     "endColumn": 24,
-    "endLine": 14,
-    "line": 14,
+    "endLine": 15,
+    "line": 15,
     "messageId": "undef",
     "nodeType": "Identifier",
     "ruleId": "no-undef",
@@ -75,9 +109,9 @@ exports[`'recommended' > React JSX (bad) 1`] = `
 ]
 `;
 
-exports[`'recommended' > React JSX (good) 1`] = `[]`;
+exports[`'legacy' > React JSX (good) 1`] = `[]`;
 
-exports[`'recommended' > plain JS (bad) 1`] = `
+exports[`'recommended' > Plain JS (bad) 1`] = `
 [
   {
     "column": 10,
@@ -109,4 +143,81 @@ exports[`'recommended' > plain JS (bad) 1`] = `
 ]
 `;
 
-exports[`'recommended' > plain JS (good) 1`] = `[]`;
+exports[`'recommended' > Plain JS (good) 1`] = `[]`;
+
+exports[`'recommended' > Plain TS (bad) 1`] = `
+[
+  {
+    "column": 7,
+    "endColumn": 25,
+    "endLine": 5,
+    "line": 5,
+    "messageId": "noInferrableType",
+    "nodeType": "VariableDeclarator",
+    "ruleId": "@typescript-eslint/no-inferrable-types",
+  },
+  {
+    "column": 7,
+    "endColumn": 12,
+    "endLine": 5,
+    "line": 5,
+    "messageId": "unusedVar",
+    "nodeType": null,
+    "ruleId": "@typescript-eslint/no-unused-vars",
+  },
+  {
+    "column": 10,
+    "endColumn": 13,
+    "endLine": 8,
+    "line": 8,
+    "messageId": "unusedVar",
+    "nodeType": null,
+    "ruleId": "@typescript-eslint/no-unused-vars",
+  },
+  {
+    "column": 14,
+    "endColumn": 26,
+    "endLine": 17,
+    "line": 17,
+    "messageId": "anyAssignment",
+    "nodeType": "VariableDeclarator",
+    "ruleId": "@typescript-eslint/no-unsafe-assignment",
+  },
+  {
+    "column": 20,
+    "endColumn": 24,
+    "endLine": 17,
+    "line": 17,
+    "messageId": "unsafeCall",
+    "nodeType": "Identifier",
+    "ruleId": "@typescript-eslint/no-unsafe-call",
+  },
+]
+`;
+
+exports[`'recommended' > Plain TS (good) 1`] = `[]`;
+
+exports[`'recommended' > React JSX (bad) 1`] = `
+[
+  {
+    "column": 10,
+    "endColumn": 13,
+    "endLine": 4,
+    "line": 4,
+    "messageId": "unusedVar",
+    "nodeType": "Identifier",
+    "ruleId": "no-unused-vars",
+  },
+  {
+    "column": 20,
+    "endColumn": 24,
+    "endLine": 14,
+    "line": 14,
+    "messageId": "undef",
+    "nodeType": "Identifier",
+    "ruleId": "no-undef",
+  },
+]
+`;
+
+exports[`'recommended' > React JSX (good) 1`] = `[]`;

package/test/eslint.test.mjs

@@ -3,6 +3,10 @@ import path from 'path'
 import util from 'util'
 import { beforeAll, describe, expect, test } from 'vitest'
 
+/**
+ * @import { Linter } from 'eslint'
+ */
+
 /**
  * @typedef {object} EslintTestInfo
  * @property {string} name - the title/message for this test
@@ -17,7 +21,7 @@ import { beforeAll, describe, expect, test } from 'vitest'
 const testInfo = {
   recommended: [
     {
-      name: 'plain JS (good)',
+      name: 'Plain JS (good)',
       filePath: 'plain.good.mjs',
       warningCount: 0,
       errorCount: 0,
@@ -29,7 +33,7 @@ const testInfo = {
       errorCount: 0,
     },
     {
-      name: 'plain JS (bad)',
+      name: 'Plain JS (bad)',
       filePath: 'plain.bad.mjs',
       warningCount: 0,
       errorCount: 3,
@@ -53,12 +57,50 @@ const testInfo = {
       errorCount: 5,
     },
   ],
+  legacy: [
+    {
+      name: 'Plain JS (good)',
+      filePath: 'plain.good.mjs',
+      warningCount: 0,
+      errorCount: 0,
+    },
+    {
+      name: 'React JSX (good)',
+      filePath: 'react.good.jsx',
+      warningCount: 0,
+      errorCount: 0,
+    },
+    {
+      name: 'Plain JS (bad)',
+      filePath: 'plain.bad.mjs',
+      warningCount: 0,
+      errorCount: 4,
+    },
+    {
+      name: 'React JSX (bad)',
+      filePath: 'react.bad.jsx',
+      warningCount: 0,
+      errorCount: 2,
+    },
+    {
+      name: 'Plain TS (good)',
+      filePath: 'plain.good.ts',
+      warningCount: 0,
+      errorCount: 0,
+    },
+    {
+      name: 'Plain TS (bad)',
+      filePath: 'plain.bad.ts',
+      warningCount: 0,
+      errorCount: 4,
+    },
+  ],
 }
 
 /**
  * Create a snapshot of a lint message.
  * Excludes properties that may change without affecting correctness, such as human-readable text.
- * @param {ESLint.LintMessage} result - the lint message to filter
+ * @param {Linter.LintMessage} result - the lint message to filter
  * @returns {object} a filtered snapshot of the lint message
  */
 const messageSnapshot = result =>
@@ -94,7 +136,7 @@ describe.concurrent.for(Object.entries(testInfo))('$0', ([subdir, testList]) =>
     results = await eslint.lintFiles(testList.map(info => path.resolve(import.meta.dirname, subdir, info.filePath)))
   })
 
-  test('results container', () => {
+  test('Results container', () => {
     expect(results).toBeDefined()
     expect(results.length).toBe(testList.length)
   })

package/test/legacy/eslint.config.mjs

@@ -0,0 +1,19 @@
+import {eslintConfigScratch} from '../../lib/index.mjs';
+
+const config = eslintConfigScratch.defineConfig(
+    {
+        files: ['**/*.{mjs,cjs,js,jsx,ts,tsx}'],
+        extends: [
+            eslintConfigScratch.legacy.base,
+            eslintConfigScratch.legacy.react
+        ]
+    },
+    {
+        files: ['**/*.{ts,tsx}'],
+        extends: [
+            eslintConfigScratch.legacy.typescript
+        ]
+    }
+);
+
+export default config;

package/test/legacy/plain.bad.mjs

@@ -0,0 +1,16 @@
+import {ESLint} from 'eslint';
+
+// foo isn't used
+const foo = () => {
+    const eslint = new ESLint({
+        overrideConfigFile: true
+    });
+    return eslint;
+};
+
+// React isn't allowed in plain JS
+// React must be in scope when using JSX
+export const myElement = <div>{'hello'}</div>;
+
+// foo2 isn't defined
+export const bar = foo2();

package/test/legacy/plain.bad.ts

@@ -0,0 +1,16 @@
+import {ESLint} from 'eslint';
+
+// @typescript-eslint/no-inferrable-types
+// @typescript-eslint/no-unused-vars
+const forty: number = 40;
+
+// @typescript-eslint/no-unused-vars
+const foo = (): ESLint => {
+    const eslint = new ESLint({
+        overrideConfigFile: true
+    });
+    return eslint;
+};
+
+// no-undef ('foo2' is not defined)
+export const bar = foo2();

package/test/legacy/plain.good.mjs

@@ -0,0 +1,10 @@
+import {ESLint} from 'eslint';
+
+const foo = () => {
+    const eslint = new ESLint({
+        overrideConfigFile: true
+    });
+    return eslint;
+};
+
+export const bar = foo();

package/test/legacy/plain.good.ts

@@ -0,0 +1,10 @@
+import {ESLint} from 'eslint';
+
+const foo = (): ESLint => {
+    const eslint = new ESLint({
+        overrideConfigFile: true
+    });
+    return eslint;
+};
+
+export const bar = foo();

package/test/legacy/react.bad.jsx

@@ -0,0 +1,15 @@
+import {ESLint} from 'eslint';
+import React from 'react';
+
+// @typescript-eslint/no-unused-vars
+const foo = () => {
+    const eslint = new ESLint({
+        overrideConfigFile: true
+    });
+    return eslint;
+};
+
+export const myElement = <div>{'hello'}</div>;
+
+// foo2 isn't defined
+export const bar = foo2();

package/test/legacy/react.good.jsx

@@ -0,0 +1,13 @@
+import {ESLint} from 'eslint';
+import React from 'react';
+
+const foo = () => {
+    const eslint = new ESLint({
+        overrideConfigFile: true
+    });
+    return eslint;
+};
+
+export const myElement = <div>{'hello'}</div>;
+
+export const bar = foo();

package/test/legacy/tsconfig.json

@@ -0,0 +1,6 @@
+{
+  "compilerOptions": {
+    "strict": true
+  },
+  "include": ["**/*.ts", "**/*.tsx"]
+}

package/test/recommended/eslint.config.mjs

@@ -1,6 +1,6 @@
 import { eslintConfigScratch } from '../../lib/index.mjs'
 
-const config = eslintConfigScratch.config(eslintConfigScratch.recommended, {
+const config = eslintConfigScratch.defineConfig(eslintConfigScratch.recommended, {
   files: ['**/*.ts', '**/*.tsx'],
   languageOptions: {
     parserOptions: {

package/test/recommended/plain.bad.mjs

@@ -1,4 +1,4 @@
-import ESLint from 'eslint'
+import { ESLint } from 'eslint'
 
 // foo isn't used
 function foo() {

package/test/recommended/plain.good.mjs

@@ -1,4 +1,4 @@
-import ESLint from 'eslint'
+import { ESLint } from 'eslint'
 
 function foo() {
   const eslint = new ESLint({

package/test/recommended/react.bad.jsx

@@ -1,4 +1,4 @@
-import ESLint from 'eslint'
+import { ESLint } from 'eslint'
 
 // foo isn't used
 function foo() {

package/test/recommended/react.good.jsx

@@ -1,4 +1,4 @@
-import ESLint from 'eslint'
+import { ESLint } from 'eslint'
 
 function foo() {
   const eslint = new ESLint({