eslint-config-react-app-new 2.0.0 → 2.0.2

package/base.js

@@ -2,6 +2,10 @@ const react = require('eslint-plugin-react');
 const babelParser = require('@babel/eslint-parser');
 const globals = require('globals');
 
+if (!process.env.NODE_ENV) {
+    process.env.NODE_ENV = 'development';
+}
+
 module.exports = [
     {
         languageOptions: {
@@ -14,7 +18,7 @@ module.exports = [
                 }
             },
             // true means writeable, false means readonly, 'off' means disabled
-            gloabls: {
+            globals: {
                 ...globals.browser,
                 ...globals.node,
                 ...globals.commonjs,

package/import.js

@@ -0,0 +1,52 @@
+const importPlugin = require('eslint-plugin-import');
+
+module.exports = [
+    {
+        plugins: {
+            import: importPlugin
+        },
+        rules: {
+            // https://github.com/import-js/eslint-plugin-import/tree/main/docs/rules
+            'import/first': 'error',
+            'import/no-anonymous-default-export': [
+                'error',
+                {
+                    allowArray: true,
+                    allowArrowFunction: false,
+                    allowAnonymousClass: false,
+                    allowAnonymousFunction: false,
+                    allowCallExpression: true,
+                    allowLiteral: true,
+                    allowObject: true,
+                    allowNew: true
+                }
+            ],
+            'import/no-duplicates': 'error',
+            'import/no-webpack-loader-syntax': 'error',
+            'import/order': [
+                'error',
+                {
+                    groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index', 'object'],
+                    sortTypesGroup: false,
+                    alphabetize: { order: 'asc', caseInsensitive: true },
+                    'newlines-between': 'never'
+                }
+            ],
+            // 负责 { a, b, c } 子导出顺序
+            'sort-imports': [
+                'warn',
+                {
+                    ignoreCase: true,
+                    ignoreDeclarationSort: true,
+                    ignoreMemberSort: false
+                }
+            ],
+            'import/no-useless-path-segments': [
+                'error',
+                {
+                    noUselessIndex: true
+                }
+            ]
+        }
+    }
+];

package/index.js

@@ -4,16 +4,18 @@ const baseConfig = require('./base');
 const reactConfig = require('./react');
 const jsxA11yConfig = require('./jsx-a11y');
 const importConfig = require('./import');
+const jestConfig = require('./jest');
 
 module.exports = [
+    baseConfig,
+    reactConfig,
+    jsxA11yConfig,
+    importConfig,
+    jestConfig,
     {
-        extends: [baseConfig, reactConfig, jsxA11yConfig, importConfig],
-        // NOTE: When adding rules here, you need to make sure they are compatible with
-        // `typescript-eslint`, as some rules such as `no-array-constructor` aren't compatible.
         rules: {
-            // http://eslint.org/docs/rules/
             'array-callback-return': 'warn',
-            'default-case': ['warn', { commentPattern: '^no default$' }],
+            'default-case': ['warn', { commentPattern: '^no[-\\s]+default$' }],
             'dot-location': ['warn', 'property'],
             eqeqeq: ['warn', 'smart'],
             'new-parens': 'warn',
@@ -93,8 +95,13 @@ module.exports = [
             'no-unused-vars': [
                 'warn',
                 {
-                    args: 'none',
-                    ignoreRestSiblings: true
+                    vars: 'all',
+                    args: 'after-used',
+                    caughtErrors: 'none',
+                    ignoreRestSiblings: true,
+                    varsIgnorePattern: '^_',
+                    destructuredArrayIgnorePattern: '^_',
+                    argsIgnorePattern: '^_|^err|^ev'
                 }
             ],
             'no-use-before-define': [
@@ -141,21 +148,110 @@ module.exports = [
                         'Please use import() instead. More info: https://facebook.github.io/create-react-app/docs/code-splitting'
                 }
             ],
-            'getter-return': 'warn'
-        }
-    },
-    {
-        files: ['app/**/*'],
-        rules: {
-            'no-console': 'warn'
+            'getter-return': 'warn',
+            'linebreak-style': ['warn', 'unix'],
+            'semi-spacing': ['warn', { before: false }],
+            'no-extra-semi': 'warn',
+            'padded-blocks': ['warn', 'never'],
+            'one-var-declaration-per-line': ['warn', 'initializations'],
+            'spaced-comment': ['warn', 'always'],
+            'space-in-parens': ['warn', 'never'],
+            'space-before-function-paren': [
+                'warn',
+                {
+                    anonymous: 'never',
+                    named: 'never',
+                    asyncArrow: 'always'
+                }
+            ],
+            'space-unary-ops': 'warn',
+            'space-infix-ops': 'warn',
+            'space-before-blocks': 'warn',
+            'no-trailing-spaces': ['warn', { ignoreComments: true }],
+            'key-spacing': ['warn', { mode: 'strict' }],
+            'switch-colon-spacing': 'warn',
+            'func-call-spacing': ['warn', 'never'],
+            'keyword-spacing': 'warn',
+            'no-multiple-empty-lines': [
+                'warn',
+                {
+                    max: 1,
+                    maxEOF: 0,
+                    maxBOF: 0
+                }
+            ],
+            'default-param-last': 'error',
+            curly: 'error',
+            'dot-notation': 'warn',
+            'symbol-description': 'error',
+            'prefer-template': 'warn',
+            'no-unexpected-multiline': 'warn',
+            'no-else-return': 'warn',
+            'guard-for-in': 'error',
+            'no-multi-spaces': [
+                'warn',
+                {
+                    ignoreEOLComments: true,
+                    exceptions: {
+                        VariableDeclarator: true,
+                        ImportDeclaration: true
+                    }
+                }
+            ],
+            'no-floating-decimal': 'warn',
+            yoda: 'warn',
+            'no-unmodified-loop-condition': 'warn',
+            'wrap-iife': ['error', 'inside'],
+            'lines-between-class-members': ['warn', 'always', { exceptAfterSingleLine: true }],
+            'padding-line-between-statements': [
+                'warn',
+                {
+                    blankLine: 'always',
+                    prev: [
+                        'multiline-block-like',
+                        'multiline-expression',
+                        'const',
+                        'let',
+                        'var',
+                        'cjs-import',
+                        'import',
+                        'export',
+                        'cjs-export',
+                        'class',
+                        'throw',
+                        'directive'
+                    ],
+                    next: '*'
+                },
+                {
+                    blankLine: 'always',
+                    prev: '*',
+                    next: [
+                        'multiline-block-like',
+                        'multiline-expression',
+                        'const',
+                        'let',
+                        'var',
+                        'cjs-import',
+                        'import',
+                        'export',
+                        'cjs-export',
+                        'class',
+                        'throw',
+                        'return'
+                    ]
+                },
+                { blankLine: 'any', prev: ['cjs-import', 'import'], next: ['cjs-import', 'import'] },
+                { blankLine: 'any', prev: ['export', 'cjs-export'], next: ['export', 'cjs-export'] },
+                { blankLine: 'any', prev: ['const', 'let', 'var'], next: ['const', 'let', 'var'] }
+            ]
         }
     },
     {
         files: ['**/*.ts', '**/*.tsx', '**/*.mts', '**/*.cts'],
         plugins: {
-            '@typescript-eslint': tseslint
+            '@typescript-eslint': tseslint.plugin
         },
-        extends: ['@typescript-eslint/eslint-recommended'],
         languageOptions: {
             parser: tseslint.parser,
             sourceType: 'module',
@@ -170,13 +266,76 @@ module.exports = [
             }
         },
         rules: {
-            // TypeScript's `noFallthroughCasesInSwitch` option is more robust (#6906)
+            ...tseslint.configs.eslintRecommended.rules,
             'default-case': 'off',
-            // Add TypeScript specific rules (and turn off ESLint equivalents)
+            '@typescript-eslint/ban-tslint-comment': 'warn',
             '@typescript-eslint/consistent-type-assertions': 'warn',
-            'no-array-constructor': 'off',
-            '@typescript-eslint/no-array-constructor': 'warn',
-            '@typescript-eslint/no-redeclare': 'warn',
+            '@typescript-eslint/adjacent-overload-signatures': 'error',
+            '@typescript-eslint/array-type': [
+                'warn',
+                {
+                    default: 'array-simple'
+                }
+            ],
+            '@typescript-eslint/class-literal-property-style': 'warn',
+            '@typescript-eslint/consistent-indexed-object-style': 'warn',
+            '@typescript-eslint/consistent-type-definitions': ['error', 'interface'],
+            '@typescript-eslint/naming-convention': [
+                'error',
+                {
+                    selector: 'typeLike',
+                    format: ['PascalCase']
+                }
+            ],
+            '@typescript-eslint/no-confusing-non-null-assertion': 'warn',
+            '@typescript-eslint/no-duplicate-enum-values': 'error',
+            '@typescript-eslint/no-extra-non-null-assertion': 'error',
+            '@typescript-eslint/no-extraneous-class': 'error',
+            '@typescript-eslint/no-invalid-void-type': 'error',
+            '@typescript-eslint/no-import-type-side-effects': 'error',
+            '@typescript-eslint/no-misused-new': 'error',
+            '@typescript-eslint/no-namespace': 'error',
+            '@typescript-eslint/no-non-null-asserted-optional-chain': 'warn',
+            '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'warn',
+            '@typescript-eslint/no-unnecessary-type-constraint': 'error',
+            '@typescript-eslint/no-unsafe-declaration-merging': 'error',
+            '@typescript-eslint/no-empty-object-type': [
+                'error',
+                {
+                    allowInterfaces: 'never',
+                    allowObjectTypes: 'always'
+                }
+            ],
+            '@typescript-eslint/no-redeclare': [
+                'error',
+                {
+                    ignoreDeclarationMerge: true
+                }
+            ],
+            '@typescript-eslint/no-require-imports': ['error', {
+                allowAsImport: false
+            }],
+            '@typescript-eslint/no-this-alias': [
+                'error',
+                {
+                    allowDestructuring: true, // Allow `const { props, state } = this`; false by default
+                    allowedNames: ['self'] // Allow `const self = this`; `[]` by default
+                }
+            ],
+            '@typescript-eslint/no-wrapper-object-types': 'error',
+            '@typescript-eslint/prefer-as-const': 'warn',
+            '@typescript-eslint/prefer-literal-enum-member': 'error',
+            '@typescript-eslint/prefer-as-const': 'error',
+            '@typescript-eslint/prefer-namespace-keyword': 'error',
+            '@typescript-eslint/triple-slash-reference': 'error',
+            '@typescript-eslint/unified-signatures': 'warn',
+
+            'default-param-last': 'off',
+            '@typescript-eslint/default-param-last': 'error',
+
+            'no-loop-func': 'off',
+            '@typescript-eslint/no-loop-func': 'warn',
+
             'no-use-before-define': 'off',
             '@typescript-eslint/no-use-before-define': [
                 'warn',
@@ -187,6 +346,7 @@ module.exports = [
                     typedefs: false
                 }
             ],
+
             'no-unused-expressions': 'off',
             '@typescript-eslint/no-unused-expressions': [
                 'error',
@@ -196,14 +356,24 @@ module.exports = [
                     allowTaggedTemplates: true
                 }
             ],
+
             'no-unused-vars': 'off',
             '@typescript-eslint/no-unused-vars': [
                 'warn',
                 {
-                    args: 'none',
-                    ignoreRestSiblings: true
+                    vars: 'all',
+                    args: 'after-used',
+                    caughtErrors: 'none',
+                    ignoreRestSiblings: true,
+                    varsIgnorePattern: '^_',
+                    destructuredArrayIgnorePattern: '^_',
+                    argsIgnorePattern: '^_|^err|^ev'
                 }
             ],
+
+            'no-array-constructor': 'off',
+            '@typescript-eslint/no-array-constructor': 'warn',
+
             'no-useless-constructor': 'off',
             '@typescript-eslint/no-useless-constructor': 'warn'
         }

package/jest.js

@@ -32,17 +32,16 @@ module.exports = [
             'jest/valid-title': 'warn',
 
             // https://github.com/testing-library/eslint-plugin-testing-library
-            'testing-library/await-async-query': 'error',
+            'testing-library/await-async-queries': 'error',
             'testing-library/await-async-utils': 'error',
-            'testing-library/no-await-sync-query': 'error',
+            'testing-library/no-await-sync-queries': 'error',
             'testing-library/no-container': 'error',
             'testing-library/no-debugging-utils': 'error',
             'testing-library/no-dom-import': ['error', 'react'],
             'testing-library/no-node-access': 'error',
             'testing-library/no-promise-in-fire-event': 'error',
-            'testing-library/no-render-in-setup': 'error',
+            'testing-library/no-render-in-lifecycle': 'error',
             'testing-library/no-unnecessary-act': 'error',
-            'testing-library/no-wait-for-empty-callback': 'error',
             'testing-library/no-wait-for-multiple-assertions': 'error',
             'testing-library/no-wait-for-side-effects': 'error',
             'testing-library/no-wait-for-snapshot': 'error',

package/jsx-a11y.js

@@ -0,0 +1,34 @@
+const a11yPlugin = require('eslint-plugin-jsx-a11y');
+
+module.exports = [
+    {
+        plugins: {
+            'jsx-a11y': a11yPlugin
+        },
+        rules: {
+            // https://github.com/evcohen/eslint-plugin-jsx-a11y/tree/master/docs/rules
+            'jsx-a11y/alt-text': 'warn',
+            'jsx-a11y/anchor-has-content': 'warn',
+            'jsx-a11y/anchor-is-valid': [
+                'warn',
+                {
+                    aspects: ['noHref', 'invalidHref']
+                }
+            ],
+            'jsx-a11y/aria-activedescendant-has-tabindex': 'warn',
+            'jsx-a11y/aria-props': 'warn',
+            'jsx-a11y/aria-proptypes': 'warn',
+            'jsx-a11y/aria-role': ['warn', { ignoreNonDOM: true }],
+            'jsx-a11y/aria-unsupported-elements': 'warn',
+            'jsx-a11y/heading-has-content': 'warn',
+            'jsx-a11y/iframe-has-title': 'warn',
+            'jsx-a11y/img-redundant-alt': 'warn',
+            'jsx-a11y/no-access-key': 'warn',
+            'jsx-a11y/no-distracting-elements': 'warn',
+            'jsx-a11y/no-redundant-roles': 'warn',
+            'jsx-a11y/role-has-required-aria-props': 'warn',
+            'jsx-a11y/role-supports-aria-props': 'warn',
+            'jsx-a11y/scope': 'warn'
+        }
+    }
+];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-react-app-new",
-  "version": "2.0.0",
+  "version": "2.0.2",
   "description": "ESLint configuration used by tiger-new",
   "repository": {
     "type": "git",
@@ -10,7 +10,10 @@
   "files": [
     "base.js",
     "index.js",
-    "jest.js"
+    "jest.js",
+    "react.js",
+    "jsx-a11y.js",
+    "import.js"
   ],
   "dependencies": {
     "@babel/core": "^7.28.5",

package/react.js

@@ -0,0 +1,66 @@
+const react = require('eslint-plugin-react');
+const reactHooksPlugin = require('eslint-plugin-react-hooks');
+
+const hasJsxRuntime = (() => {
+    try {
+        require.resolve('react/jsx-runtime');
+
+        return true;
+    } catch {}
+
+    return false;
+})();
+
+module.exports = [
+    {
+        plugins: {
+            react,
+            'react-hooks': reactHooksPlugin
+        },
+        settings: {
+            react: {
+                version: 'detect'
+            }
+        },
+        rules: {
+            // https://github.com/yannickcr/eslint-plugin-react/tree/master/docs/rules
+            'react/forbid-foreign-prop-types': ['warn', { allowInPropTypes: true }],
+            'react/forward-ref-uses-ref': 'warn',
+            'react/jsx-boolean-value': [
+                'warn',
+                'never',
+                {
+                    always: ['value']
+                }
+            ],
+            'react/jsx-key': ['warn', { checkFragmentShorthand: true, warnOnDuplicates: true }],
+            'react/jsx-no-comment-textnodes': 'warn',
+            'react/jsx-no-duplicate-props': 'warn',
+            'react/jsx-no-undef': 'error',
+            'react/jsx-pascal-case': [
+                'warn',
+                {
+                    allowAllCaps: true,
+                    ignore: []
+                }
+            ],
+            'react/jsx-uses-react': hasJsxRuntime ? 'off' : 'warn',
+            'react/jsx-uses-vars': 'warn',
+            'react/no-arrow-function-lifecycle': 'error',
+            'react/no-danger-with-children': 'warn',
+            'react/no-deprecated': 'error',
+            'react/no-direct-mutation-state': 'warn',
+            'react/no-is-mounted': 'warn',
+            'react/no-string-refs': ['warn', { noTemplateLiterals: true }],
+            'react/no-this-in-sfc': 'error',
+            'react/no-typos': 'error',
+            'react/no-unsafe': ['error', { checkAliases: true }],
+            'react/react-in-jsx-scope': hasJsxRuntime ? 'off' : 'warn',
+            'react/require-render-return': 'error',
+            'react/style-prop-object': 'warn',
+
+            ...reactHooksPlugin.configs.recommended.rules,
+            'react-hooks/refs': 'off'
+        }
+    }
+];