eslint-config-matsuri 0.0.2 → 1.1.0

package/index.js

@@ -20,7 +20,7 @@ const config = {
         browser: true,
         es2021: true,
       },
-      plugins: ["css-reorder", "import", "jsx-a11y"],
+      plugins: ["css-reorder", "import", "jsx-a11y", "unused-imports"],
       extends: [
         "plugin:react/recommended",
         "plugin:react-hooks/recommended",
@@ -30,6 +30,10 @@ const config = {
         "plugin:jsx-a11y/recommended",
         "prettier",
       ],
+      parser: "@typescript-eslint/parser",
+      parserOptions: {
+        project: "./tsconfig.json",
+      },
       settings: {
         react: {
           version: "detect",
@@ -41,9 +45,16 @@ const config = {
         "css-reorder/property-reorder": "error",
 
         "@typescript-eslint/explicit-module-boundary-types": "off",
-        "@typescript-eslint/no-unused-vars": [
+        
+        "@typescript-eslint/strict-boolean-expressions": [
           "error",
-          { vars: "all", argsIgnorePattern: "^_" },
+          {
+            allowString: true,
+            allowNullableObject: true,
+            allowNullableBoolean: true,
+            allowNullableString: true,
+            allowAny: true,
+          },
         ],
 
         "react/self-closing-comp": [
@@ -59,6 +70,21 @@ const config = {
 
         "jsx-a11y/click-events-have-key-events": "off",
         "jsx-a11y/no-autofocus": "off",
+
+        /**
+         * settings for unused-imports
+         */
+        "@typescript-eslint/no-unused-vars": "off",
+        "unused-imports/no-unused-imports": "error",
+        "unused-imports/no-unused-vars": [
+          "warn",
+          {
+            vars: "all",
+            varsIgnorePattern: "^_",
+            args: "after-used",
+            argsIgnorePattern: "^_",
+          },
+        ],
       },
     },
   ],

package/package.json

@@ -1,8 +1,11 @@
 {
   "name": "eslint-config-matsuri",
-  "version": "0.0.2",
+  "version": "1.1.0",
   "description": "",
   "main": "index.js",
+  "files": [
+    "index.js"
+  ],
   "scripts": {
     "test": "eslint . --max-warnings 0"
   },
@@ -15,20 +18,22 @@
     "eslint": ">= 8"
   },
   "devDependencies": {
-    "@types/react": "^18.0.14",
+    "@emotion/react": "11.9.3",
+    "@types/react": "18.0.14",
     "eslint": "8.18.0",
-    "react": "^18.2.0",
-    "typescript": "^4.7.4"
+    "react": "18.2.0",
+    "typescript": "4.7.4"
   },
   "dependencies": {
     "@typescript-eslint/eslint-plugin": "5.30.0",
-    "@typescript-eslint/parser": "5.30.5",
+    "@typescript-eslint/parser": "5.32.0",
     "eslint-config-prettier": "8.5.0",
-    "eslint-import-resolver-typescript": "^3.2.4",
+    "eslint-import-resolver-typescript": "3.2.4",
     "eslint-plugin-css-reorder": "0.5.1",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jsx-a11y": "^6.6.0",
+    "eslint-plugin-import": "2.26.0",
+    "eslint-plugin-jsx-a11y": "6.6.0",
     "eslint-plugin-react": "7.30.1",
-    "eslint-plugin-react-hooks": "4.6.0"
+    "eslint-plugin-react-hooks": "4.6.0",
+    "eslint-plugin-unused-imports": "2.0.0"
   }
 }

package/.eslintrc.js

@@ -1 +0,0 @@
-module.exports = require("./index");

package/.github/dependabot.yml

@@ -1,9 +0,0 @@
-version: 2
-updates:
-  - package-ecosystem: "npm"
-    directory: "/"
-    schedule:
-      interval: "monthly"
-    reviewers:
-      - "hrdtbs"
-    open-pull-requests-limit: 1

package/.github/workflows/test.yml

@@ -1,34 +0,0 @@
-name: Test
-
-on:
-  push:
-    branches: ["main"]
-  pull_request:
-    branches: ["main"]
-
-jobs:
-  test:
-    runs-on: ubuntu-latest
-
-    strategy:
-      matrix:
-        node-version: [16]
-
-    steps:
-      - uses: actions/checkout@v3
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
-      - name: Cache node_modules
-        id: node_modules_cache_id
-        uses: actions/cache@v2
-        with:
-          key: node-${{ matrix.node }}-deps-${{ hashFiles(format('{0}{1}', github.workspace, '/yarn.lock')) }}
-          path: |
-            node_modules
-      - name: Install dependencies
-        run: yarn install --frozen-lockfile
-        env:
-          CI: true
-      - run: yarn run test

package/tests/console.ts

@@ -1,4 +0,0 @@
-// eslint-disable-next-line no-console
-console.log("log");
-
-console.error("error");

package/tests/jsx-a11y-alt-text.tsx

@@ -1,4 +0,0 @@
-// eslint-disable-next-line jsx-a11y/alt-text
-export const Incorrect = () => <img src="hoge.png" />;
-
-export const Correct = () => <img src="hoge.png" alt="hoge" />;

package/tests/jsx-a11y-interactive-supports-focus.tsx

@@ -1,19 +0,0 @@
-export const Incorrect = () => (
-  // eslint-disable-next-line jsx-a11y/interactive-supports-focus
-  <div
-    onClick={(event) => {
-      window.alert(event.currentTarget);
-    }}
-    role="button"
-  />
-);
-
-export const Correct = () => (
-  <div
-    onClick={(event) => {
-      window.alert(event.currentTarget);
-    }}
-    role="button"
-    tabIndex={0}
-  />
-);

package/tests/mocks/deprecated-function.ts

@@ -1,6 +0,0 @@
-/**
- * @deprecated This is a deprecated function.
- */
-export const deprecated = () => {
-  return "deprecated";
-};

package/tests/no-deprecated.ts

@@ -1,5 +0,0 @@
-// eslint-disable-next-line import/no-deprecated
-import { deprecated } from "./mocks/deprecated-function";
-
-// eslint-disable-next-line import/no-deprecated
-deprecated();

package/tests/no-unused-vars.ts

@@ -1,31 +0,0 @@
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-import React, { useState } from "react";
-
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-export const MyComponent = ({ hoge }) => {
-  return "Hello, World";
-};
-
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-export const MyComponent2 = ({ hoge, ...props }) => {
-  return props;
-};
-
-export const MyComponent3 = ({ hoge: _hoge, ...props }) => {
-  return props;
-};
-
-try {
-  1 + 1;
-} catch (error) {
-  1 + 1;
-}
-
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-(function (foo, bar, baz, qux) {
-  return bar;
-})();
-
-(function (foo, bar, baz, qux) {
-  return qux;
-})();

package/tests/react-self-closing-comp.tsx

@@ -1,19 +0,0 @@
-export const ImaginaryChild = () => <div />;
-
-export const IncorrectParentWithImaginaryChild = () => {
-  // eslint-disable-next-line react/self-closing-comp
-  return <ImaginaryChild></ImaginaryChild>;
-};
-
-export const NonImaginaryChild = ({ children }: { children?: string }) => (
-  <div>{children}</div>
-);
-
-export const CorrectParent = () => {
-  return <NonImaginaryChild>Hello</NonImaginaryChild>;
-};
-
-export const IncorrectParentWithNonImaginaryChild = () => {
-  // eslint-disable-next-line react/self-closing-comp
-  return <NonImaginaryChild></NonImaginaryChild>;
-};