eslint-config-jc 5.2.0 → 6.0.0

package/dist/base.js

@@ -236,7 +236,7 @@ export default tseslint.config({
         // https://jc-verse.github.io/js-style-guide/eslint-base/functions#no-extra-bind
         "no-extra-bind": "error",
         // https://jc-verse.github.io/js-style-guide/eslint-base/operators#no-extra-boolean-cast
-        "no-extra-boolean-cast": ["error", { enforceForLogicalOperands: true }],
+        "no-extra-boolean-cast": ["error", { enforceForInnerExpressions: true }],
         // https://jc-verse.github.io/js-style-guide/eslint-base/control-flow#no-extra-label
         "no-extra-label": "error",
         // A eslint-disable is as expressive as a special comment.
@@ -566,6 +566,8 @@ export default tseslint.config({
                 variables: true,
             },
         ],
+        // https://jc-verse.github.io/js-style-guide/eslint-base/variables-names#no-useless-assignment
+        "no-useless-assignment": "error",
         // https://jc-verse.github.io/js-style-guide/eslint-base/literals#no-useless-backreference
         "no-useless-backreference": "error",
         // https://jc-verse.github.io/js-style-guide/eslint-base/functions#no-useless-call

package/dist/index.d.ts

@@ -1,8 +1,8 @@
 import type { TSESLint } from "@typescript-eslint/utils";
 export default function configCreator({ react, typescriptTypeCheck, node, reactClassComp, reactPropTypes, }?: {
-    react?: boolean | TSESLint.FlatConfig.FileSpec[];
-    typescriptTypeCheck?: boolean | TSESLint.FlatConfig.FileSpec[];
-    node?: boolean | TSESLint.FlatConfig.FileSpec[];
-    reactClassComp?: boolean | TSESLint.FlatConfig.FileSpec[];
-    reactPropTypes?: boolean | TSESLint.FlatConfig.FileSpec[];
+    react?: boolean | (string[] | string)[];
+    typescriptTypeCheck?: boolean | (string[] | string)[];
+    node?: boolean | (string[] | string)[];
+    reactClassComp?: boolean | (string[] | string)[];
+    reactPropTypes?: boolean | (string[] | string)[];
 }): TSESLint.FlatConfig.ConfigArray;

package/dist/jsx.js

@@ -294,6 +294,7 @@ export default tseslint.config({
         "react/jsx-props-no-multi-spaces": "off",
         // We like spreading
         "react/jsx-props-no-spreading": "off",
+        "react/jsx-props-no-spread-multi": "error",
         "react/jsx-sort-props": 0,
         // Formatting
         "react/jsx-tag-spacing": "off",

package/dist/node.js

@@ -9,6 +9,7 @@ export default tseslint.config({
         },
     },
     plugins: {
+        // @ts-expect-error: TODO make an issue
         n: nPlugin,
     },
     rules: {

package/dist/react.js

@@ -17,10 +17,13 @@ export default tseslint.config({
         "react-hooks/exhaustive-deps": "error",
         "react-hooks/rules-of-hooks": "error",
         "react/boolean-prop-naming": "off",
-        "react/checked-requires-onchange-or-readonly": ["error", {
+        "react/checked-requires-onchange-or-readonly": [
+            "error",
+            {
                 ignoreExclusiveCheckedAttribute: false,
                 ignoreMissingProperties: false,
-            }],
+            },
+        ],
         // Sometimes we do need `props` as a whole, e.g. for spreading
         "react/destructuring-assignment": "off",
         // Isn't useful
@@ -28,6 +31,7 @@ export default tseslint.config({
         "react/forbid-component-props": 0,
         "react/forbid-dom-props": 0,
         "react/forbid-elements": 0,
+        "react/forward-ref-uses-ref": "error",
         // Note that it false-positives for `const Foo: Comp = () => <></>`
         "react/function-component-definition": [
             "warn",

package/dist/typescript-typecheck.js

@@ -28,6 +28,7 @@ export default tseslint.config({
                 ignoreVoidOperator: false,
             },
         ],
+        "@typescript-eslint/no-deprecated": "warn",
         "@typescript-eslint/no-floating-promises": [
             "warn",
             {
@@ -42,7 +43,7 @@ export default tseslint.config({
         "@typescript-eslint/no-unnecessary-boolean-literal-compare": "warn",
         "@typescript-eslint/no-unnecessary-condition": [
             "error",
-            { allowConstantLoopConditions: true },
+            { allowConstantLoopConditions: true, checkTypePredicates: true },
         ],
         // Enums & namespaces aren't allowed anyway.
         "@typescript-eslint/no-unnecessary-qualifier": "warn",
@@ -91,6 +92,6 @@ export default tseslint.config({
         "@typescript-eslint/switch-exhaustiveness-check": "error",
         // Not very useful in practice... A lot of false-positives
         "@typescript-eslint/unbound-method": "off",
-        "@typescript-eslint/use-unknown-in-catch-callback-variables": "error",
+        "@typescript-eslint/use-unknown-in-catch-callback-variable": "error",
     },
 });

package/dist/typescript.js

@@ -27,16 +27,6 @@ export default tseslint.config({
         // We've never used TSLint anyway
         // https://jc-verse.github.io/js-style-guide/typescript/base#ban-tslint-comment
         "@typescript-eslint/ban-tslint-comment": "error",
-        // https://jc-verse.github.io/js-style-guide/typescript/base#ban-types
-        "@typescript-eslint/ban-types": [
-            "error",
-            {
-                extendDefaults: true,
-                types: {
-                    "{}": false,
-                },
-            },
-        ],
         // https://jc-verse.github.io/js-style-guide/typescript/base#class-literal-property-style
         "@typescript-eslint/class-literal-property-style": ["warn", "getters"],
         // We turn off the base rule too
@@ -99,13 +89,16 @@ export default tseslint.config({
         // This can be useful for dynamic object transformations
         // https://jc-verse.github.io/js-style-guide/typescript/base#no-dynamic-delete
         "@typescript-eslint/no-dynamic-delete": "off",
+        // https://jc-verse.github.io/js-style-guide/typescript/base#no-empty-object-type
+        "@typescript-eslint/no-empty-object-type": [
+            "warn",
+            {
+                allowInterfaces: "with-single-extends",
+                allowObjectTypes: "never",
+            },
+        ],
         // We turn off the base rule too
         "@typescript-eslint/no-empty-function": "off",
-        // https://jc-verse.github.io/js-style-guide/typescript/base#no-empty-interface
-        "@typescript-eslint/no-empty-interface": [
-            "error",
-            { allowSingleExtends: true },
-        ],
         // https://jc-verse.github.io/js-style-guide/typescript/base#no-explicit-any
         "@typescript-eslint/no-explicit-any": "warn",
         // https://jc-verse.github.io/js-style-guide/typescript/base#no-extra-non-null-assertion
@@ -136,8 +129,6 @@ export default tseslint.config({
         ],
         // We turn off the base rule too
         "@typescript-eslint/no-loop-func": "off",
-        // To be deprecated
-        "@typescript-eslint/no-loss-of-precision": "off",
         // We turn off the base rule too
         "@typescript-eslint/no-magic-numbers": "off",
         // https://jc-verse.github.io/js-style-guide/typescript/base#no-misused-new
@@ -226,8 +217,6 @@ export default tseslint.config({
         "@typescript-eslint/no-useless-constructor": "error",
         // https://jc-verse.github.io/js-style-guide/typescript/base#no-useless-empty-export
         "@typescript-eslint/no-useless-empty-export": "error",
-        // https://jc-verse.github.io/js-style-guide/typescript/base#no-var-requires
-        "@typescript-eslint/no-var-requires": "error",
         // https://jc-verse.github.io/js-style-guide/typescript/base#parameter-properties
         "@typescript-eslint/parameter-properties": [
             "warn",
@@ -248,8 +237,6 @@ export default tseslint.config({
         ],
         // https://jc-verse.github.io/js-style-guide/typescript/base#prefer-namespace-keyword
         "@typescript-eslint/prefer-namespace-keyword": "error",
-        // https://jc-verse.github.io/js-style-guide/typescript/base#prefer-ts-expect-error
-        "@typescript-eslint/prefer-ts-expect-error": "error",
         "@typescript-eslint/sort-type-constituents": 0,
         // https://jc-verse.github.io/js-style-guide/typescript/base#triple-slash-reference
         "@typescript-eslint/triple-slash-reference": [
@@ -271,7 +258,6 @@ export default tseslint.config({
         "@typescript-eslint/default-param-last": "off",
         "@typescript-eslint/explicit-module-boundary-types": "off",
         "@typescript-eslint/no-require-imports": "off",
-        "@typescript-eslint/no-var-requires": "off",
     },
 }, {
     files: ["**/*.{ts,tsx,cts,mts}"],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-jc",
-  "version": "5.2.0",
+  "version": "6.0.0",
   "description": "Josh-Cena's personal coding style",
   "type": "module",
   "repository": {
@@ -36,20 +36,22 @@
     "prepublishOnly": "yarn build"
   },
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^7.8.0",
-    "@typescript-eslint/parser": "^7.8.0",
+    "@typescript-eslint/eslint-plugin": "^8.8.1",
+    "@typescript-eslint/parser": "^8.8.1",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-header": "^3.1.1",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-jsx-a11y": "^6.8.0",
-    "eslint-plugin-n": "^17.4.0",
-    "eslint-plugin-react": "^7.34.1",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-jsx-a11y": "^6.10.0",
+    "eslint-plugin-n": "^17.11.1",
+    "eslint-plugin-react": "^7.37.1",
     "eslint-plugin-react-hooks": "^4.6.2",
-    "eslint-plugin-regexp": "^2.5.0",
-    "globals": "^15.0.0",
-    "typescript-eslint": "^7.8.0"
+    "eslint-plugin-regexp": "^2.6.0",
+    "globals": "^15.11.0",
+    "typescript-eslint": "^8.8.1"
   },
   "devDependencies": {
     "@types/eslint-config-prettier": "^6.11.3"
+  },
+  "peerDependencies": {
+    "eslint": "^9.12.0"
   }
 }

package/src/base.ts

@@ -313,7 +313,7 @@ export default tseslint.config({
     "no-extra-bind": "error",
 
     // https://jc-verse.github.io/js-style-guide/eslint-base/operators#no-extra-boolean-cast
-    "no-extra-boolean-cast": ["error", { enforceForLogicalOperands: true }],
+    "no-extra-boolean-cast": ["error", { enforceForInnerExpressions: true }],
 
     // https://jc-verse.github.io/js-style-guide/eslint-base/control-flow#no-extra-label
     "no-extra-label": "error",
@@ -727,6 +727,9 @@ export default tseslint.config({
       },
     ],
 
+    // https://jc-verse.github.io/js-style-guide/eslint-base/variables-names#no-useless-assignment
+    "no-useless-assignment": "error",
+
     // https://jc-verse.github.io/js-style-guide/eslint-base/literals#no-useless-backreference
     "no-useless-backreference": "error",
 

package/src/index.ts

@@ -17,7 +17,7 @@ import reactPropTypesRules from "./react-prop-types.js";
 
 function expandConfig(
   config: TSESLint.FlatConfig.ConfigArray,
-  enabled: undefined | boolean | TSESLint.FlatConfig.FileSpec[],
+  enabled: undefined | boolean | (string[] | string)[],
 ): TSESLint.FlatConfig.ConfigArray {
   if (enabled === true) return config;
   if (!enabled) return [];
@@ -34,11 +34,11 @@ export default function configCreator({
   reactClassComp,
   reactPropTypes,
 }: {
-  react?: boolean | TSESLint.FlatConfig.FileSpec[];
-  typescriptTypeCheck?: boolean | TSESLint.FlatConfig.FileSpec[];
-  node?: boolean | TSESLint.FlatConfig.FileSpec[];
-  reactClassComp?: boolean | TSESLint.FlatConfig.FileSpec[];
-  reactPropTypes?: boolean | TSESLint.FlatConfig.FileSpec[];
+  react?: boolean | (string[] | string)[];
+  typescriptTypeCheck?: boolean | (string[] | string)[];
+  node?: boolean | (string[] | string)[];
+  reactClassComp?: boolean | (string[] | string)[];
+  reactPropTypes?: boolean | (string[] | string)[];
 } = {}): TSESLint.FlatConfig.ConfigArray {
   return tseslint.config(
     {

package/src/jsx.ts

@@ -362,6 +362,8 @@ export default tseslint.config({
     // We like spreading
     "react/jsx-props-no-spreading": "off",
 
+    "react/jsx-props-no-spread-multi": "error",
+
     "react/jsx-sort-props": 0,
 
     // Formatting

package/src/node.ts

@@ -10,6 +10,7 @@ export default tseslint.config({
     },
   },
   plugins: {
+    // @ts-expect-error: TODO make an issue
     n: nPlugin,
   },
   rules: {

package/src/react.ts

@@ -21,10 +21,13 @@ export default tseslint.config({
 
     "react/boolean-prop-naming": "off",
 
-    "react/checked-requires-onchange-or-readonly": ["error", {
-      ignoreExclusiveCheckedAttribute: false,
-      ignoreMissingProperties: false,
-    }],
+    "react/checked-requires-onchange-or-readonly": [
+      "error",
+      {
+        ignoreExclusiveCheckedAttribute: false,
+        ignoreMissingProperties: false,
+      },
+    ],
 
     // Sometimes we do need `props` as a whole, e.g. for spreading
     "react/destructuring-assignment": "off",
@@ -38,6 +41,8 @@ export default tseslint.config({
 
     "react/forbid-elements": 0,
 
+    "react/forward-ref-uses-ref": "error",
+
     // Note that it false-positives for `const Foo: Comp = () => <></>`
     "react/function-component-definition": [
       "warn",

package/src/typescript-typecheck.ts

@@ -36,6 +36,8 @@ export default tseslint.config({
       },
     ],
 
+    "@typescript-eslint/no-deprecated": "warn",
+
     "@typescript-eslint/no-floating-promises": [
       "warn",
       {
@@ -56,7 +58,7 @@ export default tseslint.config({
 
     "@typescript-eslint/no-unnecessary-condition": [
       "error",
-      { allowConstantLoopConditions: true },
+      { allowConstantLoopConditions: true, checkTypePredicates: true },
     ],
 
     // Enums & namespaces aren't allowed anyway.
@@ -130,6 +132,6 @@ export default tseslint.config({
     // Not very useful in practice... A lot of false-positives
     "@typescript-eslint/unbound-method": "off",
 
-    "@typescript-eslint/use-unknown-in-catch-callback-variables": "error",
+    "@typescript-eslint/use-unknown-in-catch-callback-variable": "error",
   },
 });

package/src/typescript.ts

@@ -33,17 +33,6 @@ export default tseslint.config(
       // https://jc-verse.github.io/js-style-guide/typescript/base#ban-tslint-comment
       "@typescript-eslint/ban-tslint-comment": "error",
 
-      // https://jc-verse.github.io/js-style-guide/typescript/base#ban-types
-      "@typescript-eslint/ban-types": [
-        "error",
-        {
-          extendDefaults: true,
-          types: {
-            "{}": false,
-          },
-        },
-      ],
-
       // https://jc-verse.github.io/js-style-guide/typescript/base#class-literal-property-style
       "@typescript-eslint/class-literal-property-style": ["warn", "getters"],
 
@@ -98,7 +87,7 @@ export default tseslint.config(
 
       "init-declarations": "off",
       // https://jc-verse.github.io/js-style-guide/typescript/base#init-declarations
-       
+
       "@typescript-eslint/init-declarations": ["error", "always"],
 
       // We turn off the base rule too
@@ -121,22 +110,25 @@ export default tseslint.config(
 
       "no-dupe-class-members": "off",
       // https://jc-verse.github.io/js-style-guide/typescript/base#no-dupe-class-members
-       
+
       "@typescript-eslint/no-dupe-class-members": "error",
 
       // This can be useful for dynamic object transformations
       // https://jc-verse.github.io/js-style-guide/typescript/base#no-dynamic-delete
       "@typescript-eslint/no-dynamic-delete": "off",
 
+      // https://jc-verse.github.io/js-style-guide/typescript/base#no-empty-object-type
+      "@typescript-eslint/no-empty-object-type": [
+        "warn",
+        {
+          allowInterfaces: "with-single-extends",
+          allowObjectTypes: "never",
+        },
+      ],
+
       // We turn off the base rule too
       "@typescript-eslint/no-empty-function": "off",
 
-      // https://jc-verse.github.io/js-style-guide/typescript/base#no-empty-interface
-      "@typescript-eslint/no-empty-interface": [
-        "error",
-        { allowSingleExtends: true },
-      ],
-
       // https://jc-verse.github.io/js-style-guide/typescript/base#no-explicit-any
       "@typescript-eslint/no-explicit-any": "warn",
 
@@ -175,9 +167,6 @@ export default tseslint.config(
       // We turn off the base rule too
       "@typescript-eslint/no-loop-func": "off",
 
-      // To be deprecated
-      "@typescript-eslint/no-loss-of-precision": "off",
-
       // We turn off the base rule too
       "@typescript-eslint/no-magic-numbers": "off",
 
@@ -200,7 +189,7 @@ export default tseslint.config(
 
       "no-redeclare": "off",
       // https://jc-verse.github.io/js-style-guide/typescript/base#no-redeclare
-       
+
       "@typescript-eslint/no-redeclare": [
         "error",
         {
@@ -216,7 +205,7 @@ export default tseslint.config(
 
       "no-shadow": "off",
       // https://jc-verse.github.io/js-style-guide/typescript/base#no-shadow
-       
+
       "@typescript-eslint/no-shadow": [
         "warn",
         {
@@ -243,7 +232,7 @@ export default tseslint.config(
 
       "no-unused-expressions": "off",
       // https://jc-verse.github.io/js-style-guide/typescript/base#no-unused-expressions
-       
+
       "@typescript-eslint/no-unused-expressions": [
         "error",
         {
@@ -256,7 +245,7 @@ export default tseslint.config(
 
       "no-unused-vars": "off",
       // https://jc-verse.github.io/js-style-guide/typescript/base#no-unused-vars
-       
+
       "@typescript-eslint/no-unused-vars": [
         "error",
         {
@@ -268,7 +257,7 @@ export default tseslint.config(
       ],
 
       "no-use-before-define": "off",
-       
+
       "@typescript-eslint/no-use-before-define": [
         "error",
         {
@@ -283,15 +272,12 @@ export default tseslint.config(
       ],
 
       "no-useless-constructor": "off",
-       
+
       "@typescript-eslint/no-useless-constructor": "error",
 
       // https://jc-verse.github.io/js-style-guide/typescript/base#no-useless-empty-export
       "@typescript-eslint/no-useless-empty-export": "error",
 
-      // https://jc-verse.github.io/js-style-guide/typescript/base#no-var-requires
-      "@typescript-eslint/no-var-requires": "error",
-
       // https://jc-verse.github.io/js-style-guide/typescript/base#parameter-properties
       "@typescript-eslint/parameter-properties": [
         "warn",
@@ -319,9 +305,6 @@ export default tseslint.config(
       // https://jc-verse.github.io/js-style-guide/typescript/base#prefer-namespace-keyword
       "@typescript-eslint/prefer-namespace-keyword": "error",
 
-      // https://jc-verse.github.io/js-style-guide/typescript/base#prefer-ts-expect-error
-      "@typescript-eslint/prefer-ts-expect-error": "error",
-
       "@typescript-eslint/sort-type-constituents": 0,
 
       // https://jc-verse.github.io/js-style-guide/typescript/base#triple-slash-reference
@@ -347,7 +330,6 @@ export default tseslint.config(
       "@typescript-eslint/default-param-last": "off",
       "@typescript-eslint/explicit-module-boundary-types": "off",
       "@typescript-eslint/no-require-imports": "off",
-      "@typescript-eslint/no-var-requires": "off",
     },
   },
   {