eslint-config-isaacscript 5.0.2 → 6.0.1

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-config-isaacscript",
-  "version": "5.0.2",
-  "description": "A sharable ESLint config for TypeScript and IsaacScript projects.",
+  "version": "6.0.1",
+  "description": "A sharable ESLint config for IsaacScript projects.",
   "keywords": [
     "eslint",
     "config",
@@ -24,19 +24,19 @@
   "type": "module",
   "main": "./src/index.js",
   "files": [
-    "LICENSE",
-    "package.json",
-    "README.md",
     "src"
   ],
   "scripts": {
     "lint": "tsx ./scripts/lint.ts"
   },
   "dependencies": {
-    "eslint-plugin-isaacscript": "^4.0.0",
-    "typescript-eslint": "^8.5.0"
+    "eslint-plugin-isaacscript": "4.0.0",
+    "typescript-eslint": "8.43.0"
   },
   "devDependencies": {
-    "complete-node": "^1.3.0"
+    "complete-node": "12.0.0"
+  },
+  "peerDependencies": {
+    "eslint": ">= 9.0.0"
   }
 }

package/src/mod.js

@@ -1,24 +1,30 @@
 import ESLintPluginIsaacScript from "eslint-plugin-isaacscript";
-import tseslint from "typescript-eslint";
-
-// Hot-patch "eslint-plugin-isaacscript" to convert errors to warnings.
-for (const config of ESLintPluginIsaacScript.configs.recommended) {
-  if (config.rules !== undefined) {
-    for (const [key, value] of Object.entries(config.rules)) {
-      if (value === "error") {
-        config.rules[key] = "warn";
-      }
-    }
-  }
-}
+import { defineConfig } from "eslint/config";
 
 /**
  * This ESLint config is meant to be used as a base for IsaacScript mods (or TypeScriptToLua
  * projects).
  */
-export const isaacScriptModConfigBase = tseslint.config(
-  // `eslint-plugin-isaacscript` provides rules specifically for IsaacScript mods.
-  ...ESLintPluginIsaacScript.configs.recommended,
+export const isaacScriptModConfigBase = defineConfig(
+  {
+    plugins: {
+      // TODO: The `defineConfig` helper function is bugged.
+      // @ts-expect-error https://github.com/typescript-eslint/typescript-eslint/issues/11543
+      isaacscript: ESLintPluginIsaacScript,
+    },
+
+    rules: {
+      "isaacscript/enum-member-number-separation": "warn",
+      "isaacscript/no-invalid-default-map": "warn",
+      "isaacscript/no-throw": "warn",
+      "isaacscript/require-v-registration": "warn",
+    },
+
+    // Rules that require type information will throw an error on ".json" files. (This is needed
+    // when using `eslint-plugin-package-json`. Even though this config does not currently use the
+    // plugin, we include it here defensively.)
+    ignores: ["*.json", "*.jsonc"],
+  },
 
   {
     rules: {
@@ -199,5 +205,45 @@ export const isaacScriptModConfigBase = tseslint.config(
        */
       "no-restricted-globals": "off",
     },
+
+    // Rules that require type information will throw an error on ".json" files. (This is needed
+    // when using `eslint-plugin-package-json`. Even though this config does not currently use the
+    // plugin, we include it here defensively.)
+    ignores: ["*.json", "*.jsonc"],
+  },
+
+  {
+    files: [
+      "eslint.config.js",
+      "eslint.config.cjs",
+      "eslint.config.mjs",
+      "eslint.config.ts",
+      "eslint.config.cts",
+      "eslint.config.mts",
+    ],
+    rules: {
+      // TypeScript projects that use "complete-lint" have a false positive when importing
+      // "defineConfig" from "eslint/config", because "eslint" is a transitive dependency in
+      // "complete-lint". Similarly, importing "completeConfigBase" from "eslint-config-complete"
+      // fails, because "eslint-config-complete" is a transitive dependency in "complete-lint". (We
+      // extend the logic from "eslint-config-complete" and add a new value for
+      // "eslint-config-isaacscript.")
+      "import-x/no-extraneous-dependencies": [
+        "warn",
+        {
+          devDependencies: ["**/eslint.config.{js,cjs,mjs,ts,cts,mts}"],
+          optionalDependencies: false,
+          whitelist: [
+            "eslint",
+            "eslint-config-complete",
+            "eslint-config-isaacscript",
+          ],
+        },
+      ],
+
+      // ESLint configuration files in monorepos often intentionally import from the "packages"
+      // subdirectory, because the config files are JavaScript so they cannot use tsconfig-paths.
+      "import-x/no-relative-packages": "off",
+    },
   },
 );