eslint-config-isaacscript 4.8.1 → 4.10.0

package/configs/base-typescript-eslint.js

@@ -147,6 +147,7 @@ const SUPPORTED_RULES = {
   "@typescript-eslint/no-unsafe-enum-comparison": "error",
   "@typescript-eslint/no-unsafe-member-access": "error",
   "@typescript-eslint/no-unsafe-return": "error",
+  "@typescript-eslint/no-unsafe-unary-minus": "error",
   "@typescript-eslint/no-useless-empty-export": "error",
   "@typescript-eslint/no-var-requires": "error",
   "@typescript-eslint/non-nullable-type-assertion-style": "error",
@@ -329,10 +330,59 @@ const EXTENSION_RULES = {
   "@typescript-eslint/no-redeclare": "off",
 
   /**
-   * Disabled since it would only be needed in specific environments (such as forbidding Node.js
-   * imports in a browser environment).
+   * Configured to prevent importing with some common patterns that are almost always a mistake:
+   *
+   * - "src" directories (but allowed in test files that are in a separate "tests" directory)
+   * - "dist" directories
+   * - "index" files (things in the same package should directly import instead of use the public
+   *   API)
    */
-  "@typescript-eslint/no-restricted-imports": "off",
+  "@typescript-eslint/no-restricted-imports": [
+    "error",
+    {
+      patterns: [
+        // Some "src" directories have an "index.ts" file, which means that importing from the
+        // directory is valid. Thus, we check for the "src" directory with no suffix.
+        {
+          group: ["**/src"],
+          message:
+            'You cannot import from a "src" directory. If this is a monorepo, import using the package name like you would in a non-monorepo project.',
+        },
+
+        {
+          group: ["**/src/**"],
+          message:
+            'You cannot import from a "src" directory. If this is a monorepo, import using the package name like you would in a non-monorepo project.',
+        },
+
+        // Some "dist" directories have an "index.ts" file, which means that importing from the
+        // directory is valid. Thus, we check for the "dist" directory with no suffix.
+        {
+          group: ["**/dist"],
+          message:
+            'You cannot import from a "dist" directory. If this is a monorepo, import using the package name like you would in a non-monorepo project.',
+        },
+
+        {
+          group: ["**/dist/**"],
+          message:
+            'You cannot import from a "dist" directory. If this is a monorepo, import using the package name like you would in a non-monorepo project.',
+        },
+
+        {
+          group: ["**/index"],
+          message:
+            "You cannot import from a package index. Instead, import directly from the file where the code is located.",
+        },
+
+        {
+          group: ["**/index.{js,cjs,mjs,ts,cts,mts}"],
+          message:
+            "You cannot import from a package index. Instead, import directly from the file where the code is located.",
+        },
+      ],
+    },
+  ],
 
   "@typescript-eslint/no-shadow": "error",
   "@typescript-eslint/no-throw-literal": "error",
@@ -446,11 +496,20 @@ const config = {
 
     // The built-in Node.js test-runner returns a promise which is not meant to be awaited.
     {
-      files: ["*.test.ts"],
+      files: ["*.test.{js,cjs,mjs,ts,cts,mts}"],
       rules: {
         "@typescript-eslint/no-floating-promises": "off",
       },
     },
+
+    // We want to be allowed to import from the "src" directory in test files that are located in a
+    // separate "tests" directory.
+    {
+      files: ["**/tests/**"],
+      rules: {
+        "@typescript-eslint/no-restricted-imports": "off",
+      },
+    },
   ],
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-isaacscript",
-  "version": "4.8.1",
+  "version": "4.10.0",
   "description": "A sharable ESLint config for TypeScript and IsaacScript projects.",
   "keywords": [
     "eslint",
@@ -31,7 +31,8 @@
     "README.md"
   ],
   "scripts": {
-    "lint": "tsx ./scripts/lint.mts"
+    "lint": "tsx ./scripts/lint.mts",
+    "query-rule": "tsx ./scripts/queryRule.mts"
   },
   "dependencies": {
     "confusing-browser-globals": "^1.0.11"