eslint-config-isaacscript 1.0.50 → 1.0.54

package/.vscode/settings.json

@@ -19,7 +19,7 @@
   // ----------
 
   // Automatically run the formatter when a JavaScript file is saved
-  "[javascript]":  {
+  "[javascript]": {
     "editor.codeActionsOnSave": [
       "source.fixAll.eslint",
     ],

package/base.js

@@ -34,6 +34,11 @@ module.exports = {
     // https://github.com/Zamiell/eslint-plugin-eqeqeq-fix
     "plugin:eqeqeq-fix/recommended",
 
+    // This prevents implicit iteration of Maps and Sets,
+    // which is helpful to prevent bugs when refactoring
+    // https://github.com/Zamiell/eslint-plugin-no-implicit-map-set-loops
+    "plugin:no-implicit-map-set-loops/recommended",
+
     // This provides a version of the "no-template-curly-in-string" that the "--fix" flag can fix
     // https://github.com/Zamiell/eslint-plugin-no-template-curly-in-string-fix
     "plugin:no-template-curly-in-string-fix/recommended",
@@ -42,12 +47,6 @@ module.exports = {
     // https://github.com/Zamiell/eslint-plugin-no-void-return-type
     "plugin:no-void-return-type/recommended",
 
-    // We use Prettier to automatically format TypeScript files
-    // We want to run Prettier as an ESLint rule so that we can detect non-formatted files in CI
-    // https://github.com/prettier/eslint-plugin-prettier
-    // https://silvenon.com/blog/integrating-and-enforcing-prettier-and-eslint
-    "plugin:prettier/recommended",
-
     // Disable any ESLint rules that conflict with Prettier
     // (otherwise, we will have unfixable ESLint errors)
     // https://github.com/prettier/eslint-config-prettier
@@ -205,7 +204,8 @@ module.exports = {
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md
     // Defined at:
     // https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/imports.js
-    // It is common to only export one thing with the intention of adding more exports later
+    // The case against default exports is layed out here:
+    // https://basarat.gitbook.io/typescript/main-1/defaultisbad
     "import/prefer-default-export": "off",
 
     // Documentation:
@@ -220,6 +220,7 @@ module.exports = {
         definedTags: [
           "category", // Used in TypeDoc
           "hidden", // Used in TypeDoc
+          "internal", // Used by TypeScript
           "noResolution", // Used in TypeScriptToLua as a compiler annotation
           "noSelf", // Used in TypeScriptToLua as a compiler annotation
         ],

package/mod.js

@@ -5,16 +5,21 @@ module.exports = {
     // The mod config extends the base configuration:
     // https://github.com/IsaacScript/eslint-config-isaacscript/blob/main/base.js
     "./base",
-
-    // This prevents implicit iteration of Maps and Sets,
-    // since it does not work robustly with the TypeScriptToLua transpiler
-    // https://github.com/Zamiell/eslint-plugin-no-implicit-map-set-loops
-    "plugin:no-implicit-map-set-loops/recommended",
   ],
 
   // We modify the linting rules from the base for some specific things
   // (listed in alphabetical order)
   rules: {
+    // Documentation:
+    // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-loop-func.md
+    // https://eslint.org/docs/rules/no-loop-func
+    // Defined at:
+    // https://github.com/iamturns/eslint-config-airbnb-typescript/blob/master/lib/shared.js
+    // This rule throws false positives with API functions
+    // It can be worked around by supplying lists of globals to ESLint, but this is ugly
+    // See: https://github.com/typescript-eslint/typescript-eslint/issues/2780
+    "@typescript-eslint/no-loop-func": "off",
+
     // Documentation:
     // https://github.com/eslint/eslint/blob/master/docs/rules/no-bitwise.md
     // Defined at:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-isaacscript",
-  "version": "1.0.50",
+  "version": "1.0.54",
   "description": "An ESLint config for IsaacScript projects.",
   "repository": {
     "type": "git",
@@ -9,8 +9,6 @@
   "license": "GPL-3.0",
   "author": "Zamiell",
   "devDependencies": {
-    "eslint": "^7.32.0",
-    "eslint-plugin-prettier": "^4.0.0",
-    "prettier": "^2.4.1"
+    "prettier": "^2.5.1"
   }
 }