eslint-config-heck 0.0.4 → 0.1.3

package/node.js

@@ -20,7 +20,7 @@ const env = {
 
 const globals = {};
 
-const plugins = ["react"];
+const plugins = ["react", "unicorn"];
 const settings = {
     react: {
         version: "detect",
@@ -148,7 +148,7 @@ const rules = {
     "no-floating-decimal": "error",
     "no-global-assign": "error",
     "no-implicit-coercion": "error",
-    "no-implicit-globals": "error",
+    "no-implicit-globals": "off",
     "no-implied-eval": "error",
     "no-invalid-this": "error",
     "no-iterator": "error",
@@ -244,7 +244,7 @@ const rules = {
             caughtErrors: "all",
         },
     ],
-    "no-use-before-define": "error",
+    "no-use-before-define": ["error", "nofunc"],
 
     // Stylistic issues
     "array-bracket-newline": [
@@ -268,7 +268,7 @@ const rules = {
     "func-call-spacing": "error",
     "func-name-matching": "off",
     "func-names": "off",
-    "func-style": "error",
+    "func-style": ["error", "declaration", { allowArrowFunctions: true }],
     "function-call-argument-newline": ["error", "consistent"],
     "function-paren-newline": ["error", "multiline-arguments"],
     "id-denylist": "off",
@@ -292,22 +292,7 @@ const rules = {
     "keyword-spacing": "error",
     "line-comment-position": "error",
     "linebreak-style": ["error"],
-    "lines-around-comment": [
-        "error",
-        {
-            beforeBlockComment: true,
-            beforeLineComment: true,
-            allowBlockStart: true,
-            allowBlockEnd: false,
-            allowObjectStart: true,
-            allowObjectEnd: false,
-            allowArrayStart: true,
-            allowArrayEnd: false,
-            allowClassStart: true,
-            allowClassEnd: false,
-            applyDefaultIgnorePatterns: true,
-        },
-    ],
+    "lines-around-comment": "off",
     "lines-between-class-members": [
         "error",
         "always",
@@ -350,6 +335,7 @@ const rules = {
         },
     ],
     "no-negated-condition": "off",
+
     "no-nested-ternary": "error",
     "no-new-object": "error",
     "no-plusplus": "off",
@@ -372,14 +358,7 @@ const rules = {
             consistent: true,
         },
     ],
-    "object-curly-spacing": [
-        "error",
-        "always",
-        {
-            arraysInObjects: false,
-            objectsInObjects: false,
-        },
-    ],
+    "object-curly-spacing": ["error", "always"],
     "object-property-newline": [
         "error",
         {
@@ -489,8 +468,14 @@ const rules = {
     "prefer-destructuring": [
         "error",
         {
-            object: true,
-            array: false,
+            VariableDeclarator: {
+                array: false,
+                object: true,
+            },
+            AssignmentExpression: {
+                array: false,
+                object: false,
+            },
         },
     ],
     "prefer-numeric-literals": "error",
@@ -523,8 +508,8 @@ const rules = {
     "react/function-component-definition": [
         "error",
         {
-            namedComponents: "function-expression",
-            unnamedComponents: "function-expression",
+            namedComponents: "function-declaration",
+            unnamedComponents: "arrow-function",
         },
     ],
     "react/no-access-state-in-setstate": "error",
@@ -572,7 +557,7 @@ const rules = {
         "error",
         {
             groups: {
-                rendering: ["/^render.+$/", "render"],
+                render: ["render", "/^render.+$/"],
             },
         },
     ],
@@ -632,7 +617,7 @@ const rules = {
     "react/jsx-max-depth": "off",
     "react/jsx-max-props-per-line": "error",
     "react/jsx-newline": "off",
-    "react/jsx-no-bind": "error",
+    "react/jsx-no-bind": ["error", { allowArrowFunctions: true }],
     "react/jsx-no-comment-textnodes": "error",
     "react/jsx-no-constructed-context-values": "error",
     "react/jsx-no-duplicate-props": "error",
@@ -676,6 +661,127 @@ const rules = {
             arrow: "parens-new-line",
         },
     ],
+
+    // eslint-plugin-unicorn
+    "unicorn/better-regex": "error",
+    "unicorn/catch-error-name": [
+        "error", {
+            name: "ex",
+            ignore: ["^ex([A-Z0-9].*)?$"],
+        },
+    ],
+    "unicorn/consistent-destructuring": "error",
+    "unicorn/consistent-function-scoping": [
+        "error", {
+            checkArrowFunctions: false,
+        },
+    ],
+    "unicorn/custom-error-definition": "off",
+    "unicorn/empty-brace-spaces": "off",
+    "unicorn/error-message": "error",
+    "unicorn/escape-case": "error",
+    "unicorn/expiring-todo-comments": "error",
+    "unicorn/explicit-length-check": "error",
+    "unicorn/filename-case": [
+        "error", {
+            cases: {
+                camelCase: true,
+                pascalCase: true,
+                kebabCase: false,
+                snakeCase: false,
+            },
+        },
+    ],
+    "unicorn/import-index": "error",
+    "unicorn/import-style": "error",
+    "unicorn/new-for-builtins": "error",
+    "unicorn/no-abusive-eslint-disable": "error",
+    "unicorn/no-array-callback-reference": "off",
+    "unicorn/no-array-for-each": "off",
+    "unicorn/no-array-method-this-argument": "error",
+    "unicorn/no-array-push-push": "error",
+    "unicorn/no-array-reduce": "off",
+    "unicorn/no-console-spaces": "error",
+    "unicorn/no-document-cookie": "error",
+    "unicorn/no-empty-file": "error",
+    "unicorn/no-for-loop": "error",
+    "unicorn/no-hex-escape": "error",
+    "unicorn/no-instanceof-array": "error",
+    "unicorn/no-invalid-remove-event-listener": "error",
+    "unicorn/no-keyword-prefix": "off",
+    "unicorn/no-lonely-if": "error",
+    "unicorn/no-nested-ternary": "off",
+    "unicorn/no-new-array": "error",
+    "unicorn/no-new-buffer": "error",
+    "unicorn/no-null": "off",
+    "unicorn/no-object-as-default-parameter": "error",
+    "unicorn/no-process-exit": "error",
+    "unicorn/no-static-only-class": "error",
+    "unicorn/no-this-assignment": "error",
+    "unicorn/no-unreadable-array-destructuring": "error",
+    "unicorn/no-unsafe-regex": "off",
+    "unicorn/no-unused-properties": "error",
+    "unicorn/no-useless-fallback-in-spread": "error",
+    "unicorn/no-useless-length-check": "error",
+    "unicorn/no-useless-spread": "error",
+    "unicorn/no-useless-undefined": "error",
+    "unicorn/no-zero-fractions": "error",
+    "unicorn/number-literal-case": "error",
+    "unicorn/numeric-separators-style": [
+        "error", {
+            number: { minimumDigits: 0, groupLength: 3 },
+        },
+    ],
+    "unicorn/prefer-add-event-listener": "error",
+    "unicorn/prefer-array-find": "error",
+    "unicorn/prefer-array-flat": "error",
+    "unicorn/prefer-array-flat-map": "error",
+    "unicorn/prefer-array-index-of": "error",
+    "unicorn/prefer-array-some": "error",
+    "unicorn/prefer-at": "error",
+    "unicorn/prefer-date-now": "error",
+    "unicorn/prefer-default-parameters": "error",
+    "unicorn/prefer-dom-node-append": "error",
+    "unicorn/prefer-dom-node-dataset": "error",
+    "unicorn/prefer-dom-node-remove": "error",
+    "unicorn/prefer-dom-node-text-content": "error",
+    "unicorn/prefer-export-from": "off",
+    "unicorn/prefer-includes": "error",
+    "unicorn/prefer-keyboard-event-key": "error",
+    "unicorn/prefer-math-trunc": "error",
+    "unicorn/prefer-modern-dom-apis": "error",
+    "unicorn/prefer-module": "off",
+    "unicorn/prefer-negative-index": "error",
+    "unicorn/prefer-node-protocol": "error",
+    "unicorn/prefer-number-properties": "error",
+    "unicorn/prefer-object-from-entries": "error",
+    "unicorn/prefer-object-has-own": "error",
+    "unicorn/prefer-optional-catch-binding": "error",
+    "unicorn/prefer-prototype-methods": "error",
+    "unicorn/prefer-query-selector": "off",
+    "unicorn/prefer-reflect-apply": "error",
+    "unicorn/prefer-regexp-test": "error",
+    "unicorn/prefer-set-has": "error",
+    "unicorn/prefer-spread": "error",
+
+    // TODO: only available in Node.js 15+, so enable it later
+    "unicorn/prefer-string-replace-all": "off",
+    "unicorn/prefer-string-slice": "error",
+    "unicorn/prefer-string-starts-ends-with": "error",
+    "unicorn/prefer-string-trim-start-end": "error",
+    "unicorn/prefer-switch": "error",
+
+    // TODO: off until there is a solution to this: https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1079
+    "unicorn/prefer-ternary": "off",
+    "unicorn/prefer-top-level-await": "off",
+    "unicorn/prefer-type-error": "error",
+    "unicorn/prevent-abbreviations": "off",
+    "unicorn/require-array-join-separator": "error",
+    "unicorn/require-number-to-fixed-digits-argument": "error",
+    "unicorn/require-post-message-target-origin": "error",
+    "unicorn/string-content": "off",
+    "unicorn/template-indent": "off",
+    "unicorn/throw-new-error": "error",
 };
 
 const overrides = [
@@ -716,7 +822,7 @@ const overrides = [
             "@typescript-eslint/class-literal-property-style": "error",
             "@typescript-eslint/consistent-indexed-object-style": "error",
             "@typescript-eslint/consistent-type-assertions": "error",
-            "@typescript-eslint/consistent-type-definitions": "off",
+            "@typescript-eslint/consistent-type-definitions": ["error", "interface"],
             "@typescript-eslint/consistent-type-imports": [
                 "error",
                 {
@@ -761,6 +867,12 @@ const overrides = [
                         regex: "^__html$", match: false,
                     },
                 },
+                {
+                    selector: ["parameter"],
+                    modifiers: ["unused"],
+                    format: ["strictCamelCase"],
+                    leadingUnderscore: "require",
+                },
                 {
                     selector: ["typeLike"],
                     format: ["StrictPascalCase"],
@@ -787,7 +899,11 @@ const overrides = [
             "@typescript-eslint/no-for-in-array": "error",
             "@typescript-eslint/no-implicit-any-catch": "error",
             "@typescript-eslint/no-inferrable-types": "error",
-            "@typescript-eslint/no-invalid-void-type": "error",
+            "@typescript-eslint/no-invalid-void-type": [
+                "error", {
+                    allowAsThisParameter: true,
+                },
+            ],
             "@typescript-eslint/no-meaningless-void-operator": "error",
             "@typescript-eslint/no-misused-new": "error",
             "@typescript-eslint/no-misused-promises": "error",
@@ -960,12 +1076,7 @@ const overrides = [
             "no-useless-constructor": "off",
             "@typescript-eslint/no-useless-constructor": "error",
             "object-curly-spacing": "off",
-            "@typescript-eslint/object-curly-spacing": [
-                "error", "always", {
-                    arraysInObjects: false,
-                    objectsInObjects: false,
-                },
-            ],
+            "@typescript-eslint/object-curly-spacing": ["error", "always"],
             "padding-line-between-statements": "off",
             "@typescript-eslint/padding-line-between-statements": [
                 "error",
@@ -1034,7 +1145,11 @@ const overrides = [
         rules: {
             // eslint-plugin-jest
             "jest/consistent-test-it": "error",
-            "jest/expect-expect": "error",
+            "jest/expect-expect": [
+                "error", {
+                    assertFunctionNames: ["expect*"],
+                },
+            ],
             "jest/max-nested-describe": "off",
             "jest/no-alias-methods": "error",
             "jest/no-commented-out-tests": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-heck",
-  "version": "0.0.4",
+  "version": "0.1.3",
   "description": "Contains an ESLint configuration for ES2015+, TypeScript, and React.",
   "main": "index.js",
   "scripts": {
@@ -15,18 +15,19 @@
   "author": "atheck",
   "license": "MIT",
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "5.3.1",
-    "@typescript-eslint/parser": "5.3.1",
+    "@typescript-eslint/eslint-plugin": "5.4.0",
+    "@typescript-eslint/parser": "5.4.0",
     "eslint": "8.2.0",
     "eslint-plugin-deprecation": "1.2.1",
     "eslint-plugin-jest": "25.2.4",
     "eslint-plugin-react": "7.27.0",
+    "eslint-plugin-unicorn": "38.0.1",
     "react": "17.0.2",
-    "typescript": "4.4.4"
+    "typescript": "4.5.2"
   },
   "devDependencies": {
     "@types/jest": "27.0.2",
-    "@types/react": "17.0.34",
+    "@types/react": "17.0.35",
     "jest": "27.3.1"
   }
 }