eslint-config-gristow 2.0.5 → 2.0.6

package/.vscode/settings.json

@@ -1,23 +1,20 @@
 {
-	// These are all my auto-save configs
-	"editor.formatOnSave": true,
-	// turn it off for JS and JSX, we will do this via eslint
-	"[javascript]": {
-		"editor.formatOnSave": false
-	},
-	"[typescript]": {
-		"editor.formatOnSave": false
-	},
-	"[svelte]": {
-		"editor.defaultFormatter": "esbenp.prettier-vscode"
-	},
-	// tell the ESLint plugin to run on save
-	"editor.codeActionsOnSave": {
-		"source.fixAll.eslint": true
-	},
-	"eslint.autoFixOnSave": true,
-	// Optional BUT IMPORTANT: If you have the prettier extension enabled for other languages like CSS and HTML, turn it off for JS since we are doing it through Eslint already
-	"prettier.disableLanguages": ["javascript", "javascriptreact", "typescript"],
-	"eslint.validate": ["javascript", "javascriptreact", "typescript", "svelte"],
-	"eslint.probe": ["javascript", "typescript", "html", "svelte", "markdown"]
+  "[javascript]": {
+    "editor.codeActionsOnSave": {
+      "source.fixAll.eslint": true
+    }
+  },
+  "[typescript]": {
+    "editor.codeActionsOnSave": {
+      "source.fixAll.eslint": true
+    }
+  },
+  "eslint.validate": ["javascript", "typescript", "svelte"],
+	"eslint.probe": ["javascript", "typescript", "html", "svelte", "markdown"],
+  "editor.defaultFormatter": "esbenp.prettier-vscode",
+  "editor.formatOnSave": true,
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "prettier.disableLanguages": ["javascript", "javascriptreact", "typescript"],
+  "editor.tabSize": 2,
+  "editor.insertSpaces": true
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-gristow",
-  "version": "2.0.5",
+  "version": "2.0.6",
   "description": "Eslint settings for Greg Ristow",
   "main": "index.js",
   "scripts": {

package/rules/shared-rules.cjs

@@ -83,9 +83,70 @@ module.exports = {
   'implicit-arrow-linebreak': 'off',
   'function-paren-newline': 'off',
   // Snake case often comes in via external libraries
-  camelcase: ['error', {
-    properties: 'always',
-    ignoreDestructuring: true,
-    ignoreImports: true,
-  }]
+  // camelcase: ['error', {
+  //   properties: 'always',
+  //   ignoreDestructuring: true,
+  //   ignoreImports: true,
+  // }],
+  camelcase: 'off',
+  '@typescript-eslint/naming-convention': [
+    'error',
+    // By default, all should be camelCase
+    {
+      selector: 'default',
+      format: ['camelCase'],
+    },
+    // But, when we're destructuring, allow whatever it was:
+    {
+      selector: 'variable',
+      modifiers: ['destructured'],
+      format: null,
+    },
+    // And, if the property requires quotes, allow anything:
+    {
+      selector: [
+        'classProperty',
+        'objectLiteralProperty',
+        'typeProperty',
+        'classMethod',
+        'objectLiteralMethod',
+        'typeMethod',
+        'accessor',
+        'enumMember',
+      ],
+      format: null,
+      modifiers: ['requiresQuotes'],
+    },
+    // But require variables to be in camelCase or UPPER_SNAKE
+    {
+      selector: 'variable',
+      format: ['camelCase', 'UPPER_CASE'],
+    },
+    // Allow leading underscores in function params
+    {
+      selector: 'parameter',
+      format: ['camelCase'],
+      leadingUnderscore: 'allow',
+    },
+    // Allow leading underscores in class private members
+    {
+      selector: 'memberLike',
+      modifiers: ['private'],
+      format: ['camelCase'],
+      leadingUnderscore: 'allow',
+    },
+    // And allow snake_case in object literals -- which simplifies
+    // our interaction with external libraries where options objects
+    // often require these.
+    {
+      selector: 'objectLiteralProperty',
+      format: ['camelCase', 'snake_case'],
+    },
+    // Make sure types and interfaces are in PascalCase. (Also applies
+    // to classes.)
+    {
+      selector: 'typeLike',
+      format: ['PascalCase'],
+    },
+  ],
 };

package/test-ts-export.ts

@@ -1,3 +1,5 @@
 export function greet(firstName: string, lastName: string): string {
   return `${firstName} ${lastName}`;
 }
+
+export const snake_case_import = 'snake case import';

package/test.ts

@@ -1,5 +1,5 @@
 import { greetJS } from './test-js-export';
-import { greet } from './test-ts-export';
+import { greet, snake_case_import } from './test-ts-export';
 
 greetJS('Johnny', 'Appleseed');
 greet('Jenny', 'Applesseed');
@@ -25,4 +25,23 @@ function addOne(n) {
   return n + 1;
 }
 
+// error because not PascalCase
+export class myClassName {}
+
+const SNAKE_CASE_VARIABLE = 'snake case variable';
+console.log(SNAKE_CASE_VARIABLE);
+
+const this_is_a_problem = 'snake case variable';
+console.log(this_is_a_problem);
+
+console.log(snake_case_import);
+
+const coordinates = {
+  x_top: 0,
+};
+
+const { x_top } = coordinates;
+
 throw 'hello';
+
+console.log('unreachable code error!');