eslint-config-gristow 2.0.19 → 3.0.0-alpha.1

package/rules/{typescript-only-rules.cjs → typescript-only-rules.js}

@@ -1,4 +1,7 @@
-module.exports = {
+/**
+ * Rules that apply only to TypeScript files
+ */
+export default {
   // Everything we get in .js from this, we get in .ts for free. And, if we
   // add this, we can't hoist type definitions any more.
   'no-use-before-define': 'off',

package/.eslintrc.cjs

@@ -1,44 +0,0 @@
-const rules = require('./rules/shared-rules.cjs');
-const importRules = require('./rules/import-rules.js');
-const typescriptOnlyRules = require('./rules/typescript-only-rules.cjs');
-
-module.exports = {
-  root: true,
-  extends: [
-    'eslint:recommended',
-    'plugin:@typescript-eslint/recommended',
-    'airbnb/base',
-    'prettier',
-  ],
-  parser: '@typescript-eslint/parser',
-  plugins: ['@typescript-eslint', 'import'],
-  // plugins: ['@typescript-eslint'],
-  parserOptions: {
-    sourceType: 'module',
-    ecmaVersion: 2020,
-    project: './tsconfig.json',
-  },
-  settings: {
-    'import/parsers': {
-      '@typescript-eslint/parser': ['.ts'],
-    },
-    'import/resolver': {
-      typescript: true,
-    },
-  },
-  rules: {
-    ...rules,
-    ...importRules,
-  },
-  env: {
-    browser: true,
-    es2017: true,
-    node: true,
-  },
-  overrides: [
-    {
-      files: ['*.ts'],
-      rules: typescriptOnlyRules,
-    },
-  ],
-};

package/.eslintrc.cjs.recent.bak

@@ -1,68 +0,0 @@
-const rules = require('./shared-rules.js');
-
-module.exports = {
-  root: true,
-  extends: [
-    'eslint:recommended',
-    'plugin:@typescript-eslint/recommended',
-    'prettier',
-    'plugin:svelte/recommended',
-    'plugin:import/recommended',
-  ],
-  parser: '@typescript-eslint/parser',
-  plugins: ['@typescript-eslint', 'import'],
-  parserOptions: {
-    sourceType: 'module',
-    ecmaVersion: 2020,
-    extraFileExtensions: ['.svelte'],
-  },
-  env: {
-    browser: true,
-    es2017: true,
-    node: true,
-  },
-  settings: {
-    'import/parsers': {
-      '@typescript-eslint/parser': ['.ts', '.tsx'],
-    },
-    'import/resolver': {
-      typescript: {
-        alwaysTryTypes: true, // always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
-      },
-    },
-    import: {
-      parsers: {
-        '@typescript-eslint/parser': ['.ts'],
-      },
-    },
-  },
-  rules,
-  overrides: [
-    {
-      files: ['*.svelte'],
-      parser: 'svelte-eslint-parser',
-      parserOptions: {
-        parser: '@typescript-eslint/parser',
-        extraFileExtensions: ['.svelte'],
-        sourceType: 'module',
-        ecmaVersion: 2020,
-      },
-    },
-    {
-      files: ['*.ts'],
-      parser: '@typescript-eslint/parser',
-      rules,
-    },
-    {
-      files: ['*.js'],
-      rules,
-    },
-    {
-      files: ['*.cjs'],
-      rules: {
-        '@typescript-eslint/no-var-requires': 'off',
-        ...rules,
-      },
-    },
-  ],
-};

package/.eslintrc.cjs.working.bak

@@ -1,40 +0,0 @@
-const sharedRules = require('./shared-rules.cjs');
-
-module.exports = {
-  root: true,
-  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier'],
-  parser: '@typescript-eslint/parser',
-  plugins: ['@typescript-eslint', 'import'],
-  // plugins: ['@typescript-eslint'],
-  parserOptions: {
-    sourceType: 'module',
-    ecmaVersion: 2020,
-    extraFileExtensions: ['.svelte'],
-  },
-  settings: {
-    'import/parsers': {
-      '@typescript-eslint/parser': ['.ts', '.tsx'],
-    },
-    'import/resolver': {
-      typescript: true,
-    },
-  },
-  rules: {
-    'no-throw-literal': 'error',
-    ...sharedRules,
-  },
-  env: {
-    browser: true,
-    es2017: true,
-    node: true,
-  },
-  overrides: [
-    {
-      files: ['*.svelte'],
-      parser: 'svelte-eslint-parser',
-      parserOptions: {
-        parser: '@typescript-eslint/parser',
-      },
-    },
-  ],
-};

package/.eslintrc.js.original.bak

@@ -1,82 +0,0 @@
-// See https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/ROADMAP.md for tslint-eslint rule migration
-
-const rules = require('./shared-rules');
-const prettierRules = require('./prettier-rules');
-
-module.exports = {
-  parser: '@typescript-eslint/parser',
-  parserOptions: {
-    ecmaVersion: 2022,
-    project: ['./tsconfig.json'],
-    allowAutomaticSingleRunInference: true,
-    // Can I remove these now?
-    ecmaFeatures: {
-      impliedStrict: true,
-      classes: true,
-    },
-    requireConfigFile: false,
-  },
-  rules,
-  overrides: [
-    {
-      files: ['*.js'],
-      plugins: ['prettier', 'jsdoc'],
-      extends: ['airbnb/base', 'prettier'],
-      rules: {
-        ...prettierRules,
-        '@typescript-eslint/indent': 'off',
-        'jsdoc/check-alignment': 1, // Recommended
-        'jsdoc/check-param-names': 1, // Recommended
-        'jsdoc/check-tag-names': 1, // Recommended
-        'jsdoc/check-types': 1, // Recommended
-        'jsdoc/implements-on-classes': 1, // Recommended
-        'jsdoc/newline-after-description': 1, // Recommended
-        'jsdoc/no-undefined-types': 1, // Recommended
-        'jsdoc/require-description': 'warn',
-        'jsdoc/require-param': 1, // Recommended
-        'jsdoc/require-param-description': 'warn', // Recommended
-        'jsdoc/require-param-name': 1, // Recommended
-        'jsdoc/require-param-type': 1, // Recommended
-        'jsdoc/require-returns': 'warn', // Recommended
-        'jsdoc/require-returns-check': 1, // Recommended
-        'jsdoc/require-returns-description': 'warn', // Recommended
-        'jsdoc/require-returns-type': 1, // Recommended
-        'jsdoc/valid-types': 1, // Recommended
-        'import/no-cycle': 'off',
-      },
-    },
-    {
-      files: ['*.ts'],
-      plugins: ['prettier', 'eslint-plugin-tsdoc'],
-      parser: '@typescript-eslint/parser',
-      extends: ['airbnb-typescript/base', 'prettier'],
-      rules: {
-        ...prettierRules,
-        '@typescript-eslint/indent': 'off',
-        'import/no-cycle': 'off', // otherwise captures cycles by type inclusion
-        '@typescript-eslint/no-var-requires': 'warn',
-        '@typescript-eslint/no-use-before-define': ['error', { functions: false }],
-        'import/no-unresolved': 0,
-        'no-use-before-define': 'off',
-        'no-useless-constructor': 'off',
-        // no-dupe-class-members should be removed when this PR lands:
-        // https://github.com/typescript-eslint/typescript-eslint/pull/1492
-        'no-dupe-class-members': 'off',
-        // So we can allow overloading, and list of class props defined
-        'lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: true }],
-        '@typescript-eslint/no-useless-constructor': 'error',
-        'tsdoc/syntax': 'warn',
-        'no-shadow': 'off',
-        // We get these via TS checking, and w/ import type we might have 2 entries,
-        // one for named, one for default, one for actual import.
-        'import/no-duplicates': 'off',
-        'no-duplicate-imports': 'off',
-      },
-      settings: {
-        jsdoc: {
-          mode: 'typescript',
-        },
-      },
-    },
-  ],
-};

package/.prettierrc

@@ -1,7 +0,0 @@
-{
-  "useTabs": false,
-  "singleQuote": true,
-  "trailingComma": "es5",
-  "printWidth": 100,
-  "parser": "typescript"
-}

package/.vscode/settings.json

@@ -1,20 +0,0 @@
-{
-  "[javascript]": {
-    "editor.codeActionsOnSave": {
-      "source.fixAll.eslint": true
-    }
-  },
-  "[typescript]": {
-    "editor.codeActionsOnSave": {
-      "source.fixAll.eslint": true
-    }
-  },
-  "eslint.validate": ["javascript", "typescript", "svelte"],
-	"eslint.probe": ["javascript", "typescript", "html", "svelte", "markdown"],
-  "editor.defaultFormatter": "esbenp.prettier-vscode",
-  "editor.formatOnSave": true,
-  "typescript.tsdk": "node_modules/typescript/lib",
-  "prettier.disableLanguages": ["javascript", "javascriptreact", "typescript"],
-  "editor.tabSize": 2,
-  "editor.insertSpaces": true
-}

package/rules/svelte-rules.cjs

@@ -1,12 +0,0 @@
-module.exports = {
-  // Must disable to make 2-way data binding possible
-  'import/no-mutable-exports': 'off',
-  'no-labels': 'off',
-  'no-restricted-syntax': 'off',
-  // In svelte we often have to init an export ot undefined to mark it as an optional
-  // property:
-  'no-undef-init': 'off',
-  // Svelte checking will handle verifying resolved imports, and eslint is unfortunately
-  // unaware of vite paths:
-  'import/no-unresolved': 'off',
-};

package/svelte/svelte.eslintrc.cjs

@@ -1,28 +0,0 @@
-const svelteRules = require('../rules/svelte-rules.cjs');
-
-module.exports = {
-  extends: ['gristow', 'plugin:svelte/recommended'],
-  parserOptions: {
-    sourceType: 'module',
-    ecmaVersion: 2020,
-    extraFileExtensions: ['.svelte'],
-  },
-  settings: {
-    'import/parsers': {
-      '@typescript-eslint/parser': ['.ts', '.svelte'],
-    },
-    'import/resolver': {
-      typescript: true,
-    },
-  },
-  overrides: [
-    {
-      files: ['*.svelte'],
-      parser: 'svelte-eslint-parser',
-      parserOptions: {
-        parser: '@typescript-eslint/parser',
-      },
-      rules: svelteRules,
-    },
-  ],
-};

package/svelte.js

@@ -1,3 +0,0 @@
-const eslintrc = require('./svelte/svelte.eslintrc.cjs');
-
-module.exports = eslintrc;

package/test-js-export.js

@@ -1,3 +0,0 @@
-export function greetJS(firstName, lastName) {
-  return `${firstName} ${lastName}`;
-}

package/test-ts-export.ts

@@ -1,8 +0,0 @@
-export function greet(firstName: string, lastName: string): string {
-  return `${firstName} ${lastName}`;
-}
-
-export const snake_case_import = 'snake case import';
-
-export type Apple = 'apple';
-export const apple: Apple = 'apple';

package/test.js

@@ -1,44 +0,0 @@
-// Import should work:
-import { greetJS } from './test-js-export';
-import { greet } from './test-ts-export.ts';
-
-greetJS('Johnny', 'Appleseed');
-greet('Jenny', 'Applesseed');
-
-/**
- * A person
- */
-class Person {
-  name = 'Gregory Ristow';
-
-  /**
-   * Initialize and set the person's name
-   *
-   * @param {string} name
-   */
-  constructor(name = 'Gregory Ristow') {
-    this.name = name;
-  }
-}
-
-/**
- * @param firstName
- * @param lastName
- */
-function userData(firstName, lastName) {
-  // Should show error
-  const a = 3;
-  const b = a > 3 ? 1 : a > 5 ? 2 : 3;
-  let c = 4;
-  c++;
-  addOne(c);
-
-  return `${firstName} ${lastName}`;
-}
-
-/**
- * @param n
- */
-function addOne(n) {
-  return n + 1;
-}

package/test.ts

@@ -1,64 +0,0 @@
-import { greetJS } from './test-js-export';
-import { apple, snake_case_import, greet } from './test-ts-export';
-import type { Apple } from './test-ts-export';
-
-greetJS('Johnny', 'Appleseed');
-greet('Jenny', 'Applesseed');
-
-const a = {
-  this_pRop_is_ok: 3,
-  _this_prop_is_not: 4,
-  neither__is_this_one: 5,
-};
-console.log(a);
-
-export function completeName(fullName);
-export function completeName(firstName, lastName?) {
-  // Should show error, unused variable...
-  const a = 3;
-  const b = a > 3 ? 1 : a > 5 ? 2 : 3;
-  let c = 4;
-  c++;
-  addOne(c);
-
-  return `${firstName}${lastName ? ` ${lastName}` : ''}`;
-}
-
-// Should NOT complain we haven't used an arrow callback:
-setTimeout(function isNotAnArrowFunction() {
-  console.log('timeout');
-}, 500);
-
-function addOne(n) {
-  return n + 1;
-}
-
-// error because not PascalCase
-export class myClassName {}
-
-const SNAKE_CASE_VARIABLE = 'snake case variable';
-console.log(SNAKE_CASE_VARIABLE);
-
-const this_is_a_problem = 'snake case variable';
-console.log(this_is_a_problem);
-
-console.log(snake_case_import);
-
-const coordinates = {
-  x_top: 0,
-};
-
-const { x_top } = coordinates;
-
-const a: Apple = apple;
-console.log(a);
-
-throw 'hello';
-
-console.log('unreachable code error!');
-
-later();
-
-function later() {
-  return 'later';
-}

package/tsconfig.json

@@ -1,17 +0,0 @@
-{
-  "compilerOptions": {
-    "outDir": "build",
-    "allowJs": true,
-    "sourceMap": true,
-    "target": "ESNext",
-    "noUnusedLocals": true,
-    "declaration": false,
-    "baseUrl": "./",
-    "allowSyntheticDefaultImports": true,
-    "experimentalDecorators": true,
-  },
-
-  "exclude": [
-    "node_modules",
-  ]
-}