eslint-config-gristow 2.0.14 → 2.0.16

package/.eslintrc.cjs

@@ -1,5 +1,6 @@
 const rules = require('./rules/shared-rules.cjs');
 const importRules = require('./rules/import-rules.js');
+const typescriptOnlyRules = require('./rules/typescript-only-rules.cjs');
 
 module.exports = {
   root: true,
@@ -33,4 +34,8 @@ module.exports = {
     es2017: true,
     node: true,
   },
+  overrides: {
+    files: ['*.ts'],
+    rules: typescriptOnlyRules,
+  },
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-gristow",
-  "version": "2.0.14",
+  "version": "2.0.16",
   "description": "Eslint settings for Greg Ristow",
   "main": "index.js",
   "scripts": {

package/rules/shared-rules.cjs

@@ -83,7 +83,8 @@ module.exports = {
   'no-redeclare': 'off',
   '@typescript-eslint/no-redeclare': 'error',
   // Enabled by airbnb -- but we use literal throws extensively, and intentionally, in /backend
-  'no-throw-literal': 'off',
+  // so we override this there.
+  'no-throw-literal': 'on',
   '@typescript-eslint/no-throw-literal': 'off',
   'no-useless-constructor': 'off',
   '@typescript-eslint/no-useless-constructor': 'error',
@@ -102,4 +103,5 @@ module.exports = {
   // }],
   camelcase: 'off',
   ...namingConvention,
+  '@typescript-eslint/no-unnecessary-condition': ['warn'],
 };

package/rules/typescript-only-rules.cjs

@@ -0,0 +1,5 @@
+module.exports = {
+  // Everything we get in .js from this, we get in .ts for free. And, if we
+  // add this, we can't hoist type definitions any more.
+  'no-use-before-define': 'off',
+};

package/test.ts

@@ -56,3 +56,9 @@ console.log(a);
 throw 'hello';
 
 console.log('unreachable code error!');
+
+later();
+
+function later() {
+  return 'later';
+}