eslint-config-conventions 1.1.0 → 2.0.0

package/.eslintrc.json

@@ -144,7 +144,6 @@
     "prefer-regex-literals": ["error", { "disallowRedundantWrapping": true }],
     "quote-props": ["error", "as-needed"],
     "radix": "error",
-    "require-await": "error",
     "yoda": ["error", "never"],
 
     "import/no-absolute-path": "error",
@@ -231,11 +230,8 @@
         ],
         "no-useless-constructor": "off",
         "@typescript-eslint/no-useless-constructor": "error",
-        "require-await": "off",
-        "@typescript-eslint/require-await": "error",
 
         "@typescript-eslint/adjacent-overload-signatures": "error",
-        "@typescript-eslint/await-thenable": "error",
         "@typescript-eslint/array-type": [
           "error",
           { "default": "array-simple" }
@@ -292,7 +288,6 @@
         "@typescript-eslint/no-for-in-array": "error",
         "@typescript-eslint/no-invalid-void-type": "error",
         "@typescript-eslint/no-misused-new": "error",
-        "@typescript-eslint/no-misused-promises": "error",
         "@typescript-eslint/no-non-null-asserted-optional-chain": "error",
         "@typescript-eslint/no-non-null-assertion": "error",
         "@typescript-eslint/no-this-alias": [

package/.github/workflows/lint.yml

@@ -10,10 +10,10 @@ jobs:
   lint:
     runs-on: 'ubuntu-latest'
     steps:
-      - uses: 'actions/checkout@v2.4.0'
+      - uses: 'actions/checkout@v3.0.0'
 
       - name: 'Use Node.js'
-        uses: 'actions/setup-node@v2.5.1'
+        uses: 'actions/setup-node@v3.1.0'
         with:
           node-version: 'lts/*'
           cache: 'npm'

package/.github/workflows/release.yml

@@ -8,13 +8,13 @@ jobs:
   release:
     runs-on: 'ubuntu-latest'
     steps:
-      - uses: 'actions/checkout@v2.4.0'
+      - uses: 'actions/checkout@v3.0.0'
         with:
           fetch-depth: 0
           persist-credentials: false
 
       - name: 'Use Node.js'
-        uses: 'actions/setup-node@v2.5.1'
+        uses: 'actions/setup-node@v3.1.0'
         with:
           node-version: 'lts/*'
           cache: 'npm'

package/.github/workflows/test.yml

@@ -10,10 +10,10 @@ jobs:
   test:
     runs-on: 'ubuntu-latest'
     steps:
-      - uses: 'actions/checkout@v2.4.0'
+      - uses: 'actions/checkout@v3.0.0'
 
       - name: 'Use Node.js'
-        uses: 'actions/setup-node@v2.5.1'
+        uses: 'actions/setup-node@v3.1.0'
         with:
           node-version: 'lts/*'
           cache: 'npm'

package/.taprc

@@ -0,0 +1,8 @@
+ts: false
+jsx: false
+flow: false
+check-coverage: true
+coverage: true
+
+test-ignore:
+  - 'test/fixtures'

package/README.md

@@ -41,9 +41,9 @@ Here is an example, but use it only for reference, because your decisions regard
 ```sh
 npm install --save-dev \
   eslint@^8.9.0 \
-  eslint-plugin-import@^2.25.4 \
+  eslint-plugin-import@^2.26.0 \
   eslint-plugin-promise@^6.0.0 \
-  eslint-plugin-unicorn@^41.0.0 \
+  eslint-plugin-unicorn@^42.0.0 \
   eslint-config-conventions@latest
 ```
 
@@ -62,9 +62,9 @@ If you want to use **TypeScript**, you also need to install:
 
 ```sh
 npm install --save-dev \
-  typescript@^4.4.0 \
-  @typescript-eslint/eslint-plugin@^5.12.0 \
-  @typescript-eslint/parser@^5.12.0
+  typescript@^4.6.0 \
+  @typescript-eslint/eslint-plugin@^5.18.0 \
+  @typescript-eslint/parser@^5.18.0
 ```
 
 Dependencies are:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-conventions",
-  "version": "1.1.0",
+  "version": "2.0.0",
   "public": true,
   "description": "ESLint shareable config to enforce strict conventions and good code quality.",
   "author": "Divlo <contact@divlo.fr>",
@@ -34,7 +34,7 @@
     "lint:javascript": "eslint \"**/*.{js,jsx,ts,tsx}\" -c \"eslintrc.json\"",
     "lint:prettier": "prettier \".\" --check --ignore-path \".gitignore\"",
     "lint:staged": "lint-staged",
-    "test": "tape \"test/**/*.js\"",
+    "test": "tap",
     "release": "semantic-release",
     "_postinstall": "husky install",
     "prepublishOnly": "pinst --disable",
@@ -42,29 +42,29 @@
   },
   "peerDependencies": {
     "eslint": "^8.9.0",
-    "eslint-plugin-import": "^2.25.4",
+    "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-promise": "^6.0.0",
-    "eslint-plugin-unicorn": "^41.0.0"
+    "eslint-plugin-unicorn": "^42.0.0"
   },
   "devDependencies": {
-    "@commitlint/cli": "16.2.1",
+    "@commitlint/cli": "16.2.3",
     "@commitlint/config-conventional": "16.2.1",
-    "editorconfig-checker": "4.0.2",
-    "eslint": "8.9.0",
     "@types/eslint": "8.4.1",
-    "eslint-plugin-import": "2.25.4",
+    "@types/tap": "15.0.6",
+    "@typescript-eslint/eslint-plugin": "5.18.0",
+    "@typescript-eslint/parser": "5.18.0",
+    "editorconfig-checker": "4.0.2",
+    "eslint": "8.12.0",
+    "eslint-plugin-import": "2.26.0",
     "eslint-plugin-promise": "6.0.0",
-    "eslint-plugin-unicorn": "41.0.0",
-    "typescript": "4.5.5",
-    "@typescript-eslint/parser": "5.12.0",
-    "@typescript-eslint/eslint-plugin": "5.12.0",
-    "tape": "5.5.2",
+    "eslint-plugin-unicorn": "42.0.0",
     "husky": "7.0.4",
-    "lint-staged": "12.3.4",
+    "lint-staged": "12.3.7",
     "markdownlint-cli": "0.31.1",
-    "@types/tape": "4.13.2",
-    "pinst": "2.1.6",
-    "prettier": "2.5.1",
-    "semantic-release": "19.0.2"
+    "pinst": "3.0.0",
+    "prettier": "2.6.2",
+    "semantic-release": "19.0.2",
+    "tap": "16.0.1",
+    "typescript": "4.6.3"
   }
 }

package/test/basic.js

@@ -1,13 +1,12 @@
-const test = require('tape')
+const tap = require('tap')
 
 const config = require('../index.js')
 
-test('test basic properties of config', function (t) {
+tap.test('test basic properties of config', async (t) => {
   t.ok(isObject(config.parserOptions))
   t.ok(isObject(config.env))
   t.ok(isObject(config.rules))
   t.ok(isObject(config.overrides))
-  t.end()
 })
 
 function isObject(object) {

package/test/validate-config.js

@@ -1,5 +1,5 @@
 const { ESLint } = require('eslint')
-const test = require('tape')
+const tap = require('tap')
 
 const eslint = new ESLint({
   ignore: false,
@@ -7,7 +7,7 @@ const eslint = new ESLint({
   overrideConfigFile: 'eslintrc.json'
 })
 
-test('ensure we validate correctly JavaScript files', async (t) => {
+tap.test('ensure we validate correctly JavaScript files', async (t) => {
   const [noErrors] = await eslint.lintFiles(
     'test/fixtures/javascript-no-errors.js'
   )
@@ -16,10 +16,9 @@ test('ensure we validate correctly JavaScript files', async (t) => {
   )
   t.equal(noErrors.errorCount, 0)
   t.equal(withErrors.errorCount, 3)
-  t.end()
 })
 
-test('ensure we validate correctly TypeScript files', async (t) => {
+tap.test('ensure we validate correctly TypeScript files', async (t) => {
   const [noErrors] = await eslint.lintFiles(
     'test/fixtures/typescript-no-errors.ts'
   )
@@ -28,13 +27,11 @@ test('ensure we validate correctly TypeScript files', async (t) => {
   )
   t.equal(noErrors.errorCount, 0)
   t.equal(withErrors.errorCount, 3)
-  t.end()
 })
 
-test('ensure we allow top-level await', async (t) => {
+tap.test('ensure we allow top-level await', async (t) => {
   const [lintResult] = await eslint.lintFiles(
     'test/fixtures/top-level-await.mjs'
   )
   t.equal(lintResult.errorCount, 0)
-  t.end()
 })