eslint-config-beslogic 5.2.1 → 5.2.3

package/.dprint.jsonc

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 {
   // https://dprint.dev/config/#extending-a-different-configuration-file

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 5.2.3
+
+- `unicorn/prevent-abbreviations` in `react` preset allow "Prop" abbreviation to allow "PropTypes" constants
+- Added `"incremental": true` and `"strictNullChecks": true` to shared `tsconfig.json`
+- Fixed type-checking issues in source so that pure-JS projects with `"checkJs": true` don't fail type-checking
+
+## 5.2.2
+
+- Don't sort alphabetically in `@stylistic/jsx-sort-props` in non-extra-strict preset
+
 ## 5.2.1
 
 - Replaced `react/jsx-sort-props` with `@stylistic/jsx-sort-props`

package/LICENSE

@@ -1,6 +1,6 @@
 The MIT License
 
-Copyright 2025 Beslogic Inc.
+Copyright 2026 Beslogic Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 

package/angular.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { ASTUtils } from "@angular-eslint/utils"
 import { defineConfig } from "@eslint/config-helpers"
@@ -21,7 +21,11 @@ const typescriptVersion = getModuleVersion("typescript", 99)
 const typeDeclarationOverride = beslogicTypeScript.find(
   config => config.name === "beslogic/typescript/type-declaration"
 )
+if (!typeDeclarationOverride) {
+  throw new TypeError("beslogic/typescript/type-declaration config not found in typescript.mjs")
+}
 
+/** @type {[import('@eslint/core').Severity, ...(string | { selector: string, message: string })[]]} */
 export const noRestrictedSyntax = [
   ...noRestrictedSyntaxJS,
   // TODO: Possibly implement that ourselves?

package/eslint.config.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import eslintPlugin from "eslint-plugin-eslint-plugin"

package/extra-strict.mjs

@@ -1,9 +1,9 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 
-import { jestFilePatterns, resolveModuleLocation } from "./lib/utils.mjs"
+import { jestFilePatterns, jsxSortPropsConfig, resolveModuleLocation } from "./lib/utils.mjs"
 import { noFloatingPromisesKnownSafeCalls, noRestrictedSyntax as noRestrictedSyntaxTS, restrictTemplateExpressionsConfig } from "./typescript.mjs"
 
 // These extra strict configs are not only for Angular. User may be using a different framework
@@ -32,11 +32,12 @@ export const explicitModuleBoundaryType = [
   }
 ]
 
+/** @type {[import('@eslint/core').Severity, ...(string | { selector: string, message: string })[]]} */
 export const noRestrictedSyntax = [
   ...noRestrictedSyntaxTS,
   // TODO: This would really be better as its own rule.
   // My understanding is that it only negatively affects published libs,
-  // and even then there's way o work around it.
+  // and even then there's ways to work around it.
   // Ban `const` enums: https://typescript-eslint.io/troubleshooting/faqs/general/#how-can-i-ban-specific-language-feature
   {
     "selector": "TSEnumDeclaration[const=true]",
@@ -53,6 +54,14 @@ export default defineConfig(
       "**/*.tsx"
     ],
     "rules": {
+      "@stylistic/jsx-sort-props": [
+        "error",
+        {
+          ...jsxSortPropsConfig,
+          "noSortAlphabetically": false
+        }
+      ],
+
       // This is caught when noImplicitThis is enabled, which we assume in this config
       // https://typescript-eslint.io/rules/no-invalid-this/
       "@typescript-eslint/no-invalid-this": "off",

package/index.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import beslogicJavascript from "./javascript.mjs"
 import beslogicTypeScript from "./typescript.mjs"

package/javascript.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { fixupPluginRules } from "@eslint/compat"
 import { defineConfig } from "@eslint/config-helpers"
@@ -33,6 +33,7 @@ export const restrictedGlobals = [
   }
 ]
 
+/** @type {[import('@eslint/core').Severity, ...(string | { selector: string, message: string })[]]} */
 export const noRestrictedSyntax = [
   "error",
   "WithStatement",
@@ -88,6 +89,8 @@ export const noMagicNumbersConfig = {
     }
     : {}
 }
+
+/** @type {[import('@eslint/core').Severity, Record<string, string | boolean>]} */
 export const noUnusedVariables = [
   "error",
   {
@@ -101,6 +104,7 @@ export const noUnusedVariables = [
 ]
 // Same as S00107
 // Projects with dependency Injection (Angular) also need more params in their constructor
+/** @type {[import('@eslint/core').Severity, { max: number }]} */
 export const maxParams = [
   "error",
   { "max": 7 }
@@ -207,6 +211,9 @@ export default defineConfig(
   sonarjs.configs.recommended,
   eslintPluginUnicorn.configs["flat/all"],
   regexp.configs["flat/recommended"],
+  // @ts-ignore
+  // - https://github.com/un-ts/eslint-plugin-import-x/issues/439
+  // - https://github.com/typescript-eslint/typescript-eslint/issues/11543
   importX.flatConfigs.recommended,
   comments.recommended,
   {

package/jest.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import jest from "eslint-plugin-jest"

package/json-like.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 

package/lib/utils.mjs

@@ -31,16 +31,16 @@ export const resolveModuleLocation = (/** @type {string} */ nodeModule) => {
 }
 
 export const jestNoRestrictedSyntax = (
-  /** @type {(string | number | { selector: string; })[]} */ noRestrictedSyntax
-) =>
-  noRestrictedSyntax.filter(
-    entry =>
-      typeof entry === "number"
-      || typeof entry === "string"
-      // Exclude from jest tests for compatibility with
-      // `jest/valid-describe-callback` and `jest/no-test-return-statement`
-      || !entry.selector.startsWith("ArrowFunctionExpression")
-  )
+  /** @type {readonly (number | string | {readonly selector: string})[]} */ noRestrictedSyntax
+  // eslint-disable-next-line @stylistic/no-extra-parens -- https://github.com/eslint-stylistic/eslint-stylistic/issues/1088
+) => /** @type {import('@eslint/config-helpers').RuleConfig} */ (noRestrictedSyntax.filter(
+  entry =>
+    typeof entry === "number"
+    || typeof entry === "string"
+    // Exclude from jest tests for compatibility with
+    // `jest/valid-describe-callback` and `jest/no-test-return-statement`
+    || !entry.selector.startsWith("ArrowFunctionExpression")
+))
 
 // Matching Jest's own default file patterns: https://jestjs.io/docs/configuration#testmatch-arraystring
 export const jestFilePatterns = [
@@ -85,3 +85,15 @@ export const idLenghtConfig = {
     "z"
   ]
 }
+
+// eslint-disable-next-line unicorn/prevent-abbreviations -- Props allowed in React
+export const jsxSortPropsConfig = {
+  // Keeping special props first, and not hiding props under big multiline
+  // both help a lot with readability and semantics
+  "reservedFirst": true,
+  "shorthandFirst": true,
+  "multiline": "last",
+  // Alphabetical sorting is nice for automated consistency,
+  // but is too pedantic for widespread adoption. Set in extra-strict preset.
+  "noSortAlphabetically": true
+}

package/mui.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import mui from "eslint-plugin-mui"

package/node-js.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import { createNodeResolver } from "eslint-plugin-import-x"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "5.2.1",
+  "version": "5.2.3",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "type": "module",
@@ -8,8 +8,8 @@
   "scripts": {
     "eslint-unstable-flag": "set TIMING=1 && eslint . --flag unstable_config_lookup_from_file",
     "eslint": "set TIMING=1 && eslint . --flag v10_config_lookup_from_file",
-    "lint": "dprint check && npm run eslint",
-    "lint:fix": "npm run eslint -- --fix && dprint fmt",
+    "lint": "dprint check && npm run eslint && tsc",
+    "lint:fix": "npm run eslint -- --fix && dprint fmt && tsc",
     "upgrade": "npx npm-check-updates -u & npm i",
     "prepack": "type .gitignore* > .npmignore",
     "postinstall": "node ./lib/patch-dependencies.mjs",

package/react-native.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 

package/react-redux.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import reactRedux from "eslint-plugin-react-redux"

package/react.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import jsxA11y from "eslint-plugin-jsx-a11y"
@@ -10,14 +10,15 @@ import testingLibrary from "eslint-plugin-testing-library"
 import globals from "globals"
 
 import beslogicJavascript, { preventAbbreviationsConfig as preventAbbreviationsConfigJS } from "./javascript.mjs"
-import { jestFilePatterns } from "./lib/utils.mjs"
+import { jestFilePatterns, jsxSortPropsConfig } from "./lib/utils.mjs"
 import beslogicTypeScript from "./typescript.mjs"
 
 const typeDeclarationOverride = beslogicTypeScript.find(
   config => config.name === "beslogic/typescript/type-declaration"
 )
-
-if (!typeDeclarationOverride) throw new TypeError("**/*.d.ts not found in typescript.mjs")
+if (!typeDeclarationOverride) {
+  throw new TypeError("beslogic/typescript/type-declaration config not found in typescript.mjs")
+}
 
 const preventAbbreviationsConfig = { ...preventAbbreviationsConfigJS }
 // React props
@@ -25,6 +26,9 @@ preventAbbreviationsConfig.allowList.props = true
 preventAbbreviationsConfig.allowList.Props = true
 preventAbbreviationsConfig.allowList.ref = true
 preventAbbreviationsConfig.allowList.Ref = true
+preventAbbreviationsConfig.allowList.PropTypes = true
+// Apparently Trying to set "PropTypes" doesn't work
+preventAbbreviationsConfig.allowList.Prop = true
 // useState's set method using the previous state
 // Note: It's still better to name it like prevSomething
 preventAbbreviationsConfig.allowList.prev = true
@@ -98,10 +102,7 @@ export default defineConfig(
       "react/jsx-sort-props": "off",
       "@stylistic/jsx-sort-props": [
         "error",
-        // Keeping special props first, and not hiding props under big multiline
-        // both help a lot with readability and semantics
-        // Still keeping alphabetical sorting for automatic consistency
-        { "reservedFirst": true, "shorthandFirst": true, "multiline": "last" }
+        jsxSortPropsConfig
       ],
 
       /*

package/rxjs.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import rxjsX from "eslint-plugin-rxjs-x"

package/storybook.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig, globalIgnores } from "@eslint/config-helpers"
 import storybook from "eslint-plugin-storybook"

package/stylistic.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import stylistic from "@stylistic/eslint-plugin"

package/tsconfig.4.3.json

@@ -1,16 +1,18 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 {
   "compilerOptions": {
     "strict": true,
     "checkJs": true,
+    "incremental": true, // Performance improvement during dev through incremental checking
     "newLine": "LF", // Now default in TypeScript 5.0
     "forceConsistentCasingInFileNames": true, // Now default in TypeScript 5.0
     "resolveJsonModule": true,
     "noFallthroughCasesInSwitch": true,
     "noImplicitOverride": true,
     "noImplicitReturns": true,
+    "strictNullChecks": true, // Stop hiding null/undefined types, *even* with strict=false !
     // This makes index accesses even stricter. You may not want it in your project.
     // You should probably disable it at least in tests.
     "noUncheckedIndexedAccess": true,

package/tsconfig.5.0.json

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 {
   "extends": "./tsconfig.4.3.json",

package/tsconfig.5.6.json

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 {
   "extends": "./tsconfig.5.0.json",

package/tsconfig.json

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 {
   "extends": "./tsconfig.5.6.json",
@@ -12,5 +12,9 @@
     "jsx": "react-jsx",
     "allowJs": true,
     "noImplicitAny": false,
+    // Some issues in upstream .d.ts imports
+    "skipLibCheck": true,
+    // Necessary as long as we still test old-style Angular decorators
+    "experimentalDecorators": true,
   },
 }

package/typescript.mjs

@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: MIT
-// Copyright 2025 Beslogic Inc.
+// Copyright 2026 Beslogic Inc.
 
 import { defineConfig } from "@eslint/config-helpers"
 import { createTypeScriptImportResolver } from "eslint-import-resolver-typescript"
@@ -11,6 +11,7 @@ import { maxParams, noMagicNumbersConfig as noMagicNumbersConfigJS, noRestricted
 import beslogicJest from "./jest.mjs"
 import { jestFilePatterns, jestNoRestrictedSyntax } from "./lib/utils.mjs"
 
+/** @type {[import('@eslint/core').Severity, ...(string | { selector: string, message: string })[]]} */
 export const noRestrictedSyntax = [
   ...noRestrictedSyntaxJS,
   {