eslint-config-beslogic 4.2.2 → 4.3.0

package/.dprint.jsonc

@@ -3,5 +3,5 @@
 
 {
   // https://dprint.dev/config/#extending-a-different-configuration-file
-  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json",
+  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/.dprint-json-like.jsonc",
 }

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 4.3.0
+
+- Correctly also disable `compilerOptions.emitDecoratorMetadata` when disabling `compilerOptions.experimentalDecorators` out of the box
+  - Added instructions to explicitely enable both on Angular projects using experimental decorators
+- Added a `tsconfig.5.6.json` TSConfig preset with `noUncheckedSideEffectImports` enabled
+- Enabled `compilerOptions.resolveJsonModule` by default
+- Enabled `compilerOptions.checkJS` by default
+- Relaxed `prefer-arrow/prefer-arrow-functions` for `**/*[.-]service.ts` files as we expected `@Injectable` to have lifecycle methods
+- Disabled `@typescript-eslint/prefer-for-of` and `sonarjs/prefer-for-of` in favor of `unicorn/no-for-loop`
+- Allowed `i++` in "loop afterthrought" (`for (i = 0; i < l; i++)`) for rule `autofix/no-plusplus`
+- Set `@typescript-eslint/switch-exhaustiveness-check`'s `considerDefaultExhaustiveForUnions` to `false` in non-extra-strict preset
+- Disabled `unicorn/no-useless-switch-case` in extra-strict preset as it and conflicts with `considerDefaultExhaustiveForUnions`
+- Bumped `@stylistic/eslint-plugin` to `^2.12.0` as it fixed `jsx-wrap-multilines` breaking in the presence of comments
+- Bumped `dprint` to `^0.46` to ensure .gitignore support
+
 ## 4.2.2
 
 - Exclude `<select>` and `<textarea>` from `react/jsx-props-no-spreading` as it is very often needed for custom inputs and validation using Higher Order Components
@@ -58,6 +73,15 @@
   - Bumped `eslint-plugin-react` to `^7.37.1`
   - Added dependency on `@eslint/compat` and `eslint-config-flat-gitignore`
 
+## 3.2.1
+
+- Disabled `@typescript-eslint/no-misused-spread`:\
+  Still a handful of false-positives and I couldn't get the configuration working.\
+  Especially annoying with autogenerated API when spreading class instance
+  with readonly properties as its contructor object.\
+  ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`\
+  NOTE: If fixed, we'd still only want this in extra-strict config.
+
 ## 3.2.0
 
 - Migrated from `eslint-plugin-import` to `eslint-plugin-import-x@^4.2.1` for performance and better support.

package/README.md

@@ -23,6 +23,12 @@ Read the [`package.json`](https://github.com/BesLogic/shared-configs/blob/main/R
 
 Extend the following in your base `tsconfig.json` (follow link for more details):
 
+[`typescript@>=5.6`](https://socket.dev/npm/package/eslint-config-beslogic/files/latest/tsconfig.5.6.json):
+
+```jsonc
+"extends": ["eslint-config-beslogic/tsconfig.5.6.json"],
+```
+
 [`typescript@>=5.0`](https://socket.dev/npm/package/eslint-config-beslogic/files/latest/tsconfig.5.0.json):
 
 ```jsonc
@@ -37,6 +43,15 @@ Extend the following in your base `tsconfig.json` (follow link for more details)
 
 "No Unchecked Indexed Access" makes index accesses even stricter. You may not want it in your project or in your tests. You can disable it with `"compilerOptions": { "noUncheckedIndexedAccess": false }`.
 
+If using experimental decorators (likely for an Angular project), you still need to set
+
+```jsonc
+"compilerOptions": { 
+  "emitDecoratorMetadata": true,
+  "experimentalDecorators": true,
+}
+```
+
 If deploying / bundling with an Angular npm package, also set `angularCompilerOptions": { "strictMetadataEmit": true }`.
 
 ### `.vscode/settings.json` and `.vscode/extensions.json`

package/TODO-SONARJS_CHECK_IF_DUPLICATED.json

@@ -136,7 +136,6 @@
   "sonarjs/os-command": "error",
   "sonarjs/post-message": "error",
   "sonarjs/prefer-default-last": "error",
-  "sonarjs/prefer-for-of": "error",
   "sonarjs/prefer-function-type": "error",
   "sonarjs/prefer-namespace-keyword": "error",
   "sonarjs/prefer-promise-shorthand": "error",

package/angular.mjs

@@ -7,7 +7,7 @@ import rxjsAngular from "eslint-plugin-rxjs-angular"
 import testingLibrary from "eslint-plugin-testing-library"
 import tseslint from "typescript-eslint"
 
-import { noAutofixRreferArrowFunctionsConfig, noRestrictedSyntax as noRestrictedSyntaxJS, preferArrowFunctionsConfig, preventAbbreviationsConfig as preventAbbreviationsConfigJS } from "./javascript.mjs"
+import { noAutofixPreferArrowFunctionsConfig, noRestrictedSyntax as noRestrictedSyntaxJS, preferArrowFunctionsConfig, preventAbbreviationsConfig as preventAbbreviationsConfigJS } from "./javascript.mjs"
 import { getModuleVersion, jestFilePatterns, jestNoRestrictedSyntax } from "./lib/utils.mjs"
 import beslogicNodeJS from "./node-js.mjs"
 import beslogicRXJS from "./rxjs.mjs"
@@ -282,6 +282,7 @@ export default tseslint.config(
       "**/*[.-]component.ts",
       "**/*[.-]directive.ts",
       "**/*[.-]interceptor.ts",
+      "**/*[.-]service.ts", // @Injectable
       "**/*[.-]pipes.ts"
     ],
     "rules": {
@@ -292,7 +293,7 @@ export default tseslint.config(
       "no-autofix/prefer-arrow/prefer-arrow-functions": [
         "error",
         {
-          ...noAutofixRreferArrowFunctionsConfig,
+          ...noAutofixPreferArrowFunctionsConfig,
           // https://github.com/TristonJ/eslint-plugin-prefer-arrow/issues/17
           "classPropertiesAllowed": false
         }

package/extra-strict.mjs

@@ -76,6 +76,15 @@ export default tseslint.config(
           "allowNullish": false
         }
       ],
+      "@typescript-eslint/switch-exhaustiveness-check": [
+        "error",
+        {
+          "requireDefaultForNonUnion": true,
+          "considerDefaultExhaustiveForUnions": true
+        }
+      ],
+      // Unconfigurable and conflicts with `considerDefaultExhaustiveForUnions: true`
+      "unicorn/no-useless-switch-case": "off",
 
       /*
        * @typescript-eslint rules that require strictNullChecks

package/javascript.mjs

@@ -159,7 +159,7 @@ export const noRestrictedImportsConfig = {
     }
   ]
 }
-export const noAutofixRreferArrowFunctionsConfig = {
+export const noAutofixPreferArrowFunctionsConfig = {
   "classPropertiesAllowed": true,
   "disallowPrototype": true,
   "singleReturnOnly": false,
@@ -179,6 +179,7 @@ export default tseslint.config(
   sonarjs.configs.recommended,
   unicorn.configs["flat/all"],
   regexp.configs["flat/recommended"],
+  // @ts-expect-error: Fixed by https://github.com/un-ts/eslint-plugin-import-x/releases/tag/v4.13.3
   pluginImportX.flatConfigs.recommended,
   comments.recommended,
   {
@@ -234,6 +235,8 @@ export default tseslint.config(
       "sonarjs/todo-tag": "off",
       // Duplicates unicorn/prefer-string-starts-ends-with
       "sonarjs/prefer-string-starts-ends-with": "off",
+      // Duplicates unicorn/no-for-loop and typescript-eslint/prefer-for-of
+      "sonarjs/prefer-for-of": "off",
       // Duplicates no-nested-ternary and unicorn/no-nested-ternary
       "sonarjs/no-nested-conditional": "off",
 
@@ -452,7 +455,7 @@ export default tseslint.config(
       // but we still want to check for other cases
       "no-autofix/prefer-arrow/prefer-arrow-functions": [
         "error",
-        noAutofixRreferArrowFunctionsConfig
+        noAutofixPreferArrowFunctionsConfig
       ],
       "prefer-arrow/prefer-arrow-functions": [
         "error",
@@ -834,6 +837,10 @@ export default tseslint.config(
      */
     "rules": {
       "autofix/no-caller": "error",
+      "autofix/no-plusplus": [
+        "error",
+        { "allowForLoopAfterthoughts": true }
+      ],
       "autofix/no-proto": "error",
       "autofix/no-prototype-builtins": "error",
       "autofix/no-throw-literal": "error",

package/node-js.mjs

@@ -21,6 +21,7 @@ export default tseslint.config(
   n.configs["flat/recommended-script"],
   {
     "settings": {
+      // This is apparently legacy in a recent update: https://github.com/un-ts/eslint-plugin-import-x/pull/272
       "import-x/resolver": {
         "node": true
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "4.2.2",
+  "version": "4.3.0",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
@@ -45,10 +45,10 @@
   "dependencies": {
     "@eslint-community/eslint-plugin-eslint-comments": "^4.1",
     "@eslint/compat": "^1.2.4",
-    "@stylistic/eslint-plugin": "^2.8.0",
+    "@stylistic/eslint-plugin": "^2.12.0",
     "@types/eslint": "^8.56",
     "confusing-browser-globals": "^1.0",
-    "dprint": "^0.40.2",
+    "dprint": "^0.46.0",
     "eslint": "^8.56 || ^9.12",
     "eslint-config-flat-gitignore": "^1.0.0",
     "eslint-import-resolver-typescript": "^3.2.6",

package/react.mjs

@@ -147,7 +147,11 @@ export default tseslint.config(
           "explicitSpread": "ignore",
           "custom": "ignore",
           // Very often needed for custom inputs and validation using Higher Order Components
-          "exceptions": ["input", "select", "textarea"]
+          "exceptions": [
+            "input",
+            "select",
+            "textarea"
+          ]
         }
       ],
       "react/prop-types": "off",

package/tsconfig.4.3.json

@@ -4,8 +4,10 @@
 {
   "compilerOptions": {
     "strict": true,
+    "checkJs": true,
     "newLine": "LF", // Now default in TypeScript 5.0
     "forceConsistentCasingInFileNames": true, // Now default in TypeScript 5.0
+    "resolveJsonModule": true,
     "noFallthroughCasesInSwitch": true,
     "noImplicitOverride": true,
     "noImplicitReturns": true,

package/tsconfig.5.0.json

@@ -5,10 +5,14 @@
   "extends": "./tsconfig.4.3.json",
   "compilerOptions": {
     "verbatimModuleSyntax": true,
-    // Since this is no longer needed for Angular with TypeScript 5, let's
+    // Since these are no longer needed for most projects with TypeScript 5, let's
     // disable it so @typescript-eslint/consistent-type-imports doesn't turn
     // itself off in files using decorators.
+    // Likely still needed in Angular, if you wanna try without,
+    // see https://angular.dev/reference/migrations/inject-function for migrating @Inject
+    //
     // https://typescript-eslint.io/rules/consistent-type-imports/#caveat-decorators--experimentaldecorators-true--emitdecoratormetadata-true
+    "emitDecoratorMetadata": false,
     "experimentalDecorators": false
   }
 }

package/tsconfig.5.6.json

@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: MIT
+// Copyright 2025 Beslogic Inc.
+
+{
+  "extends": "./tsconfig.5.0.json",
+  "compilerOptions": {
+    "noUncheckedSideEffectImports": true
+    // Likely still needed in Angular, if you wanna try without,
+    // see https://angular.dev/reference/migrations/inject-function for migrating @Inject
+    //
+    // https://typescript-eslint.io/rules/consistent-type-imports/#caveat-decorators--experimentaldecorators-true--emitdecoratormetadata-true
+    // "emitDecoratorMetadata": true,
+    // "experimentalDecorators": true,
+  }
+}

package/tsconfig.json

@@ -2,16 +2,14 @@
 // Copyright 2024 Beslogic Inc.
 
 {
-  "extends": "./tsconfig.4.3.json",
+  "extends": "./tsconfig.5.6.json",
   "compilerOptions": {
-    "moduleResolution": "Node16",
-    "module": "Node16",
+    "module": "nodenext", // Set to node18 once we update to typescript 5.8
     "allowSyntheticDefaultImports": true,
     "noUncheckedIndexedAccess": false,
     "noEmit": true,
     "jsx": "react-jsx",
     "allowJs": true,
-    "checkJs": true,
-    "noImplicitAny": false
-  }
+    "noImplicitAny": false,
+  },
 }

package/typescript.mjs

@@ -79,6 +79,7 @@ export default tseslint.config(
       ...tseslint.configs.all,
       // https://github.com/cartant/eslint-plugin-etc/issues/74
       fixupConfigRules(compat.extends("plugin:etc/recommended")),
+      // @ts-expect-error: Fixed by https://github.com/un-ts/eslint-plugin-import-x/releases/tag/v4.13.3
       pluginImportX.flatConfigs.typescript
     ],
     "languageOptions": {
@@ -102,6 +103,7 @@ export default tseslint.config(
       }
     },
     "settings": {
+      // This is apparently legacy in a recent update: https://github.com/un-ts/eslint-plugin-import-x/pull/272
       "import-x/resolver": {
         "typescript": {
           // Recommended by eslint-import-resolver-typescript
@@ -334,6 +336,11 @@ export default tseslint.config(
       ],
       "@typescript-eslint/prefer-enum-initializers": "off",
 
+      // Very similar to `unicorn/no-for-loop` but doesn't have autofixes.
+      // TODO: If autofixes or suggestion is added, prefer over unicorn's
+      // https://github.com/typescript-eslint/typescript-eslint/issues/11336
+      "@typescript-eslint/prefer-for-of": "off",
+
       // TODO: Would accept this if it had autofixes, otherwise this is too tedious to use. Check again later
       "@typescript-eslint/prefer-readonly-parameter-types": "off",
       "@typescript-eslint/prefer-string-starts-ends-with": [
@@ -356,7 +363,12 @@ export default tseslint.config(
       ],
       "@typescript-eslint/switch-exhaustiveness-check": [
         "error",
-        { "requireDefaultForNonUnion": true }
+        {
+          "requireDefaultForNonUnion": true,
+          // Set to true in extra-strict configs
+          // Helps prevent conflicts with unicorn/no-useless-switch-case
+          "considerDefaultExhaustiveForUnions": false
+        }
       ],
       "@typescript-eslint/unbound-method": [
         "error",