eslint-config-beslogic 4.1.0 → 4.2.0

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 4.2.0
+
+- `@typescript-eslint/no-floating-promises` is now ignored on `i18next.changeLanguage` as it is known to not throw and already `console.warn` itself
+- In `extra-strict` preset, `@typescript-eslint/no-floating-promises`doesn't ignore voided promises, forcing a comment to explain
+- Disabled `@typescript-eslint/no-misused-spread`:\
+  Still a handful of false-positives and I couldn't get the configuration working.\
+  Especially annoying with autogenerated API when spreading class instance
+  with readonly properties as its contructor object.\
+  ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`\
+  NOTE: If fixed, we'd still only want this in extra-strict config.
+
 ## 4.1.0
 
 - Migrated from `eslint-plugin-import` to `eslint-plugin-import-x@^4.2.1` for performance and better support.

package/extra-strict.mjs

@@ -4,7 +4,7 @@
 import tseslint from "typescript-eslint"
 
 import { jestFilePatterns, resolveModuleLocation } from "./lib/utils.mjs"
-import { restrictTemplateExpressionsConfig } from "./typescript.mjs"
+import { noFloatingPromisesKnownSafeCalls, restrictTemplateExpressionsConfig } from "./typescript.mjs"
 
 // These extra strict configs are not only for Angular. User may be using a different framework
 const hasAngularEslintTemplate = !!resolveModuleLocation("@angular-eslint/eslint-plugin-template")
@@ -56,6 +56,13 @@ export default tseslint.config(
       ],
       "@typescript-eslint/no-unsafe-type-assertion": "error",
 
+      "@typescript-eslint/no-floating-promises": [
+        "error",
+        {
+          "ignoreVoid": false, // Don't even ignore voided promises. Force a comment explaining.
+          "allowForKnownSafeCalls": noFloatingPromisesKnownSafeCalls
+        }
+      ],
       "@typescript-eslint/related-getter-setter-pairs": "error",
       "@typescript-eslint/restrict-template-expressions": [
         "error",

package/javascript.mjs

@@ -8,7 +8,7 @@ import restrictedGlobals from "confusing-browser-globals"
 import gitignore from "eslint-config-flat-gitignore"
 import autofix from "eslint-plugin-autofix"
 import extraRules from "eslint-plugin-extra-rules"
-import eslintPluginImportX from "eslint-plugin-import-x"
+import * as pluginImportX from "eslint-plugin-import-x"
 import noAutofix from "eslint-plugin-no-autofix"
 import noRelativeImportPaths from "eslint-plugin-no-relative-import-paths"
 import preferArrow from "eslint-plugin-prefer-arrow"
@@ -179,9 +179,7 @@ export default tseslint.config(
   sonarjs.configs.recommended,
   unicorn.configs["flat/all"],
   regexp.configs["flat/recommended"],
-  /* eslint-disable-next-line import-x/no-named-as-default-member
-  -- https://github.com/un-ts/eslint-plugin-import-x/issues/285 */
-  eslintPluginImportX.flatConfigs.recommended,
+  pluginImportX.flatConfigs.recommended,
   comments.recommended,
   {
     "plugins": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "4.1.0",
+  "version": "4.2.0",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",

package/typescript.mjs

@@ -8,7 +8,7 @@ import { fixupConfigRules } from "@eslint/compat"
 import { FlatCompat } from "@eslint/eslintrc"
 import js from "@eslint/js"
 import tsParser from "@typescript-eslint/parser"
-import eslintPluginImportX from "eslint-plugin-import-x"
+import * as pluginImportX from "eslint-plugin-import-x"
 import globals from "globals"
 import tseslint from "typescript-eslint"
 
@@ -64,6 +64,11 @@ export const restrictTemplateExpressionsConfig = {
   // ]
 }
 
+export const noFloatingPromisesKnownSafeCalls = [
+  // Doesn't throw and already console.warn itself
+  { "from": "package", "package": "i18next", "name": "changeLanguage" }
+]
+
 export default tseslint.config(
   {
     "files": [
@@ -74,9 +79,7 @@ export default tseslint.config(
       ...tseslint.configs.all,
       // https://github.com/cartant/eslint-plugin-etc/issues/74
       fixupConfigRules(compat.extends("plugin:etc/recommended")),
-      /* eslint-disable-next-line import-x/no-named-as-default-member
-      -- https://github.com/un-ts/eslint-plugin-import-x/issues/285 */
-      eslintPluginImportX.flatConfigs.typescript
+      pluginImportX.flatConfigs.typescript
     ],
     "languageOptions": {
       "parser": tsParser,
@@ -198,6 +201,10 @@ export default tseslint.config(
       "import-x/no-deprecated": "off",
       "import/no-deprecated": "off",
       "sonarjs/deprecation": "off",
+      "@typescript-eslint/no-floating-promises": [
+        "error",
+        { "allowForKnownSafeCalls": noFloatingPromisesKnownSafeCalls }
+      ],
       // Explicit types rules complicates things uselessly and are redundant
       "@typescript-eslint/explicit-function-return-type": "off",
       "@typescript-eslint/explicit-member-accessibility": [
@@ -235,6 +242,12 @@ export default tseslint.config(
         "error",
         { "checksVoidReturn": false }
       ],
+      // Still a handful of false-positives and I couldn't get the configuration working.
+      // Especially annoying with autogenerated API when spreading class instance
+      // with readonly properties as its contructor object.
+      // ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`
+      // NOTE: If fixed, we'd still only want this in extra-strict config.
+      "@typescript-eslint/no-misused-spread": "off",
       "@typescript-eslint/no-restricted-imports": [
         "error",
         {