eslint-config-beslogic 4.0.3 → 4.2.0

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 4.2.0
+
+- `@typescript-eslint/no-floating-promises` is now ignored on `i18next.changeLanguage` as it is known to not throw and already `console.warn` itself
+- In `extra-strict` preset, `@typescript-eslint/no-floating-promises`doesn't ignore voided promises, forcing a comment to explain
+- Disabled `@typescript-eslint/no-misused-spread`:\
+  Still a handful of false-positives and I couldn't get the configuration working.\
+  Especially annoying with autogenerated API when spreading class instance
+  with readonly properties as its contructor object.\
+  ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`\
+  NOTE: If fixed, we'd still only want this in extra-strict config.
+
+## 4.1.0
+
+- Migrated from `eslint-plugin-import` to `eslint-plugin-import-x@^4.2.1` for performance and better support.
+
 ## 4.0.3
 
 - Allow `^8.56 || ^9.12` for the ESLint version range. But v9 is completely untested.
@@ -35,6 +50,15 @@
   - Bumped `eslint-plugin-react` to `^7.37.1`
   - Added dependency on `@eslint/compat` and `eslint-config-flat-gitignore`
 
+## 3.2.0
+
+- Migrated from `eslint-plugin-import` to `eslint-plugin-import-x@^4.2.1` for performance and better support.
+  - This also forces `eslint` to version `8.57` or above
+
+## 3.1.4
+
+- Pinned `eslint-plugin-unicorn` to `>=49.0 && <57`
+
 ## 3.1.3
 
 - Bumped `"@typescript-eslint` to `^8.15.0`

package/eslint.config.mjs

@@ -47,7 +47,7 @@ export default tseslint.config(
       "@stylistic/indent": "off",
 
       // We're using typescript (tsconfig) for that
-      "import/no-unresolved": "off",
+      "import-x/no-unresolved": "off",
 
       // TODO: Remove these config once we're no longer using the pre-flat-config compatibility layer
       "no-shadow": [

package/extra-strict.mjs

@@ -4,7 +4,7 @@
 import tseslint from "typescript-eslint"
 
 import { jestFilePatterns, resolveModuleLocation } from "./lib/utils.mjs"
-import { restrictTemplateExpressionsConfig } from "./typescript.mjs"
+import { noFloatingPromisesKnownSafeCalls, restrictTemplateExpressionsConfig } from "./typescript.mjs"
 
 // These extra strict configs are not only for Angular. User may be using a different framework
 const hasAngularEslintTemplate = !!resolveModuleLocation("@angular-eslint/eslint-plugin-template")
@@ -56,6 +56,13 @@ export default tseslint.config(
       ],
       "@typescript-eslint/no-unsafe-type-assertion": "error",
 
+      "@typescript-eslint/no-floating-promises": [
+        "error",
+        {
+          "ignoreVoid": false, // Don't even ignore voided promises. Force a comment explaining.
+          "allowForKnownSafeCalls": noFloatingPromisesKnownSafeCalls
+        }
+      ],
       "@typescript-eslint/related-getter-setter-pairs": "error",
       "@typescript-eslint/restrict-template-expressions": [
         "error",

package/javascript.mjs

@@ -8,7 +8,7 @@ import restrictedGlobals from "confusing-browser-globals"
 import gitignore from "eslint-config-flat-gitignore"
 import autofix from "eslint-plugin-autofix"
 import extraRules from "eslint-plugin-extra-rules"
-import importPlugin from "eslint-plugin-import"
+import * as pluginImportX from "eslint-plugin-import-x"
 import noAutofix from "eslint-plugin-no-autofix"
 import noRelativeImportPaths from "eslint-plugin-no-relative-import-paths"
 import preferArrow from "eslint-plugin-prefer-arrow"
@@ -179,7 +179,7 @@ export default tseslint.config(
   sonarjs.configs.recommended,
   unicorn.configs["flat/all"],
   regexp.configs["flat/recommended"],
-  importPlugin.flatConfigs.recommended,
+  pluginImportX.flatConfigs.recommended,
   comments.recommended,
   {
     "plugins": {
@@ -330,30 +330,30 @@ export default tseslint.config(
       /*
        * import settings (https://github.com/import-js/eslint-plugin-import#rules)
        */
-      "import/consistent-type-specifier-style": [
+      "import-x/consistent-type-specifier-style": [
         "error",
         "prefer-top-level"
       ],
-      "import/newline-after-import": [
+      "import-x/newline-after-import": [
         "error",
         {
           "exactCount": true,
           "considerComments": true
         }
       ],
-      "import/no-duplicates": [
+      "import-x/no-duplicates": [
         "error",
         { "considerQueryString": true }
       ],
-      "import/no-empty-named-blocks": "error",
-      "import/no-named-as-default": "error",
-      "import/no-named-as-default-member": "error",
+      "import-x/no-empty-named-blocks": "error",
+      "import-x/no-named-as-default": "error",
+      "import-x/no-named-as-default-member": "error",
       // Extracted restricted import into its own rule so it's easier for projects to override/ignore
       "no-autofix/no-relative-import-paths/no-relative-import-paths": [
         "error",
         { "allowSameFolder": true }
       ],
-      "import/no-unresolved": [
+      "import-x/no-unresolved": [
         "error",
         // https://github.com/import-js/eslint-plugin-import/issues/3140
         { "ignore": ["typescript-eslint"] }
@@ -723,7 +723,7 @@ export default tseslint.config(
       "no-constant-binary-expression": "error",
       "no-constructor-return": "error",
       "no-dupe-else-if": "error",
-      // Obsoleted by import/no-duplicates
+      // Obsoleted by import-x/no-duplicates
       "no-duplicate-imports": "off",
       "no-extend-native": "error",
       "no-implied-eval": "error",

package/node-js.mjs

@@ -20,6 +20,11 @@ export default tseslint.config(
   // @ts-expect-error: TODO: Raise upstream
   n.configs["flat/recommended-script"],
   {
+    "settings": {
+      "import-x/resolver": {
+        "node": true
+      }
+    },
     "languageOptions": {
       "ecmaVersion": "latest", // Will be default in ESLint 9
       "sourceType": "module", // Will be default in ESLint 9

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "4.0.3",
+  "version": "4.2.0",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
   "scripts": {
     "eslint": "set TIMING=1 && eslint .",
     "lint": "dprint check && npm run eslint",
-    "lint:fix": "dprint fmt && npm run eslint -- --fix",
+    "lint:fix": "npm run eslint -- --fix && dprint fmt",
     "upgrade": "npx npm-check-updates -u & npm i",
     "yalc": "yalc publish",
     "prepack": "type .gitignore* > .npmignore",
@@ -55,7 +55,7 @@
     "eslint-plugin-autofix": "^1.1 || ^2.0",
     "eslint-plugin-etc": "^2.0",
     "eslint-plugin-extra-rules": "^0.0.0-development",
-    "eslint-plugin-import": "^2.30",
+    "eslint-plugin-import-x": "^4.2.1",
     "eslint-plugin-jest": "^28.7",
     "eslint-plugin-jest-formatting": "^3.1",
     "eslint-plugin-no-autofix": "^2.0",

package/typescript.mjs

@@ -7,7 +7,8 @@ import { fileURLToPath } from "node:url"
 import { fixupConfigRules } from "@eslint/compat"
 import { FlatCompat } from "@eslint/eslintrc"
 import js from "@eslint/js"
-import importPlugin from "eslint-plugin-import"
+import tsParser from "@typescript-eslint/parser"
+import * as pluginImportX from "eslint-plugin-import-x"
 import globals from "globals"
 import tseslint from "typescript-eslint"
 
@@ -15,8 +16,6 @@ import { maxParams, noMagicNumbersConfig as noMagicNumbersConfigJS, noRestricted
 import beslogicJest from "./jest.mjs"
 import { jestFilePatterns, jestNoRestrictedSyntax } from "./lib/utils.mjs"
 
-// import tsParser from "@typescript-eslint/parser"
-
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
 const compat = new FlatCompat({
@@ -65,6 +64,11 @@ export const restrictTemplateExpressionsConfig = {
   // ]
 }
 
+export const noFloatingPromisesKnownSafeCalls = [
+  // Doesn't throw and already console.warn itself
+  { "from": "package", "package": "i18next", "name": "changeLanguage" }
+]
+
 export default tseslint.config(
   {
     "files": [
@@ -75,10 +79,10 @@ export default tseslint.config(
       ...tseslint.configs.all,
       // https://github.com/cartant/eslint-plugin-etc/issues/74
       fixupConfigRules(compat.extends("plugin:etc/recommended")),
-      importPlugin.flatConfigs.typescript
+      pluginImportX.flatConfigs.typescript
     ],
     "languageOptions": {
-      // "parser": tsParser,
+      "parser": tsParser,
       "parserOptions": {
         "project": ["tsconfig?(.*).json"],
         // "useProjectService": true,
@@ -98,7 +102,7 @@ export default tseslint.config(
       }
     },
     "settings": {
-      "import/resolver": {
+      "import-x/resolver": {
         "typescript": {
           // Recommended by eslint-import-resolver-typescript
           // Always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
@@ -111,25 +115,25 @@ export default tseslint.config(
           ]
         }
       },
-      "import/parsers": {
+      "import-x/parsers": {
         "@typescript-eslint/parser": [
           ".ts",
           ".tsx"
         ]
       },
-      // Required even with plugin:import/typescript
-      "import/extensions": [
+      // Required even with plugin:import-x/typescript
+      "import-x/extensions": [
         ".ts",
         ".tsx"
       ]
     },
     "rules": {
       // Slow and not as useful with TypeScript: https://github.com/import-js/eslint-plugin-import/issues/2340
-      "import/namespace": "off",
+      "import-x/namespace": "off",
       // TypeScript already ensures imports resolve
-      "import/no-unresolved": "off",
+      "import-x/no-unresolved": "off",
       // Already checked by @typescript-eslint/no-import-type-side-effects
-      "import/consistent-type-specifier-style": "off",
+      "import-x/consistent-type-specifier-style": "off",
 
       /*
        * Cartant's etc rules
@@ -197,6 +201,10 @@ export default tseslint.config(
       "import-x/no-deprecated": "off",
       "import/no-deprecated": "off",
       "sonarjs/deprecation": "off",
+      "@typescript-eslint/no-floating-promises": [
+        "error",
+        { "allowForKnownSafeCalls": noFloatingPromisesKnownSafeCalls }
+      ],
       // Explicit types rules complicates things uselessly and are redundant
       "@typescript-eslint/explicit-function-return-type": "off",
       "@typescript-eslint/explicit-member-accessibility": [
@@ -234,6 +242,12 @@ export default tseslint.config(
         "error",
         { "checksVoidReturn": false }
       ],
+      // Still a handful of false-positives and I couldn't get the configuration working.
+      // Especially annoying with autogenerated API when spreading class instance
+      // with readonly properties as its contructor object.
+      // ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`
+      // NOTE: If fixed, we'd still only want this in extra-strict config.
+      "@typescript-eslint/no-misused-spread": "off",
       "@typescript-eslint/no-restricted-imports": [
         "error",
         {