eslint-config-beslogic 4.0.2 → 4.0.3

package/CHANGELOG.md

@@ -1,9 +1,28 @@
 # Changelog
 
+## 4.0.3
+
+- Allow `^8.56 || ^9.12` for the ESLint version range. But v9 is completely untested.
+
 ## 4.0.2
 
-- Initial support for Flat Configs. v4 will only support Flat Configs (`eslint.config.js`), please use v3 for Legacy Configs (`.eslintrc`).
+### Important migration notes
+
+- You'll have to migrate your configs to use Flat Config
+  - We recommend `eslint.config.mjs` to use configs as ES Modules and be explicit about it.
+  - The README has been updated with basic configuration examples
+  - See <https://eslint.org/docs/latest/use/configure/migration-guide> for further help
+- You can remove `--ignore-path .gitignore` from your lint command.
 - `angular-eslint` won't work on HTML files on ESLint v8 due to parser configuration issues.
+- Nested configuration files autodiscovery won't work until [ESLint v9.12](https://github.com/eslint/eslint/pull/18742).\
+  In the mean time, you can extend your child configs in your parent with a `files` restriction.
+- `@eslint-community/eslint-comments/no-unused-disable` does not currently work with Flat Configs,
+  so unused disable comments are no longer reported.
+  See <https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/244>
+
+### Rest of the changes
+
+- Initial support for Flat Configs. v4 will only support Flat Configs (`eslint.config.js`), please use v3 for Legacy Configs (`.eslintrc`).
 - Autodetection of `.gitignore` using `eslint-config-flat-gitignore`
 - Updated dependencies:
   - Using the combined `typescript-eslint` package instead of `@typescript-eslint/eslint-plugin` + `@typescript-eslint/parser`
@@ -16,6 +35,26 @@
   - Bumped `eslint-plugin-react` to `^7.37.1`
   - Added dependency on `@eslint/compat` and `eslint-config-flat-gitignore`
 
+## 3.1.3
+
+- Bumped `"@typescript-eslint` to `^8.15.0`
+- Disabled `sonarjs/fixme-tag`
+- Disabled `@typescript-eslint/no-unsafe-type-assertion` and `@typescript-eslint/related-getter-setter-pairs` in non-`extra-strict` presets.
+- Added `"checkTypePredicates": true` to `@typescript-eslint/no-unnecessary-condition`
+- Configured `@typescript-eslint/prefer-nullish-coalescing` as
+  <!-- markdownlint-disable-next-line MD031 -->
+  ```js
+  [
+    "error",
+    {
+      // > If you're looking to enforce stricter conditional tests,
+      // > you should consider using the strict-boolean-expressions rule.
+      "ignoreConditionalTests": true,
+      "ignoreBooleanCoercion": true
+    }
+  ],
+  ```
+
 ## 3.1.2
 
 - Removed `globalThis` from `no-restricted-globals` as the adoption is now much wider (no more IE11) and it conflicts with `unicorn/prefer-global-this`

package/README.md

@@ -6,7 +6,7 @@ Run `npm i  --save-dev eslint-config-beslogic`
 
 Depending on your needs, you will need to also install other peer dependencies for linting.
 
-In your `eslint.config.[cm]?js` file, simply [extend](https://typescript-eslint.io/getting-started#step-2-configuration) our [presets](#presets) appropriate for your project.
+In your `eslint.config.[cm]?js` file, simply [extend](https://typescript-eslint.io/packages/typescript-eslint#config) our [presets](#presets) appropriate for your project.
 
 For stylistic rules, it is highly recommended to use a dedicated formatter over ESLint. Read more here: <https://typescript-eslint.io/docs/linting/troubleshooting/formatting/>\
 We assume [dprint](https://dprint.dev/) and don't enable any rules it covers by default. If you're not using a formatter, a [stylistic.mjs](#stylisticmjs) configuration is offered below.

package/eslint.config.mjs

@@ -71,10 +71,10 @@ export default tseslint.config(
   },
   // We need to explicitely set these paths because
   // ESLint flat configs doesn't do automated config lookup until 9.12
-  { "files": ["static-tests/*"], "extends": [...staticTestsRoot] },
-  { "files": ["static-tests/angular/**"], "extends": [...staticTestsAngular] },
-  { "files": ["static-tests/javascript/**"], "extends": [...staticTestsJavascript] },
-  { "files": ["static-tests/react-typescript/**"], "extends": [...staticTestsReactTypeScript] },
-  { "files": ["static-tests/storybook/**"], "extends": [...staticTestsStorybook] },
-  { "files": ["static-tests/typescript/**"], "extends": [...staticTestsTypeScript] }
+  { "files": ["static-tests/*"], "extends": staticTestsRoot },
+  { "files": ["static-tests/angular/**"], "extends": staticTestsAngular },
+  { "files": ["static-tests/javascript/**"], "extends": staticTestsJavascript },
+  { "files": ["static-tests/react-typescript/**"], "extends": staticTestsReactTypeScript },
+  { "files": ["static-tests/storybook/**"], "extends": staticTestsStorybook },
+  { "files": ["static-tests/typescript/**"], "extends": staticTestsTypeScript }
 )

package/javascript.mjs

@@ -118,7 +118,8 @@ export const noRestrictedImportsConfig = {
         "default",
         "React"
       ],
-      "message": "Please don't use the default React import."
+      "message": "Please don't use the default React import. "
+        + "You can configure `\"compilerOptions.jsx\": \"react-jsx\"` in tsconfig.json instead."
     },
     {
       // From https://github.com/angular-eslint/angular-eslint/blob/master/packages/eslint-plugin/src/configs/recommended--extra.json

package/lib/patch-dependencies.mjs

@@ -143,7 +143,6 @@ const patches = [
           "to": "false"
         },
         {
-          // eslint-disable-next-line regexp/no-super-linear-move -- Is it really?
           "from": /.+?devkit_1\.ensurePackage\)\('prettier'.+?[\n;]/gu,
           "to": ""
         }

package/lib/utils.mjs

@@ -7,7 +7,6 @@ const getModuleVersion = (
   /** @type {number} */ fallbackVersion
 ) => {
   try {
-    // eslint-disable-next-line n/global-require -- Dynamic loading
     return Number.parseFloat(require(`${nodeModule}/package.json`).version)
   } catch (error) {
     if (

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "4.0.2",
+  "version": "4.0.3",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
@@ -49,7 +49,7 @@
     "@types/eslint": "^8.56",
     "confusing-browser-globals": "^1.0",
     "dprint": "^0.40.2",
-    "eslint": "^8.56",
+    "eslint": "^8.56 || ^9.12",
     "eslint-config-flat-gitignore": "^1.0.0",
     "eslint-import-resolver-typescript": "^3.2.6",
     "eslint-plugin-autofix": "^1.1 || ^2.0",
@@ -84,20 +84,22 @@
     "eslint-plugin-storybook": "^0.10"
   },
   "// jest": "Don't install it, so that we test failure to specify jest version",
+  "// eslint": "v9 support is untested",
   "devDependencies": {
     "@angular/core": ">=18.0",
     "@types/node": "^18.0",
+    "@types/react": "^18.3.3",
     "eslint-plugin-eslint-plugin": "^6.0",
     "react": "^18.3.1",
     "yalc": "^1.0.0-pre.53"
   },
-  "// @eslint/compat": "Declares itself as ESLint 9 compatible only, but we need it for flat config compat",
+  "// eslint overrides": "Deps that declare themselves as ESLint 9 compatible only, but we need it for flat config compat",
   "overrides": {
     "@eslint/compat": {
-      "eslint": "^8.56"
+      "eslint": "^8.56 || ^9.12"
     },
     "eslint-config-flat-gitignore": {
-      "eslint": "^8.56"
+      "eslint": "^8.56 || ^9.12"
     }
   }
 }

package/tsconfig.json

@@ -9,7 +9,7 @@
     "allowSyntheticDefaultImports": true,
     "noUncheckedIndexedAccess": false,
     "noEmit": true,
-    "jsx": "react",
+    "jsx": "react-jsx",
     "allowJs": true,
     "checkJs": true,
     "noImplicitAny": false