eslint-config-beslogic 3.2.1 → 3.3.0

package/.dprint.jsonc

@@ -3,5 +3,5 @@
 
 {
   // https://dprint.dev/config/#extending-a-different-configuration-file
-  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json",
+  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/.dprint-json-like.jsonc",
 }

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # Changelog
 
+## 3.3.0
+
+(backport of 4.3.0)
+
+- Correctly also disable `compilerOptions.emitDecoratorMetadata` when disabling `compilerOptions.experimentalDecorators` out of the box
+  - Added instructions to explicitely enable both on Angular projects using experimental decorators
+- Added a `tsconfig.5.6.json` TSConfig preset with `noUncheckedSideEffectImports` enabled
+- Enabled `compilerOptions.resolveJsonModule` by default
+- Enabled `compilerOptions.checkJS` by default
+- Relaxed `prefer-arrow/prefer-arrow-functions` for `**/*[.-]service.ts` files as we expected `@Injectable` to have lifecycle methods
+- Disabled `@typescript-eslint/prefer-for-of` and `sonarjs/prefer-for-of` in favor of `unicorn/no-for-loop`
+- Allowed `i++` in "loop afterthrought" (`for (i = 0; i < l; i++)`) for rule `autofix/no-plusplus`
+- Set `@typescript-eslint/switch-exhaustiveness-check`'s `considerDefaultExhaustiveForUnions` to `false` in non-extra-strict preset
+- Disabled `unicorn/no-useless-switch-case` in extra-strict preset as it and conflicts with `considerDefaultExhaustiveForUnions`
+- Bumped `@stylistic/eslint-plugin` to `^2.12.0` as it fixed `jsx-wrap-multilines` breaking in the presence of comments
+- Bumped `dprint` to `^0.46` to ensure .gitignore support
+
+## 3.2.2
+
+- Disabled `unicorn/no-useless-switch-case` in extra-strict preset as it conflicts with `considerDefaultExhaustiveForUnions`
+- Relaxed `prefer-arrow/prefer-arrow-functions` for `**/*[.-]service.ts` files as we expected `@Injectable` to have lifecycle methods
+
 ## 3.2.1
 
 - Disabled `@typescript-eslint/no-misused-spread`:\
@@ -82,7 +104,6 @@
   }
   ```
 
-```
 `eslint-plugin-sonarjs@2` added a ton of rules, a lot of which duplicates base ESLint rules and other plugins we have. _**Please report those you find**_
 
 ### Changes
@@ -293,4 +314,3 @@
 - Changed the maximum line length from `120` to `100`
 - Split language-specific `editor.defaultFormatter` to work around
   <https://github.com/microsoft/vscode/issues/168411>
-```

package/README.md

@@ -23,6 +23,12 @@ Read the [`package.json`](https://github.com/BesLogic/shared-configs/blob/main/R
 
 Extend the following in your base `tsconfig.json` (follow link for more details):
 
+[`typescript@>=5.6`](https://socket.dev/npm/package/eslint-config-beslogic/files/latest/tsconfig.5.6.json):
+
+```jsonc
+"extends": ["eslint-config-beslogic/tsconfig.5.6.json"],
+```
+
 [`typescript@>=5.0`](https://socket.dev/npm/package/eslint-config-beslogic/files/latest/tsconfig.5.0.json):
 
 ```jsonc
@@ -37,6 +43,15 @@ Extend the following in your base `tsconfig.json` (follow link for more details)
 
 "No Unchecked Indexed Access" makes index accesses even stricter. You may not want it in your project or in your tests. You can disable it with `"compilerOptions": { "noUncheckedIndexedAccess": false }`.
 
+If using experimental decorators (likely for an Angular project), you still need to set
+
+```jsonc
+"compilerOptions": { 
+  "emitDecoratorMetadata": true,
+  "experimentalDecorators": true,
+}
+```
+
 If deploying / bundling with an Angular npm package, also set `angularCompilerOptions": { "strictMetadataEmit": true }`.
 
 ### `.vscode/settings.json` and `.vscode/extensions.json`

package/TODO-SONARJS_CHECK_IF_DUPLICATED.json

@@ -136,7 +136,6 @@
   "sonarjs/os-command": "error",
   "sonarjs/post-message": "error",
   "sonarjs/prefer-default-last": "error",
-  "sonarjs/prefer-for-of": "error",
   "sonarjs/prefer-function-type": "error",
   "sonarjs/prefer-namespace-keyword": "error",
   "sonarjs/prefer-promise-shorthand": "error",

package/angular.js

@@ -49,7 +49,7 @@ const typeDefinitionOverride = typescriptConfig
   .overrides
   ?.find(override => override.files === "*.d.ts")
 
-const noAutofixRreferArrowFunctionsConfig = javascriptConfig
+const noAutofixPreferArrowFunctionsConfig = javascriptConfig
   .rules
   ?.["no-autofix/prefer-arrow/prefer-arrow-functions"]
   ?.[1]
@@ -296,6 +296,7 @@ module.exports = {
         "*[.-]component.ts",
         "*[.-]directive.ts",
         "*[.-]interceptor.ts",
+        "*[.-]service.ts", // @Injectable
         "*[.-]pipes.ts"
       ],
       "rules": {
@@ -306,7 +307,7 @@ module.exports = {
         "no-autofix/prefer-arrow/prefer-arrow-functions": [
           "error",
           {
-            ...noAutofixRreferArrowFunctionsConfig,
+            ...noAutofixPreferArrowFunctionsConfig,
             // https://github.com/TristonJ/eslint-plugin-prefer-arrow/issues/17
             "classPropertiesAllowed": false
           }

package/extra-strict.js

@@ -70,6 +70,8 @@ module.exports = {
             "allowNullish": false
           }
         ],
+        // Unconfigurable and conflicts with `considerDefaultExhaustiveForUnions: true` (set in v4)
+        "unicorn/no-useless-switch-case": "off",
 
         /*
          * @typescript-eslint rules that require strictNullChecks

package/javascript.js

@@ -76,6 +76,10 @@ module.exports = {
        */
       "rules": {
         "autofix/no-caller": "error",
+        "autofix/no-plusplus": [
+          "error",
+          { "allowForLoopAfterthoughts": true }
+        ],
         "autofix/no-proto": "error",
         "autofix/no-prototype-builtins": "error",
         "autofix/no-throw-literal": "error",
@@ -333,6 +337,8 @@ module.exports = {
     "sonarjs/todo-tag": "off",
     // Duplicates unicorn/prefer-string-starts-ends-with
     "sonarjs/prefer-string-starts-ends-with": "off",
+    // Duplicates unicorn/no-for-loop and typescript-eslint/prefer-for-of
+    "sonarjs/prefer-for-of": "off",
     // Duplicates no-nested-ternary and unicorn/no-nested-ternary
     "sonarjs/no-nested-conditional": "off",
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "3.2.1",
+  "version": "3.3.0",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
@@ -43,12 +43,12 @@
   "// eslint-plugin-sonarjs": "Exact version pin. Check for new presets and typescript-eslint@8 support as we",
   "dependencies": {
     "@eslint-community/eslint-plugin-eslint-comments": "^4.1",
-    "@stylistic/eslint-plugin": "^2.8.0",
+    "@stylistic/eslint-plugin": "^2.12.0",
     "@typescript-eslint/eslint-plugin": "^8.15.0",
     "@typescript-eslint/parser": "^8.15.0",
     "@types/eslint": "^8.56",
     "confusing-browser-globals": "^1.0",
-    "dprint": "^0.40.2",
+    "dprint": "^0.46.0",
     "eslint": "^8.57",
     "eslint-import-resolver-typescript": "^3.2.6",
     "eslint-plugin-autofix": "^1.1 || ^2.0",

package/tsconfig.4.3.json

@@ -4,8 +4,10 @@
 {
   "compilerOptions": {
     "strict": true,
+    "checkJs": true,
     "newLine": "LF", // Now default in TypeScript 5.0
     "forceConsistentCasingInFileNames": true, // Now default in TypeScript 5.0
+    "resolveJsonModule": true,
     "noFallthroughCasesInSwitch": true,
     "noImplicitOverride": true,
     "noImplicitReturns": true,

package/tsconfig.5.0.json

@@ -5,10 +5,14 @@
   "extends": "./tsconfig.4.3.json",
   "compilerOptions": {
     "verbatimModuleSyntax": true,
-    // Since this is no longer needed for Angular with TypeScript 5, let's
+    // Since these are no longer needed for most projects with TypeScript 5, let's
     // disable it so @typescript-eslint/consistent-type-imports doesn't turn
     // itself off in files using decorators.
+    // Likely still needed in Angular, if you wanna try without,
+    // see https://angular.dev/reference/migrations/inject-function for migrating @Inject
+    //
     // https://typescript-eslint.io/rules/consistent-type-imports/#caveat-decorators--experimentaldecorators-true--emitdecoratormetadata-true
+    "emitDecoratorMetadata": false,
     "experimentalDecorators": false
   }
 }

package/tsconfig.5.6.json

@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: MIT
+// Copyright 2025 Beslogic Inc.
+
+{
+  "extends": "./tsconfig.5.0.json",
+  "compilerOptions": {
+    "noUncheckedSideEffectImports": true
+    // Likely still needed in Angular, if you wanna try without,
+    // see https://angular.dev/reference/migrations/inject-function for migrating @Inject
+    //
+    // https://typescript-eslint.io/rules/consistent-type-imports/#caveat-decorators--experimentaldecorators-true--emitdecoratormetadata-true
+    // "emitDecoratorMetadata": true,
+    // "experimentalDecorators": true,
+  }
+}

package/tsconfig.json

@@ -1,14 +1,16 @@
 {
-  "extends": "./tsconfig.4.3.json",
+  "extends": "./tsconfig.5.6.json",
   "compilerOptions": {
-    "moduleResolution": "Node16",
-    "module": "Node16",
+    "module": "nodenext", // Set to node18 once we update to typescript 5.8
     "allowSyntheticDefaultImports": true,
     "noUncheckedIndexedAccess": false,
     "noEmit": true,
     "jsx": "react",
     "allowJs": true,
-    "checkJs": true,
     "noImplicitAny": false,
+    // For Angular tests
+    "verbatimModuleSyntax": false,
+    "emitDecoratorMetadata": true,
+    "experimentalDecorators": true,
   },
 }

package/typescript.js

@@ -299,6 +299,11 @@ module.exports = {
         ],
         "@typescript-eslint/prefer-enum-initializers": "off",
 
+        // Very similar to `unicorn/no-for-loop` but doesn't have autofixes.
+        // TODO: If autofixes or suggestion is added, prefer over unicorn's
+        // https://github.com/typescript-eslint/typescript-eslint/issues/11336
+        "@typescript-eslint/prefer-for-of": "off",
+
         // TODO: Would accept this if it had autofixes, otherwise this is too tedious to use. Check again later
         "@typescript-eslint/prefer-readonly-parameter-types": "off",
         "@typescript-eslint/prefer-string-starts-ends-with": [