eslint-config-beslogic 3.2.0 → 3.2.2

package/.dprint.jsonc

@@ -3,5 +3,5 @@
 
 {
   // https://dprint.dev/config/#extending-a-different-configuration-file
-  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json",
+  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/.dprint-json-like.jsonc",
 }

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 3.2.2
+
+- Disabled `unicorn/no-useless-switch-case` in extra-strict preset as it conflicts with `considerDefaultExhaustiveForUnions`
+- Relaxed `prefer-arrow/prefer-arrow-functions` for `**/*[.-]service.ts` files as we expected `@Injectable` to have lifecycle methods
+
+## 3.2.1
+
+- Disabled `@typescript-eslint/no-misused-spread`:\
+  Still a handful of false-positives and I couldn't get the configuration working.\
+  Especially annoying with autogenerated API when spreading class instance
+  with readonly properties as its contructor object.\
+  ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`\
+  NOTE: If fixed, we'd still only want this in extra-strict config.
+
 ## 3.2.0
 
 - Migrated from `eslint-plugin-import` to `eslint-plugin-import-x@^4.2.1` for simpler configs and performance improvement.
@@ -73,7 +87,6 @@
   }
   ```
 
-```
 `eslint-plugin-sonarjs@2` added a ton of rules, a lot of which duplicates base ESLint rules and other plugins we have. _**Please report those you find**_
 
 ### Changes
@@ -284,4 +297,3 @@
 - Changed the maximum line length from `120` to `100`
 - Split language-specific `editor.defaultFormatter` to work around
   <https://github.com/microsoft/vscode/issues/168411>
-```

package/angular.js

@@ -49,7 +49,7 @@ const typeDefinitionOverride = typescriptConfig
   .overrides
   ?.find(override => override.files === "*.d.ts")
 
-const noAutofixRreferArrowFunctionsConfig = javascriptConfig
+const noAutofixPreferArrowFunctionsConfig = javascriptConfig
   .rules
   ?.["no-autofix/prefer-arrow/prefer-arrow-functions"]
   ?.[1]
@@ -296,6 +296,7 @@ module.exports = {
         "*[.-]component.ts",
         "*[.-]directive.ts",
         "*[.-]interceptor.ts",
+        "**/*[.-]service.ts", // @Injectable
         "*[.-]pipes.ts"
       ],
       "rules": {
@@ -306,7 +307,7 @@ module.exports = {
         "no-autofix/prefer-arrow/prefer-arrow-functions": [
           "error",
           {
-            ...noAutofixRreferArrowFunctionsConfig,
+            ...noAutofixPreferArrowFunctionsConfig,
             // https://github.com/TristonJ/eslint-plugin-prefer-arrow/issues/17
             "classPropertiesAllowed": false
           }

package/extra-strict.js

@@ -70,6 +70,8 @@ module.exports = {
             "allowNullish": false
           }
         ],
+        // Unconfigurable and conflicts with `considerDefaultExhaustiveForUnions: true` (set in v4)
+        "unicorn/no-useless-switch-case": "off",
 
         /*
          * @typescript-eslint rules that require strictNullChecks

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "3.2.0",
+  "version": "3.2.2",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",

package/tsconfig.json

@@ -9,6 +9,6 @@
     "jsx": "react",
     "allowJs": true,
     "checkJs": true,
-    "noImplicitAny": false
-  }
+    "noImplicitAny": false,
+  },
 }

package/typescript.js

@@ -208,6 +208,12 @@ module.exports = {
             "ignoreTypeIndexes": true
           }
         ],
+        // Still a handful of false-positives and I couldn't get the configuration working.
+        // Especially annoying with autogenerated API when spreading class instance
+        // with readonly properties as its contructor object.
+        // ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`
+        // NOTE: If fixed, we'd still only want this in extra-strict config.
+        "@typescript-eslint/no-misused-spread": "off",
         "@typescript-eslint/no-misused-promises": [
           "error",
           {