eslint-config-beslogic 3.1.4 → 3.2.1

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 3.2.1
+
+- Disabled `@typescript-eslint/no-misused-spread`:\
+  Still a handful of false-positives and I couldn't get the configuration working.\
+  Especially annoying with autogenerated API when spreading class instance
+  with readonly properties as its contructor object.\
+  ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`\
+  NOTE: If fixed, we'd still only want this in extra-strict config.
+
+## 3.2.0
+
+- Migrated from `eslint-plugin-import` to `eslint-plugin-import-x@^4.2.1` for simpler configs and performance improvement.
+  - This also forces `eslint` to version `8.57` or above
+
 ## 3.1.4
 
 - Pinned `eslint-plugin-unicorn` to `>=49.0 && <57`

package/javascript.js

@@ -43,7 +43,7 @@ module.exports = {
     "plugin:sonarjs/recommended-legacy", // "legacy" is for ESLint v8 compatibility
     "plugin:unicorn/all",
     "plugin:regexp/all",
-    "plugin:import/recommended",
+    "plugin:import-x/recommended",
     "plugin:@eslint-community/eslint-comments/recommended"
   ],
   "env": {
@@ -427,26 +427,26 @@ module.exports = {
     // - no-useless-react-setstate
 
     /*
-     * import settings (https://github.com/import-js/eslint-plugin-import#rules)
+     * import settings (https://github.com/un-ts/eslint-plugin-import-x#rules)
      */
-    "import/consistent-type-specifier-style": [
+    "import-x/consistent-type-specifier-style": [
       "error",
       "prefer-top-level"
     ],
-    "import/no-duplicates": [
+    "import-x/no-duplicates": [
       "error",
       { "considerQueryString": true }
     ],
-    "import/no-empty-named-blocks": "error",
-    "import/newline-after-import": [
+    "import-x/no-empty-named-blocks": "error",
+    "import-x/newline-after-import": [
       "error",
       {
         "exactCount": true,
         "considerComments": true
       }
     ],
-    "import/no-named-as-default": "error",
-    "import/no-named-as-default-member": "error",
+    "import-x/no-named-as-default": "error",
+    "import-x/no-named-as-default-member": "error",
 
     // Extracted restricted import into its own rule so it's easier for projects to override/ignore
     "no-autofix/no-relative-import-paths/no-relative-import-paths": [
@@ -878,7 +878,7 @@ module.exports = {
     "no-constant-binary-expression": "error",
     "no-constructor-return": "error",
     "no-dupe-else-if": "error",
-    // Obsoleted by import/no-duplicates
+    // Obsoleted by import-x/no-duplicates
     "no-duplicate-imports": "off",
     "no-extend-native": "error",
     "no-implied-eval": "error",

package/node-js.js

@@ -25,6 +25,11 @@ module.exports = {
   "env": {
     "node": true
   },
+  "settings": {
+    "import-x/resolver": {
+      "node": true
+    }
+  },
   "globals": {
     "__dirname": true,
     "require": true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "3.1.4",
+  "version": "3.2.1",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
@@ -49,12 +49,12 @@
     "@types/eslint": "^8.56",
     "confusing-browser-globals": "^1.0",
     "dprint": "^0.40.2",
-    "eslint": "^8.56",
+    "eslint": "^8.57",
     "eslint-import-resolver-typescript": "^3.2.6",
     "eslint-plugin-autofix": "^1.1 || ^2.0",
     "eslint-plugin-etc": "^2.0",
     "eslint-plugin-extra-rules": "^0.0.0-development",
-    "eslint-plugin-import": "^2.30",
+    "eslint-plugin-import-x": "^4.2.1",
     "eslint-plugin-jest": "^28.7",
     "eslint-plugin-jest-formatting": "^3.1",
     "eslint-plugin-no-autofix": "^2.0",

package/tsconfig.json

@@ -9,6 +9,6 @@
     "jsx": "react",
     "allowJs": true,
     "checkJs": true,
-    "noImplicitAny": false
-  }
+    "noImplicitAny": false,
+  },
 }

package/typescript.js

@@ -40,14 +40,14 @@ module.exports = {
       "extends": [
         "plugin:@typescript-eslint/all",
         "plugin:etc/recommended",
-        "plugin:import/typescript"
+        "plugin:import-x/typescript"
       ],
       "env": {
         // https://eslint.org/docs/v8.x/use/configure/language-options#specifying-environments
         "es2022": true // Same as tsconfig.json > compilerOptions.lib
       },
       "settings": {
-        "import/resolver": {
+        "import-x/resolver": {
           "typescript": {
             // Recommended by eslint-import-resolver-typescript
             // Always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
@@ -92,11 +92,11 @@ module.exports = {
       },
       "rules": {
         // Slow and not as useful with TypeScript: https://github.com/import-js/eslint-plugin-import/issues/2340
-        "import/namespace": "off",
+        "import-x/namespace": "off",
         // TypeScript already ensures imports resolve
-        "import/no-unresolved": "off",
+        "import-x/no-unresolved": "off",
         // Already checked by @typescript-eslint/no-import-type-side-effects
-        "import/consistent-type-specifier-style": "off",
+        "import-x/consistent-type-specifier-style": "off",
 
         /*
          * Cartant's etc rules
@@ -208,6 +208,12 @@ module.exports = {
             "ignoreTypeIndexes": true
           }
         ],
+        // Still a handful of false-positives and I couldn't get the configuration working.
+        // Especially annoying with autogenerated API when spreading class instance
+        // with readonly properties as its contructor object.
+        // ie: `new Myclass({...someInstance, overwritten_prop: "foo"})`
+        // NOTE: If fixed, we'd still only want this in extra-strict config.
+        "@typescript-eslint/no-misused-spread": "off",
         "@typescript-eslint/no-misused-promises": [
           "error",
           {