eslint-config-beslogic 3.1.2 → 4.0.2

package/.dprint.jsonc

@@ -3,5 +3,5 @@
 
 {
   // https://dprint.dev/config/#extending-a-different-configuration-file
-  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json"
+  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json",
 }

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## 4.0.2
+
+- Initial support for Flat Configs. v4 will only support Flat Configs (`eslint.config.js`), please use v3 for Legacy Configs (`.eslintrc`).
+- `angular-eslint` won't work on HTML files on ESLint v8 due to parser configuration issues.
+- Autodetection of `.gitignore` using `eslint-config-flat-gitignore`
+- Updated dependencies:
+  - Using the combined `typescript-eslint` package instead of `@typescript-eslint/eslint-plugin` + `@typescript-eslint/parser`
+  - Using the combined `angular-eslint` package instead of `@angular-eslint/eslint-plugin` + `@angular-eslint/eslint-plugin-template` + `@angular-eslint/template-parser`
+  - Bumped `typescript-eslint` to `^8.15`
+  - Bumped `angular-eslint` to `>=18.0`
+  - Bumped `eslint-plugin-react-hooks` to `^5.0`
+  - Bumped `eslint-plugin-react-prefer-function-component` to `^3.3.0`
+  - Bumped `eslint-plugin-storybook` to `^0.10`
+  - Bumped `eslint-plugin-react` to `^7.37.1`
+  - Added dependency on `@eslint/compat` and `eslint-config-flat-gitignore`
+
 ## 3.1.2
 
 - Removed `globalThis` from `no-restricted-globals` as the adoption is now much wider (no more IE11) and it conflicts with `unicorn/prefer-global-this`

package/README.md

@@ -6,10 +6,10 @@ Run `npm i  --save-dev eslint-config-beslogic`
 
 Depending on your needs, you will need to also install other peer dependencies for linting.
 
-In your `.eslintrc` file, add `"extends": "beslogic/<preset>"` (see all available presets below)
+In your `eslint.config.[cm]?js` file, simply [extend](https://typescript-eslint.io/getting-started#step-2-configuration) our [presets](#presets) appropriate for your project.
 
 For stylistic rules, it is highly recommended to use a dedicated formatter over ESLint. Read more here: <https://typescript-eslint.io/docs/linting/troubleshooting/formatting/>\
-A [dprint preset](#beslogicdprint) is offered below.
+We assume [dprint](https://dprint.dev/) and don't enable any rules it covers by default. If you're not using a formatter, a [stylistic.mjs](#stylisticmjs) configuration is offered below.
 
 ## Parallel configurations
 
@@ -59,7 +59,7 @@ Extend the following in your base `.dprint.jsonc` (follow link for more details)
 This configuration automatically includes known "exclusion" folders. But if you need to add more, you can copy and expand the `exludes` list in [dprint.json](https://github.com/BesLogic/shared-configs/blob/main/dprint.json).\
 If you'd like to pin your config version, you can use a commit hash, like `https://raw.githubusercontent.com/BesLogic/shared-configs/a0d9a34/dprint.json`.
 
-If also using [`beslogic/json-like` preset](#beslogicjson-like) extend from `https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json` instead.
+If also using [`json-like.mjs` preset](#json-likemjs) extend from `https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json` instead.
 
 ### PR Autofixes
 
@@ -84,29 +84,91 @@ Angular Material's MatDialogRef [defaults it dialog result generic to `any`](htt
 
 ## Presets
 
-Below are all the different configurations you can extend from. You can mix and match as you want if a predefined configuration does not exist for your specific stack. You should import TypeScript configs after regular javascript ones. ie `"extends": ["beslogic/node", "beslogic/typescript"]` at the root of the configuration.
+Below are all the different configurations you can extend from. You can mix and match as you want if a predefined configuration does not exist for your specific stack. You should import TypeScript configs after regular javascript ones at the root of the configuration.
 
-### `beslogic`
+Examples
 
-Default preset, extends from `beslogic/javascript` and `beslogic/typescript`.
+<details>
+<summary>React + TypeScript</summary>
 
-### `beslogic/jest`
+```js
+import tseslint from 'typescript-eslint'
+import beslogicExtraStrict from 'eslint-config-beslogic/extra-strict.mjs'
+import beslogicReact from 'eslint-config-beslogic/react.mjs'
+import beslogicTypeScript from 'eslint-config-beslogic/typescript.mjs'
 
-[Jest](https://www.npmjs.com/package/jest) and [Testing Library](https://testing-library.com/) configs. Is already extended by `beslogic/javascript` and `beslogic/typescript` for all `*spec.[jt]s` and `*.test.[jt]sx` files, as well as `*.[jt]s` and `*.[jt]sx` files inside of `__tests__` folders. You should not need to extend from this configuration unless you want to add it to a test file that is not automatically picked up by the naming convention.
+export default tseslint.config(
+  beslogicReact,
+  beslogicTypeScript,
+  beslogicExtraStrict,
+  // Your configs here
+  {...}
+)
+```
+
+</details>
+
+<details>
+<summary>Angular</summary>
+
+```js
+import tseslint from 'typescript-eslint'
+import beslogicAngular from 'eslint-config-beslogic/angular.mjs'
+import beslogicExtraStrict from 'eslint-config-beslogic/extra-strict.mjs'
+
+export default tseslint.config(
+  beslogicAngular,
+  beslogicExtraStrict,
+  // Your configs here
+  {...}
+)
+```
+
+</details>
+
+<details>
+<summary>Frameworkless TypeScript w/o dprint</summary>
+
+```js
+import tseslint from 'typescript-eslint'
+import beslogicExtraStrict from 'eslint-config-beslogic/extra-strict.mjs'
+import beslogicJavascript from 'eslint-config-beslogic/javascript.mjs'
+import beslogicStylistic from 'eslint-config-beslogic/stylistic.mjs'
+import beslogicTypeScript from 'eslint-config-beslogic/typescript.mjs'
+
+export default tseslint.config(
+  beslogicJavascript,
+  beslogicTypeScript,
+  beslogicExtraStrict,
+  beslogicStylistic,
+  // Your configs here
+  {...}
+)
+```
+
+</details>
+
+### `index.mjs`
+
+Default preset, extends from `javascript.mjs` and `typescript.mjs`.
 
-### `beslogic/javascript`
+### `jest.mjs`
 
-Basic javascript configs, is extended by all other configs except `beslogic/typescript`, `beslogic/jest`, `beslogic/storybook` and `beslogic/json-like`.
+[Jest](https://www.npmjs.com/package/jest) and [Testing Library](https://testing-library.com/) configs. Is already extended by `javascript.mjs` and `typescript.mjs` for all `*spec.[jt]s` and `*.test.[jt]sx` files, as well as `*.[jt]s` and `*.[jt]sx` files inside of `__tests__` folders. You should not need to extend from this configuration unless you want to add it to a test file that is not automatically picked up by the naming convention.
 
-### `beslogic/typescript`
+### `javascript.mjs`
 
-Basic TypeScript-specific configs and `TSX` support, is extended by all other TypeScript exclusive configs. To avoid rules conflicts, it does **not** already extend from `beslogic/javascript`. So you should extend from both in a pure TypeScript project. You may also need to specify `parserOptions.project`. ie: `"parserOptions": { "project": ["tsconfig.json"] },` and `"parser": "@typescript-eslint/parser"` if you reconfigure some rules yourself.
+Basic javascript configs, is extended by all other configs except `typescript.mjs`, `jest.mjs`, `storybook.mjs` and `json-like.mjs`.
+
+### `typescript.mjs`
+
+Basic TypeScript-specific configs and `TSX` support, is extended by all other TypeScript exclusive configs. To avoid rules conflicts, it does **not** already extend from `javascript.mjs`. So you should extend from both in a pure TypeScript project. You may also need to specify `parserOptions.project`. ie: `"parserOptions": { "project": ["tsconfig.json"] },` and `"parser": "@typescript-eslint/parser"` if you reconfigure some rules yourself.
 
 For the linting to be fully effective, please make sure that your base `tsconfig.json` extends `eslint-config-beslogic/tsconfig.X.X.json` (see [Parallel configurations](#parallel-configurations)).
 
-If you want extra strict linting, consider adding the [`beslogic/extra-strict` preset](#beslogicextra-strict).
+If you want extra strict linting, consider adding the [`extra-strict.mjs` preset](#extra-strictmjs).
 
-### `beslogic/node-js`
+### `node-js.mjs`
 
 Configurations for NodeJS backends.
 
@@ -116,9 +178,9 @@ Add the following `devDependencies` to your `package.json`:
 npm install --save-dev eslint-plugin-n
 ```
 
-### `beslogic/rxjs`
+### `rxjs.mjs`
 
-Configurations for projects using RxJs. Already extends and `beslogic/typescript` for TypeScript-specific rules and is already extended by `beslogic/angular`.
+Configurations for projects using RxJs. Already extends and `typescript.mjs` for TypeScript-specific rules and is already extended by `angular.mjs`.
 
 Add the following `devDependencies` to your `package.json`:
 
@@ -126,7 +188,7 @@ Add the following `devDependencies` to your `package.json`:
 npm install --save-dev eslint-plugin-rxjs
 ```
 
-### `beslogic/react`
+### `react.mjs`
 
 Configurations for React projects. Comes with `JSX` support.
 
@@ -136,9 +198,9 @@ Add the following `devDependencies` to your `package.json`:
 npm install --save-dev eslint-plugin-jsx-a11y eslint-plugin-react eslint-plugin-react-hooks eslint-plugin-react-prefer-function-component
 ```
 
-### `beslogic/react-native`
+### `react-native.mjs`
 
-Configurations for [React Native](https://reactnative.dev/) projects, including [Expo](https://expo.dev/). Already extends `beslogic/react`.
+Configurations for [React Native](https://reactnative.dev/) projects, including [Expo](https://expo.dev/). Already extends `react.mjs`.
 
 Add the following `devDependencies` to your `package.json`:
 
@@ -146,9 +208,9 @@ Add the following `devDependencies` to your `package.json`:
 npm install --save-dev eslint-plugin-react-native eslint-plugin-jsx-a11y eslint-plugin-react eslint-plugin-react-hooks eslint-plugin-react-prefer-function-component
 ```
 
-### `beslogic/react-redux`
+### `react-redux.mjs`
 
-Configurations for React projects using the Redux bindings. Already extends `beslogic/react`.
+Configurations for React projects using the Redux bindings. Already extends `react.mjs`.
 
 Add the following `devDependencies` to your `package.json`:
 
@@ -156,9 +218,9 @@ Add the following `devDependencies` to your `package.json`:
 npm install --save-dev eslint-plugin-react-redux eslint-plugin-jsx-a11y eslint-plugin-react eslint-plugin-react-hooks eslint-plugin-react-prefer-function-component
 ```
 
-### `beslogic/mui`
+### `mui.mjs`
 
-[MUI/material](https://github.com/mui-org/material-ui) framework configurations. Already extends `beslogic/react` and `beslogic/typescript`.
+[MUI/material](https://github.com/mui-org/material-ui) framework configurations. Already extends `react.mjs` and `typescript.mjs`.
 
 Add the following `devDependencies` to your `package.json`:
 
@@ -166,20 +228,22 @@ Add the following `devDependencies` to your `package.json`:
 npm install --save-dev eslint-plugin-mui eslint-plugin-jsx-a11y eslint-plugin-react eslint-plugin-react-hooks eslint-plugin-react-prefer-function-component
 ```
 
-### `beslogic/angular`
+### `angular.mjs`
 
-Configurations for NGX projects. Comes with `html` template and inline template support. Already extends `beslogic/rxjs` and `beslogic/typescript`. Also extends `beslogic/node-js` for Javascript files.
+Configurations for NGX projects. Comes with `html` template and inline template support. Already extends `rxjs.mjs` and `typescript.mjs`. Also extends `node-js.mjs` for Javascript files.
 
 For the linting to be fully effective, please make sure that your base `tsconfig.json` extends `eslint-config-beslogic/tsconfig.X.X.json` (see [Parallel configurations](#parallel-configurations)).\
 If bundling as an npm package set `"strictMetadataEmit": true` under `angularCompilerOptions`.
 
+**NOTE**: `angular-eslint` won't work on HTML files on ESLint v8 due to parser configuration issues.
+
 Add the following `devDependencies` to your `package.json`:
 
 ```shell
 npm install --save-dev @angular-eslint/eslint-plugin @angular-eslint/eslint-plugin-template @angular-eslint/template-parser github:BesLogic/eslint-plugin-rxjs-angular#dist eslint-plugin-angular-file-naming
 ```
 
-### `beslogic/storybook`
+### `storybook.mjs`
 
 Includes strict Storybook ESLint plugin and a custom rule for Angular components. This preset should be added last.\
 If you're using different ESLint configs for your Angular and Storybook projects, you should add this preset to both.
@@ -194,11 +258,11 @@ npm install --save-dev eslint-plugin-storybook
 
 If used, these presets should always come last, in this specific order.
 
-### `beslogic/extra-strict`
+### `extra-strict.mjs`
 
-Enables extra-strict rules for `beslogic/typescript` and `beslogic/angular`, and forces that your `tsconfig.json` is strictly configured.
+Enables extra-strict rules for `typescript.mjs` and `angular.mjs`, and forces that your `tsconfig.json` is strictly configured.
 
-### `beslogic/stylistic`
+### `stylistic.mjs`
 
 Enables stylistic rules that would be taken care of by [dprint](https://dprint.dev/plugins/typescript/). Please read [What About Formatting?](https://typescript-eslint.io/users/what-about-formatting/)
 
@@ -206,7 +270,7 @@ We don't recommend using this preset, and to use dprint instead (see [Parallel c
 
 But if for some reason, `dprint` isn't an option for you, this preset follows our standards using ESLint.
 
-### `beslogic/json-like`
+### `json-like.mjs`
 
 Enforces stylistic rules for JS objects to look like valid JSON objects.
 
@@ -220,6 +284,6 @@ You can view the changelog under the [Code Tab](https://www.npmjs.com/package/es
 To test updates to ESLint-Config-Beslogic in other existing projects:
 1. At the root of this repo, run `npm i` then `npm run yalc`
 2. In the target project, run `npm i --save-dev yalc` then `yalc add eslint-config-beslogic`
-3. Update the project's .eslintrc config file as needed
+3. Update the project's eslintrc.config.mjs config file as needed
 4. Run your linting
 -->

package/TODO-SONARJS_CHECK_IF_DUPLICATED.json

@@ -28,7 +28,6 @@
   "sonarjs/encryption-secure-mode": "error",
   "sonarjs/file-permissions": "error",
   "sonarjs/file-uploads": "error",
-  "sonarjs/fixme-tag": "error",
   "sonarjs/for-loop-increment-sign": "error",
   "sonarjs/frame-ancestors": "error",
   "sonarjs/function-inside-loop": "error",

package/angular.mjs

@@ -0,0 +1,358 @@
+// SPDX-License-Identifier: MIT
+// Copyright 2024 Beslogic Inc.
+
+import angular from "angular-eslint"
+import angularFileNaming from "eslint-plugin-angular-file-naming"
+import rxjsAngular from "eslint-plugin-rxjs-angular"
+import testingLibrary from "eslint-plugin-testing-library"
+import tseslint from "typescript-eslint"
+
+import { noAutofixRreferArrowFunctionsConfig, noRestrictedSyntax as noRestrictedSyntaxJS, preferArrowFunctionsConfig, preventAbbreviationsConfig as preventAbbreviationsConfigJS } from "./javascript.mjs"
+import { getModuleVersion, jestFilePatterns, jestNoRestrictedSyntax } from "./lib/utils.mjs"
+import beslogicNodeJS from "./node-js.mjs"
+import beslogicRXJS from "./rxjs.mjs"
+import beslogicTypeScript from "./typescript.mjs"
+
+const typescriptVersion = getModuleVersion("typescript", 4.7)
+const eslintVersion = getModuleVersion("eslint", 8.56)
+
+const typeDefinitionOverride = beslogicTypeScript.find(
+  config => config.files?.includes("**/*.d.ts")
+)
+
+export const noRestrictedSyntax = [
+  ...noRestrictedSyntaxJS,
+  // TODO: Asked to be its own rule: https://github.com/angular-eslint/angular-eslint/issues/1002
+  {
+    "selector":
+      "ClassDeclaration:has(Decorator :matches([name=\"Component\"], [name=\"Injectable\"], [name=\"Directive\"], [name=\"Pipe\"])) :matches(PropertyDefinition[key.name=\"intercept\"], PropertyDefinition[key.name=\"ngOnChanges\"], PropertyDefinition[key.name=\"ngOnInit\"], PropertyDefinition[key.name=\"ngDoCheck\"], PropertyDefinition[key.name=\"ngAfterContentInit\"], PropertyDefinition[key.name=\"ngAfterContentChecked\"], PropertyDefinition[key.name=\"ngAfterViewInit\"], PropertyDefinition[key.name=\"ngAfterViewChecked\"], PropertyDefinition[key.name=\"ngOnDestroy\"])",
+    "message":
+      "Angular hooks need to be functions defined on the prototype: https://github.com/angular/angular/issues/7270#issuecomment-201137617"
+  },
+  // TODO: Possibly implement that ourselves?
+  // Upstream request: https://github.com/MelvinVermeer/eslint-plugin-no-relative-import-paths/issues/30
+  {
+    "selector": "ImportDeclaration[source.value=/\\.\\.\\u002F?$/]",
+    "message": "Don't use imports that ends in \"..\" or \"../\""
+  },
+  // From typescript configs, but allow on @Input()
+  {
+    "selector":
+      "PropertyDefinition[definite=true]:not(:has(Decorator[expression.callee.name=\"Input\"] Property[key.name=\"required\"][value.value=true]))",
+    "message":
+      "Forbidden non-null property assertion. https://typescript-eslint.io/rules/no-non-null-assertion . "
+      + "This is only allowed on required component @Input({ required:true }). https://angular.io/api/core/Input#required"
+  },
+  {
+    "selector":
+      "MethodDefinition[key.name=\"constructor\"]:has(TSParameterProperty:has(Decorator[expression.callee.name=\"Optional\"]):not(:has(Identifier[optional=true])))",
+    "message":
+      "Constructor parameter with @Optional decorator should be marked as optional using `?`."
+  },
+  {
+    "selector":
+      "ClassDeclaration:has(Decorator :matches([name=\"Component\"], [name=\"Injectable\"], [name=\"Directive\"], [name=\"Pipe\"])) MethodDefinition[key.name=\"constructor\"]:has(TSParameterProperty:has(Identifier[optional=true]):not(:has(Decorator[expression.callee.name=\"Optional\"])))",
+    "message": "Optional constructor parameter should have @Optional decorator."
+  }
+]
+
+const preventAbbreviationsConfig = { ...preventAbbreviationsConfigJS }
+
+// Supported Refs
+preventAbbreviationsConfig.allowList.Ref = true
+// ag-grid ColumnDef
+preventAbbreviationsConfig.allowList.Def = true
+preventAbbreviationsConfig.allowList.def = true
+
+const end2endPreventAbbreviationsConfig = { ...preventAbbreviationsConfig }
+end2endPreventAbbreviationsConfig.allowList.e = true
+
+export default tseslint.config(
+  beslogicRXJS,
+  beslogicTypeScript,
+  // For some reasons I'm unable to configure the parser.
+  // The doc doesn't even mention needing to configure it, could be a v9 only support.
+  eslintVersion >= 9
+    ? {
+      "files": ["**/*.html"],
+      "extends": [...angular.configs.templateAll],
+      "rules": {
+        "@angular-eslint/template/click-events-have-key-events": "off",
+        "@angular-eslint/template/conditional-complexity": [
+          "error",
+          // Same as ESLint sonarjs/cognitive-complexity
+          { "maxComplexity": 20 }
+        ],
+        "@angular-eslint/template/cyclomatic-complexity": [
+          "error",
+          // Same as ESLint complexity
+          { "maxComplexity": 20 }
+        ],
+        "@angular-eslint/template/eqeqeq": [
+          "error",
+          { "allowNullOrUndefined": true }
+        ],
+        "@angular-eslint/template/no-inline-styles": [
+          "error",
+          {
+            "allowNgStyle": true,
+            "allowBindToStyle": true
+          }
+        ],
+        "@angular-eslint/template/attributes-order": "error",
+        // Don't autofix as these should be handled manually, also configured in extra-strict preset
+        "@angular-eslint/template/i18n": "off",
+        // This constantly requires wrapping images in an additional div or knowing the exact display size.
+        // Doesn't support relative sizing either, not sure if worth even trying to enforce.
+        "@angular-eslint/template/prefer-ngsrc": "off",
+        // TODO: Investigate the value of this rule.
+        // It is new to me as well and I want to ensure I can isolate and understand breaking changes.
+        // Maybe with NG17's new control flow syntax that eliminates the need for track-by directive?
+        "@angular-eslint/template/use-track-by-function": "off"
+      }
+    }
+    : {},
+  {
+    "files": ["**/*.ts"],
+    "extends": [...angular.configs.tsAll],
+    "processor": angular.processInlineTemplates,
+    "plugins": {
+      "rxjs-angular": rxjsAngular,
+      "angular-file-naming": angularFileNaming
+    },
+    "languageOptions": {
+      "parserOptions": {
+        "project": [
+          "tsconfig?(.*).json",
+          "**/tsconfig?(.*).json" // For example: e2e/tsconfig.json
+        ],
+        // Needed specifically for @typescript-eslint/consistent-type-imports
+        // https://typescript-eslint.io/rules/consistent-type-imports/#caveat-decorators--experimentaldecorators-true--emitdecoratormetadata-true
+        "emitDecoratorMetadata": typescriptVersion >= 5
+      }
+    },
+    "rules": {
+      /*
+       * angular-file-naming rules (https://github.com/takuya-nakayasu/eslint-plugin-angular-file-naming#rules)
+       */
+      "angular-file-naming/component-filename-suffix": "error",
+      "angular-file-naming/directive-filename-suffix": "error",
+      "angular-file-naming/module-filename-suffix": "error",
+      "angular-file-naming/pipe-filename-suffix": "error",
+      "angular-file-naming/service-filename-suffix": [
+        "error",
+        {
+          "suffixes": [
+            "service",
+            "data-service",
+            "interceptor",
+            "guard"
+          ]
+        }
+      ],
+
+      /*
+       * rxjs-angular rules
+       */
+      "rxjs/no-finnish": "error",
+      "rxjs-angular/prefer-async-pipe": "off",
+      "rxjs-angular/prefer-composition": [
+        "error",
+        {
+          "superClass": [
+            "BaseComponent",
+            "BaseDirective"
+          ]
+        }
+      ],
+      "rxjs-angular/prefer-takeuntil": [
+        "error",
+        {
+          "checkComplete": true,
+          "superClass": [
+            "BaseComponent",
+            "BaseDirective"
+          ]
+        }
+      ],
+
+      /*
+       * Angular-eslint overrides (https://github.com/angular-eslint/angular-eslint/tree/master/packages/eslint-plugin/docs/rules)
+       */
+      "@angular-eslint/component-class-suffix": [
+        "error",
+        {
+          "suffixes": [
+            "Component",
+            "Dialog"
+          ]
+        }
+      ],
+      "@angular-eslint/component-selector": [
+        "error",
+        {
+          "type": "element",
+          "style": "kebab-case"
+        }
+      ],
+      "@angular-eslint/directive-selector": [
+        "error",
+        {
+          "type": "attribute",
+          "style": "camelCase"
+        }
+      ],
+      "@angular-eslint/prefer-on-push-component-change-detection": "off",
+      // We need to disable the autofix because some of the "new" standalone components
+      // would still be declared in their module. This breaks Angular and requires manual changes.
+      "@angular-eslint/prefer-standalone-component": "off",
+      // IDEM but updated rule that now works on more than components
+      "@angular-eslint/prefer-standalone": "off",
+      // Prefer Standalone still requires a bit of convincing,
+      // maybe with NG17's new control flow syntax that reduces imports in standalone components?
+      // And not until this rule also applies to Pipes and Directives
+      // https://github.com/angular-eslint/angular-eslint/pull/1627#pullrequestreview-1807581472
+      "no-autofix/@angular-eslint/prefer-standalone-component": "off",
+      // IDEM but updated rule that now works on more than components
+      "no-autofix/@angular-eslint/prefer-standalone": "off",
+
+      /*
+       * Custom rules and @typescript-eslint/all overrides (https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/src/configs/all.ts)
+       */
+      "@typescript-eslint/consistent-type-definitions": [
+        "error",
+        "interface"
+      ],
+      // TODO: https://dev.azure.com/Beslogic/ESLint-Config-Beslogic/_workitems/edit/16268
+      "@typescript-eslint/member-ordering": "off",
+      // Angular directives can lead to empty classes
+      // Angular's withConfig pattern for @NgModule leads to only static method
+      // https://angular.io/api/platform-browser/animations/BrowserAnimationsModule#withconfig
+      "@typescript-eslint/no-extraneous-class": [
+        "error",
+        { "allowWithDecorator": true }
+      ],
+      // Incompatible with Angular's dependecy injection
+      "@typescript-eslint/no-invalid-this": "off",
+      // Redundant with Angular's dependecy injection
+      "@typescript-eslint/parameter-properties": "off",
+      "unicorn/no-keyword-prefix": [
+        "error",
+        {
+          // Allow class because of "classList"
+          "disallowedPrefixes": [
+            "for",
+            "of"
+          ]
+        }
+      ],
+      // Angular is ESM
+      "unicorn/prefer-module": "error",
+      // This is not supported in Angular's Vite builder https://github.com/angular/angular-cli/issues/26507
+      "unicorn/prefer-top-level-await": "off",
+      "unicorn/prevent-abbreviations": [
+        "error",
+        preventAbbreviationsConfig
+      ],
+      // In Angular, @Input decorated only-setters are valid
+      "accessor-pairs": [
+        "error",
+        { "enforceForClassMembers": false }
+      ],
+      "no-restricted-syntax": noRestrictedSyntax
+    }
+  },
+  {
+    "files": [
+      "**/*.js",
+      "**/*.[cm]js"
+    ],
+    "extends": [...beslogicNodeJS]
+  },
+  {
+    "files": ["**/polyfills.ts"],
+    "rules": {
+      "simple-import-sort/imports": "off"
+    }
+  },
+  {
+    "files": [
+      // See no-restricted-syntax
+      // TODO: See if it's possible to implement myself (library updates or eslint-rule-composer)
+      "**/*[.-]component.ts",
+      "**/*[.-]directive.ts",
+      "**/*[.-]interceptor.ts",
+      "**/*[.-]pipes.ts"
+    ],
+    "rules": {
+      // Angular hooks should be named functions
+      // https://github.com/bahmutov/eslint-rules/issues/54
+      // TODO: consider https://github.com/jonaskello/eslint-plugin-functional/blob/HEAD/docs/rules/prefer-tacit.md
+      "extra-rules/potential-point-free": "off",
+      "no-autofix/prefer-arrow/prefer-arrow-functions": [
+        "error",
+        {
+          ...noAutofixRreferArrowFunctionsConfig,
+          // https://github.com/TristonJ/eslint-plugin-prefer-arrow/issues/17
+          "classPropertiesAllowed": false
+        }
+      ],
+      "prefer-arrow/prefer-arrow-functions": [
+        "error",
+        {
+          ...preferArrowFunctionsConfig,
+          // https://github.com/TristonJ/eslint-plugin-prefer-arrow/issues/17
+          "classPropertiesAllowed": false
+        }
+      ]
+    }
+  },
+  {
+    "files": jestFilePatterns,
+    "extends": [testingLibrary.configs["flat/angular"]],
+    "rules": {
+      "no-restricted-syntax": jestNoRestrictedSyntax(noRestrictedSyntax)
+    }
+  },
+  {
+    "files": [
+      "**/*.e2e-spec.ts",
+      "**/*.d.ts"
+    ],
+    "rules": {
+      "unicorn/prevent-abbreviations": [
+        // Can't configure e in e2e
+        "off",
+        end2endPreventAbbreviationsConfig
+      ]
+    }
+  },
+  {
+    // Exceptions for Storybook
+    "files": [
+      "**/*.stories.ts",
+      "**/*.story.ts"
+    ],
+    "rules": {
+      // Stories are allowed to use inline-templates to stay single-file.
+      "@angular-eslint/component-max-inline-declarations": "off",
+      // Stories don't need to add `.component`, that's redundant.
+      "angular-file-naming/component-filename-suffix": "off"
+    }
+  },
+  {
+    "files": [
+      "**/*.[jt]s",
+      "**/*.html"
+    ],
+    "rules": {
+      "unicorn/filename-case": [
+        "error",
+        {
+          "case": "kebabCase"
+        }
+      ]
+    }
+  },
+  typeDefinitionOverride
+)