eslint-config-beslogic 3.1.2 → 3.1.4

package/.dprint.jsonc

@@ -3,5 +3,5 @@
 
 {
   // https://dprint.dev/config/#extending-a-different-configuration-file
-  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json"
+  "extends": "https://raw.githubusercontent.com/BesLogic/shared-configs/main/dprint-json-like.json",
 }

package/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## 3.1.4
+
+- Pinned `eslint-plugin-unicorn` to `>=49.0 && <57`
+
+## 3.1.3
+
+- Bumped `"@typescript-eslint` to `^8.15.0`
+- Disabled `sonarjs/fixme-tag`
+- Disabled `@typescript-eslint/no-unsafe-type-assertion` and `@typescript-eslint/related-getter-setter-pairs` in non-`extra-strict` presets.
+- Added `"checkTypePredicates": true` to `@typescript-eslint/no-unnecessary-condition`
+- Configured `@typescript-eslint/prefer-nullish-coalescing` as
+  <!-- markdownlint-disable-next-line MD031 -->
+  ```js
+  [
+    "error",
+    {
+      // > If you're looking to enforce stricter conditional tests,
+      // > you should consider using the strict-boolean-expressions rule.
+      "ignoreConditionalTests": true,
+      "ignoreBooleanCoercion": true
+    }
+  ],
+  ```
+
 ## 3.1.2
 
 - Removed `globalThis` from `no-restricted-globals` as the adoption is now much wider (no more IE11) and it conflicts with `unicorn/prefer-global-this`
@@ -44,6 +68,7 @@
   }
   ```
 
+```
 `eslint-plugin-sonarjs@2` added a ton of rules, a lot of which duplicates base ESLint rules and other plugins we have. _**Please report those you find**_
 
 ### Changes
@@ -254,3 +279,4 @@
 - Changed the maximum line length from `120` to `100`
 - Split language-specific `editor.defaultFormatter` to work around
   <https://github.com/microsoft/vscode/issues/168411>
+```

package/README.md

@@ -9,7 +9,7 @@ Depending on your needs, you will need to also install other peer dependencies f
 In your `.eslintrc` file, add `"extends": "beslogic/<preset>"` (see all available presets below)
 
 For stylistic rules, it is highly recommended to use a dedicated formatter over ESLint. Read more here: <https://typescript-eslint.io/docs/linting/troubleshooting/formatting/>\
-A [dprint preset](#beslogicdprint) is offered below.
+We assume [dprint](https://dprint.dev/) and don't enable any rules it covers by default. If you're not using a formatter, a [stylistic.mjs](#beslogicstylistic) configuration is offered below.
 
 ## Parallel configurations
 

package/TODO-SONARJS_CHECK_IF_DUPLICATED.json

@@ -28,7 +28,6 @@
   "sonarjs/encryption-secure-mode": "error",
   "sonarjs/file-permissions": "error",
   "sonarjs/file-uploads": "error",
-  "sonarjs/fixme-tag": "error",
   "sonarjs/for-loop-increment-sign": "error",
   "sonarjs/frame-ancestors": "error",
   "sonarjs/function-inside-loop": "error",

package/extra-strict.js

@@ -1,10 +1,5 @@
 const { resolveModuleLocation, jestFilePatterns } = require("./lib/utils")
 
-// TODO: ADD no-unsafe-type-assertion ONCE IT'S PUBLISHED ! (and the message I used to include)
-// (remove from non-strict, add back here, then re-disable for jest at the bottom of the file)
-// https://github.com/typescript-eslint/typescript-eslint/pull/10051
-// https://github.com/typescript-eslint/typescript-eslint/issues/7173
-
 // These extra strict configs are not only for Angular. User may be using a different framework
 const hasAngularEslintTemplate = !!resolveModuleLocation("@angular-eslint/eslint-plugin-template")
 
@@ -33,8 +28,8 @@ module.exports = {
         // https://typescript-eslint.io/rules/no-invalid-this/
         "@typescript-eslint/no-invalid-this": "off",
 
-        // Replaces total-functions/no-unsafe-type-assertion
-        // See when this gets merged for upstream support https://github.com/typescript-eslint/typescript-eslint/issues/7173
+        // consistent-type-assertions + no-unsafe-type-assertion replaced total-functions/no-unsafe-type-assertion
+        // TODO: Ask to include my examples of how to fix, or eventually highjack rules to add more descriptions
         //
         // It takes an advanced TypeScript user to fully make sense of this rule
         /**
@@ -60,7 +55,9 @@ module.exports = {
           "error",
           { "assertionStyle": "as", "objectLiteralTypeAssertions": "allow-as-parameter" }
         ],
+        "@typescript-eslint/no-unsafe-type-assertion": "error",
 
+        "@typescript-eslint/related-getter-setter-pairs": "error",
         "@typescript-eslint/restrict-template-expressions": [
           "error",
           {
@@ -85,7 +82,15 @@ module.exports = {
           "error",
           { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": false }
         ],
-        "@typescript-eslint/prefer-nullish-coalescing": "error",
+        "@typescript-eslint/prefer-nullish-coalescing": [
+          "error",
+          {
+            // > If you're looking to enforce stricter conditional tests,
+            // > you should consider using the strict-boolean-expressions rule.
+            "ignoreConditionalTests": true,
+            "ignoreBooleanCoercion": true
+          }
+        ],
         // We accept nullish as falsy
         "@typescript-eslint/strict-boolean-expressions": "off",
 

package/javascript.js

@@ -329,6 +329,7 @@ module.exports = {
      * eslint-plugin-sonarjs@2 added rules that duplicate base ESLint rules or specific plugins we prefer
      */
     // Duplicates no-warning-comments
+    "sonarjs/fixme-tag": "off",
     "sonarjs/todo-tag": "off",
     // Duplicates unicorn/prefer-string-starts-ends-with
     "sonarjs/prefer-string-starts-ends-with": "off",

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "eslint-config-beslogic",
-  "version": "3.1.2",
+  "version": "3.1.4",
   "description": "ESLint rules, plugins and configs used at Beslogic",
   "main": "index.js",
   "// dependencies": "Run for ourselves when we install dependencies w/o running npm i afterward",
   "scripts": {
     "eslint": "set TIMING=1 && eslint ./ --ignore-path .gitignore",
     "lint": "dprint check && npm run eslint",
-    "lint:fix": "dprint fmt && npm run eslint -- --fix",
+    "lint:fix": "npm run eslint -- --fix && dprint fmt",
     "upgrade": "npx npm-check-updates -u & npm i",
     "yalc": "yalc publish",
     "prepack": "type .gitignore* > .npmignore",
@@ -44,8 +44,8 @@
   "dependencies": {
     "@eslint-community/eslint-plugin-eslint-comments": "^4.1",
     "@stylistic/eslint-plugin": "^2.8.0",
-    "@typescript-eslint/eslint-plugin": "^8.3.0",
-    "@typescript-eslint/parser": "^8.3.0",
+    "@typescript-eslint/eslint-plugin": "^8.15.0",
+    "@typescript-eslint/parser": "^8.15.0",
     "@types/eslint": "^8.56",
     "confusing-browser-globals": "^1.0",
     "dprint": "^0.40.2",
@@ -64,7 +64,7 @@
     "eslint-plugin-simple-import-sort": ">=12.0",
     "eslint-plugin-sonarjs": "2.0.4",
     "eslint-plugin-testing-library": "^6.0",
-    "eslint-plugin-unicorn": ">=49.0"
+    "eslint-plugin-unicorn": ">=49.0 && <57"
   },
   "optionalDependencies": {
     "@angular-eslint/eslint-plugin": ">=16.2",
@@ -82,15 +82,11 @@
     "eslint-plugin-rxjs-angular": "github:BesLogic/eslint-plugin-rxjs-angular#dist",
     "eslint-plugin-storybook": "^0.6.10"
   },
-  "// plugins": "Test against highest supported version to catch new breaking changes",
+  "// jest": "Don't install it, so that we test failure to specify jest version",
   "devDependencies": {
-    "@angular-eslint/eslint-plugin": ">=16.2",
-    "@angular-eslint/eslint-plugin-template": ">=16.2",
-    "@angular-eslint/template-parser": ">=16.2",
     "@angular/core": ">=16.2",
     "@types/node": "^18.0",
     "eslint-plugin-eslint-plugin": "^6.0",
-    "eslint-plugin-storybook": "^0.6.10",
     "react": "^18.3.1",
     "yalc": "^1.0.0-pre.53"
   }

package/tsconfig.4.3.json

@@ -1,3 +1,6 @@
+// SPDX-License-Identifier: MIT
+// Copyright 2024 Beslogic Inc.
+
 {
   "compilerOptions": {
     "strict": true,

package/tsconfig.5.0.json

@@ -1,3 +1,6 @@
+// SPDX-License-Identifier: MIT
+// Copyright 2024 Beslogic Inc.
+
 {
   "extends": "./tsconfig.4.3.json",
   "compilerOptions": {

package/tsconfig.json

@@ -1,7 +1,9 @@
 {
   "extends": "./tsconfig.4.3.json",
   "compilerOptions": {
-    "moduleResolution": "node",
+    "moduleResolution": "Node16",
+    "module": "Node16",
+    "allowSyntheticDefaultImports": true,
     "noUncheckedIndexedAccess": false,
     "noEmit": true,
     "jsx": "react",

package/typescript.js

@@ -257,6 +257,8 @@ module.exports = {
         ],
         // Too many false-positives in TypeScript code
         "autofix/no-unused-vars": "off",
+        // Leave to extra-strict configs
+        "@typescript-eslint/no-unsafe-type-assertion": "off",
         "@typescript-eslint/no-unused-vars": noUnusedVariablesConfig,
         "@typescript-eslint/no-use-before-define": [
           "error",
@@ -303,6 +305,8 @@ module.exports = {
             "checkArrowFunctions": false
           }
         ],
+        // Leave to extra-strict configs
+        "@typescript-eslint/related-getter-setter-pairs": "off",
         "@typescript-eslint/require-array-sort-compare": [
           "error",
           {
@@ -352,7 +356,10 @@ module.exports = {
         // null/undefined checks. So only set it in non-strict preset.
         "@typescript-eslint/no-unnecessary-condition": [
           "error",
-          { "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": true }
+          {
+            "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": true,
+            "checkTypePredicates": true
+          }
         ],
         // IDEM, but fully useless w/o strictNullChecks
         "@typescript-eslint/prefer-nullish-coalescing": "off",